100258 2012-10-24 08:48:45 -0700 BlackBerry fix for webgl-depth-texture.html 2012-10-24 13:16:12 -0700 1 1 1 Unclassified WebKit WebGL 528+ (Nightly build) Other Other RESOLVED FIXED P2 Normal --- 0 jfeldstein webkit-unassigned dino fspacek mifenton staikos webkit.review.bot yong.li.webkit oldest_to_newest 749710 0 jfeldstein 2012-10-24 08:48:45 -0700 webgl-depth-texture.html is a WebGL conformance suite test that is partially failing on the BlackBerry platform. We need to upstream a fix for this. 749800 1 170425 jfeldstein 2012-10-24 10:31:47 -0700 Created attachment 170425 Patch 749820 2 170428 jfeldstein 2012-10-24 10:50:51 -0700 Created attachment 170428 Patch 749883 3 170428 yong.li.webkit 2012-10-24 11:57:45 -0700 Comment on attachment 170428 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=170428&action=review > Source/WebCore/ChangeLog:11 > + > + No new tests (OOPS!). > + Please change this line with some short explanation. Patch with (OOPS!) in changelog cannot get committed > Source/WebCore/platform/graphics/GraphicsContext3D.cpp:-121 > -#if !PLATFORM(BLACKBERRY) > case GraphicsContext3D::UNSIGNED_INT_24_8: > -#endif any idea about why we did this before? 749899 4 jfeldstein 2012-10-24 12:10:54 -0700 (In reply to comment #3) > (From update of attachment 170428 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=170428&action=review > > > Source/WebCore/ChangeLog:11 > > + > > + No new tests (OOPS!). > > + > > Please change this line with some short explanation. Patch with (OOPS!) in changelog cannot get committed > > > Source/WebCore/platform/graphics/GraphicsContext3D.cpp:-121 > > -#if !PLATFORM(BLACKBERRY) > > case GraphicsContext3D::UNSIGNED_INT_24_8: > > -#endif > > any idea about why we did this before? I spoke with a few other people and no one came up with a good reason. Worst case instead of returning false we'd eventually cause a gl error for an invalid enum. Not that that should happen anyways. I'll add you as the reviewer at the same time as removing the no new tests line. 749901 5 170444 jfeldstein 2012-10-24 12:15:09 -0700 Created attachment 170444 Patch 749945 6 170444 yong.li.webkit 2012-10-24 12:51:53 -0700 Comment on attachment 170444 Patch seems this code was added for build fix... so I assume we can build with UNSIGNED_INT_24_8 now. 749965 7 170444 webkit.review.bot 2012-10-24 13:16:09 -0700 Comment on attachment 170444 Patch Clearing flags on attachment: 170444 Committed r132387: <http://trac.webkit.org/changeset/132387> 749966 8 webkit.review.bot 2012-10-24 13:16:12 -0700 All reviewed patches have been landed. Closing bug. 170425 2012-10-24 10:31:47 -0700 2012-10-24 10:50:47 -0700 Patch bug-100258-20121024133231.patch text/plain 753 jfeldstein U3VidmVyc2lvbiBSZXZpc2lvbjogMTMyMzYwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9ncmFwaGljcy9HcmFwaGljc0NvbnRleHQzRC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9ncmFwaGljcy9HcmFwaGljc0NvbnRleHQzRC5jcHAKaW5kZXggYmM4OTk0NzJjOWIy ZTkyYWEwOWJiNjhkYjRiODY1NTM1MmQ1ZTkxOS4uMzhiMDg5MjY4ZWZjMDllYTg4NGI2MjI2OWIw YTljY2E3YjE3YTNkNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhp Y3MvR3JhcGhpY3NDb250ZXh0M0QuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dy YXBoaWNzL0dyYXBoaWNzQ29udGV4dDNELmNwcApAQCAtMTE2LDkgKzExNiw3IEBAIGJvb2wgR3Jh cGhpY3NDb250ZXh0M0Q6OmNvbXB1dGVGb3JtYXRBbmRUeXBlUGFyYW1ldGVycyhHQzNEZW51bSBm b3JtYXQsCiAgICAgICAgICpjb21wb25lbnRzUGVyUGl4ZWwgPSAxOwogICAgICAgICAqYnl0ZXNQ ZXJDb21wb25lbnQgPSBzaXplb2YoR0MzRHVzaG9ydCk7CiAgICAgICAgIGJyZWFrOwotI2lmICFQ TEFURk9STShCTEFDS0JFUlJZKQogICAgIGNhc2UgR3JhcGhpY3NDb250ZXh0M0Q6OlVOU0lHTkVE X0lOVF8yNF84OgotI2VuZGlmCiAgICAgY2FzZSBHcmFwaGljc0NvbnRleHQzRDo6VU5TSUdORURf SU5UOgogICAgICAgICAqYnl0ZXNQZXJDb21wb25lbnQgPSBzaXplb2YoR0MzRHVpbnQpOwogICAg ICAgICBicmVhazsK 170428 2012-10-24 10:50:51 -0700 2012-10-24 12:15:05 -0700 Patch bug-100258-20121024135134.patch text/plain 1611 jfeldstein U3VidmVyc2lvbiBSZXZpc2lvbjogMTMyMzYwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNDBjNzEwZDAxM2Q3Yjdl YjYzM2Q3Y2RjMDBhMGMxODc5NmU1YjY3Zi4uZjhlYmVkNzU2YjJhZGQzYWJjZTlmZjc0MmNlMjcz NjRmZDQzMmM4YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEyLTEwLTI0ICBKb25h dGhhbiBGZWxkc3RlaW4gIDxqZmVsZHN0ZWluQHJpbS5jb20+CisKKyAgICAgICAgQmxhY2tCZXJy eSBmaXggZm9yIHdlYmdsLWRlcHRoLXRleHR1cmUuaHRtbAorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTAwMjU4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkaXRpb25hbCBpbmZvcm1hdGlvbiBvZiB0aGUg Y2hhbmdlIHN1Y2ggYXMgYXBwcm9hY2gsIHJhdGlvbmFsZS4gUGxlYXNlIGFkZCBwZXItZnVuY3Rp b24gZGVzY3JpcHRpb25zIGJlbG93IChPT1BTISkuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzIChP T1BTISkuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9HcmFwaGljc0NvbnRleHQzRC5j cHA6CisgICAgICAgIChXZWJDb3JlOjpHcmFwaGljc0NvbnRleHQzRDo6Y29tcHV0ZUZvcm1hdEFu ZFR5cGVQYXJhbWV0ZXJzKToKKwogMjAxMi0xMC0yNCAgUGFydGggUGF0ZWwgIDxwYXJwYXRlbEBy aW0uY29tPgogCiAgICAgICAgIFtCbGFja0JlcnJ5XSBFeHRlbmRpbmcgZXhpc3RpbmcgVGhyZWFk VW5zYWZlIHNpbmdsZXRvbnMgaW4gd2Via2l0IHRvCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9ncmFwaGljcy9HcmFwaGljc0NvbnRleHQzRC5jcHAgYi9Tb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9ncmFwaGljcy9HcmFwaGljc0NvbnRleHQzRC5jcHAKaW5kZXggYmM4OTk0NzJj OWIyZTkyYWEwOWJiNjhkYjRiODY1NTM1MmQ1ZTkxOS4uMzhiMDg5MjY4ZWZjMDllYTg4NGI2MjI2 OWIwYTljY2E3YjE3YTNkNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3Jh cGhpY3MvR3JhcGhpY3NDb250ZXh0M0QuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L2dyYXBoaWNzL0dyYXBoaWNzQ29udGV4dDNELmNwcApAQCAtMTE2LDkgKzExNiw3IEBAIGJvb2wg R3JhcGhpY3NDb250ZXh0M0Q6OmNvbXB1dGVGb3JtYXRBbmRUeXBlUGFyYW1ldGVycyhHQzNEZW51 bSBmb3JtYXQsCiAgICAgICAgICpjb21wb25lbnRzUGVyUGl4ZWwgPSAxOwogICAgICAgICAqYnl0 ZXNQZXJDb21wb25lbnQgPSBzaXplb2YoR0MzRHVzaG9ydCk7CiAgICAgICAgIGJyZWFrOwotI2lm ICFQTEFURk9STShCTEFDS0JFUlJZKQogICAgIGNhc2UgR3JhcGhpY3NDb250ZXh0M0Q6OlVOU0lH TkVEX0lOVF8yNF84OgotI2VuZGlmCiAgICAgY2FzZSBHcmFwaGljc0NvbnRleHQzRDo6VU5TSUdO RURfSU5UOgogICAgICAgICAqYnl0ZXNQZXJDb21wb25lbnQgPSBzaXplb2YoR0MzRHVpbnQpOwog ICAgICAgICBicmVhazsK 170444 2012-10-24 12:15:09 -0700 2012-10-24 13:16:09 -0700 Patch bug-100258-20121024151552.patch text/plain 1509 jfeldstein U3VidmVyc2lvbiBSZXZpc2lvbjogMTMyMzYwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNDBjNzEwZDAxM2Q3Yjdl YjYzM2Q3Y2RjMDBhMGMxODc5NmU1YjY3Zi4uYjIyNDc1NDgxMmJhYzRkZTNjNGFiOTU4NTJjMjI3 MGUxOWY4ODc0OCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEyLTEwLTI0ICBKb25h dGhhbiBGZWxkc3RlaW4gIDxqZmVsZHN0ZWluQHJpbS5jb20+CisKKyAgICAgICAgQmxhY2tCZXJy eSBmaXggZm9yIHdlYmdsLWRlcHRoLXRleHR1cmUuaHRtbAorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTAwMjU4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg WW9uZyBMaS4KKworICAgICAgICBSZW1vdmVkIGEgcGxhdGZvcm0gc3BlY2lmaWMgZGVmaW5lIHRo YXQgaXMgdW5uZWNlc3NhcnkuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9HcmFwaGlj c0NvbnRleHQzRC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpHcmFwaGljc0NvbnRleHQzRDo6Y29t cHV0ZUZvcm1hdEFuZFR5cGVQYXJhbWV0ZXJzKToKKwogMjAxMi0xMC0yNCAgUGFydGggUGF0ZWwg IDxwYXJwYXRlbEByaW0uY29tPgogCiAgICAgICAgIFtCbGFja0JlcnJ5XSBFeHRlbmRpbmcgZXhp c3RpbmcgVGhyZWFkVW5zYWZlIHNpbmdsZXRvbnMgaW4gd2Via2l0IHRvCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9HcmFwaGljc0NvbnRleHQzRC5jcHAgYi9T b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9HcmFwaGljc0NvbnRleHQzRC5jcHAKaW5k ZXggYmM4OTk0NzJjOWIyZTkyYWEwOWJiNjhkYjRiODY1NTM1MmQ1ZTkxOS4uMzhiMDg5MjY4ZWZj MDllYTg4NGI2MjI2OWIwYTljY2E3YjE3YTNkNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vZ3JhcGhpY3MvR3JhcGhpY3NDb250ZXh0M0QuY3BwCisrKyBiL1NvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL2dyYXBoaWNzL0dyYXBoaWNzQ29udGV4dDNELmNwcApAQCAtMTE2LDkgKzEx Niw3IEBAIGJvb2wgR3JhcGhpY3NDb250ZXh0M0Q6OmNvbXB1dGVGb3JtYXRBbmRUeXBlUGFyYW1l dGVycyhHQzNEZW51bSBmb3JtYXQsCiAgICAgICAgICpjb21wb25lbnRzUGVyUGl4ZWwgPSAxOwog ICAgICAgICAqYnl0ZXNQZXJDb21wb25lbnQgPSBzaXplb2YoR0MzRHVzaG9ydCk7CiAgICAgICAg IGJyZWFrOwotI2lmICFQTEFURk9STShCTEFDS0JFUlJZKQogICAgIGNhc2UgR3JhcGhpY3NDb250 ZXh0M0Q6OlVOU0lHTkVEX0lOVF8yNF84OgotI2VuZGlmCiAgICAgY2FzZSBHcmFwaGljc0NvbnRl eHQzRDo6VU5TSUdORURfSU5UOgogICAgICAgICAqYnl0ZXNQZXJDb21wb25lbnQgPSBzaXplb2Yo R0MzRHVpbnQpOwogICAgICAgICBicmVhazsK