100256 2012-10-24 08:35:16 -0700 change CMAKE_<CCXX|C>_FLAGS_<RELEASE|DEBUG> from enviroment flags 2012-10-24 15:49:19 -0700 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Mac (Intel) OS X 10.3 RESOLVED FIXED P2 Enhancement --- 0 mcarmody mcarmody gyuyoung.kim mcarmody rakuco rwlbuis webkit.review.bot oldest_to_newest 749704 0 mcarmody 2012-10-24 08:35:16 -0700 If BB_RELEASE_FLAGS or BB_DEBUG_FLAGS are present in enviroment copy values to resppect cmake flags. 749913 1 170448 mcarmody 2012-10-24 12:30:12 -0700 Created attachment 170448 Patch 749975 2 170448 rwlbuis 2012-10-24 13:22:26 -0700 Comment on attachment 170448 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=170448&action=review I agree this is useful! Please fix the minor issues. > Source/cmake/OptionsBlackBerry.cmake:129 > + message( "<<<< ENV Overide RELEASE ${CMAKE_CXX_FLAGS_RELEASE}" ) Better use == instead of <<<< to match our style elsewhere. Also it is override. > Source/cmake/OptionsBlackBerry.cmake:134 > + message( "<<<< ENV Overide DEBUG ${CMAKE_CXX_FLAGS_DEBUG}") Ditto. 749997 3 170463 mcarmody 2012-10-24 13:44:12 -0700 Created attachment 170463 Patch 750015 4 170463 rwlbuis 2012-10-24 14:01:38 -0700 Comment on attachment 170463 Patch Ok. 750144 5 170463 webkit.review.bot 2012-10-24 15:49:15 -0700 Comment on attachment 170463 Patch Clearing flags on attachment: 170463 Committed r132414: <http://trac.webkit.org/changeset/132414> 750145 6 webkit.review.bot 2012-10-24 15:49:19 -0700 All reviewed patches have been landed. Closing bug. 170448 2012-10-24 12:30:12 -0700 2012-10-24 13:44:07 -0700 Patch bug-100256-20121024152847.patch text/plain 1882 mcarmody U3VidmVyc2lvbiBSZXZpc2lvbjogMTMyMzY2CmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvT3B0 aW9uc0JsYWNrQmVycnkuY21ha2UgYi9Tb3VyY2UvY21ha2UvT3B0aW9uc0JsYWNrQmVycnkuY21h a2UKaW5kZXggYjk0NjAxNGM2YzY0ZjUwMGNiMDUyMDU4YTVjZDFkYTg0YzQzMjhmOS4uNWQ0MzEx MWJmNjdlMjc3ZjIzOTBlNjE1MjRjNDNmYTgyYmM0MzVjZiAxMDA2NDQKLS0tIGEvU291cmNlL2Nt YWtlL09wdGlvbnNCbGFja0JlcnJ5LmNtYWtlCisrKyBiL1NvdXJjZS9jbWFrZS9PcHRpb25zQmxh Y2tCZXJyeS5jbWFrZQpAQCAtMTIyLDYgKzEyMiwxNyBAQCBJRiAoVEFSR0VUSU5HX1BMQVlCT09L KQogICAgIFNFVChDTUFLRV9DX0ZMQUdTICItbWZwdT1uZW9uICR7Q01BS0VfQ19GTEFHU30iKQog ICAgIFNFVChDTUFLRV9DWFhfRkxBR1MgIi1tdGh1bWIgLW10aHVtYi1pbnRlcndvcmsgJHtDTUFL RV9DWFhfRkxBR1N9IikKICAgICBTRVQoQ01BS0VfQ19GTEFHUyAiLW10aHVtYiAtbXRodW1iLWlu dGVyd29yayAke0NNQUtFX0NfRkxBR1N9IikKKyAgICAjIGNoZWNrIGZvciBCQl9SRUxFQVNFX0ZM QUdTIG9yIEJCX0RFQlVHX0ZMQUdTIHRvIHNldCBDTUFLRV9DX0ZMQUdTe0RFQlVHfFJFTEVBU0V9 IENNQUtFX0NYWF9GTEFHU3tERUJVR3xSRUxFQVNFfQorICAgIGlmKCBERUZJTkVEIEVOVntCQl9S RUxFQVNFX0ZMQUdTfSApCisgICAgICAgIHNldChDTUFLRV9DWFhfRkxBR1NfUkVMRUFTRSAgIiRF TlZ7QkJfUkVMRUFTRV9GTEFHU30gLUROREVCVUciKQorICAgICAgICBzZXQoQ01BS0VfQ19GTEFH U19SRUxFQVNFICAiJEVOVntCQl9SRUxFQVNFX0ZMQUdTfSAtRE5ERUJVRyIpCisgICAgICAgIG1l c3NhZ2UoICI8PDw8IEVOViBPdmVyaWRlIFJFTEVBU0UgJHtDTUFLRV9DWFhfRkxBR1NfUkVMRUFT RX0iICkKKyAgICBlbmRpZigpCisgICAgaWYoIERFRklORUQgRU5We0JCX0RFQlVHX0ZMQUdTfSAp CisgICAgICAgIHNldChDTUFLRV9DWFhfRkxBR1NfREVCVUcgIiRFTlZ7QkJfREVCVUdfRkxBR1N9 IikKKyAgICAgICAgc2V0KENNQUtFX0NfRkxBR1NfREVCVUcgIiRFTlZ7QkJfREVCVUdfRkxBR1N9 IikKKyAgICAgICAgbWVzc2FnZSggIjw8PDwgRU5WIE92ZXJpZGUgREVCVUcgJHtDTUFLRV9DWFhf RkxBR1NfREVCVUd9IikKKyAgICBlbmRpZigpCiBFTkRJRiAoKQogCiBBRERfREVGSU5JVElPTlMo LURSRVNPVVJDRV9QQVRIPSIvdXNyL3NoYXJlL3dlYmtpdC9yZXNvdXJjZXMvIikKZGlmZiAtLWdp dCBhL0NoYW5nZUxvZyBiL0NoYW5nZUxvZwppbmRleCA2N2U4ZDZjZjU2ZTgyMTQ5OGNiMDYzNDA4 OGE1MTU1MTRmZjE0ODc4Li42NmFkN2VlMjNkMTRhZWM5OTVjMWIyMzcxOWQzODBjNjEyN2Q4MDEy IDEwMDY0NAotLS0gYS9DaGFuZ2VMb2cKKysrIGIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAK KzIwMTItMTAtMjQgIE1pY2hhZWwgQ2FybW9keSAgPG1jYXJtb2R5QHJpbS5jb20+CisKKyAgICAg ICAgY2hhbmdlIENNQUtFXzxDQ1hYfEM+X0ZMQUdTXzxSRUxFQVNFfERFQlVHPiBmcm9tIGVudmly b21lbnQgZmxhZ3MKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTEwMDI1NgorCisgICAgICAgIFJldmlld2VkIGJ5IFJvYiBCdWlzLgorCisgICAgICAgIFRo aXMgYWxsb3cgb3ZlcnJpZGUgb2YgY29tcGlsZSBmbGFncyB3aXRob3V0IGhhdmluZyB0byBlZGl0 IENNYWtlIGZpbGVzLgorCisgICAgICAgICogU291cmNlL2NtYWtlL09wdGlvbnNCbGFja0JlcnJ5 LmNtYWtlOgorCiAyMDEyLTEwLTI0ICBQcmlpdCBMYWVzICA8cGxhZXNAcGxhZXMub3JnPgogCiAg ICAgICAgIFtHVEtdIC4vY29uZmlndXJlIG91dHB1dCBmb3IgQ1NTIFNoYWRlcnMgaXMgYnJva2Vu Cg== 170463 2012-10-24 13:44:12 -0700 2012-10-24 15:49:15 -0700 Patch bug-100256-20121024164246.patch text/plain 1893 mcarmody U3VidmVyc2lvbiBSZXZpc2lvbjogMTMyMzY2CmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvT3B0 aW9uc0JsYWNrQmVycnkuY21ha2UgYi9Tb3VyY2UvY21ha2UvT3B0aW9uc0JsYWNrQmVycnkuY21h a2UKaW5kZXggYjk0NjAxNGM2YzY0ZjUwMGNiMDUyMDU4YTVjZDFkYTg0YzQzMjhmOS4uNmEzYmQy OWUwNjcyNThmMDZmMTNhN2FhNTI4NWQ3ZDI1ODI1YzNjNCAxMDA2NDQKLS0tIGEvU291cmNlL2Nt YWtlL09wdGlvbnNCbGFja0JlcnJ5LmNtYWtlCisrKyBiL1NvdXJjZS9jbWFrZS9PcHRpb25zQmxh Y2tCZXJyeS5jbWFrZQpAQCAtMTIyLDYgKzEyMiwxNyBAQCBJRiAoVEFSR0VUSU5HX1BMQVlCT09L KQogICAgIFNFVChDTUFLRV9DX0ZMQUdTICItbWZwdT1uZW9uICR7Q01BS0VfQ19GTEFHU30iKQog ICAgIFNFVChDTUFLRV9DWFhfRkxBR1MgIi1tdGh1bWIgLW10aHVtYi1pbnRlcndvcmsgJHtDTUFL RV9DWFhfRkxBR1N9IikKICAgICBTRVQoQ01BS0VfQ19GTEFHUyAiLW10aHVtYiAtbXRodW1iLWlu dGVyd29yayAke0NNQUtFX0NfRkxBR1N9IikKKyAgICAjIGNoZWNrIGZvciBCQl9SRUxFQVNFX0ZM QUdTIG9yIEJCX0RFQlVHX0ZMQUdTIHRvIHNldCBDTUFLRV9DX0ZMQUdTe0RFQlVHfFJFTEVBU0V9 IENNQUtFX0NYWF9GTEFHU3tERUJVR3xSRUxFQVNFfQorICAgIGlmKCBERUZJTkVEIEVOVntCQl9S RUxFQVNFX0ZMQUdTfSApCisgICAgICAgIHNldChDTUFLRV9DWFhfRkxBR1NfUkVMRUFTRSAgIiRF TlZ7QkJfUkVMRUFTRV9GTEFHU30gLUROREVCVUciKQorICAgICAgICBzZXQoQ01BS0VfQ19GTEFH U19SRUxFQVNFICAiJEVOVntCQl9SRUxFQVNFX0ZMQUdTfSAtRE5ERUJVRyIpCisgICAgICAgIG1l c3NhZ2UoICI9PSBFTlYgb3ZlcnJpZGUgUkVMRUFTRSAke0NNQUtFX0NYWF9GTEFHU19SRUxFQVNF fSIgKQorICAgIGVuZGlmKCkKKyAgICBpZiggREVGSU5FRCBFTlZ7QkJfREVCVUdfRkxBR1N9ICkK KyAgICAgICAgc2V0KENNQUtFX0NYWF9GTEFHU19ERUJVRyAiJEVOVntCQl9ERUJVR19GTEFHU30i KQorICAgICAgICBzZXQoQ01BS0VfQ19GTEFHU19ERUJVRyAiJEVOVntCQl9ERUJVR19GTEFHU30i KQorICAgICAgICBtZXNzYWdlKCAiPT0gRU5WIG92ZXJyaWRlIERFQlVHICR7Q01BS0VfQ1hYX0ZM QUdTX0RFQlVHfSIpCisgICAgZW5kaWYoKQogRU5ESUYgKCkKIAogQUREX0RFRklOSVRJT05TKC1E UkVTT1VSQ0VfUEFUSD0iL3Vzci9zaGFyZS93ZWJraXQvcmVzb3VyY2VzLyIpCmRpZmYgLS1naXQg YS9DaGFuZ2VMb2cgYi9DaGFuZ2VMb2cKaW5kZXggNjdlOGQ2Y2Y1NmU4MjE0OThjYjA2MzQwODhh NTE1NTE0ZmYxNDg3OC4uMjgyYjA3OGM0ODhhMjBkMjM5MDA5MTAyYjU5MzhhNmJjOWQ4MmFkMiAx MDA2NDQKLS0tIGEvQ2hhbmdlTG9nCisrKyBiL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisy MDEyLTEwLTI0ICBNaWNoYWVsIENhcm1vZHkgIDxtY2FybW9keUByaW0uY29tPgorCisgICAgICAg IFtCbGFja0JlcnJ5XSBjaGFuZ2UgQ01BS0VfPENDWFh8Qz5fRkxBR1NfPFJFTEVBU0V8REVCVUc+ IGZyb20gZW52aXJvbWVudCBmbGFncworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTAwMjU2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgUm9iIEJ1aXMuCisK KyAgICAgICAgVGhpcyBhbGxvdyBvdmVycmlkZSBvZiBjb21waWxlIGZsYWdzIHdpdGhvdXQgaGF2 aW5nIHRvIGVkaXQgQ01ha2UgZmlsZXMuCisKKyAgICAgICAgKiBTb3VyY2UvY21ha2UvT3B0aW9u c0JsYWNrQmVycnkuY21ha2U6CisKIDIwMTItMTAtMjQgIFByaWl0IExhZXMgIDxwbGFlc0BwbGFl cy5vcmc+CiAKICAgICAgICAgW0dUS10gLi9jb25maWd1cmUgb3V0cHV0IGZvciBDU1MgU2hhZGVy cyBpcyBicm9rZW4K