100253 2012-10-24 07:55:57 -0700 [Qt] Move the QQuickWebViewExperimental pointer to QQuickWebViewPrivate 2012-10-24 08:28:56 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jturcotte jturcotte webkit.review.bot oldest_to_newest 749675 0 jturcotte 2012-10-24 07:55:57 -0700 [Qt] Move the QQuickWebViewExperimental pointer to QQuickWebViewPrivate 749682 1 170396 jturcotte 2012-10-24 08:01:17 -0700 Created attachment 170396 Patch 749695 2 170396 webkit.review.bot 2012-10-24 08:28:53 -0700 Comment on attachment 170396 Patch Clearing flags on attachment: 170396 Committed r132359: <http://trac.webkit.org/changeset/132359> 749696 3 webkit.review.bot 2012-10-24 08:28:56 -0700 All reviewed patches have been landed. Closing bug. 170396 2012-10-24 08:01:17 -0700 2012-10-24 08:28:53 -0700 Patch bug-100253-20121024165952.patch text/plain 6959 jturcotte U3VidmVyc2lvbiBSZXZpc2lvbjogMTMyMzU0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggYjI0NDRmMDkxMmM5OWZi YWZkNDM1NDFkNDBkODFlZTUwNTY5ZDRiMy4uNTk1Nzc4Yjg4NjM3MzhhNjIzMDY4NzIzZDA3OGZl ZWY2YTFkNjEyNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDI1IEBACiAyMDEyLTEwLTI0ICBKb2Nl bHluIFR1cmNvdHRlICA8am9jZWx5bi50dXJjb3R0ZUBkaWdpYS5jb20+CiAKKyAgICAgICAgW1F0 XSBNb3ZlIHRoZSBRUXVpY2tXZWJWaWV3RXhwZXJpbWVudGFsIHBvaW50ZXIgdG8gUVF1aWNrV2Vi Vmlld1ByaXZhdGUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTEwMDI1MworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIFdlJ2xsIG5lZWQgdG8gYXZvaWQgcGxhY2luZyBkYXRhIGluIFFRdWlja1dlYlZpZXcgdG8g cHJlc2VydmUKKyAgICAgICAgaXRzIGJpbmFyeSBjb21wYXRpYmlsaXR5IG9uY2UgaXQncyBwdWJs aWMuCisgICAgICAgIEFsc28gbWFrZSB0aGUgUVF1aWNrV2ViVmlld0V4cGVyaW1lbnRhbCBjb25z dHJ1Y3RvciBwcml2YXRlLgorCisgICAgICAgICogVUlQcm9jZXNzL0FQSS9xdC9xcXVpY2t3ZWJ2 aWV3LmNwcDoKKyAgICAgICAgKFFRdWlja1dlYlZpZXdQcml2YXRlOjpRUXVpY2tXZWJWaWV3UHJp dmF0ZSk6CisgICAgICAgIChRUXVpY2tXZWJWaWV3RXhwZXJpbWVudGFsOjpRUXVpY2tXZWJWaWV3 RXhwZXJpbWVudGFsKToKKyAgICAgICAgKFFRdWlja1dlYlZpZXc6OlFRdWlja1dlYlZpZXcpOgor ICAgICAgICAoUVF1aWNrV2ViVmlldzo6ZXhwZXJpbWVudGFsKToKKyAgICAgICAgKiBVSVByb2Nl c3MvQVBJL3F0L3FxdWlja3dlYnZpZXdfcC5oOgorICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvcXQv cXF1aWNrd2Vidmlld19wX3AuaDoKKyAgICAgICAgKFFRdWlja1dlYlZpZXdQcml2YXRlKToKKwor MjAxMi0xMC0yNCAgSm9jZWx5biBUdXJjb3R0ZSAgPGpvY2VseW4udHVyY290dGVAZGlnaWEuY29t PgorCiAgICAgICAgIEljb25EYXRhYmFzZTogUHJvcGVybHkgY2xlYW4gdXAgb24gZGVzdHJ1Y3Rp b24KICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwMDIz NwogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL3F0L3FxdWlja3dl YnZpZXcuY3BwIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9xdC9xcXVpY2t3ZWJ2aWV3 LmNwcAppbmRleCA4ZDNkZDQ5ODQ1MDhiMjhmYjM2OGZlZGNjYmM4NmQ0M2U3YTBhZGFmLi5mOTRh YmNmMTM0ODU4ZGQ4ZmZjY2FkMzVkMGZkNmM5NGFlZjU1NWMxIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0Mi9VSVByb2Nlc3MvQVBJL3F0L3FxdWlja3dlYnZpZXcuY3BwCisrKyBiL1NvdXJjZS9X ZWJLaXQyL1VJUHJvY2Vzcy9BUEkvcXQvcXF1aWNrd2Vidmlldy5jcHAKQEAgLTI1OCw2ICsyNTgs NyBAQCBRUG9pbnRGIFFRdWlja1dlYlZpZXdQcml2YXRlOjpGbGlja2FibGVBeGlzTG9ja2VyOjph ZGp1c3QoY29uc3QgUVBvaW50RiYgcG9zaXRpbwogCiBRUXVpY2tXZWJWaWV3UHJpdmF0ZTo6UVF1 aWNrV2ViVmlld1ByaXZhdGUoUVF1aWNrV2ViVmlldyogdmlld3BvcnQpCiAgICAgOiBxX3B0cih2 aWV3cG9ydCkKKyAgICAsIGV4cGVyaW1lbnRhbChuZXcgUVF1aWNrV2ViVmlld0V4cGVyaW1lbnRh bCh2aWV3cG9ydCwgdGhpcykpCiAgICAgLCBhbGVydERpYWxvZygwKQogICAgICwgY29uZmlybURp YWxvZygwKQogICAgICwgcHJvbXB0RGlhbG9nKDApCkBAIC04OTcsMTIgKzg5OCwxMiBAQCB2b2lk IFFRdWlja1dlYlZpZXdGbGlja2FibGVQcml2YXRlOjpoYW5kbGVNb3VzZUV2ZW50KFFNb3VzZUV2 ZW50KiBldmVudCkKICAgICBwYWdlVmlldy0+ZXZlbnRIYW5kbGVyKCktPmhhbmRsZUlucHV0RXZl bnQoZXZlbnQpOwogfQogCi1RUXVpY2tXZWJWaWV3RXhwZXJpbWVudGFsOjpRUXVpY2tXZWJWaWV3 RXhwZXJpbWVudGFsKFFRdWlja1dlYlZpZXcgKndlYlZpZXcpCitRUXVpY2tXZWJWaWV3RXhwZXJp bWVudGFsOjpRUXVpY2tXZWJWaWV3RXhwZXJpbWVudGFsKFFRdWlja1dlYlZpZXcgKndlYlZpZXcs IFFRdWlja1dlYlZpZXdQcml2YXRlKiB3ZWJWaWV3UHJpdmF0ZSkKICAgICA6IFFPYmplY3Qod2Vi VmlldykKICAgICAsIHFfcHRyKHdlYlZpZXcpCi0gICAgLCBkX3B0cih3ZWJWaWV3LT5kX3B0ci5k YXRhKCkpCisgICAgLCBkX3B0cih3ZWJWaWV3UHJpdmF0ZSkKICAgICAsIHNjaGVtZVBhcmVudChu ZXcgUU9iamVjdCh0aGlzKSkKLSAgICAsIG1fdGVzdChuZXcgUVdlYktpdFRlc3Qod2ViVmlldy0+ ZF9wdHIuZGF0YSgpLCB0aGlzKSkKKyAgICAsIG1fdGVzdChuZXcgUVdlYktpdFRlc3Qod2ViVmll d1ByaXZhdGUsIHRoaXMpKQogewogfQogCkBAIC0xNDczLDcgKzE0NzQsNiBAQCBRUXVpY2tXZWJQ YWdlKiBRUXVpY2tXZWJWaWV3RXhwZXJpbWVudGFsOjpwYWdlKCkKIFFRdWlja1dlYlZpZXc6OlFR dWlja1dlYlZpZXcoUVF1aWNrSXRlbSogcGFyZW50KQogICAgIDogUVF1aWNrRmxpY2thYmxlKHBh cmVudCkKICAgICAsIGRfcHRyKGNyZWF0ZVByaXZhdGVPYmplY3QodGhpcykpCi0gICAgLCBtX2V4 cGVyaW1lbnRhbChuZXcgUVF1aWNrV2ViVmlld0V4cGVyaW1lbnRhbCh0aGlzKSkKIHsKICAgICBR X0QoUVF1aWNrV2ViVmlldyk7CiAgICAgZC0+aW5pdGlhbGl6ZSgpOwpAQCAtMTQ4Miw3ICsxNDgy LDYgQEAgUVF1aWNrV2ViVmlldzo6UVF1aWNrV2ViVmlldyhRUXVpY2tJdGVtKiBwYXJlbnQpCiBR UXVpY2tXZWJWaWV3OjpRUXVpY2tXZWJWaWV3KFdLQ29udGV4dFJlZiBjb250ZXh0UmVmLCBXS1Bh Z2VHcm91cFJlZiBwYWdlR3JvdXBSZWYsIFFRdWlja0l0ZW0qIHBhcmVudCkKICAgICA6IFFRdWlj a0ZsaWNrYWJsZShwYXJlbnQpCiAgICAgLCBkX3B0cihjcmVhdGVQcml2YXRlT2JqZWN0KHRoaXMp KQotICAgICwgbV9leHBlcmltZW50YWwobmV3IFFRdWlja1dlYlZpZXdFeHBlcmltZW50YWwodGhp cykpCiB7CiAgICAgUV9EKFFRdWlja1dlYlZpZXcpOwogICAgIGQtPmluaXRpYWxpemUoY29udGV4 dFJlZiwgcGFnZUdyb3VwUmVmKTsKQEAgLTE3NjIsNyArMTc2MSw4IEBAIFFWYXJpYW50IFFRdWlj a1dlYlZpZXc6OmlucHV0TWV0aG9kUXVlcnkoUXQ6OklucHV0TWV0aG9kUXVlcnkgcHJvcGVydHkp IGNvbnN0CiAqLwogUVF1aWNrV2ViVmlld0V4cGVyaW1lbnRhbCogUVF1aWNrV2ViVmlldzo6ZXhw ZXJpbWVudGFsKCkgY29uc3QKIHsKLSAgICByZXR1cm4gbV9leHBlcmltZW50YWw7CisgICAgUV9E KGNvbnN0IFFRdWlja1dlYlZpZXcpOworICAgIHJldHVybiBkLT5leHBlcmltZW50YWw7CiB9CiAK IC8qIQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9xdC9xcXVpY2t3 ZWJ2aWV3X3AuaCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvcXQvcXF1aWNrd2Vidmll d19wLmgKaW5kZXggODllN2ZiYzk5MTdhYTFhYjNkZmQwYjQzMTQ4ZWQ3YTA1MzZhZWU4MS4uZGZl N2FkODhlM2E5YTBhYzUyYTkzZDZlMzI0ZGI0MTIxMGE5MDM4ZCAxMDA2NDQKLS0tIGEvU291cmNl L1dlYktpdDIvVUlQcm9jZXNzL0FQSS9xdC9xcXVpY2t3ZWJ2aWV3X3AuaAorKysgYi9Tb3VyY2Uv V2ViS2l0Mi9VSVByb2Nlc3MvQVBJL3F0L3FxdWlja3dlYnZpZXdfcC5oCkBAIC0yMTMsOSArMjEz LDkgQEAgcHJpdmF0ZToKICAgICBRX1BSSVZBVEVfU0xPVChkX2Z1bmMoKSwgdm9pZCBfcV9vblVy bENoYW5nZWQoKSk7CiAgICAgUV9QUklWQVRFX1NMT1QoZF9mdW5jKCksIHZvaWQgX3Ffb25SZWNl aXZlZFJlc3BvbnNlRnJvbURvd25sb2FkKFFXZWJEb3dubG9hZEl0ZW0qKSk7CiAgICAgUV9QUklW QVRFX1NMT1QoZF9mdW5jKCksIHZvaWQgX3Ffb25JY29uQ2hhbmdlZEZvclBhZ2VVUkwoY29uc3Qg UVN0cmluZyYpKTsKKwogICAgIC8vIEhpZGVzIFFPYmplY3Q6OmRfcHRyIGFsbG93aW5nIHVzIHRv IHVzZSB0aGUgY29udmVuaWVuY2UgbWFjcm9zLgogICAgIFFTY29wZWRQb2ludGVyPFFRdWlja1dl YlZpZXdQcml2YXRlPiBkX3B0cjsKLSAgICBRUXVpY2tXZWJWaWV3RXhwZXJpbWVudGFsKiBtX2V4 cGVyaW1lbnRhbDsKIAogICAgIGZyaWVuZCBjbGFzcyBRV2ViS2l0VGVzdDsKICAgICBmcmllbmQg Y2xhc3MgV2ViS2l0OjpQYWdlVmlld3BvcnRDb250cm9sbGVyQ2xpZW50UXQ7CkBAIC0yODQsNyAr Mjg0LDYgQEAgcHVibGljOgogICAgICAgICBEb3dubG9hZFJlcXVlc3QgPSBRUXVpY2tXZWJWaWV3 OjpJZ25vcmVSZXF1ZXN0IC0gMQogICAgIH07CiAKLSAgICBRUXVpY2tXZWJWaWV3RXhwZXJpbWVu dGFsKFFRdWlja1dlYlZpZXcqIHdlYlZpZXcpOwogICAgIHZpcnR1YWwgflFRdWlja1dlYlZpZXdF eHBlcmltZW50YWwoKTsKIAogICAgIFFRbWxDb21wb25lbnQqIGFsZXJ0RGlhbG9nKCkgY29uc3Q7 CkBAIC0zODAsNiArMzc5LDcgQEAgUV9TSUdOQUxTOgogICAgIHZvaWQgcmVtb3RlSW5zcGVjdG9y VXJsQ2hhbmdlZCgpOwogCiBwcml2YXRlOgorICAgIFFRdWlja1dlYlZpZXdFeHBlcmltZW50YWwo UVF1aWNrV2ViVmlldyogd2ViVmlldywgUVF1aWNrV2ViVmlld1ByaXZhdGUqIHdlYlZpZXdQcml2 YXRlKTsKICAgICBRUXVpY2tXZWJWaWV3KiBxX3B0cjsKICAgICBRUXVpY2tXZWJWaWV3UHJpdmF0 ZSogZF9wdHI7CiAgICAgUU9iamVjdCogc2NoZW1lUGFyZW50OwpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYktpdDIvVUlQcm9jZXNzL0FQSS9xdC9xcXVpY2t3ZWJ2aWV3X3BfcC5oIGIvU291cmNlL1dl YktpdDIvVUlQcm9jZXNzL0FQSS9xdC9xcXVpY2t3ZWJ2aWV3X3BfcC5oCmluZGV4IDE1YmY4MThk NzY3NzVmZTU3MDMxNzViOWVkOGVmMDJhODAwZmJjMzguLmFkZWRiNmEzMTdhMDg4ODY3ZGExNjEz MzhkZWExNjhiNTc3YjAzYmEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9B UEkvcXQvcXF1aWNrd2Vidmlld19wX3AuaAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3Mv QVBJL3F0L3FxdWlja3dlYnZpZXdfcF9wLmgKQEAgLTE3MSw2ICsxNzEsNyBAQCBwcm90ZWN0ZWQ6 CiAKICAgICBRU2NvcGVkUG9pbnRlcjxRUXVpY2tXZWJQYWdlPiBwYWdlVmlldzsKICAgICBRUXVp Y2tXZWJWaWV3KiBxX3B0cjsKKyAgICBRUXVpY2tXZWJWaWV3RXhwZXJpbWVudGFsKiBleHBlcmlt ZW50YWw7CiAKICAgICBGbGlja2FibGVBeGlzTG9ja2VyIGF4aXNMb2NrZXI7CiAKZGlmZiAtLWdp dCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCBlODQyMGJiOTg2OGI4 MDczNDQzZTQzNDQzOWIwYjQ4NzE0NTcwMzU5Li5jYTc2MWJjNmVmMTEyYmQyM2VkMDIyMDY3N2Q0 ZmViNDk2ZWViM2I1IDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTItMTAtMjQgIEpvY2VseW4gVHVyY290dGUgIDxq b2NlbHluLnR1cmNvdHRlQGRpZ2lhLmNvbT4KKworICAgICAgICBbUXRdIE1vdmUgdGhlIFFRdWlj a1dlYlZpZXdFeHBlcmltZW50YWwgcG9pbnRlciB0byBRUXVpY2tXZWJWaWV3UHJpdmF0ZQorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTAwMjUzCisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBXZWJLaXRUZXN0 UnVubmVyL3F0L1BsYXRmb3JtV2ViVmlld1F0LmNwcDoKKyAgICAgICAgKFdUUjo6V3JhcHBlcldp bmRvdzo6aGFuZGxlU3RhdHVzQ2hhbmdlZCk6CisgICAgICAgIFVzZSBRUXVpY2tXZWJWaWV3Ojpl eHBlcmltZW50YWwgcmF0aGVyIHRoYW4gY3JlYXRpbmcgYSBuZXcgaW5zdGFuY2UuCisKIDIwMTIt MTAtMjQgIFRoaWFnbyBNYXJjb3MgUC4gU2FudG9zICA8dGhpYWdvLnNhbnRvc0BpbnRlbC5jb20+ CiAKICAgICAgICAgW0VGTF0gcnVuLXdlYmtpdC10ZXN0cyB3cml0ZXMgZ2FyYmFnZSBvbiBzdGRl cnIgd2hlbiBydW5uaW5nIG9uIFh2ZmIKZGlmZiAtLWdpdCBhL1Rvb2xzL1dlYktpdFRlc3RSdW5u ZXIvcXQvUGxhdGZvcm1XZWJWaWV3UXQuY3BwIGIvVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9xdC9Q bGF0Zm9ybVdlYlZpZXdRdC5jcHAKaW5kZXggNThjMDZjYzdlNTNiY2E1ZTJjN2NjMjE2N2IxNTU3 MGJhZGU2MjQ2Zi4uZTFjY2U0OGE1ZTIxYjZiMjdkMTU5MWVmNTNlMGQ1OTViYjcxNGI3MSAxMDA2 NDQKLS0tIGEvVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9xdC9QbGF0Zm9ybVdlYlZpZXdRdC5jcHAK KysrIGIvVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9xdC9QbGF0Zm9ybVdlYlZpZXdRdC5jcHAKQEAg LTY2LDEwICs2Niw4IEBAIHByaXZhdGUgUV9TTE9UUzoKICAgICAgICAgICAgIHNldFN1cmZhY2VU eXBlKE9wZW5HTFN1cmZhY2UpOwogICAgICAgICAgICAgY3JlYXRlKCk7CiAgICAgICAgICAgICBR UXVpY2tXaW5kb3dQcml2YXRlOjpnZXQodGhpcyktPnNldFJlbmRlcldpdGhvdXRTaG93aW5nKHRy dWUpOwotICAgICAgICB9IGVsc2UgewotICAgICAgICAgICAgUVF1aWNrV2ViVmlld0V4cGVyaW1l bnRhbCBleHBlcmltZW50YWwobV92aWV3KTsKLSAgICAgICAgICAgIGV4cGVyaW1lbnRhbC5zZXRS ZW5kZXJUb09mZnNjcmVlbkJ1ZmZlcih0cnVlKTsKLSAgICAgICAgfQorICAgICAgICB9IGVsc2UK KyAgICAgICAgICAgIG1fdmlldy0+ZXhwZXJpbWVudGFsKCktPnNldFJlbmRlclRvT2Zmc2NyZWVu QnVmZmVyKHRydWUpOwogCiAgICAgICAgIFFXaW5kb3dTeXN0ZW1JbnRlcmZhY2U6OmhhbmRsZVdp bmRvd0FjdGl2YXRlZCh0aGlzKTsKICAgICAgICAgbV92aWV3LT5wYWdlKCktPnNldEZvY3VzKHRy dWUpOwo=