100252 2012-10-24 07:51:13 -0700 [GTK] Typos in user-visible strings: "coordintate" 2012-10-24 09:44:10 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 cjlhomeaddress webkit-unassigned claude webkit.review.bot oldest_to_newest 749669 0 cjlhomeaddress 2012-10-24 07:51:13 -0700 coordintate > coordinate Spotted in WebKitGTK+ PO file ../webkit/webkithittestresult.cpp:255 The x coordintate of the event relative to the view's window. to The x coordinate of the event relative to the view's window. ../webkit/webkithittestresult.cpp:269 The y coordintate of the event relative to the view's window. to The y coordinate of the event relative to the view's window. 749686 1 170399 plaes 2012-10-24 08:09:27 -0700 Created attachment 170399 typo-fix.patch 749688 2 170401 plaes 2012-10-24 08:11:42 -0700 Created attachment 170401 typo-fix.patch Correct patch this time. 749691 3 webkit.review.bot 2012-10-24 08:17:05 -0700 Attachment 170401 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/gtk/ChangeLog', u'Source/Web..." exit_code: 1 Source/WebKit/gtk/webkit/webkithittestresult.cpp:255: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebKit/gtk/webkit/webkithittestresult.cpp:269: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 2 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 749748 4 170401 webkit.review.bot 2012-10-24 09:44:07 -0700 Comment on attachment 170401 typo-fix.patch Clearing flags on attachment: 170401 Committed r132363: <http://trac.webkit.org/changeset/132363> 749749 5 webkit.review.bot 2012-10-24 09:44:10 -0700 All reviewed patches have been landed. Closing bug. 170399 2012-10-24 08:09:27 -0700 2012-10-24 08:11:42 -0700 typo-fix.patch 0001-2012-10-24-Priit-Laes-plaes-plaes.org.patch text/plain 2065 plaes RnJvbSBjNmViNzhiZTc5ODA5OTY0NzE1ZDE0OTE2ZmVjZGJlY2JjODlkMDBlIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQcmlpdCBMYWVzIDxwbGFlc0BwbGFlcy5vcmc+CkRhdGU6IFdl ZCwgMjQgT2N0IDIwMTIgMTI6NDY6MDggKzAzMDAKU3ViamVjdDogW1BBVENIXSAyMDEyLTEwLTI0 ICBQcmlpdCBMYWVzICA8cGxhZXNAcGxhZXMub3JnPgoKICAgICAgICBbR1RLXSAuL2NvbmZpZ3Vy ZSBvdXRwdXQgZm9yIENTUyBTaGFkZXJzIGlzIGJyb2tlbgogICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDAyMTcKCiAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCgogICAgICAgIFJlZm9ybWF0IENTUyBGaWx0ZXJzIC8gU2hhZGVycyBjaGVj ayB0byBjbGVhbiBjb25maWd1cmUgb3V0cHV0LgoKICAgICAgICAqIGNvbmZpZ3VyZS5hYzoKLS0t CiBDaGFuZ2VMb2cgICAgfCAxMSArKysrKysrKysrKwogY29uZmlndXJlLmFjIHwgMTAgKysrKyst LS0tLQogMiBmaWxlcyBjaGFuZ2VkLCAxNiBpbnNlcnRpb25zKCspLCA1IGRlbGV0aW9ucygtKQoK ZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5nZUxvZwppbmRleCAzZDg4ZTBjLi4zMjg1ZmNj IDEwMDY0NAotLS0gYS9DaGFuZ2VMb2cKKysrIGIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAK KzIwMTItMTAtMjQgIFByaWl0IExhZXMgIDxwbGFlc0BwbGFlcy5vcmc+CisKKyAgICAgICAgW0dU S10gLi9jb25maWd1cmUgb3V0cHV0IGZvciBDU1MgU2hhZGVycyBpcyBicm9rZW4KKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwMDIxNworCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFJlZm9ybWF0IENTUyBGaWx0 ZXJzIC8gU2hhZGVycyBjaGVjayB0byBjbGVhbiBjb25maWd1cmUgb3V0cHV0LgorCisgICAgICAg ICogY29uZmlndXJlLmFjOgorCiAyMDEyLTEwLTI0ICBNYXJpbyBTYW5jaGV6IFByYWRhICA8bWFy aW9Ad2Via2l0Lm9yZz4KIAogICAgICAgICBbV0syXSBbR1RLXSBUZXN0V2ViS2l0QWNjZXNzaWJp bGl0eSBpcyBub3QgYmVpbmcgcnVuCmRpZmYgLS1naXQgYS9jb25maWd1cmUuYWMgYi9jb25maWd1 cmUuYWMKaW5kZXggYjIzMDA0NS4uODZlMTNlMCAxMDA2NDQKLS0tIGEvY29uZmlndXJlLmFjCisr KyBiL2NvbmZpZ3VyZS5hYwpAQCAtODY1LDE1ICs4NjUsMTUgQEAgQUNfQVJHX0VOQUJMRShbaW50 cm9zcGVjdGlvbl0sCiAgIFtdLFtlbmFibGVfaW50cm9zcGVjdGlvbj1ub10pCiBBQ19NU0dfUkVT VUxUKFskZW5hYmxlX2ludHJvc3BlY3Rpb25dKQogCi0jIEVuYWJsZSBjc3Mgc2hhZGVycyBpZiB1 bnN0YWJsZV9mZWF0dXJlcywgY3NzX2ZpbHRlcnMgYW5kCi0jIGFjY2VsZXJhdGVkX2NvbXBvc2l0 aW5nIGFyZSB0dXJuZWQgb24uCi1BQ19NU0dfQ0hFQ0tJTkcoW3doZXRoZXIgdG8gZW5hYmxlIENT UyBTaGFkZXJzXSkKKyMgRW5hYmxlIENTUyBGaWx0ZXJzIGFuZCBTaGFkZXJzIGlmIHVuc3RhYmxl X2ZlYXR1cmVzIGFuZCBhY2NlbGVyYXRlZF9jb21wb3NpdGluZyBhcmUgdHVybmVkIG9uLgorZW5h YmxlX2Nzc19maWx0ZXJzPW5vOworZW5hYmxlX2Nzc19zaGFkZXJzPW5vOworQUNfTVNHX0NIRUNL SU5HKFt3aGV0aGVyIHRvIGVuYWJsZSBDU1MgRmlsdGVycyBhbmQgU2hhZGVyc10pCiBpZiB0ZXN0 ICIkZW5hYmxlX3Vuc3RhYmxlX2ZlYXR1cmVzIiA9ICJ5ZXMiICYmIHRlc3QgIiRlbmFibGVfYWNj ZWxlcmF0ZWRfY29tcG9zaXRpbmciID0gInllcyIgJiYgdGVzdCAiJHdpdGhfYWNjZWxlcmF0aW9u X2JhY2tlbmQiID0gIm9wZW5nbCI7IHRoZW4KLSAgICBlbmFibGVfY3NzX3NoYWRlcnM9eWVzOwog ICAgIGVuYWJsZV9jc3NfZmlsdGVycz15ZXM7CisgICAgZW5hYmxlX2Nzc19zaGFkZXJzPXllczsK IGZpCiBBQ19NU0dfUkVTVUxUKFskZW5hYmxlX2Nzc19maWx0ZXJzXSkKLUFDX01TR19SRVNVTFQo WyRlbmFibGVfY3NzX3NoYWRlcnNdKQogCiBHX0lSX1NDQU5ORVI9CiBHX0lSX0NPTVBJTEVSPQot LSAKMS43LjEyLjQKCg== 170401 2012-10-24 08:11:42 -0700 2012-10-24 09:44:07 -0700 typo-fix.patch 0001-2012-10-24-Priit-Laes-plaes-plaes.org.patch text/plain 3423 plaes RnJvbSBmNDA2ZDk4MjIxMjVlZjk0MWMyYmMzMjY5OTEwYzE5MDMzMjc3YzU0IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQcmlpdCBMYWVzIDxwbGFlc0BwbGFlcy5vcmc+CkRhdGU6IFdl ZCwgMjQgT2N0IDIwMTIgMTg6MDc6NDAgKzAzMDAKU3ViamVjdDogW1BBVENIXSAyMDEyLTEwLTI0 ICBQcmlpdCBMYWVzICA8cGxhZXNAcGxhZXMub3JnPgoKICAgICAgICBbR1RLXSBUeXBvcyBpbiB1 c2VyLXZpc2libGUgc3RyaW5nczogImNvb3JkaW50YXRlIgogICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDAyNTIKCiAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCgogICAgICAgIHMvY29vcmRpbnRhdGUvY29vcmRpbmF0ZQoKICAgICAgICAq IHdlYmtpdC93ZWJraXRoaXR0ZXN0cmVzdWx0LmNwcDoKICAgICAgICAod2Via2l0X2hpdF90ZXN0 X3Jlc3VsdF9jbGFzc19pbml0KToKLS0tCiBTb3VyY2UvV2ViS2l0L2d0ay9DaGFuZ2VMb2cgICAg ICAgICAgICAgICAgICAgICAgfCAxMiArKysrKysrKysrKysKIFNvdXJjZS9XZWJLaXQvZ3RrL3dl YmtpdC93ZWJraXRoaXR0ZXN0cmVzdWx0LmNwcCB8ICA4ICsrKystLS0tCiAyIGZpbGVzIGNoYW5n ZWQsIDE2IGluc2VydGlvbnMoKyksIDQgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYktpdC9ndGsvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9ndGsvQ2hhbmdlTG9nCmluZGV4 IDE1MDFiZTcuLmNkOWMyZGUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvZ3RrL0NoYW5nZUxv ZworKysgYi9Tb3VyY2UvV2ViS2l0L2d0ay9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAx Mi0xMC0yNCAgUHJpaXQgTGFlcyAgPHBsYWVzQHBsYWVzLm9yZz4KKworICAgICAgICBbR1RLXSBU eXBvcyBpbiB1c2VyLXZpc2libGUgc3RyaW5nczogImNvb3JkaW50YXRlIgorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTAwMjUyCisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgcy9jb29yZGludGF0ZS9jb29yZGlu YXRlCisKKyAgICAgICAgKiB3ZWJraXQvd2Via2l0aGl0dGVzdHJlc3VsdC5jcHA6CisgICAgICAg ICh3ZWJraXRfaGl0X3Rlc3RfcmVzdWx0X2NsYXNzX2luaXQpOgorCiAyMDEyLTEwLTIzICBNYXJ0 aW4gUm9iaW5zb24gIDxtcm9iaW5zb25AaWdhbGlhLmNvbT4KIAogICAgICAgICBbR1RLXVtTb3Vw XSBJbXBsZW1lbnQgdGhlIGRlZmF1bHQgYXV0aGVudGljYXRpb24gZGlhbG9nIHZpYSBXZWJDb3Jl U3VwcG9ydApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9ndGsvd2Via2l0L3dlYmtpdGhpdHRl c3RyZXN1bHQuY3BwIGIvU291cmNlL1dlYktpdC9ndGsvd2Via2l0L3dlYmtpdGhpdHRlc3RyZXN1 bHQuY3BwCmluZGV4IDNiNmE3N2EuLjFhOTQzNGEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQv Z3RrL3dlYmtpdC93ZWJraXRoaXR0ZXN0cmVzdWx0LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L2d0 ay93ZWJraXQvd2Via2l0aGl0dGVzdHJlc3VsdC5jcHAKQEAgLTI0NSwyOCArMjQ1LDI4IEBAIHN0 YXRpYyB2b2lkIHdlYmtpdF9oaXRfdGVzdF9yZXN1bHRfY2xhc3NfaW5pdChXZWJLaXRIaXRUZXN0 UmVzdWx0Q2xhc3MqIHdlYkhpdFRlCiAgICAgLyoqCiAgICAgICogV2ViS2l0SGl0VGVzdFJlc3Vs dDp4OgogICAgICAqCi0gICAgICogVGhlIHggY29vcmRpbnRhdGUgb2YgdGhlIGV2ZW50IHJlbGF0 aXZlIHRvIHRoZSB2aWV3J3Mgd2luZG93LgorICAgICAqIFRoZSB4IGNvb3JkaW5hdGUgb2YgdGhl IGV2ZW50IHJlbGF0aXZlIHRvIHRoZSB2aWV3J3Mgd2luZG93LgogICAgICAqCiAgICAgICogU2lu Y2U6IDEuMTAKICAgICAgKi8KICAgICBnX29iamVjdF9jbGFzc19pbnN0YWxsX3Byb3BlcnR5KG9i amVjdENsYXNzLCBQUk9QX1gsCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBn X3BhcmFtX3NwZWNfaW50KCJ4IiwKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgXygiWCBjb29yZGluYXRlIiksCi0gICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIF8oIlRoZSB4IGNvb3JkaW50YXRlIG9m IHRoZSBldmVudCByZWxhdGl2ZSB0byB0aGUgdmlldydzIHdpbmRvdy4iKSwKKyAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgXygiVGhlIHggY29vcmRp bmF0ZSBvZiB0aGUgZXZlbnQgcmVsYXRpdmUgdG8gdGhlIHZpZXcncyB3aW5kb3cuIiksCiAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIEdfTUlOSU5U LCBHX01BWElOVCwgMCwKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgc3RhdGljX2Nhc3Q8R1BhcmFtRmxhZ3M+KFdFQktJVF9QQVJBTV9SRUFEV1JJ VEUgfCBHX1BBUkFNX0NPTlNUUlVDVF9PTkxZKSkpOwogCiAgICAgLyoqCiAgICAgICogV2ViS2l0 SGl0VGVzdFJlc3VsdDp5OgogICAgICAqCi0gICAgICogVGhlIHggY29vcmRpbnRhdGUgb2YgdGhl IGV2ZW50IHJlbGF0aXZlIHRvIHRoZSB2aWV3J3Mgd2luZG93LgorICAgICAqIFRoZSB4IGNvb3Jk aW5hdGUgb2YgdGhlIGV2ZW50IHJlbGF0aXZlIHRvIHRoZSB2aWV3J3Mgd2luZG93LgogICAgICAq CiAgICAgICogU2luY2U6IDEuMTAKICAgICAgKi8KICAgICBnX29iamVjdF9jbGFzc19pbnN0YWxs X3Byb3BlcnR5KG9iamVjdENsYXNzLCBQUk9QX1ksCiAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICBnX3BhcmFtX3NwZWNfaW50KCJ5IiwKICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgXygiWSBjb29yZGluYXRlIiksCi0gICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIF8oIlRoZSB5IGNv b3JkaW50YXRlIG9mIHRoZSBldmVudCByZWxhdGl2ZSB0byB0aGUgdmlldydzIHdpbmRvdy4iKSwK KyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgXygi VGhlIHkgY29vcmRpbmF0ZSBvZiB0aGUgZXZlbnQgcmVsYXRpdmUgdG8gdGhlIHZpZXcncyB3aW5k b3cuIiksCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgIEdfTUlOSU5ULCBHX01BWElOVCwgMCwKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgc3RhdGljX2Nhc3Q8R1BhcmFtRmxhZ3M+KFdFQktJVF9Q QVJBTV9SRUFEV1JJVEUgfCBHX1BBUkFNX0NPTlNUUlVDVF9PTkxZKSkpOwogCi0tIAoxLjcuMTIu NAoK