100247 2012-10-24 07:17:04 -0700 [Qt][WK2] Fix "Unable to find a renderable master window QQuickView" warnings in tst_QQuickWebView 2012-10-31 09:46:07 -0700 1 1 1 Unclassified WebKit New Bugs 420+ All All RESOLVED FIXED Qt, QtTriaged P1 Blocker --- 70236 76773 1 ossy kbalazs abecsi cmarcelo hausmann jturcotte kbalazs menard ossy webkit.review.bot oldest_to_newest 749638 0 ossy 2012-10-24 07:17:04 -0700 The WK2 API tests work more or less (apart from https://wkb.ug/100224) with the actual Qt5 hash (34f1dbc74a893db80786a7723c6a90ff2cf7d7b7). I tested the trunk qt5.git hash - 98a605eb6b085a0d95a8c7c3926e46ba35e865a5, but unfortunately almost all API tests fail with it: $ run-in-xvfb.sh python ./Tools/Scripts/run-qtwebkit-tests --output-file=qt-unit-tests.html --do-not-open-results --timeout=120 WebKitBuild/Release/Source/WebKit2/UIProcess/API/qt/tests/ INFO:Exec:Running... WebKitBuild/Release/Source/WebKit2/UIProcess/API/qt/tests/qmltests/tst_qmltests_DesktopBehavior INFO:Exec:Running... WebKitBuild/Release/Source/WebKit2/UIProcess/API/qt/tests/qmltests/tst_qmltests_WebView INFO:Exec:Running... WebKitBuild/Release/Source/WebKit2/UIProcess/API/qt/tests/qrawwebview/tst_qrawwebview INFO:Exec:Running... WebKitBuild/Release/Source/WebKit2/UIProcess/API/qt/tests/inspectorserver/tst_inspectorserver INFO:Exec:Running... WebKitBuild/Release/Source/WebKit2/UIProcess/API/qt/tests/publicapi/tst_publicapi INFO:Exec:Running... WebKitBuild/Release/Source/WebKit2/UIProcess/API/qt/tests/qquickwebview/tst_qquickwebview INFO:Exec:Finished WebKitBuild/Release/Source/WebKit2/UIProcess/API/qt/tests/publicapi/tst_publicapi INFO:Exec:Finished WebKitBuild/Release/Source/WebKit2/UIProcess/API/qt/tests/inspectorserver/tst_inspectorserver INFO:Exec:Finished WebKitBuild/Release/Source/WebKit2/UIProcess/API/qt/tests/qmltests/tst_qmltests_DesktopBehavior INFO:Exec:Finished WebKitBuild/Release/Source/WebKit2/UIProcess/API/qt/tests/qrawwebview/tst_qrawwebview ERROR:Exec:Timeout, process 'WebKitBuild/Release/Source/WebKit2/UIProcess/API/qt/tests/qmltests/tst_qmltests_WebView' (18674) was terminated ERROR:Exec:Timeout, process 'WebKitBuild/Release/Source/WebKit2/UIProcess/API/qt/tests/qquickwebview/tst_qquickwebview' (18680) was terminated INFO:Exec:Finished WebKitBuild/Release/Source/WebKit2/UIProcess/API/qt/tests/qmltests/tst_qmltests_WebView INFO:Exec:Finished WebKitBuild/Release/Source/WebKit2/UIProcess/API/qt/tests/qquickwebview/tst_qquickwebview WARNING:Main:Missing sub-summary: WebKitBuild/Release/Source/WebKit2/UIProcess/API/qt/tests/qmltests/tst_qmltests_WebView WARNING:Main:Missing sub-summary: WebKitBuild/Release/Source/WebKit2/UIProcess/API/qt/tests/qmltests/tst_qmltests_WebView ********* Start testing of qmltests ********* Config: Using QTest library 5.0.0, Qt 5.0.0 PASS : qmltests::DesktopWebViewLinkHovered::initTestCase() FAIL! : qmltests::DesktopWebViewLinkHovered::test_linkHovered() 'verify()' returned FALSE. () Loc: [/home/oszi/WebKit/Source/WebKit2/UIProcess/API/qt/tests/qmltests/DesktopBehavior/tst_linkHovered.qml(47)] FAIL! : qmltests::DesktopWebViewLinkHovered::test_linkHoveredDoesntEmitRepeated() 'verify()' returned FALSE. () Loc: [/home/oszi/WebKit/Source/WebKit2/UIProcess/API/qt/tests/qmltests/DesktopBehavior/tst_linkHovered.qml(63)] PASS : qmltests::DesktopWebViewLinkHovered::cleanupTestCase() PASS : qmltests::DesktopWebViewLoadHtml::initTestCase() FAIL! : qmltests::DesktopWebViewLoadHtml::test_baseUrlAfterLoadHtml() 'verify()' returned FALSE. () Loc: [/home/oszi/WebKit/Source/WebKit2/UIProcess/API/qt/tests/qmltests/DesktopBehavior/tst_loadHtml.qml(45)] PASS : qmltests::DesktopWebViewLoadHtml::cleanupTestCase() PASS : qmltests::DesktopWebViewNavigationRequested::initTestCase() FAIL! : qmltests::DesktopWebViewNavigationRequested::test_downloadPolicy() 'verify()' returned FALSE. () Loc: [/home/oszi/WebKit/Source/WebKit2/UIProcess/API/qt/tests/qmltests/DesktopBehavior/tst_navigationRequested.qml(103)] FAIL! : qmltests::DesktopWebViewNavigationRequested::test_ignorePolicy() 'verify()' returned FALSE. () Loc: [/home/oszi/WebKit/Source/WebKit2/UIProcess/API/qt/tests/qmltests/DesktopBehavior/tst_navigationRequested.qml(92)] FAIL! : qmltests::DesktopWebViewNavigationRequested::test_usePolicy() 'verify()' returned FALSE. () Loc: [/home/oszi/WebKit/Source/WebKit2/UIProcess/API/qt/tests/qmltests/DesktopBehavior/tst_navigationRequested.qml(83)] PASS : qmltests::DesktopWebViewNavigationRequested::cleanupTestCase() Totals: 6 passed, 6 failed, 0 skipped ********* Finished testing of qmltests ********* ********* Start testing of qmltests ********* Config: Using QTest library 5.0.0, Qt 5.0.0 PASS : qmltests::WebViewApplicationSchemes::initTestCase() FAIL! : qmltests::WebViewApplicationSchemes::test_applicationScheme() 'verify()' returned FALSE. () Loc: [/home/oszi/WebKit/Source/WebKit2/UIProcess/API/qt/tests/qmltests/WebView/tst_applicationScheme.qml(75)] FAIL! : qmltests::WebViewApplicationSchemes::test_charsets() 'verify()' returned FALSE. () Loc: [/home/oszi/WebKit/Source/WebKit2/UIProcess/API/qt/tests/qmltests/WebView/tst_applicationScheme.qml(108)] FAIL! : qmltests::WebViewApplicationSchemes::test_multipleSchemes() 'verify()' returned FALSE. () Loc: [/home/oszi/WebKit/Source/WebKit2/UIProcess/API/qt/tests/qmltests/WebView/tst_applicationScheme.qml(83)] FAIL! : qmltests::WebViewApplicationSchemes::test_multipleUrlsForScheme() 'verify()' returned FALSE. () Loc: [/home/oszi/WebKit/Source/WebKit2/UIProcess/API/qt/tests/qmltests/WebView/tst_applicationScheme.qml(95)] PASS : qmltests::WebViewApplicationSchemes::cleanupTestCase() PASS : qmltests::WebViewColorChooser::initTestCase() FAIL! : qmltests::WebViewColorChooser::test_accept() 'verify()' returned FALSE. () Loc: [/home/oszi/WebKit/Source/WebKit2/UIProcess/API/qt/tests/qmltests/WebView/tst_colorChooser.qml(47)] FAIL! : qmltests::WebViewColorChooser::test_currentValue() 'verify()' returned FALSE. () Loc: [/home/oszi/WebKit/Source/WebKit2/UIProcess/API/qt/tests/qmltests/WebView/tst_colorChooser.qml(47)] FAIL! : qmltests::WebViewColorChooser::test_reject() 'verify()' returned FALSE. () Loc: [/home/oszi/WebKit/Source/WebKit2/UIProcess/API/qt/tests/qmltests/WebView/tst_colorChooser.qml(47)] PASS : qmltests::WebViewColorChooser::cleanupTestCase() PASS : qmltests::DevicePixelRatio::initTestCase() FAIL! : qmltests::DevicePixelRatio::test_devicePixelRatio() 'verify()' returned FALSE. () Loc: [/home/oszi/WebKit/Source/WebKit2/UIProcess/API/qt/tests/qmltests/WebView/tst_devicePixelRatio.qml(33)] FAIL! : qmltests::DevicePixelRatio::test_devicePixelRatioMediaQuery() 'verify()' returned FALSE. () Loc: [/home/oszi/WebKit/Source/WebKit2/UIProcess/API/qt/tests/qmltests/WebView/tst_devicePixelRatio.qml(50)] PASS : qmltests::DevicePixelRatio::cleanupTestCase() PASS : qmltests::DoubleTapToZoom::initTestCase() FAIL! : qmltests::DoubleTapToZoom::test_basic() 'verify()' returned FALSE. () Loc: [/home/oszi/WebKit/Source/WebKit2/UIProcess/API/qt/tests/qmltests/WebView/tst_doubleTapToZoom.qml(82)] PASS : qmltests::DoubleTapToZoom::cleanupTestCase() PASS : qmltests::WebViewDownload::initTestCase() FAIL! : qmltests::WebViewDownload::test_downloadRequest() 'wait for signal downloadRequested' returned FALSE. () Loc: [/home/oszi/WebKit/Source/WebKit2/UIProcess/API/qt/tests/qmltests/WebView/tst_download.qml(65)] FAIL! : qmltests::WebViewDownload::test_expectedLength() 'wait for signal downloadRequested' returned FALSE. () Loc: [/home/oszi/WebKit/Source/WebKit2/UIProcess/API/qt/tests/qmltests/WebView/tst_download.qml(72)] FAIL! : qmltests::WebViewDownload::test_succeeded() 'wait for signal downloadRequested' returned FALSE. () Loc: [/home/oszi/WebKit/Source/WebKit2/UIProcess/API/qt/tests/qmltests/WebView/tst_download.qml(80)] PASS : qmltests::WebViewDownload::cleanupTestCase() PASS : qmltests::JavaScriptEvaluation::initTestCase() FAIL! : qmltests::JavaScriptEvaluation::test_basic() 'verify()' returned FALSE. () Loc: [/home/oszi/WebKit/Source/WebKit2/UIProcess/API/qt/tests/qmltests/WebView/tst_evaluateJavaScript.qml(45)] FAIL! : qmltests::JavaScriptEvaluation::test_booleanValue() 'verify()' returned FALSE. () Loc: [/home/oszi/WebKit/Source/WebKit2/UIProcess/API/qt/tests/qmltests/WebView/tst_evaluateJavaScript.qml(87)] FAIL! : qmltests::JavaScriptEvaluation::test_floatValue() 'verify()' returned FALSE. () Loc: [/home/oszi/WebKit/Source/WebKit2/UIProcess/API/qt/tests/qmltests/WebView/tst_evaluateJavaScript.qml(138)] FAIL! : qmltests::JavaScriptEvaluation::test_integerValue() 'verify()' returned FALSE. () Loc: [/home/oszi/WebKit/Source/WebKit2/UIProcess/API/qt/tests/qmltests/WebView/tst_evaluateJavaScript.qml(121)] FAIL! : qmltests::JavaScriptEvaluation::test_propertyObjectWithChild() 'verify()' returned FALSE. () Loc: [/home/oszi/WebKit/Source/WebKit2/UIProcess/API/qt/tests/qmltests/WebView/tst_evaluateJavaScript.qml(62)] FAIL! : qmltests::JavaScriptEvaluation::test_queryById() 'verify()' returned FALSE. () Loc: [/home/oszi/WebKit/Source/WebKit2/UIProcess/API/qt/tests/qmltests/WebView/tst_evaluateJavaScript.qml(175)] FAIL! : qmltests::JavaScriptEvaluation::test_queryTitle() 'verify()' returned FALSE. () Loc: [/home/oszi/WebKit/Source/WebKit2/UIProcess/API/qt/tests/qmltests/WebView/tst_evaluateJavaScript.qml(156)] FAIL! : qmltests::JavaScriptEvaluation::test_stringValue() 'verify()' returned FALSE. () Loc: [/home/oszi/WebKit/Source/WebKit2/UIProcess/API/qt/tests/qmltests/WebView/tst_evaluateJavaScript.qml(104)] PASS : qmltests::JavaScriptEvaluation::cleanupTestCase() PASS : qmltests::WebViewLoadFavIcon::initTestCase() FAIL! : qmltests::WebViewLoadFavIcon::test_favIconLoad() 'wait for signal iconChanged' returned FALSE. () Loc: [/home/oszi/WebKit/Source/WebKit2/UIProcess/API/qt/tests/qmltests/WebView/tst_favIconLoad.qml(39)] CRASHED: WebKitBuild/Release/Source/WebKit2/UIProcess/API/qt/tests/qmltests/tst_qmltests_WebView ********* Start testing of tst_qrawwebview ********* Config: Using QTest library 5.0.0, Qt 5.0.0 PASS : tst_qrawwebview::initTestCase() FAIL! : tst_qrawwebview::paint() '::waitForSignal(this, SIGNAL(loaded()), 5000)' returned FALSE. () Loc: [/home/oszi/WebKit/Source/WebKit2/UIProcess/API/qt/tests/qrawwebview/tst_qrawwebview.cpp(90)] FAIL! : tst_qrawwebview::paint() 'compareImages(QImage(expectation), image.rgbSwapped(), 5)' returned FALSE. () Loc: [/home/oszi/WebKit/Source/WebKit2/UIProcess/API/qt/tests/qrawwebview/tst_qrawwebview.cpp(233)] FAIL! : tst_qrawwebview::noBackground1() '::waitForSignal(this, SIGNAL(loaded()), 5000)' returned FALSE. () Loc: [/home/oszi/WebKit/Source/WebKit2/UIProcess/API/qt/tests/qrawwebview/tst_qrawwebview.cpp(90)] FAIL! : tst_qrawwebview::noBackground1() '::waitForSignal(this, SIGNAL(loaded()), 5000)' returned FALSE. () Loc: [/home/oszi/WebKit/Source/WebKit2/UIProcess/API/qt/tests/qrawwebview/tst_qrawwebview.cpp(90)] FAIL! : tst_qrawwebview::noBackground2() '::waitForSignal(this, SIGNAL(loaded()), 5000)' returned FALSE. () Loc: [/home/oszi/WebKit/Source/WebKit2/UIProcess/API/qt/tests/qrawwebview/tst_qrawwebview.cpp(90)] FAIL! : tst_qrawwebview::noBackground2() '::waitForSignal(this, SIGNAL(loaded()), 5000)' returned FALSE. () Loc: [/home/oszi/WebKit/Source/WebKit2/UIProcess/API/qt/tests/qrawwebview/tst_qrawwebview.cpp(90)] FAIL! : tst_qrawwebview::noBackground3() '::waitForSignal(this, SIGNAL(loaded()), 5000)' returned FALSE. () Loc: [/home/oszi/WebKit/Source/WebKit2/UIProcess/API/qt/tests/qrawwebview/tst_qrawwebview.cpp(90)] FAIL! : tst_qrawwebview::noBackground3() '::waitForSignal(this, SIGNAL(loaded()), 5000)' returned FALSE. () Loc: [/home/oszi/WebKit/Source/WebKit2/UIProcess/API/qt/tests/qrawwebview/tst_qrawwebview.cpp(90)] FAIL! : tst_qrawwebview::noBackground3() 'compareImages(QImage(expectation), image.rgbSwapped(), 5)' returned FALSE. () Loc: [/home/oszi/WebKit/Source/WebKit2/UIProcess/API/qt/tests/qrawwebview/tst_qrawwebview.cpp(233)] PASS : tst_qrawwebview::cleanupTestCase() Totals: 2 passed, 9 failed, 0 skipped ********* Finished testing of tst_qrawwebview ********* ********* Start testing of tst_InspectorServer ********* Config: Using QTest library 5.0.0, Qt 5.0.0 PASS : tst_InspectorServer::initTestCase() QWARN : tst_InspectorServer::testPageList() Inspector server started successfully. Try pointing a WebKit browser to http://127.0.0.1:23654 PASS : tst_InspectorServer::testPageList() FAIL! : tst_InspectorServer::testRemoteDebuggingMessage() Compared values are not the same Actual (webSocketQueryWebView->title()): Expected (jsExpressionResult): 4 Loc: [/home/oszi/WebKit/Source/WebKit2/UIProcess/API/qt/tests/inspectorserver/tst_inspectorserver.cpp(153)] FAIL! : tst_InspectorServer::openRemoteDebuggingSession() '!inspectorWebView->title().isEmpty()' returned FALSE. () Loc: [/home/oszi/WebKit/Source/WebKit2/UIProcess/API/qt/tests/inspectorserver/tst_inspectorserver.cpp(178)] PASS : tst_InspectorServer::cleanupTestCase() Totals: 3 passed, 2 failed, 0 skipped ********* Finished testing of tst_InspectorServer ********* ********* Start testing of tst_QQuickWebView ********* Config: Using QTest library 5.0.0, Qt 5.0.0 PASS : tst_QQuickWebView::initTestCase() PASS : tst_QQuickWebView::accessPage() PASS : tst_QQuickWebView::navigationStatusAtStartup() FAIL! : tst_QQuickWebView::stopEnabledAfterLoadStarted() Compared values are not the same Actual (webView()->loading()): 0 Expected (true): 1 Loc: [/home/oszi/WebKit/Source/WebKit2/UIProcess/API/qt/tests/qquickwebview/tst_qquickwebview.cpp(148)] PASS : tst_QQuickWebView::baseUrl() PASS : tst_QQuickWebView::loadEmptyUrl() FAIL! : tst_QQuickWebView::loadEmptyPageViewVisible() 'waitForLoadSucceeded(webView())' returned FALSE. () Loc: [/home/oszi/WebKit/Source/WebKit2/UIProcess/API/qt/tests/qquickwebview/tst_qquickwebview.cpp(176)] FAIL! : tst_QQuickWebView::loadEmptyPageViewHidden() 'waitForLoadSucceeded(webView())' returned FALSE. () Loc: [/home/oszi/WebKit/Source/WebKit2/UIProcess/API/qt/tests/qquickwebview/tst_qquickwebview.cpp(176)] FAIL! : tst_QQuickWebView::loadNonexistentFileUrl() 'waitForLoadFailed(webView())' returned FALSE. () Loc: [/home/oszi/WebKit/Source/WebKit2/UIProcess/API/qt/tests/qquickwebview/tst_qquickwebview.cpp(186)] FAIL! : tst_QQuickWebView::backAndForward() 'waitForLoadSucceeded(webView())' returned FALSE. () Loc: [/home/oszi/WebKit/Source/WebKit2/UIProcess/API/qt/tests/qquickwebview/tst_qquickwebview.cpp(194)] FAIL! : tst_QQuickWebView::reload() 'waitForLoadSucceeded(webView())' returned FALSE. () Loc: [/home/oszi/WebKit/Source/WebKit2/UIProcess/API/qt/tests/qquickwebview/tst_qquickwebview.cpp(217)] FAIL! : tst_QQuickWebView::stop() 'waitForLoadSucceeded(webView())' returned FALSE. () Loc: [/home/oszi/WebKit/Source/WebKit2/UIProcess/API/qt/tests/qquickwebview/tst_qquickwebview.cpp(230)] FAIL! : tst_QQuickWebView::loadProgress() 'waitForLoadSucceeded(webView())' returned FALSE. () Loc: [/home/oszi/WebKit/Source/WebKit2/UIProcess/API/qt/tests/qquickwebview/tst_qquickwebview.cpp(244)] FAIL! : tst_QQuickWebView::scrollRequest() 'waitForViewportReady(webView())' returned FALSE. () Loc: [/home/oszi/WebKit/Source/WebKit2/UIProcess/API/qt/tests/qquickwebview/tst_qquickwebview.cpp(447)] PASS : tst_QQuickWebView::show() FAIL! : tst_QQuickWebView::showWebView() 'waitForLoadSucceeded(webView())' returned FALSE. () Loc: [/home/oszi/WebKit/Source/WebKit2/UIProcess/API/qt/tests/qquickwebview/tst_qquickwebview.cpp(264)] FAIL! : tst_QQuickWebView::removeFromCanvas() 'waitForLoadSucceeded(webView())' returned FALSE. () Loc: [/home/oszi/WebKit/Source/WebKit2/UIProcess/API/qt/tests/qquickwebview/tst_qquickwebview.cpp(264)] QFATAL : tst_QQuickWebView::multipleWebViewWindows() Received signal 15 FAIL! : tst_QQuickWebView::multipleWebViewWindows() Received a fatal error. Loc: [Unknown file(0)] Totals: 6 passed, 12 failed, 0 skipped ********* Finished testing of tst_QQuickWebView ********* ********* Start testing of tst_publicapi ********* Config: Using QTest library 5.0.0, Qt 5.0.0 PASS : tst_publicapi::initTestCase() PASS : tst_publicapi::publicAPI() PASS : tst_publicapi::cleanupTestCase() Totals: 3 passed, 0 failed, 0 skipped ********* Finished testing of tst_publicapi ********* ********************************************************************** ** TOTALS: 20 passed, 29 failed, 0 skipped, 1 crashed ** ********************************************************************** 750471 1 ossy 2012-10-25 00:22:11 -0700 I tried updating qtbase (22975c56a69b3d80939d0cb8ef633b9bca90d5b3) and qtdeclarative (a3a611d88dff663cce3fd8033295c5190624e859) to trunk as Jocelyn suggested, but in this configuration Qt5 is unbuildable. 750622 2 ossy 2012-10-25 03:41:01 -0700 I managed to build trunk qt5.git with trunk - qtbase (22975c56a69b3d80939d0cb8ef633b9bca90d5b3) - qtdeclarative (a3a611d88dff663cce3fd8033295c5190624e859) - qtlocation (a3a611d88dff663cce3fd8033295c5190624e859) submodules The fails disappered, but zillion warnings introduced: ********* Start testing of tst_QQuickWebView ********* Config: Using QTest library 5.0.0, Qt 5.0.0 PASS : tst_QQuickWebView::initTestCase() PASS : tst_QQuickWebView::accessPage() PASS : tst_QQuickWebView::navigationStatusAtStartup() PASS : tst_QQuickWebView::stopEnabledAfterLoadStarted() PASS : tst_QQuickWebView::baseUrl() PASS : tst_QQuickWebView::loadEmptyUrl() QWARN : tst_QQuickWebView::loadEmptyPageViewVisible() Unable to find a renderable master window QQuickView(0x7fcd6c04c850) when trying to render QQuickView(0x7fcd6c04c850) ( QRect(0,0 0x0) ). PASS : tst_QQuickWebView::loadEmptyPageViewVisible() PASS : tst_QQuickWebView::loadEmptyPageViewHidden() PASS : tst_QQuickWebView::loadNonexistentFileUrl() PASS : tst_QQuickWebView::backAndForward() PASS : tst_QQuickWebView::reload() PASS : tst_QQuickWebView::stop() PASS : tst_QQuickWebView::loadProgress() PASS : tst_QQuickWebView::scrollRequest() QWARN : tst_QQuickWebView::show() Unable to find a renderable master window QQuickView(0x7fcd6c079290) when trying to render QQuickView(0x7fcd6c079290) ( QRect(0,0 0x0) ). PASS : tst_QQuickWebView::show() QWARN : tst_QQuickWebView::showWebView() Unable to find a renderable master window QQuickView(0xf31330) when trying to render QQuickView(0xf31330) ( QRect(0,0 0x0) ). QWARN : tst_QQuickWebView::showWebView() Unable to find a renderable master window QQuickView(0xf31330) when trying to render QQuickView(0xf31330) ( QRect(0,0 0x0) ). PASS : tst_QQuickWebView::showWebView() QWARN : tst_QQuickWebView::removeFromCanvas() Unable to find a renderable master window QQuickView(0xf4b160) when trying to render QQuickView(0xf4b160) ( QRect(0,0 0x0) ). QWARN : tst_QQuickWebView::removeFromCanvas() Unable to find a renderable master window QQuickView(0xf4b160) when trying to render QQuickView(0xf4b160) ( QRect(0,0 0x0) ). QWARN : tst_QQuickWebView::removeFromCanvas() Unable to find a renderable master window QQuickView(0xf4b160) when trying to render QQuickView(0xf4b160) ( QRect(0,0 0x0) ). PASS : tst_QQuickWebView::removeFromCanvas() QWARN : tst_QQuickWebView::multipleWebViewWindows() Unable to find a renderable master window QQuickView(0x7fcd6c16e0f0) when trying to render QQuickView(0x7fcd6c16e0f0) ( QRect(0,0 0x0) ). QWARN : tst_QQuickWebView::multipleWebViewWindows() Unable to find a renderable master window QQuickView(0x7fcd6c16e0f0) when trying to render QQuickView(0x7fcd6c16e0f0) ( QRect(0,0 0x0) ). QWARN : tst_QQuickWebView::multipleWebViewWindows() Unable to find a renderable master window QQuickView(0x7fcd6c16e0f0) when trying to render QQuickView(0x7fcd6c16e0f0) ( QRect(0,0 0x0) ). QWARN : tst_QQuickWebView::multipleWebViewWindows() Unable to find a renderable master window QQuickView(0xf50a80) when trying to render QQuickView(0xf50a80) ( QRect(0,0 0x0) ). QWARN : tst_QQuickWebView::multipleWebViewWindows() Unable to find a renderable master window QQuickView(0x7fcd6c16e0f0) when trying to render QQuickView(0x7fcd6c16e0f0) ( QRect(0,0 0x0) ). QWARN : tst_QQuickWebView::multipleWebViewWindows() Unable to find a renderable master window QQuickView(0xf50a80) when trying to render QQuickView(0xf50a80) ( QRect(0,0 0x0) ). QWARN : tst_QQuickWebView::multipleWebViewWindows() Unable to find a renderable master window QQuickView(0x7fcd6c16e0f0) when trying to render QQuickView(0x7fcd6c16e0f0) ( QRect(0,0 0x0) ). QWARN : tst_QQuickWebView::multipleWebViewWindows() Unable to find a renderable master window QQuickView(0xf50a80) when trying to render QQuickView(0xf50a80) ( QRect(0,0 0x0) ). QWARN : tst_QQuickWebView::multipleWebViewWindows() Unable to find a renderable master window QQuickView(0x7fcd6c16e0f0) when trying to render QQuickView(0x7fcd6c16e0f0) ( QRect(0,0 0x0) ). QWARN : tst_QQuickWebView::multipleWebViewWindows() Unable to find a renderable master window QQuickView(0x7fcd6c173ea0) when trying to render QQuickView(0x7fcd6c173ea0) ( QRect(0,0 0x0) ). PASS : tst_QQuickWebView::multipleWebViewWindows() QWARN : tst_QQuickWebView::multipleWebViews() Unable to find a renderable master window QQuickView(0x7fcd6c16d1e0) when trying to render QQuickView(0x7fcd6c16d1e0) ( QRect(0,0 0x0) ). QWARN : tst_QQuickWebView::multipleWebViews() Unable to find a renderable master window QQuickView(0x7fcd6c16d1e0) when trying to render QQuickView(0x7fcd6c16d1e0) ( QRect(0,0 0x0) ). QWARN : tst_QQuickWebView::multipleWebViews() Unable to find a renderable master window QQuickView(0x7fcd6c16d1e0) when trying to render QQuickView(0x7fcd6c16d1e0) ( QRect(0,0 0x0) ). QWARN : tst_QQuickWebView::multipleWebViews() Unable to find a renderable master window QQuickView(0x7fcd6c16d1e0) when trying to render QQuickView(0x7fcd6c16d1e0) ( QRect(0,0 0x0) ). QWARN : tst_QQuickWebView::multipleWebViews() Unable to find a renderable master window QQuickView(0x7fcd6c16d1e0) when trying to render QQuickView(0x7fcd6c16d1e0) ( QRect(0,0 0x0) ). QWARN : tst_QQuickWebView::multipleWebViews() Unable to find a renderable master window QQuickView(0x7fcd6c16d1e0) when trying to render QQuickView(0x7fcd6c16d1e0) ( QRect(0,0 0x0) ). PASS : tst_QQuickWebView::multipleWebViews() PASS : tst_QQuickWebView::titleUpdate() QWARN : tst_QQuickWebView::transparentWebViews() Unable to find a renderable master window QQuickView(0x7fcd7400e310) when trying to render QQuickView(0x7fcd7400e310) ( QRect(0,0 0x0) ). QWARN : tst_QQuickWebView::transparentWebViews() Unable to find a renderable master window QQuickView(0x7fcd7400e310) when trying to render QQuickView(0x7fcd7400e310) ( QRect(0,0 0x0) ). QWARN : tst_QQuickWebView::transparentWebViews() Unable to find a renderable master window QQuickView(0x7fcd7400e310) when trying to render QQuickView(0x7fcd7400e310) ( QRect(0,0 0x0) ). QWARN : tst_QQuickWebView::transparentWebViews() Unable to find a renderable master window QQuickView(0x7fcd7400e310) when trying to render QQuickView(0x7fcd7400e310) ( QRect(0,0 0x0) ). QWARN : tst_QQuickWebView::transparentWebViews() Unable to find a renderable master window QQuickView(0x7fcd7400e310) when trying to render QQuickView(0x7fcd7400e310) ( QRect(0,0 0x0) ). QWARN : tst_QQuickWebView::transparentWebViews() Unable to find a renderable master window QQuickView(0x7fcd7400e310) when trying to render QQuickView(0x7fcd7400e310) ( QRect(0,0 0x0) ). PASS : tst_QQuickWebView::transparentWebViews() PASS : tst_QQuickWebView::inputMethod() PASS : tst_QQuickWebView::inputMethodHints() QWARN : tst_QQuickWebView::basicRenderingSanity() Unable to find a renderable master window QQuickView(0x7fcd7400a750) when trying to render QQuickView(0x7fcd7400a750) ( QRect(0,0 0x0) ). QWARN : tst_QQuickWebView::basicRenderingSanity() Unable to find a renderable master window QQuickView(0x7fcd7400a750) when trying to render QQuickView(0x7fcd7400a750) ( QRect(0,0 0x0) ). PASS : tst_QQuickWebView::basicRenderingSanity() PASS : tst_QQuickWebView::cleanupTestCase() Totals: 25 passed, 0 failed, 0 skipped ********* Finished testing of tst_QQuickWebView ********* 751046 3 ossy 2012-10-25 11:26:32 -0700 qt5.git is updated, the bug is still valid on the latest Qt5 hash - c0772fa7a5f5904ced225960897a512053d23a1b 751060 4 ossy 2012-10-25 11:39:42 -0700 This warning introduced in qtdeclarative with this update, it was assertion previously - https://qt.gitorious.org/qt/qtdeclarative/commit/e0521a579e967d670a5f6d7d4a4cd90a6aa56e17?format=html 751715 5 jturcotte 2012-10-26 02:15:12 -0700 Balazs might have an idea, else I can have a look in a couple of days. 751811 6 kbalazs 2012-10-26 03:48:59 -0700 I am going to look into this. 753006 7 kbalazs 2012-10-28 16:37:05 -0700 With ToT qt5.git (71c071399ad74325e2997980f6416a962b92e932) I also got a crash in removeFromCanvas() under LayerTreeRenderer::renderToCurrentGLContext. It does not seems to be in connection with the warnings. #0 0x00007ffff7ec6f00 in ?? () #1 0x00007ffff40e66ee in WebCore::GraphicsLayerTextureMapper::setChildren(WTF::Vector<WebCore::GraphicsLayer*, 0ul> const&) () from /home/balazs/WebKitGit/WebKitBuild/Release/lib/../lib/libWebCore.so.1 #2 0x00007ffff79f537a in WebKit::LayerTreeRenderer::setLayerChildren(unsigned int, WTF::Vector<unsigned int, 0ul> const&) () from /home/balazs/WebKitGit/WebKitBuild/Release/lib/libWebKit2.so.1 #3 0x00007ffff40eab51 in WebCore::TextureMapperLayer::paintSelf(WebCore::TextureMapperPaintOptions const&) () from /home/balazs/WebKitGit/WebKitBuild/Release/lib/../lib/libWebCore.so.1 #4 0x00007ffff40eb8a9 in WebCore::TextureMapperLayer::paintSelfAndChildren(WebCore::TextureMapperPaintOptions const&) () from /home/balazs/WebKitGit/WebKitBuild/Release/lib/../lib/libWebCore.so.1 #5 0x00007ffff40ebae9 in WebCore::TextureMapperLayer::paintSelfAndChildrenWithReplica(WebCore::TextureMapperPaintOptions const&) () from /home/balazs/WebKitGit/WebKitBuild/Release/lib/../lib/libWebCore.so.1 #6 0x00007ffff40ebce4 in WebCore::TextureMapperLayer::paintRecursive(WebCore::TextureMapperPaintOptions const&) [clone .part.80] () from /home/balazs/WebKitGit/WebKitBuild/Release/lib/../lib/libWebCore.so.1 #7 0x00007ffff40eb72f in WebCore::TextureMapperLayer::paintSelfAndChildren(WebCore::TextureMapperPaintOptions const&) [clone .part.81] () from /home/balazs/WebKitGit/WebKitBuild/Release/lib/../lib/libWebCore.so.1 #8 0x00007ffff40ebae9 in WebCore::TextureMapperLayer::paintSelfAndChildrenWithReplica(WebCore::TextureMapperPaintOptions const&) () from /home/balazs/WebKitGit/WebKitBuild/Release/lib/../lib/libWebCore.so.1 #9 0x00007ffff40ebce4 in WebCore::TextureMapperLayer::paintRecursive(WebCore::TextureMapperPaintOptions const&) [clone .part.80] () from /home/balazs/WebKitGit/WebKitBuild/Release/lib/../lib/libWebCore.so.1 #10 0x00007ffff40eb72f in WebCore::TextureMapperLayer::paintSelfAndChildren(WebCore::TextureMapperPaintOptions const&) [clone .part.81] () from /home/balazs/WebKitGit/WebKitBuild/Release/lib/../lib/libWebCore.so.1 #11 0x00007ffff40ebae9 in WebCore::TextureMapperLayer::paintSelfAndChildrenWithReplica(WebCore::TextureMapperPaintOptions const&) () from /home/balazs/WebKitGit/WebKitBuild/Release/lib/../lib/libWebCore.so.1 #12 0x00007ffff40ebce4 in WebCore::TextureMapperLayer::paintRecursive(WebCore::TextureMapperPaintOptions const&) [clone .part.80] () from /home/balazs/WebKitGit/WebKitBuild/Release/lib/../lib/libWebCore.so.1 #13 0x00007ffff40eb72f in WebCore::TextureMapperLayer::paintSelfAndChildren(WebCore::TextureMapperPaintOptions const&) [clone .part.81] () from /home/balazs/WebKitGit/WebKitBuild/Release/lib/../lib/libWebCore.so.1 #14 0x00007ffff40ebae9 in WebCore::TextureMapperLayer::paintSelfAndChildrenWithReplica(WebCore::TextureMapperPaintOptions const&) () from /home/balazs/WebKitGit/WebKitBuild/Release/lib/../lib/libWebCore.so.1 #15 0x00007ffff40ebce4 in WebCore::TextureMapperLayer::paintRecursive(WebCore::TextureMapperPaintOptions const&) [clone .part.80] () from /home/balazs/WebKitGit/WebKitBuild/Release/lib/../lib/libWebCore.so.1 #16 0x00007ffff40eb72f in WebCore::TextureMapperLayer::paintSelfAndChildren(WebCore::TextureMapperPaintOptions const&) [clone .part.81] () from /home/balazs/WebKitGit/WebKitBuild/Release/lib/../lib/libWebCore.so.1 #17 0x00007ffff40ebae9 in WebCore::TextureMapperLayer::paintSelfAndChildrenWithReplica(WebCore::TextureMapperPaintOptions const&) () from /home/balazs/WebKitGit/WebKitBuild/Release/lib/../lib/libWebCore.so.1 #18 0x00007ffff40ebce4 in WebCore::TextureMapperLayer::paintRecursive(WebCore::TextureMapperPaintOptions const&) [clone .part.80] () from /home/balazs/WebKitGit/WebKitBuild/Release/lib/../lib/libWebCore.so.1 #19 0x00007ffff40eb72f in WebCore::TextureMapperLayer::paintSelfAndChildren(WebCore::TextureMapperPaintOptions const&) [clone .part.81] () from /home/balazs/WebKitGit/WebKitBuild/Release/lib/../lib/libWebCore.so.1 #20 0x00007ffff40ebae9 in WebCore::TextureMapperLayer::paintSelfAndChildrenWithReplica(WebCore::TextureMapperPaintOptions const&) () from /home/balazs/WebKitGit/WebKitBuild/Release/lib/../lib/libWebCore.so.1 #21 0x00007ffff40ebce4 in WebCore::TextureMapperLayer::paintRecursive(WebCore::TextureMapperPaintOptions const&) [clone .part.80] () from /home/balazs/WebKitGit/WebKitBuild/Release/lib/../lib/libWebCore.so.1 #22 0x00007ffff40ec482 in WebCore::TextureMapperLayer::paint() () from /home/balazs/WebKitGit/WebKitBuild/Release/lib/../lib/libWebCore.so.1 ---Type <return> to continue, or q <return> to quit--- #23 0x00007ffff79f2c43 in WebKit::LayerTreeRenderer::paintToCurrentGLContext(WebCore::TransformationMatrix const&, float, WebCore::FloatRect const&, unsigned int) () from /home/balazs/WebKitGit/WebKitBuild/Release/lib/libWebKit2.so.1 #24 0x00007ffff7b13573 in WebKit::ContentsSGNode::render(QSGRenderNode::RenderState const&) () from /home/balazs/WebKitGit/WebKitBuild/Release/lib/libWebKit2.so.1 #25 0x00007ffff73b4c78 in QSGDefaultRenderer::renderNodes(QSGNode* const*, int) () from /home/balazs/repo/qt5/qtbase/lib/libQtQuick.so.5 #26 0x00007ffff73b5783 in QSGDefaultRenderer::render() () from /home/balazs/repo/qt5/qtbase/lib/libQtQuick.so.5 #27 0x00007ffff73bb659 in QSGRenderer::renderScene(QSGBindable const&) () from /home/balazs/repo/qt5/qtbase/lib/libQtQuick.so.5 #28 0x00007ffff73bb787 in QSGRenderer::renderScene() () from /home/balazs/repo/qt5/qtbase/lib/libQtQuick.so.5 #29 0x00007ffff73c5854 in QSGContext::renderNextFrame(QSGRenderer*, unsigned int) () from /home/balazs/repo/qt5/qtbase/lib/libQtQuick.so.5 #30 0x00007ffff73f52ec in QQuickWindowPrivate::renderSceneGraph(QSize const&) () from /home/balazs/repo/qt5/qtbase/lib/libQtQuick.so.5 #31 0x00007ffff74d9d87 in QQuickTrivialWindowManager::renderWindow(QQuickWindow*) () from /home/balazs/repo/qt5/qtbase/lib/libQtQuick.so.5 753007 8 171144 kbalazs 2012-10-28 16:47:11 -0700 Created attachment 171144 Patch 753008 9 kbalazs 2012-10-28 16:52:42 -0700 (In reply to comment #8) > Created an attachment (id=171144) [details] > Patch The warnings are disappearing with this patch, but it does not fix the crash. Also I had to do a workaround by manually resizing the window to the item's size because otherwise it does not happen before the first rendering (so the warning is triggered). I think this is a bug in Qt, it should consider the ResizeViewToRootItem flag. Feel free to correct me if you have a better understanding. 753279 10 jturcotte 2012-10-29 04:58:45 -0700 (In reply to comment #9) > The warnings are disappearing with this patch, but it does not fix the crash. Also I had to do a workaround by manually resizing the window to the item's size because otherwise it does not happen before the first rendering (so the warning is triggered). I think this is a bug in Qt, it should consider the ResizeViewToRootItem flag. Feel free to correct me if you have a better understanding. You're the one with the best understanding right now, but I think that it would be better to make sure that it can't be fixed in Qt before adding duck tape. 753295 11 kbalazs 2012-10-29 05:33:35 -0700 Err, I retested it on my office machine and here the show() test always crash in xvfb, with or without the patch (it works fine outside from xvfb). Also I get a lot of other warnings in xvfb: QWARN : tst_QQuickWebView::loadEmptyPageViewVisible() QOpenGLShader::compile(Vertex): failed QWARN : tst_QQuickWebView::loadEmptyPageViewVisible() QOpenGLShader::compile(Fragment): failed QWARN : tst_QQuickWebView::loadEmptyPageViewVisible() QSGMaterialShader: Shader compilation failed: QWARN : tst_QQuickWebView::loadEmptyPageViewVisible() "" QWARN : tst_QQuickWebView::loadEmptyPageViewVisible() QOpenGLShaderProgram::uniformLocation( matrix ): shader program is not linked QWARN : tst_QQuickWebView::loadEmptyPageViewVisible() QOpenGLShaderProgram::uniformLocation( color ): shader program is not linked and the same for scrollRequest() and show(). I'm not sure about whether xvfb is an environment we can actually support. Does anybody now whether it has GPU access? Does it fully supports OpenGL (either in software or hardware)? Actually there are a lot of random crashes appearing in the history of API tests, so it's a bigger deal to fix them (I guess some of these should have the same root). 753296 12 kbalazs 2012-10-29 05:34:17 -0700 (In reply to comment #11) > Err, I retested it on my office machine and here the show() test always crash in xvfb, with or without the patch (it works fine outside from xvfb). Also I get a lot of other warnings in xvfb: Forgot to note that the crash happens at the same place, see the backtrace above. 753299 13 jturcotte 2012-10-29 05:40:10 -0700 (In reply to comment #12) > (In reply to comment #11) > > Err, I retested it on my office machine and here the show() test always crash in xvfb, with or without the patch (it works fine outside from xvfb). Also I get a lot of other warnings in xvfb: > > Forgot to note that the crash happens at the same place, see the backtrace above. My knowledge is that xvfb uses the mesa software OpenGL implementation and it's pretty complete (but slow). If it crashes it might be bugs of the new xcb backend of Qt in combination with specific behaviors of xvfb (just a guess though). Warnings shouldn't be a problem as long as they're hidden and they're not about stuff that might fail the tests. 754227 14 kbalazs 2012-10-30 05:06:29 -0700 Current state, including Jocelyn's recent fixes: 1. pinned Qt hash native -> all green xvfb -> crash in showWebvView 2. update candidate (c0772fa7a5f5904ced225960897a512053d23a1b) native -> all green xvfb -> master window warnings + crash in basicRenderingSanity :( 754242 15 kbalazs 2012-10-30 05:23:43 -0700 (In reply to comment #14) > Current state, including Jocelyn's recent fixes: > 1. pinned Qt hash > native -> all green > xvfb -> crash in showWebvView > 2. update candidate (c0772fa7a5f5904ced225960897a512053d23a1b) > native -> all green > xvfb -> master window warnings + crash in basicRenderingSanity :( With my patch in xvfb both crash in show. Btw I don't think my patch is really necessary, since tests that actually want to render are already set size and window geometry explicitly. So the bug now is that we crash in xvfb as soon as start rendering. 754351 16 kbalazs 2012-10-30 07:26:42 -0700 This bug contains way too many mixed information already. I filed bug 100758 for tracking the problems with xvfb. 754489 17 171480 kbalazs 2012-10-30 10:25:26 -0700 Created attachment 171480 Patch 755185 18 171480 jturcotte 2012-10-31 05:31:56 -0700 Comment on attachment 171480 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=171480&action=review > Source/WebKit2/UIProcess/API/qt/tests/testwindow.h:52 > + resize(300, 400); Does it work if you put this in the TestWindow constructor instead? I'd prefer not hiding QWindow::show if possible. 755372 19 kbalazs 2012-10-31 09:30:52 -0700 (In reply to comment #18) > (From update of attachment 171480 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=171480&action=review > > > Source/WebKit2/UIProcess/API/qt/tests/testwindow.h:52 > > + resize(300, 400); > > Does it work if you put this in the TestWindow constructor instead? > I'd prefer not hiding QWindow::show if possible. Ok. Also I realized that changing showWindow to m_window->show is not identical because showWindow also load content. 755373 20 171673 kbalazs 2012-10-31 09:32:20 -0700 Created attachment 171673 Patch 755381 21 171673 jturcotte 2012-10-31 09:39:50 -0700 Comment on attachment 171673 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=171673&action=review > Source/WebKit2/UIProcess/API/qt/tests/qquickwebview/tst_qquickwebview.cpp:331 > showWebView(); Yeah showWebView is a test on its own and I think it's wrong that tests are using it to show the web view, but this cached a couple of bugs so no reason to remove it :) > Source/WebKit2/UIProcess/API/qt/tests/qquickwebview/tst_qquickwebview.cpp:-344 > - // We have to explicitly move the window into the screen, otherwise it's not rendered. > - m_window->setGeometry(0, 0, 300, 400); > - m_window->show(); Humm, not sure why this was needed. 755382 22 jturcotte 2012-10-31 09:40:55 -0700 (In reply to comment #21) > Yeah showWebView is a test on its own and I think it's wrong that tests are using it to show the web view, but this cached a couple of bugs so no reason to remove it :) s/cached/caught/ 755390 23 171673 kbalazs 2012-10-31 09:46:01 -0700 Comment on attachment 171673 Patch Clearing flags on attachment: 171673 Committed r133039: <http://trac.webkit.org/changeset/133039> 755391 24 kbalazs 2012-10-31 09:46:07 -0700 All reviewed patches have been landed. Closing bug. 171144 2012-10-28 16:47:11 -0700 2012-10-30 05:24:02 -0700 Patch bug-100247-20121029004538.patch text/plain 2587 kbalazs U3VidmVyc2lvbiBSZXZpc2lvbjogMTMyNzMzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggMTU5NWEwZGRmYTM1NDVh NWE0MmIxODY1YzM2MzVmYmEzODBkNzM5Yi4uYzhjZTZkN2ExNmRkNTQ5ODNhMjVhODdlMDE2MTEy YWUxOWQ4ODBkMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEyLTEwLTI4ICBCYWxh enMgS2VsZW1lbiAgPGtiYWxhenNAd2Via2l0Lm9yZz4KKworICAgICAgICBbUXRdW1dLMl0gRml4 ICJVbmFibGUgdG8gZmluZCBhIHJlbmRlcmFibGUgbWFzdGVyIHdpbmRvdyBRUXVpY2tWaWV3IiB3 YXJuaW5ncyBpbiB0c3RfUVF1aWNrV2ViVmlldworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTAwMjQ3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgTWFrZSBzdXJlIHdlIGhhdmUgYSB2aXNpYmxlIHdpbmRvdy4K KworICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvcXQvdGVzdHMvcXF1aWNrd2Vidmlldy90c3RfcXF1 aWNrd2Vidmlldy5jcHA6CisgICAgICAgICh0c3RfUVF1aWNrV2ViVmlldzo6bmV3V2ViVmlldyk6 IEdpdmUgYSBkZWZhdWx0IHNpemUgdG8gdGhlIGl0ZW0uCisgICAgICAgICogVUlQcm9jZXNzL0FQ SS9xdC90ZXN0cy90ZXN0d2luZG93Lmg6CisgICAgICAgIChUZXN0V2luZG93OjpUZXN0V2luZG93 KTogTWFrZSBzdXJlIHdlIHJlc2l6ZSBhY2NvcmRpbmcgdG8gdGhlIGl0ZW0ncyBzaXplLgorICAg ICAgICBUaGUgZmFjdCB0aGF0IGl0IGRvZXMgbm90IGhhcHBlbiBhdXRvbWF0aWNhbGx5IGFjY29y ZGluZyB0byBTaXplVmlld1RvUm9vdE9iamVjdAorICAgICAgICBpcyBzZWVtcyB0byBiZSBhIGJ1 ZyBpbiBRdC4KKwogMjAxMi0xMC0yNyAgRGFuIEJlcm5zdGVpbiAgPG1pdHpAYXBwbGUuY29tPgog CiAgICAgICAgIFJFQUxfUExBVEZPUk1fTkFNRSBidWlsZCBzZXR0aW5nIGlzIG5vIGxvbmdlciBu ZWVkZWQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvcXQvdGVzdHMv cXF1aWNrd2Vidmlldy90c3RfcXF1aWNrd2Vidmlldy5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9VSVBy b2Nlc3MvQVBJL3F0L3Rlc3RzL3FxdWlja3dlYnZpZXcvdHN0X3FxdWlja3dlYnZpZXcuY3BwCmlu ZGV4IDU1ODA1MzcyOTM4MmIwMTZlNjQ4OWU4ZjFmN2MxZWU4NTc5YmQ0YzMuLjE4NTQ3MjQ2YTM5 ZDdhOWNlMGJiMWU0MWIyNTQ0MTkzMzQwMGJjMGYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQy L1VJUHJvY2Vzcy9BUEkvcXQvdGVzdHMvcXF1aWNrd2Vidmlldy90c3RfcXF1aWNrd2Vidmlldy5j cHAKKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9xdC90ZXN0cy9xcXVpY2t3ZWJ2 aWV3L3RzdF9xcXVpY2t3ZWJ2aWV3LmNwcApAQCAtOTQsNiArOTQsOCBAQCBRUXVpY2tXZWJWaWV3 KiB0c3RfUVF1aWNrV2ViVmlldzo6bmV3V2ViVmlldygpCiAgICAgUU9iamVjdCogdmlld0luc3Rh bmNlID0gbV9jb21wb25lbnQtPmNyZWF0ZSgpOwogICAgIFFRdWlja1dlYlZpZXcqIHdlYlZpZXcg PSBxb2JqZWN0X2Nhc3Q8UVF1aWNrV2ViVmlldyo+KHZpZXdJbnN0YW5jZSk7CiAgICAgd2ViVmll dy0+ZXhwZXJpbWVudGFsKCktPnNldERldmljZVBpeGVsUmF0aW8oMS41KTsKKyAgICBjb25zdCBR U2l6ZUYgZGVmYXVsdFNpemUoMzAwLCA0MDApOworICAgIHdlYlZpZXctPnNldFNpemUoZGVmYXVs dFNpemUpOwogICAgIHJldHVybiB3ZWJWaWV3OwogfQogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi S2l0Mi9VSVByb2Nlc3MvQVBJL3F0L3Rlc3RzL3Rlc3R3aW5kb3cuaCBiL1NvdXJjZS9XZWJLaXQy L1VJUHJvY2Vzcy9BUEkvcXQvdGVzdHMvdGVzdHdpbmRvdy5oCmluZGV4IDRiMmNmY2YxMTE3YmIy ODk0YWM5ZDBkNGY4ZGJkNmI1NDQ1YmUzZmMuLmVhYWNmNjZjYzc3YmEwZTdkYTcxYzJhMjk4YThk NWVmZDhmMDJkNGMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvcXQv dGVzdHMvdGVzdHdpbmRvdy5oCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvcXQv dGVzdHMvdGVzdHdpbmRvdy5oCkBAIC00NCw2ICs0NCwxMCBAQCBpbmxpbmUgVGVzdFdpbmRvdzo6 VGVzdFdpbmRvdyhRUXVpY2tJdGVtKiB3ZWJWaWV3KQogewogICAgIFFfQVNTRVJUKHdlYlZpZXcp OwogICAgIHdlYlZpZXctPnNldFBhcmVudEl0ZW0oY29udGVudEl0ZW0oKSk7CisKKyAgICAvLyBG SVhNRTogdGhpcyBzaG91bGQgbm90IGJlIG5lY2Vzc2FyeSBidXQgc29tZXRpbWVzIFF0IGZhaWxz IHRvIHJlc2l6ZSB1cworICAgIC8vIHRvIHRoZSBpdGVtJ3Mgc2l6ZSBiZWZvcmUgdGhlIGZpcnN0 IHJlbmRlcmluZy4KKyAgICBzZXRHZW9tZXRyeSgwLCAwLCB3ZWJWaWV3LT53aWR0aCgpLCB3ZWJW aWV3LT5oZWlnaHQoKSk7CiB9CiAKIGlubGluZSB2b2lkIFRlc3RXaW5kb3c6OnJlc2l6ZUV2ZW50 KFFSZXNpemVFdmVudCogZXZlbnQpCg== 171480 2012-10-30 10:25:26 -0700 2012-10-31 09:32:15 -0700 Patch bug-100247-20121030182350.patch text/plain 5091 kbalazs U3VidmVyc2lvbiBSZXZpc2lvbjogMTMyODg3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggMzg0NWExMzRmNWEwNGNm NDUxYWU3N2E3ZmJmODkyMjI4MTU3YzUyNy4uNGZlMWJmNTYxZTIxNTM2MDljN2U4ZmU1YjAxMDRh ZjIzNzZjZWNhMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDEyLTEwLTMwICBCYWxh enMgS2VsZW1lbiAgPGtiYWxhenNAd2Via2l0Lm9yZz4KKworICAgICAgICBbUXRdW1dLMl0gRml4 ICJVbmFibGUgdG8gZmluZCBhIHJlbmRlcmFibGUgbWFzdGVyIHdpbmRvdyBRUXVpY2tWaWV3IiB3 YXJuaW5ncyBpbiB0c3RfUVF1aWNrV2ViVmlldworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTAwMjQ3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgTWFrZSBzdXJlIHdlIGhhdmUgYSB2aXNpYmxlIHdpbmRvdyBm b3IgdGVzdHMgdGhhdCB3YW50IHRvIHJlbmRlci4KKworICAgICAgICAqIFVJUHJvY2Vzcy9BUEkv cXQvdGVzdHMvcXF1aWNrd2Vidmlldy90c3RfcXF1aWNrd2Vidmlldy5jcHA6CisgICAgICAgICh0 c3RfUVF1aWNrV2ViVmlldzo6c2hvd1dlYlZpZXcpOgorICAgICAgICAodHN0X1FRdWlja1dlYlZp ZXc6OnJlbW92ZUZyb21DYW52YXMpOgorICAgICAgICAodHN0X1FRdWlja1dlYlZpZXc6Om11bHRp cGxlV2ViVmlld1dpbmRvd3MpOgorICAgICAgICAodHN0X1FRdWlja1dlYlZpZXc6Om11bHRpcGxl V2ViVmlld3MpOgorICAgICAgICAodHN0X1FRdWlja1dlYlZpZXc6OmJhc2ljUmVuZGVyaW5nU2Fu aXR5KToKKyAgICAgICAgKHRzdF9RUXVpY2tXZWJWaWV3Ojp0cmFuc3BhcmVudFdlYlZpZXdzKToK KyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL3F0L3Rlc3RzL3Rlc3R3aW5kb3cuaDoKKyAgICAgICAg KFRlc3RXaW5kb3cpOgorICAgICAgICAoVGVzdFdpbmRvdzo6c2hvdyk6CisKIDIwMTItMTAtMzAg IE1pa2hhaWwgUG96ZG55YWtvdiAgPG1pa2hhaWwucG96ZG55YWtvdkBpbnRlbC5jb20+CiAKICAg ICAgICAgW0VGTF1bV0syXSBTaW1wbGlmeSBzaWduYWwgZW1pdHRpbmcgQVBJIGluIEV3a1ZpZXdJ bXBsCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL3F0L3Rlc3RzL3Fx dWlja3dlYnZpZXcvdHN0X3FxdWlja3dlYnZpZXcuY3BwIGIvU291cmNlL1dlYktpdDIvVUlQcm9j ZXNzL0FQSS9xdC90ZXN0cy9xcXVpY2t3ZWJ2aWV3L3RzdF9xcXVpY2t3ZWJ2aWV3LmNwcAppbmRl eCA1NTgwNTM3MjkzODJiMDE2ZTY0ODllOGYxZjdjMWVlODU3OWJkNGMzLi43MDdlMWNkZjhiMTlm ZGU0NjI0ZGQ0Zjg3NGEzOTRjN2QwNzFiZGFlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9V SVByb2Nlc3MvQVBJL3F0L3Rlc3RzL3FxdWlja3dlYnZpZXcvdHN0X3FxdWlja3dlYnZpZXcuY3Bw CisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvcXQvdGVzdHMvcXF1aWNrd2Vidmll dy90c3RfcXF1aWNrd2Vidmlldy5jcHAKQEAgLTI1OCwxMiArMjU4LDEwIEBAIHZvaWQgdHN0X1FR dWlja1dlYlZpZXc6OnNob3coKQogCiB2b2lkIHRzdF9RUXVpY2tXZWJWaWV3OjpzaG93V2ViVmll dygpCiB7Ci0gICAgd2ViVmlldygpLT5zZXRTaXplKFFTaXplRigzMDAsIDQwMCkpOwotCiAgICAg d2ViVmlldygpLT5zZXRVcmwoUVVybDo6ZnJvbUxvY2FsRmlsZShRTGF0aW4xU3RyaW5nKFRFU1RT X1NPVVJDRV9ESVIgIi9odG1sL2RpcmVjdC1pbWFnZS1jb21wb3NpdGluZy5odG1sIikpKTsKICAg ICBRVkVSSUZZKHdhaXRGb3JMb2FkU3VjY2VlZGVkKHdlYlZpZXcoKSkpOwotCiAgICAgbV93aW5k b3ctPnNob3coKTsKKwogICAgIC8vIFRoaXMgc2hvdWxkIG5vdCBjcmFzaC4KICAgICB3ZWJWaWV3 KCktPnNldFZpc2libGUodHJ1ZSk7CiAgICAgUVRlc3Q6OnFXYWl0KDIwMCk7CkBAIC0yNzMsNyAr MjcxLDcgQEAgdm9pZCB0c3RfUVF1aWNrV2ViVmlldzo6c2hvd1dlYlZpZXcoKQogCiB2b2lkIHRz dF9RUXVpY2tXZWJWaWV3OjpyZW1vdmVGcm9tQ2FudmFzKCkKIHsKLSAgICBzaG93V2ViVmlldygp OworICAgIG1fd2luZG93LT5zaG93KCk7CiAKICAgICAvLyBUaGlzIHNob3VsZCBub3QgY3Jhc2gu CiAgICAgUVF1aWNrSXRlbSogcGFyZW50ID0gd2ViVmlldygpLT5wYXJlbnRJdGVtKCk7CkBAIC0y ODcsNyArMjg1LDcgQEAgdm9pZCB0c3RfUVF1aWNrV2ViVmlldzo6cmVtb3ZlRnJvbUNhbnZhcygp CiAKIHZvaWQgdHN0X1FRdWlja1dlYlZpZXc6Om11bHRpcGxlV2ViVmlld1dpbmRvd3MoKQogewot ICAgIHNob3dXZWJWaWV3KCk7CisgICAgbV93aW5kb3ctPnNob3coKTsKIAogICAgIC8vIFRoaXMg c2hvdWxkIG5vdCBjcmFzaC4KICAgICBRUXVpY2tXZWJWaWV3KiB3ZWJWaWV3MSA9IG5ld1dlYlZp ZXcoKTsKQEAgLTI5NSwxMyArMjkzLDExIEBAIHZvaWQgdHN0X1FRdWlja1dlYlZpZXc6Om11bHRp cGxlV2ViVmlld1dpbmRvd3MoKQogICAgIFFRdWlja1dlYlZpZXcqIHdlYlZpZXcyID0gbmV3V2Vi VmlldygpOwogICAgIFFTY29wZWRQb2ludGVyPFRlc3RXaW5kb3c+IHdpbmRvdzIobmV3IFRlc3RX aW5kb3cod2ViVmlldzIpKTsKIAotICAgIHdlYlZpZXcxLT5zZXRTaXplKFFTaXplRigzMDAsIDQw MCkpOwogICAgIHdlYlZpZXcxLT5zZXRVcmwoUVVybDo6ZnJvbUxvY2FsRmlsZShRTGF0aW4xU3Ry aW5nKFRFU1RTX1NPVVJDRV9ESVIgIi9odG1sL3Njcm9sbC5odG1sIikpKTsKICAgICBRVkVSSUZZ KHdhaXRGb3JMb2FkU3VjY2VlZGVkKHdlYlZpZXcxKSk7CiAgICAgd2luZG93MS0+c2hvdygpOwog ICAgIHdlYlZpZXcxLT5zZXRWaXNpYmxlKHRydWUpOwogCi0gICAgd2ViVmlldzItPnNldFNpemUo UVNpemVGKDMwMCwgNDAwKSk7CiAgICAgd2ViVmlldzItPnNldFVybChRVXJsOjpmcm9tTG9jYWxG aWxlKFFMYXRpbjFTdHJpbmcoVEVTVFNfU09VUkNFX0RJUiAiL2h0bWwvYmFzaWNfcGFnZS5odG1s IikpKTsKICAgICBRVkVSSUZZKHdhaXRGb3JMb2FkU3VjY2VlZGVkKHdlYlZpZXcyKSk7CiAgICAg d2luZG93Mi0+c2hvdygpOwpAQCAtMzExLDcgKzMwNyw3IEBAIHZvaWQgdHN0X1FRdWlja1dlYlZp ZXc6Om11bHRpcGxlV2ViVmlld1dpbmRvd3MoKQogCiB2b2lkIHRzdF9RUXVpY2tXZWJWaWV3Ojpt dWx0aXBsZVdlYlZpZXdzKCkKIHsKLSAgICBzaG93V2ViVmlldygpOworICAgIG1fd2luZG93LT5z aG93KCk7CiAKICAgICAvLyBUaGlzIHNob3VsZCBub3QgY3Jhc2guCiAgICAgUVNjb3BlZFBvaW50 ZXI8UVF1aWNrV2ViVmlldz4gd2ViVmlldzEobmV3V2ViVmlldygpKTsKQEAgLTMzMywxNSArMzI5 LDExIEBAIHZvaWQgdHN0X1FRdWlja1dlYlZpZXc6Om11bHRpcGxlV2ViVmlld3MoKQogCiB2b2lk IHRzdF9RUXVpY2tXZWJWaWV3OjpiYXNpY1JlbmRlcmluZ1Nhbml0eSgpCiB7Ci0gICAgc2hvd1dl YlZpZXcoKTsKLSAgICB3ZWJWaWV3KCktPnNldFNpemUoUVNpemVGKDMwMCwgNDAwKSk7CisgICAg bV93aW5kb3ctPnNob3coKTsKIAogICAgIHdlYlZpZXcoKS0+c2V0VXJsKFFVcmwoUVN0cmluZzo6 ZnJvbVV0ZjgoImRhdGE6dGV4dC9odG1sLDxodG1sPjxib2R5IGJnY29sb3I9XCIjMDBmZjAwXCI+ PC9ib2R5PjwvaHRtbD4iKSkpOwogICAgIFFWRVJJRlkod2FpdEZvckxvYWRTdWNjZWVkZWQod2Vi VmlldygpKSk7CiAKLSAgICAvLyBXZSBoYXZlIHRvIGV4cGxpY2l0bHkgbW92ZSB0aGUgd2luZG93 IGludG8gdGhlIHNjcmVlbiwgb3RoZXJ3aXNlIGl0J3Mgbm90IHJlbmRlcmVkLgotICAgIG1fd2lu ZG93LT5zZXRHZW9tZXRyeSgwLCAwLCAzMDAsIDQwMCk7Ci0gICAgbV93aW5kb3ctPnNob3coKTsK ICAgICAvLyBUaGlzIHNob3VsZCBub3QgY3Jhc2guCiAgICAgd2ViVmlldygpLT5zZXRWaXNpYmxl KHRydWUpOwogICAgIFFUZXN0OjpxV2FpdCgyMDApOwpAQCAtMzczLDcgKzM2NSw3IEBAIHZvaWQg dHN0X1FRdWlja1dlYlZpZXc6OnRpdGxlVXBkYXRlKCkKIAogdm9pZCB0c3RfUVF1aWNrV2ViVmll dzo6dHJhbnNwYXJlbnRXZWJWaWV3cygpCiB7Ci0gICAgc2hvd1dlYlZpZXcoKTsKKyAgICBtX3dp bmRvdy0+c2hvdygpOwogCiAgICAgLy8gVGhpcyBzaG91bGQgbm90IGNyYXNoLgogICAgIFFTY29w ZWRQb2ludGVyPFFRdWlja1dlYlZpZXc+IHdlYlZpZXcxKG5ld1dlYlZpZXcoKSk7CmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL3F0L3Rlc3RzL3Rlc3R3aW5kb3cuaCBi L1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvcXQvdGVzdHMvdGVzdHdpbmRvdy5oCmluZGV4 IDRiMmNmY2YxMTE3YmIyODk0YWM5ZDBkNGY4ZGJkNmI1NDQ1YmUzZmMuLjhmNzZhYzdjZjYwZDI2 NWU0MmQ3N2Q3ZjNhYzZjOGQ4ZGRhYWMzNGUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJ UHJvY2Vzcy9BUEkvcXQvdGVzdHMvdGVzdHdpbmRvdy5oCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJ UHJvY2Vzcy9BUEkvcXQvdGVzdHMvdGVzdHdpbmRvdy5oCkBAIC0zMyw2ICszMyw3IEBACiBjbGFz cyBUZXN0V2luZG93IDogcHVibGljIFFRdWlja1ZpZXcgewogcHVibGljOgogICAgIGlubGluZSBU ZXN0V2luZG93KFFRdWlja0l0ZW0qIHdlYlZpZXcpOworICAgIGlubGluZSB2b2lkIHNob3coKTsK ICAgICBRU2NvcGVkUG9pbnRlcjxRUXVpY2tJdGVtPiB3ZWJWaWV3OwogCiBwcm90ZWN0ZWQ6CkBA IC00Niw2ICs0NywxMiBAQCBpbmxpbmUgVGVzdFdpbmRvdzo6VGVzdFdpbmRvdyhRUXVpY2tJdGVt KiB3ZWJWaWV3KQogICAgIHdlYlZpZXctPnNldFBhcmVudEl0ZW0oY29udGVudEl0ZW0oKSk7CiB9 CiAKK2lubGluZSB2b2lkIFRlc3RXaW5kb3c6OnNob3coKQoreworICAgIHJlc2l6ZSgzMDAsIDQw MCk7CisgICAgUVF1aWNrVmlldzo6c2hvdygpOworfQorCiBpbmxpbmUgdm9pZCBUZXN0V2luZG93 OjpyZXNpemVFdmVudChRUmVzaXplRXZlbnQqIGV2ZW50KQogewogICAgIFFRdWlja1ZpZXc6OnJl c2l6ZUV2ZW50KGV2ZW50KTsK 171673 2012-10-31 09:32:20 -0700 2012-10-31 09:46:01 -0700 Patch bug-100247-20121031173042.patch text/plain 3891 kbalazs U3VidmVyc2lvbiBSZXZpc2lvbjogMTMyODg2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggYTMzNjE5YmU5NDkzYjll ODUzYjAyOTJiODYwOGY5Mjc3YTEzYjcwMi4uZTA1NGE0NTE2YzM3OWU5N2FlYmEwOGQxNTQ1NjUz OTAwNzg3NmU5MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDEyLTEwLTMxICBCYWxh enMgS2VsZW1lbiAgPGtiYWxhenNAd2Via2l0Lm9yZz4KKworICAgICAgICBbUXRdW1dLMl0gRml4 ICJVbmFibGUgdG8gZmluZCBhIHJlbmRlcmFibGUgbWFzdGVyIHdpbmRvdyBRUXVpY2tWaWV3IiB3 YXJuaW5ncyBpbiB0c3RfUVF1aWNrV2ViVmlldworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTAwMjQ3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgTWFrZSBzdXJlIHdlIGhhdmUgYSB2aXNpYmxlIHdpbmRvdyBm b3IgdGVzdHMgdGhhdCB3YW50IHRvIHJlbmRlci4KKworICAgICAgICAqIFVJUHJvY2Vzcy9BUEkv cXQvdGVzdHMvcXF1aWNrd2Vidmlldy90c3RfcXF1aWNrd2Vidmlldy5jcHA6CisgICAgICAgICh0 c3RfUVF1aWNrV2ViVmlldzo6c2hvd1dlYlZpZXcpOgorICAgICAgICAodHN0X1FRdWlja1dlYlZp ZXc6OnJlbW92ZUZyb21DYW52YXMpOgorICAgICAgICAodHN0X1FRdWlja1dlYlZpZXc6Om11bHRp cGxlV2ViVmlld1dpbmRvd3MpOgorICAgICAgICAodHN0X1FRdWlja1dlYlZpZXc6Om11bHRpcGxl V2ViVmlld3MpOgorICAgICAgICAodHN0X1FRdWlja1dlYlZpZXc6OmJhc2ljUmVuZGVyaW5nU2Fu aXR5KToKKyAgICAgICAgKHRzdF9RUXVpY2tXZWJWaWV3Ojp0cmFuc3BhcmVudFdlYlZpZXdzKToK KyAgICAgICAgUmVtb3ZlZCBzb21lIHVubmVjZXNzYXJ5IHJlc2l6ZSBub3cgdGhhdCB0aGUgd2lu ZG93IGhhdmUgYSBkZWZhdWx0IHNpemUuCisgICAgICAgICogVUlQcm9jZXNzL0FQSS9xdC90ZXN0 cy90ZXN0d2luZG93Lmg6CisgICAgICAgIChUZXN0V2luZG93KTogUmVzaXplIHRoZSB3aW5kb3cg dG8gYSBkZWZhdWx0IHNpemUgYXQgY29uc3RydWN0aW9uLgorCiAyMDEyLTEwLTMwICBKb2NlbHlu IFR1cmNvdHRlICA8am9jZWx5bi50dXJjb3R0ZUBkaWdpYS5jb20+CiAKICAgICAgICAgQ29vcmRp bmF0ZWQgR3JhcGhpY3M6IFVucmVsZWFzZSBhZG9wdGVkIGltYWdlcwpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9xdC90ZXN0cy9xcXVpY2t3ZWJ2aWV3L3RzdF9xcXVp Y2t3ZWJ2aWV3LmNwcCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvcXQvdGVzdHMvcXF1 aWNrd2Vidmlldy90c3RfcXF1aWNrd2Vidmlldy5jcHAKaW5kZXggNTU4MDUzNzI5MzgyYjAxNmU2 NDg5ZThmMWY3YzFlZTg1NzliZDRjMy4uNmUyYzM0MmNiYmZhZjllN2IxMDNkNTM1MjA3ZmQ5ZmJi Y2Y1ZTkxNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9xdC90ZXN0 cy9xcXVpY2t3ZWJ2aWV3L3RzdF9xcXVpY2t3ZWJ2aWV3LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0 Mi9VSVByb2Nlc3MvQVBJL3F0L3Rlc3RzL3FxdWlja3dlYnZpZXcvdHN0X3FxdWlja3dlYnZpZXcu Y3BwCkBAIC0yNTgsMTEgKzI1OCw4IEBAIHZvaWQgdHN0X1FRdWlja1dlYlZpZXc6OnNob3coKQog CiB2b2lkIHRzdF9RUXVpY2tXZWJWaWV3OjpzaG93V2ViVmlldygpCiB7Ci0gICAgd2ViVmlldygp LT5zZXRTaXplKFFTaXplRigzMDAsIDQwMCkpOwotCiAgICAgd2ViVmlldygpLT5zZXRVcmwoUVVy bDo6ZnJvbUxvY2FsRmlsZShRTGF0aW4xU3RyaW5nKFRFU1RTX1NPVVJDRV9ESVIgIi9odG1sL2Rp cmVjdC1pbWFnZS1jb21wb3NpdGluZy5odG1sIikpKTsKICAgICBRVkVSSUZZKHdhaXRGb3JMb2Fk U3VjY2VlZGVkKHdlYlZpZXcoKSkpOwotCiAgICAgbV93aW5kb3ctPnNob3coKTsKICAgICAvLyBU aGlzIHNob3VsZCBub3QgY3Jhc2guCiAgICAgd2ViVmlldygpLT5zZXRWaXNpYmxlKHRydWUpOwpA QCAtMjk1LDEzICsyOTIsMTEgQEAgdm9pZCB0c3RfUVF1aWNrV2ViVmlldzo6bXVsdGlwbGVXZWJW aWV3V2luZG93cygpCiAgICAgUVF1aWNrV2ViVmlldyogd2ViVmlldzIgPSBuZXdXZWJWaWV3KCk7 CiAgICAgUVNjb3BlZFBvaW50ZXI8VGVzdFdpbmRvdz4gd2luZG93MihuZXcgVGVzdFdpbmRvdyh3 ZWJWaWV3MikpOwogCi0gICAgd2ViVmlldzEtPnNldFNpemUoUVNpemVGKDMwMCwgNDAwKSk7CiAg ICAgd2ViVmlldzEtPnNldFVybChRVXJsOjpmcm9tTG9jYWxGaWxlKFFMYXRpbjFTdHJpbmcoVEVT VFNfU09VUkNFX0RJUiAiL2h0bWwvc2Nyb2xsLmh0bWwiKSkpOwogICAgIFFWRVJJRlkod2FpdEZv ckxvYWRTdWNjZWVkZWQod2ViVmlldzEpKTsKICAgICB3aW5kb3cxLT5zaG93KCk7CiAgICAgd2Vi VmlldzEtPnNldFZpc2libGUodHJ1ZSk7CiAKLSAgICB3ZWJWaWV3Mi0+c2V0U2l6ZShRU2l6ZUYo MzAwLCA0MDApKTsKICAgICB3ZWJWaWV3Mi0+c2V0VXJsKFFVcmw6OmZyb21Mb2NhbEZpbGUoUUxh dGluMVN0cmluZyhURVNUU19TT1VSQ0VfRElSICIvaHRtbC9iYXNpY19wYWdlLmh0bWwiKSkpOwog ICAgIFFWRVJJRlkod2FpdEZvckxvYWRTdWNjZWVkZWQod2ViVmlldzIpKTsKICAgICB3aW5kb3cy LT5zaG93KCk7CkBAIC0zMzQsMTQgKzMyOSwxMCBAQCB2b2lkIHRzdF9RUXVpY2tXZWJWaWV3Ojpt dWx0aXBsZVdlYlZpZXdzKCkKIHZvaWQgdHN0X1FRdWlja1dlYlZpZXc6OmJhc2ljUmVuZGVyaW5n U2FuaXR5KCkKIHsKICAgICBzaG93V2ViVmlldygpOwotICAgIHdlYlZpZXcoKS0+c2V0U2l6ZShR U2l6ZUYoMzAwLCA0MDApKTsKIAogICAgIHdlYlZpZXcoKS0+c2V0VXJsKFFVcmwoUVN0cmluZzo6 ZnJvbVV0ZjgoImRhdGE6dGV4dC9odG1sLDxodG1sPjxib2R5IGJnY29sb3I9XCIjMDBmZjAwXCI+ PC9ib2R5PjwvaHRtbD4iKSkpOwogICAgIFFWRVJJRlkod2FpdEZvckxvYWRTdWNjZWVkZWQod2Vi VmlldygpKSk7CiAKLSAgICAvLyBXZSBoYXZlIHRvIGV4cGxpY2l0bHkgbW92ZSB0aGUgd2luZG93 IGludG8gdGhlIHNjcmVlbiwgb3RoZXJ3aXNlIGl0J3Mgbm90IHJlbmRlcmVkLgotICAgIG1fd2lu ZG93LT5zZXRHZW9tZXRyeSgwLCAwLCAzMDAsIDQwMCk7Ci0gICAgbV93aW5kb3ctPnNob3coKTsK ICAgICAvLyBUaGlzIHNob3VsZCBub3QgY3Jhc2guCiAgICAgd2ViVmlldygpLT5zZXRWaXNpYmxl KHRydWUpOwogICAgIFFUZXN0OjpxV2FpdCgyMDApOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktp dDIvVUlQcm9jZXNzL0FQSS9xdC90ZXN0cy90ZXN0d2luZG93LmggYi9Tb3VyY2UvV2ViS2l0Mi9V SVByb2Nlc3MvQVBJL3F0L3Rlc3RzL3Rlc3R3aW5kb3cuaAppbmRleCA0YjJjZmNmMTExN2JiMjg5 NGFjOWQwZDRmOGRiZDZiNTQ0NWJlM2ZjLi45ZDVkNjU2ZTlmZTViMDkxYTg5NGIzNDMxMjBkNTU5 MWNiZDA1OWJjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL3F0L3Rl c3RzL3Rlc3R3aW5kb3cuaAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL3F0L3Rl c3RzL3Rlc3R3aW5kb3cuaApAQCAtNDQsNiArNDQsNyBAQCBpbmxpbmUgVGVzdFdpbmRvdzo6VGVz dFdpbmRvdyhRUXVpY2tJdGVtKiB3ZWJWaWV3KQogewogICAgIFFfQVNTRVJUKHdlYlZpZXcpOwog ICAgIHdlYlZpZXctPnNldFBhcmVudEl0ZW0oY29udGVudEl0ZW0oKSk7CisgICAgcmVzaXplKDMw MCwgNDAwKTsKIH0KIAogaW5saW5lIHZvaWQgVGVzdFdpbmRvdzo6cmVzaXplRXZlbnQoUVJlc2l6 ZUV2ZW50KiBldmVudCkK