100225 2012-10-24 03:49:49 -0700 [EFL][WK2] Add APIs to get/set the default text encoding name 2014-02-07 22:41:14 -0800 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Other Linux RESOLVED DUPLICATE 126736 P2 Normal --- 0 yhnet.jung webkit-unassigned cdumez gyuyoung.kim lucas.de.marchi rakuco ryuan.choi webkit.review.bot oldest_to_newest 749510 0 yhnet.jung 2012-10-24 03:49:49 -0700 Add setting APIs for default text encoding and a unit test. 749511 1 170356 yhnet.jung 2012-10-24 03:56:32 -0700 Created attachment 170356 Patch 750263 2 170356 jinwoo7.song 2012-10-24 18:01:26 -0700 Comment on attachment 170356 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=170356&action=review > Source/WebKit2/UIProcess/API/efl/ewk_settings.cpp:277 > + Why not return the encoding name from WKPrefercenCopyDefaultTextEncodingName()? > Source/WebKit2/UIProcess/API/efl/ewk_settings_private.h:41 > + mutable WKEinaSharedString defaultTextEncoding; Why do we need to add this variable? 750371 3 170356 kangil.han 2012-10-24 22:36:29 -0700 Comment on attachment 170356 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=170356&action=review > Source/WebKit2/UIProcess/API/efl/ewk_settings.cpp:265 > + EINA_SAFETY_ON_NULL_RETURN_VAL(encoding, false);? 750385 4 170356 cdumez 2012-10-24 22:50:43 -0700 Comment on attachment 170356 Patch Needs rebasing due to recent Ewk_Settings design changes. 753190 5 170356 rakuco 2012-10-29 02:32:46 -0700 Comment on attachment 170356 Patch Clearing the r? flag meanwhile. 753489 6 170356 gyuyoung.kim 2012-10-29 09:07:07 -0700 Comment on attachment 170356 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=170356&action=review > Source/WebKit2/UIProcess/API/efl/ewk_settings.h:320 > +EAPI const char* ewk_settings_default_encoding_get(const Ewk_Settings *settings); Nit : wrong * place. 798292 7 180964 yhnet.jung 2012-12-30 22:15:28 -0800 Created attachment 180964 Patch 798293 8 170356 yhnet.jung 2012-12-30 22:17:34 -0800 Comment on attachment 170356 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=170356&action=review >> Source/WebKit2/UIProcess/API/efl/ewk_settings.cpp:265 >> + > > EINA_SAFETY_ON_NULL_RETURN_VAL(encoding, false);? I added EINA_SAFETY_ON_NULL_RETURN_VAL(encoding, false). >> Source/WebKit2/UIProcess/API/efl/ewk_settings.h:320 >> +EAPI const char* ewk_settings_default_encoding_get(const Ewk_Settings *settings); > > Nit : wrong * place. I changed * place to "const char *ewk_settings_default_encoding_get". >> Source/WebKit2/UIProcess/API/efl/ewk_settings_private.h:41 >> + mutable WKEinaSharedString defaultTextEncoding; > > Why do we need to add this variable? Because memory for returned default encoding name is released after ewk_settings_default_encoding_get() is called, So, defaultTextEncoding variable is needed to keep returned default encoding name. 798301 9 180964 cdumez 2012-12-30 23:33:36 -0800 Comment on attachment 180964 Patch LGTM. 798515 10 180964 gyuyoung.kim 2013-01-01 18:04:07 -0800 Comment on attachment 180964 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=180964&action=review > Source/WebKit2/UIProcess/API/efl/ewk_settings.cpp:59 > + if (defaultTextEncoding.isEmpty()) I wonder what meaning this condition has. Because, isEmpty() just checks if String has a character at least or null. Look at isEmpty() function. bool isEmpty() const { return !m_impl || !m_impl->length(); } However, I think "preferences()->defaultTextEncodingName()" won't be null. So, it seems to me that this condition isn't needed, doesn't it ? Is below enough ? m_defaultTextEncoding = preferences()->defaultTextEncodingName().utf8().data(); 798517 11 180964 kangil.han 2013-01-01 18:24:13 -0800 Comment on attachment 180964 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=180964&action=review > Source/WebKit2/UIProcess/API/efl/ewk_settings.cpp:62 > + m_defaultTextEncoding = defaultTextEncoding.utf8().data(); Seems saved 'm_defaultTextEncoding' isn't used elsewhere. Then, can we remove it? 802865 12 180964 benjamin 2013-01-08 18:06:44 -0800 Comment on attachment 180964 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=180964&action=review >> Source/WebKit2/UIProcess/API/efl/ewk_settings.cpp:62 >> + m_defaultTextEncoding = defaultTextEncoding.utf8().data(); This is incorrect. The char buffer is invalid pas that line. You need to hold on the CString if you want to keep a character buffer alive. 803016 13 180964 cdumez 2013-01-08 21:56:26 -0800 Comment on attachment 180964 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=180964&action=review >>> Source/WebKit2/UIProcess/API/efl/ewk_settings.cpp:62 >>> + m_defaultTextEncoding = defaultTextEncoding.utf8().data(); >> >> Seems saved 'm_defaultTextEncoding' isn't used elsewhere. >> Then, can we remove it? > > This is incorrect. The char buffer is invalid pas that line. > You need to hold on the CString if you want to keep a character buffer alive. m_defaulltTextEncoding is not a char* but a WKEinaSharedString. The string is actually copied so the code is correct. This is bit of a particularity of EFL port since our APIs returns EINA Stringshared strings. 978300 14 ryuan.choi 2014-02-07 22:41:14 -0800 Already fixed at Bug 126736 *** This bug has been marked as a duplicate of bug 126736 *** 170356 2012-10-24 03:56:32 -0700 2012-12-30 22:17:34 -0800 Patch bug-100225-20121024195507.patch text/plain 5535 yhnet.jung U3VidmVyc2lvbiBSZXZpc2lvbjogMTMyMzEzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggMjdmODQxZmRkMjRjMDdi YzdkNzMxZGNhM2ViZjhiMmI3YzVkMTFhMi4uNDA5OGE5M2U2OTIzMDM3OTQ2YmRiNjJiNjc0MGYx OTNhYzcxYmIyYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDEyLTEwLTI0ICBZdW5p IEplb25nICA8eWhuZXQuanVuZ0BzYW1zdW5nLmNvbT4KKworICAgICAgICBbRUZMXVtXSzJdIEFk ZCBBUElzIHRvIGdldC9zZXQgdGhlIGRlZmF1bHQgdGV4dCBlbmNvZGluZyBuYW1lLgorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTAwMjI1CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkIHNldHRpbmcgQVBJ cyBmb3IgZGVmYXVsdCB0ZXh0IGVuY29kaW5nIGFuZCBhIHVuaXQgdGVzdC4KKworICAgICAgICAq IFVJUHJvY2Vzcy9BUEkvZWZsL2V3a19zZXR0aW5ncy5jcHA6CisgICAgICAgIChld2tfc2V0dGlu Z3NfZGVmYXVsdF9lbmNvZGluZ19zZXQpOgorICAgICAgICAoZXdrX3NldHRpbmdzX2RlZmF1bHRf ZW5jb2RpbmdfZ2V0KToKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL2VmbC9ld2tfc2V0dGluZ3Mu aDoKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL2VmbC9ld2tfc2V0dGluZ3NfcHJpdmF0ZS5oOgor ICAgICAgICAoRXdrX1NldHRpbmdzKToKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL2VmbC90ZXN0 cy90ZXN0X2V3azJfc2V0dGluZ3MuY3BwOgorICAgICAgICAoVEVTVF9GKToKKwogMjAxMi0xMC0y MyAgRGFuIEJlcm5zdGVpbiAgPG1pdHpAYXBwbGUuY29tPgogCiAgICAgICAgIFdlYktpdDIgcGFy dCBvZiA8cmRhcjovL3Byb2JsZW0vMjk2Njk3ND4gW21hY10gS2VybmluZyBhbmQgbGlnYXR1cmVz IGFyZSBub3QgZW5hYmxlZCBieSBkZWZhdWx0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9V SVByb2Nlc3MvQVBJL2VmbC9ld2tfc2V0dGluZ3MuY3BwIGIvU291cmNlL1dlYktpdDIvVUlQcm9j ZXNzL0FQSS9lZmwvZXdrX3NldHRpbmdzLmNwcAppbmRleCA4MDM3NjExNjhkMWEzYmFjZTY0NWU4 MzY3MWY5OTZiOTdmM2RhNmFjLi4wNTUxMDEwYzc3ZDlkOTk3ZjRmNmExNjE2ZTUyZTkwZWFjZjg2 MmYxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2VmbC9ld2tfc2V0 dGluZ3MuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZsL2V3a19zZXR0 aW5ncy5jcHAKQEAgLTI5LDYgKzI5LDcgQEAKICNpbmNsdWRlICJld2tfc2V0dGluZ3NfcHJpdmF0 ZS5oIgogI2luY2x1ZGUgPFdlYktpdDIvV0tQcmVmZXJlbmNlcy5oPgogI2luY2x1ZGUgPFdlYktp dDIvV0tQcmVmZXJlbmNlc1ByaXZhdGUuaD4KKyNpbmNsdWRlIDxXZWJLaXQyL1dLU3RyaW5nLmg+ CiAKICNpZiBFTkFCTEUoU1BFTExDSEVDSykKICNpbmNsdWRlICJXS1RleHRDaGVja2VyLmgiCkBA IC0yNTcsMyArMjU4LDIyIEBAIEVpbmFfTGlzdCogZXdrX3NldHRpbmdzX3NwZWxsX2NoZWNraW5n X2xhbmd1YWdlc19nZXQoKQogI2VuZGlmCiAgICAgcmV0dXJuIGxpc3RPZmxhbmd1YWdlczsKIH0K KworRWluYV9Cb29sIGV3a19zZXR0aW5nc19kZWZhdWx0X2VuY29kaW5nX3NldChFd2tfU2V0dGlu Z3MqIHNldHRpbmdzLCBjb25zdCBjaGFyKiBlbmNvZGluZykKK3sKKyAgICBFSU5BX1NBRkVUWV9P Tl9OVUxMX1JFVFVSTl9WQUwoc2V0dGluZ3MsIGZhbHNlKTsKKworICAgIFdLUmV0YWluUHRyPFdL U3RyaW5nUmVmPiBlbmNvZGluZ1N0cmluZyhBZG9wdFdLLCBXS1N0cmluZ0NyZWF0ZVdpdGhVVEY4 Q1N0cmluZyhlbmNvZGluZykpOworICAgIFdLUHJlZmVyZW5jZXNTZXREZWZhdWx0VGV4dEVuY29k aW5nTmFtZShzZXR0aW5ncy0+cHJlZmVyZW5jZXMuZ2V0KCksIGVuY29kaW5nU3RyaW5nLmdldCgp KTsKKworICAgIHJldHVybiB0cnVlOworfQorCitjb25zdCBjaGFyKiBld2tfc2V0dGluZ3NfZGVm YXVsdF9lbmNvZGluZ19nZXQoY29uc3QgRXdrX1NldHRpbmdzKiBzZXR0aW5ncykKK3sKKyAgICBF SU5BX1NBRkVUWV9PTl9OVUxMX1JFVFVSTl9WQUwoc2V0dGluZ3MsIDApOworCisgICAgc2V0dGlu Z3MtPmRlZmF1bHRUZXh0RW5jb2RpbmcgPSBXS0VpbmFTaGFyZWRTdHJpbmcoQWRvcHRXSywgV0tQ cmVmZXJlbmNlc0NvcHlEZWZhdWx0VGV4dEVuY29kaW5nTmFtZShzZXR0aW5ncy0+cHJlZmVyZW5j ZXMuZ2V0KCkpKTsKKworICAgIHJldHVybiBzZXR0aW5ncy0+ZGVmYXVsdFRleHRFbmNvZGluZzsK K30KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZsL2V3a19zZXR0 aW5ncy5oIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9lZmwvZXdrX3NldHRpbmdzLmgK aW5kZXggODYxYjk5MTdmYzIzNTdkMDdlZTA5NTE4YjI0OGU2MzhjMWY5MDVkZS4uYTlhYTAwZDIz MmM3N2I2ZjA5NjBmODYxNzQxZjZiZmJkZGU5Mzk5ZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktp dDIvVUlQcm9jZXNzL0FQSS9lZmwvZXdrX3NldHRpbmdzLmgKKysrIGIvU291cmNlL1dlYktpdDIv VUlQcm9jZXNzL0FQSS9lZmwvZXdrX3NldHRpbmdzLmgKQEAgLTI5OCw2ICsyOTgsMjcgQEAgRUFQ SSB2b2lkIGV3a19zZXR0aW5nc19zcGVsbF9jaGVja2luZ19sYW5ndWFnZXNfc2V0KGNvbnN0IGNo YXIgKmxhbmd1YWdlcyk7CiAgKi8KIEVBUEkgRWluYV9MaXN0ICpld2tfc2V0dGluZ3Nfc3BlbGxf Y2hlY2tpbmdfbGFuZ3VhZ2VzX2dldCh2b2lkKTsKIAorLyoqCisgKiBSZXF1ZXN0cyB0byBzZXQg ZGVmYXVsdCB0ZXh0IGVuY29kaW5nIG5hbWUuCisgKgorICogQnkgZGVmYXVsdCwgZGVmYXVsdCB0 ZXh0IGVuY29kaW5nIG5hbWUgaXMgc2V0IHRvICJJU08tODg1OS0xIi4KKyAqCisgKiBAcGFyYW0g c2V0dGluZ3Mgc2V0dGluZ3Mgb2JqZWN0IHRvIHNldCBkZWZhdWx0IHRleHQgZW5jb2RpbmcgbmFt ZQorICogQHBhcmFtIGVuY29kaW5nIGRlZmF1bHQgdGV4dCBlbmNvZGluZyBuYW1lCisgKgorICog QHJldHVybiBAYyBFSU5BX1RSVUUgb24gc3VjY2VzcyBvciBAYyBFSU5BX0ZBTFNFIG9uIGZhaWx1 cmUKKyAqLworRUFQSSBFaW5hX0Jvb2wgZXdrX3NldHRpbmdzX2RlZmF1bHRfZW5jb2Rpbmdfc2V0 KEV3a19TZXR0aW5ncyAqc2V0dGluZ3MsIGNvbnN0IGNoYXIgKmVuY29kaW5nKTsKKworLyoqCisg KiBSZXR1cm5zIGRlZmF1bHQgdGV4dCBlbmNvZGluZyBuYW1lLgorICoKKyAqIEBwYXJhbSBzZXR0 aW5ncyBzZXR0aW5ncyBvYmplY3QgdG8gcXVlcnkgZGVmYXVsdCB0ZXh0IGVuY29kaW5nIG5hbWUK KyAqCisgKiBAcmV0dXJuIGRlZmF1bHQgdGV4dCBlbmNvZGluZyBuYW1lIG9yIEBjIE5VTEwgaW4g Y2FzZSBvZiBlcnJvcgorICovCitFQVBJIGNvbnN0IGNoYXIqIGV3a19zZXR0aW5nc19kZWZhdWx0 X2VuY29kaW5nX2dldChjb25zdCBFd2tfU2V0dGluZ3MgKnNldHRpbmdzKTsKKwogI2lmZGVmIF9f Y3BsdXNwbHVzCiB9CiAjZW5kaWYKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vz cy9BUEkvZWZsL2V3a19zZXR0aW5nc19wcml2YXRlLmggYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nl c3MvQVBJL2VmbC9ld2tfc2V0dGluZ3NfcHJpdmF0ZS5oCmluZGV4IDQwYWUzYjc4MWU2YzlmZGE4 ZDUwNGIyZmQyMWI5NDkwZTY3MWY1MjYuLmY3MjIxNmE5ODUyMjg3NDc4NTgwMzVjMDljYTMwZDhj ZTkyZDIzZTMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZsL2V3 a19zZXR0aW5nc19wcml2YXRlLmgKKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9l ZmwvZXdrX3NldHRpbmdzX3ByaXZhdGUuaApAQCAtMjcsNiArMjcsNyBAQAogI2RlZmluZSBld2tf c2V0dGluZ3NfcHJpdmF0ZV9oCiAKICNpbmNsdWRlICJld2tfc2V0dGluZ3MuaCIKKyNpbmNsdWRl IDxXZWJLaXQyL1dLRWluYVNoYXJlZFN0cmluZy5oPgogI2luY2x1ZGUgPFdlYktpdDIvV0tQcmVm ZXJlbmNlcy5oPgogI2luY2x1ZGUgPFdlYktpdDIvV0tSZXRhaW5QdHIuaD4KICNpbmNsdWRlIDx3 dGYvUGFzc093blB0ci5oPgpAQCAtMzcsNiArMzgsNyBAQAogICovCiBzdHJ1Y3QgRXdrX1NldHRp bmdzIHsKICAgICBXS1JldGFpblB0cjxXS1ByZWZlcmVuY2VzUmVmPiBwcmVmZXJlbmNlczsKKyAg ICBtdXRhYmxlIFdLRWluYVNoYXJlZFN0cmluZyBkZWZhdWx0VGV4dEVuY29kaW5nOwogCiAgICAg ZXhwbGljaXQgRXdrX1NldHRpbmdzKFdLUHJlZmVyZW5jZXNSZWYgd2tQcmVmZXJlbmNlcykKICAg ICAgICAgOiBwcmVmZXJlbmNlcyh3a1ByZWZlcmVuY2VzKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YktpdDIvVUlQcm9jZXNzL0FQSS9lZmwvdGVzdHMvdGVzdF9ld2syX3NldHRpbmdzLmNwcCBiL1Nv dXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZsL3Rlc3RzL3Rlc3RfZXdrMl9zZXR0aW5ncy5j cHAKaW5kZXggMzJmOTgxNzg4OTA1NzJkZDY5MDY3MTZlMzU2YjllZmFmYzBjOTdlYS4uYTQxYWQ2 NzQ4ZjY5Mzk2NWE1NmRhYmY2OGRkMDQwN2FkNDM1MzhlOSAxMDA2NDQKLS0tIGEvU291cmNlL1dl YktpdDIvVUlQcm9jZXNzL0FQSS9lZmwvdGVzdHMvdGVzdF9ld2syX3NldHRpbmdzLmNwcAorKysg Yi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2VmbC90ZXN0cy90ZXN0X2V3azJfc2V0dGlu Z3MuY3BwCkBAIC0xNTcsMyArMTU3LDE2IEBAIFRFU1RfRihFV0syVW5pdFRlc3RCYXNlLCBld2tf c2V0dGluZ3NfZG5zX3ByZWZldGNoaW5nX2VuYWJsZWQpCiAgICAgQVNTRVJUX1RSVUUoZXdrX3Nl dHRpbmdzX2Ruc19wcmVmZXRjaGluZ19lbmFibGVkX3NldChzZXR0aW5ncywgZmFsc2UpKTsKICAg ICBBU1NFUlRfRkFMU0UoZXdrX3NldHRpbmdzX2Ruc19wcmVmZXRjaGluZ19lbmFibGVkX2dldChz ZXR0aW5ncykpOwogfQorCitURVNUX0YoRVdLMlVuaXRUZXN0QmFzZSwgZXdrX3NldHRpbmdzX2Rl ZmF1bHRfZW5jb2RpbmcpCit7CisgICAgRXdrX1NldHRpbmdzKiBzZXR0aW5ncyA9IGV3a192aWV3 X3NldHRpbmdzX2dldCh3ZWJWaWV3KCkpOworCisgICAgQVNTRVJUX1NUUkVRKCJJU08tODg1OS0x IiwgZXdrX3NldHRpbmdzX2RlZmF1bHRfZW5jb2RpbmdfZ2V0KHNldHRpbmdzKSk7CisKKyAgICBB U1NFUlRfVFJVRShld2tfc2V0dGluZ3NfZGVmYXVsdF9lbmNvZGluZ19zZXQoc2V0dGluZ3MsICJV VEYtOCIpKTsKKyAgICBBU1NFUlRfU1RSRVEoIlVURi04IiwgZXdrX3NldHRpbmdzX2RlZmF1bHRf ZW5jb2RpbmdfZ2V0KHNldHRpbmdzKSk7CisKKyAgICBBU1NFUlRfVFJVRShld2tfc2V0dGluZ3Nf ZGVmYXVsdF9lbmNvZGluZ19zZXQoc2V0dGluZ3MsICJVVEYtMTYiKSk7CisgICAgQVNTRVJUX1NU UkVRKCJVVEYtMTYiLCBld2tfc2V0dGluZ3NfZGVmYXVsdF9lbmNvZGluZ19nZXQoc2V0dGluZ3Mp KTsKK30K 180964 2012-12-30 22:15:28 -0800 2013-01-08 21:56:26 -0800 Patch bug-100225-20121231151236.patch text/plain 5561 yhnet.jung U3VidmVyc2lvbiBSZXZpc2lvbjogMTM4NTg2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggZjFhZmU1MDU0YzY1NjY4 OTYzMjBkZjgzODdjMjkyZDY4YjMzZDM4MS4uNmU2Yjk4MDhkOWQ4MDZmNjk2YWE0N2UyZTViNGU3 N2ZlOTM4ZDU0YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDEyLTEyLTMwICBZdW5p IEplb25nICA8eWhuZXQuanVuZ0BzYW1zdW5nLmNvbT4KKworICAgICAgICBbRUZMXVtXSzJdIEFk ZCBBUElzIHRvIGdldC9zZXQgdGhlIGRlZmF1bHQgdGV4dCBlbmNvZGluZyBuYW1lLgorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTAwMjI1CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkIHNldHRpbmcgQVBJ cyBmb3IgZGVmYXVsdCB0ZXh0IGVuY29kaW5nIGFuZCBhIHVuaXQgdGVzdC4KKworICAgICAgICAq IFVJUHJvY2Vzcy9BUEkvZWZsL2V3a19zZXR0aW5ncy5jcHA6CisgICAgICAgIChld2tfc2V0dGlu Z3NfZGVmYXVsdF9lbmNvZGluZ19zZXQpOgorICAgICAgICAoZXdrX3NldHRpbmdzX2RlZmF1bHRf ZW5jb2RpbmdfZ2V0KToKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL2VmbC9ld2tfc2V0dGluZ3Mu aDoKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL2VmbC9ld2tfc2V0dGluZ3NfcHJpdmF0ZS5oOgor ICAgICAgICAoRXdrX1NldHRpbmdzKToKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL2VmbC90ZXN0 cy90ZXN0X2V3azJfc2V0dGluZ3MuY3BwOgorICAgICAgICAoVEVTVF9GKToKKwogMjAxMi0xMi0z MCAgQ2hyaXN0b3BoZSBEdW1leiAgPGNocmlzdG9waGUuZHVtZXpAaW50ZWwuY29tPgogCiAgICAg ICAgIFtFRkxdW1dLMl0gSW52YWxpZCB1c2Ugb2YgdGVtcG9yYXJ5IG9iamVjdCBpbiBQcm9jZXNz TGF1bmNoZXI6OmxhdW5jaFByb2Nlc3MoKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQ cm9jZXNzL0FQSS9lZmwvZXdrX3NldHRpbmdzLmNwcCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vz cy9BUEkvZWZsL2V3a19zZXR0aW5ncy5jcHAKaW5kZXggMjVkOTgxZTZiNGUxODA0ZmI2ODNiYjc4 MTUxOWQwMDE1OGRhNWEwYi4uZjkxMjRlNTdjYzc3MGViMWFkMmExOTY3YTY5MDczZGNjMTc2ZjY3 NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9lZmwvZXdrX3NldHRp bmdzLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2VmbC9ld2tfc2V0dGlu Z3MuY3BwCkBAIC01Myw2ICs1MywxNyBAQCBXZWJLaXQ6OldlYlByZWZlcmVuY2VzKiBFd2tTZXR0 aW5nczo6cHJlZmVyZW5jZXMoKQogICAgIHJldHVybiBtX3ZpZXdJbXBsLT5wYWdlKCktPnBhZ2VH cm91cCgpLT5wcmVmZXJlbmNlcygpOwogfQogCitjb25zdCBjaGFyKiBFd2tTZXR0aW5nczo6ZGVm YXVsdFRleHRFbmNvZGluZ05hbWUoKSBjb25zdAoreworICAgIFN0cmluZyBkZWZhdWx0VGV4dEVu Y29kaW5nID0gcHJlZmVyZW5jZXMoKS0+ZGVmYXVsdFRleHRFbmNvZGluZ05hbWUoKTsKKyAgICBp ZiAoZGVmYXVsdFRleHRFbmNvZGluZy5pc0VtcHR5KCkpCisgICAgICAgIHJldHVybiAwOworCisg ICAgbV9kZWZhdWx0VGV4dEVuY29kaW5nID0gZGVmYXVsdFRleHRFbmNvZGluZy51dGY4KCkuZGF0 YSgpOworCisgICAgcmV0dXJuIG1fZGVmYXVsdFRleHRFbmNvZGluZzsKK30KKwogI2lmIEVOQUJM RShTUEVMTENIRUNLKQogc3RhdGljIHN0cnVjdCB7CiAgICAgYm9vbCBpc0NvbnRpbnVvdXNTcGVs bENoZWNraW5nRW5hYmxlZCA6IDE7CkBAIC00MjQsMyArNDM1LDE5IEBAIEVpbmFfQm9vbCBld2tf c2V0dGluZ3NfdGV4dF9hdXRvc2l6aW5nX2VuYWJsZWRfZ2V0KGNvbnN0IEV3a19TZXR0aW5ncyog c2V0dGluZ3MpCiAjZW5kaWYKIH0KIAorRWluYV9Cb29sIGV3a19zZXR0aW5nc19kZWZhdWx0X2Vu Y29kaW5nX3NldChFd2tfU2V0dGluZ3MqIHNldHRpbmdzLCBjb25zdCBjaGFyKiBlbmNvZGluZykK K3sKKyAgICBFSU5BX1NBRkVUWV9PTl9OVUxMX1JFVFVSTl9WQUwoc2V0dGluZ3MsIGZhbHNlKTsK KyAgICBFSU5BX1NBRkVUWV9PTl9OVUxMX1JFVFVSTl9WQUwoZW5jb2RpbmcsIGZhbHNlKTsKKwor ICAgIHNldHRpbmdzLT5wcmVmZXJlbmNlcygpLT5zZXREZWZhdWx0VGV4dEVuY29kaW5nTmFtZShl bmNvZGluZyk7CisKKyAgICByZXR1cm4gdHJ1ZTsKK30KKworY29uc3QgY2hhciogZXdrX3NldHRp bmdzX2RlZmF1bHRfZW5jb2RpbmdfZ2V0KGNvbnN0IEV3a19TZXR0aW5ncyogc2V0dGluZ3MpCit7 CisgICAgRUlOQV9TQUZFVFlfT05fTlVMTF9SRVRVUk5fVkFMKHNldHRpbmdzLCAwKTsKKworICAg IHJldHVybiBzZXR0aW5ncy0+ZGVmYXVsdFRleHRFbmNvZGluZ05hbWUoKTsKK30KZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZsL2V3a19zZXR0aW5ncy5oIGIvU291 cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9lZmwvZXdrX3NldHRpbmdzLmgKaW5kZXggN2VhNzI1 Yzc1MDUwM2I5ZjFlMjg4YmJhYjEzNmY3OWZiMmZmMzNjYy4uZTc3NjY0OTI4Yzc2ZTIxOTQwNGM3 MjRjM2QyMGVmMTkwNTZhZWJlMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNz L0FQSS9lZmwvZXdrX3NldHRpbmdzLmgKKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQ SS9lZmwvZXdrX3NldHRpbmdzLmgKQEAgLTUyMiw2ICs1MjIsMjcgQEAgRUFQSSBFaW5hX0Jvb2wg ZXdrX3NldHRpbmdzX3RleHRfYXV0b3NpemluZ19lbmFibGVkX3NldChFd2tfU2V0dGluZ3MgKnNl dHRpbmdzLAogICovCiBFQVBJIEVpbmFfQm9vbCBld2tfc2V0dGluZ3NfdGV4dF9hdXRvc2l6aW5n X2VuYWJsZWRfZ2V0KGNvbnN0IEV3a19TZXR0aW5ncyAqc2V0dGluZ3MpOwogCisvKioKKyAqIFJl cXVlc3RzIHRvIHNldCBkZWZhdWx0IHRleHQgZW5jb2RpbmcgbmFtZS4KKyAqCisgKiBCeSBkZWZh dWx0LCBkZWZhdWx0IHRleHQgZW5jb2RpbmcgbmFtZSBpcyBzZXQgdG8gIklTTy04ODU5LTEiLgor ICoKKyAqIEBwYXJhbSBzZXR0aW5ncyBzZXR0aW5ncyBvYmplY3QgdG8gc2V0IGRlZmF1bHQgdGV4 dCBlbmNvZGluZyBuYW1lCisgKiBAcGFyYW0gZW5jb2RpbmcgZGVmYXVsdCB0ZXh0IGVuY29kaW5n IG5hbWUKKyAqCisgKiBAcmV0dXJuIEBjIEVJTkFfVFJVRSBvbiBzdWNjZXNzIG9yIEBjIEVJTkFf RkFMU0Ugb24gZmFpbHVyZQorICovCitFQVBJIEVpbmFfQm9vbCBld2tfc2V0dGluZ3NfZGVmYXVs dF9lbmNvZGluZ19zZXQoRXdrX1NldHRpbmdzICpzZXR0aW5ncywgY29uc3QgY2hhciAqZW5jb2Rp bmcpOworCisvKioKKyAqIFJldHVybnMgZGVmYXVsdCB0ZXh0IGVuY29kaW5nIG5hbWUuCisgKgor ICogQHBhcmFtIHNldHRpbmdzIHNldHRpbmdzIG9iamVjdCB0byBxdWVyeSBkZWZhdWx0IHRleHQg ZW5jb2RpbmcgbmFtZQorICoKKyAqIEByZXR1cm4gZGVmYXVsdCB0ZXh0IGVuY29kaW5nIG5hbWUg b3IgQGMgTlVMTCBpbiBjYXNlIG9mIGVycm9yCisgKi8KK0VBUEkgY29uc3QgY2hhciAqZXdrX3Nl dHRpbmdzX2RlZmF1bHRfZW5jb2RpbmdfZ2V0KGNvbnN0IEV3a19TZXR0aW5ncyAqc2V0dGluZ3Mp OworCiAjaWZkZWYgX19jcGx1c3BsdXMKIH0KICNlbmRpZgpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YktpdDIvVUlQcm9jZXNzL0FQSS9lZmwvZXdrX3NldHRpbmdzX3ByaXZhdGUuaCBiL1NvdXJjZS9X ZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZsL2V3a19zZXR0aW5nc19wcml2YXRlLmgKaW5kZXggMzMz NWFhZDcxYzdjOTY1M2RhN2E0M2E4OWI4YjU4MDRhYzg0ODg3Ny4uNDU4YzFlMTcwZDU4ZGQ4OWVj N2IyNTgxNjE4NTU1YWM5MDZlNzQzYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9j ZXNzL0FQSS9lZmwvZXdrX3NldHRpbmdzX3ByaXZhdGUuaAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9V SVByb2Nlc3MvQVBJL2VmbC9ld2tfc2V0dGluZ3NfcHJpdmF0ZS5oCkBAIC00Nyw2ICs0Nyw4IEBA IHB1YmxpYzoKICAgICBjb25zdCBXZWJLaXQ6OldlYlByZWZlcmVuY2VzKiBwcmVmZXJlbmNlcygp IGNvbnN0OwogICAgIFdlYktpdDo6V2ViUHJlZmVyZW5jZXMqIHByZWZlcmVuY2VzKCk7CiAKKyAg ICBjb25zdCBjaGFyKiBkZWZhdWx0VGV4dEVuY29kaW5nTmFtZSgpIGNvbnN0OworCiBwcml2YXRl OgogICAgIGV4cGxpY2l0IEV3a1NldHRpbmdzKEV3a1ZpZXdJbXBsKiB2aWV3SW1wbCkKICAgICAg ICAgOiBtX3ZpZXdJbXBsKHZpZXdJbXBsKQpAQCAtNTUsNiArNTcsNyBAQCBwcml2YXRlOgogICAg IH0KIAogICAgIEV3a1ZpZXdJbXBsKiBtX3ZpZXdJbXBsOworICAgIG11dGFibGUgV0tFaW5hU2hh cmVkU3RyaW5nIG1fZGVmYXVsdFRleHRFbmNvZGluZzsKIH07CiAKICNlbmRpZiAvLyBld2tfc2V0 dGluZ3NfcHJpdmF0ZV9oCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJ L2VmbC90ZXN0cy90ZXN0X2V3azJfc2V0dGluZ3MuY3BwIGIvU291cmNlL1dlYktpdDIvVUlQcm9j ZXNzL0FQSS9lZmwvdGVzdHMvdGVzdF9ld2syX3NldHRpbmdzLmNwcAppbmRleCBjYWY2YWY0MTM0 OWI3MzQwY2MxNWUxYzIzNjI4OTM4NjY4MDM0NWY3Li4wMzg4NzIxMjBmODk3OTk2ODJhMjY4NmM1 YjVhODAzMmVhYzU1NzRkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJ L2VmbC90ZXN0cy90ZXN0X2V3azJfc2V0dGluZ3MuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJ UHJvY2Vzcy9BUEkvZWZsL3Rlc3RzL3Rlc3RfZXdrMl9zZXR0aW5ncy5jcHAKQEAgLTI4NywzICsy ODcsMTYgQEAgVEVTVF9GKEVXSzJVbml0VGVzdEJhc2UsIGV3a19zZXR0aW5nc190ZXh0X2F1dG9z aXppbmdfZW5hYmxlZCkKICAgICBBU1NFUlRfRkFMU0UoZXdrX3NldHRpbmdzX3RleHRfYXV0b3Np emluZ19lbmFibGVkX2dldChzZXR0aW5ncykpOwogI2VuZGlmCiB9CisKK1RFU1RfRihFV0syVW5p dFRlc3RCYXNlLCBld2tfc2V0dGluZ3NfZGVmYXVsdF9lbmNvZGluZykKK3sKKyAgICBFd2tfU2V0 dGluZ3MqIHNldHRpbmdzID0gZXdrX3ZpZXdfc2V0dGluZ3NfZ2V0KHdlYlZpZXcoKSk7CisKKyAg ICBBU1NFUlRfU1RSRVEoIklTTy04ODU5LTEiLCBld2tfc2V0dGluZ3NfZGVmYXVsdF9lbmNvZGlu Z19nZXQoc2V0dGluZ3MpKTsKKworICAgIEFTU0VSVF9UUlVFKGV3a19zZXR0aW5nc19kZWZhdWx0 X2VuY29kaW5nX3NldChzZXR0aW5ncywgIlVURi04IikpOworICAgIEFTU0VSVF9TVFJFUSgiVVRG LTgiLCBld2tfc2V0dGluZ3NfZGVmYXVsdF9lbmNvZGluZ19nZXQoc2V0dGluZ3MpKTsKKworICAg IEFTU0VSVF9UUlVFKGV3a19zZXR0aW5nc19kZWZhdWx0X2VuY29kaW5nX3NldChzZXR0aW5ncywg IlVURi0xNiIpKTsKKyAgICBBU1NFUlRfU1RSRVEoIlVURi0xNiIsIGV3a19zZXR0aW5nc19kZWZh dWx0X2VuY29kaW5nX2dldChzZXR0aW5ncykpOworfQo=