100203 2012-10-23 23:00:09 -0700 Regression(r132303) Broke debug build when SHADOW_DOM is enabled but STYLE_SCOPED is disabled 2012-10-24 01:15:32 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 88606 1 cdumez cdumez allan.jensen cmarcelo dglazkov gyuyoung.kim macpherson menard morrita rakuco ryuan.choi tasak webkit.review.bot oldest_to_newest 749372 0 cdumez 2012-10-23 23:00:09 -0700 r132303 broke debug build when SHADOW_DOM is enabled but STYLE_SCOPED is disabled: In file included from /home/buildslave-1/webkit-buildslave/efl-linux-64-debug/build/Source/WebCore/css/CSSCalculationValue.cpp:36:0: /home/buildslave-1/webkit-buildslave/efl-linux-64-debug/build/Source/WebCore/css/StyleResolver.h: In member function ‘WebCore::StyleScopeResolver* WebCore::StyleResolver::ensureScopeResolver()’: /home/buildslave-1/webkit-buildslave/efl-linux-64-debug/build/Source/WebCore/css/StyleResolver.h:178:58: error: ‘styleScopedEnabled’ is not a member of ‘WebCore::RuntimeEnabledFeatures’ make[2]: *** [Source/WebCore/CMakeFiles/webcore_efl.dir/css/CSSCalculationValue.cpp.o] Error 1 make[2]: *** Waiting for unfinished jobs.... 749373 1 170321 cdumez 2012-10-23 23:02:39 -0700 Created attachment 170321 Patch Could someone please cq+? 749380 2 ryuan.choi 2012-10-23 23:16:13 -0700 Committed r132312: <http://trac.webkit.org/changeset/132312> 749459 3 morrita 2012-10-24 01:15:32 -0700 Oops. Thanks for fixing this. 170321 2012-10-23 23:02:39 -0700 2012-10-23 23:16:55 -0700 Patch 100203_buildfix.patch text/plain 1563 cdumez ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBmMmMyMGI0Li5iY2FjZDViIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTgg QEAKKzIwMTItMTAtMjMgIENocmlzdG9waGUgRHVtZXogIDxjaHJpc3RvcGhlLmR1bWV6QGludGVs LmNvbT4KKworICAgICAgICBSZWdyZXNzaW9uKHIxMzIzMDMpIEJyb2tlIGRlYnVnIGJ1aWxkIHdo ZW4gU0hBRE9XX0RPTSBpcyBlbmFibGVkIGJ1dCBTVFlMRV9TQ09QRUQgaXMgZGlzYWJsZWQKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwMDIwMworCisg ICAgICAgIFVucmV2aWV3ZWQgQnVpbGQgZml4LgorCisgICAgICAgIEZpeCBjb21waWxhdGlvbiBl cnJvciBpbiBTdHlsZVJlc29sdmVyLmggd2hlbiBTSEFET1dfRE9NIGZsYWcgaXMKKyAgICAgICAg c2V0IGFuZCBTVFlMRV9TQ09QRUQgaXMgbm90LgorCisgICAgICAgIE5vIG5ldyB0ZXN0cywgbm8g YmVoYXZpb3IgY2hhbmdlLgorCisgICAgICAgICogY3NzL1N0eWxlUmVzb2x2ZXIuaDoKKyAgICAg ICAgKFdlYkNvcmU6OlN0eWxlUmVzb2x2ZXI6OmVuc3VyZVNjb3BlUmVzb2x2ZXIpOgorCiAyMDEy LTEwLTIzICBBbmRyZWFzIEtsaW5nICA8a2xpbmdAd2Via2l0Lm9yZz4KIAogICAgICAgICBSZW1v dmUgc3BlY2lhbGl6ZWQgaGFzaCB0cmFpdHMgZm9yIEdseXBoUGFnZXMuCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViQ29yZS9jc3MvU3R5bGVSZXNvbHZlci5oIGIvU291cmNlL1dlYkNvcmUvY3NzL1N0 eWxlUmVzb2x2ZXIuaAppbmRleCAxOGY2MWYwLi4xYzg2ZTAyIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViQ29yZS9jc3MvU3R5bGVSZXNvbHZlci5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL2Nzcy9TdHls ZVJlc29sdmVyLmgKQEAgLTE3NSw3ICsxNzUsMTUgQEAgcHJpdmF0ZToKICNpZiBFTkFCTEUoU1RZ TEVfU0NPUEVEKSB8fCBFTkFCTEUoU0hBRE9XX0RPTSkKICAgICBTdHlsZVNjb3BlUmVzb2x2ZXIq IGVuc3VyZVNjb3BlUmVzb2x2ZXIoKQogICAgIHsKKyNpZiBFTkFCTEUoU1RZTEVfU0NPUEVEKQor I2lmIEVOQUJMRShTSEFET1dfRE9NKQogICAgICAgICBBU1NFUlQoUnVudGltZUVuYWJsZWRGZWF0 dXJlczo6c2hhZG93RE9NRW5hYmxlZCgpIHx8IFJ1bnRpbWVFbmFibGVkRmVhdHVyZXM6OnN0eWxl U2NvcGVkRW5hYmxlZCgpKTsKKyNlbHNlCisgICAgICAgIEFTU0VSVChSdW50aW1lRW5hYmxlZEZl YXR1cmVzOjpzdHlsZVNjb3BlZEVuYWJsZWQoKSk7CisjZW5kaWYKKyNlbHNlCisgICAgICAgIEFT U0VSVChSdW50aW1lRW5hYmxlZEZlYXR1cmVzOjpzaGFkb3dET01FbmFibGVkKCkpOworI2VuZGlm CiAgICAgICAgIGlmICghbV9zY29wZVJlc29sdmVyKQogICAgICAgICAgICAgbV9zY29wZVJlc29s dmVyID0gYWRvcHRQdHIobmV3IFN0eWxlU2NvcGVSZXNvbHZlcigpKTsKICAgICAgICAgcmV0dXJu IG1fc2NvcGVSZXNvbHZlci5nZXQoKTsK