<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>100201</bug_id>
          
          <creation_ts>2012-10-23 22:45:36 -0700</creation_ts>
          <short_desc>Compiling WTF outside of WebKit failed on Windows</short_desc>
          <delta_ts>2012-12-08 18:31:41 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Platform</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>PC</rep_platform>
          <op_sys>Windows 7</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P5</priority>
          <bug_severity>Enhancement</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="mizi.bug">mizi.bug</reporter>
          <assigned_to name="Patrick R. Gansterer">paroga</assigned_to>
          <cc>benjamin</cc>
    
    <cc>bfulgham</cc>
    
    <cc>ojan.autocc</cc>
    
    <cc>paroga</cc>
    
    <cc>roger_fong</cc>
    
    <cc>webkit.review.bot</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>749366</commentid>
    <comment_count>0</comment_count>
    <who name="mizi.bug">mizi.bug</who>
    <bug_when>2012-10-23 22:45:36 -0700</bug_when>
    <thetext>1&gt;  Source\WTF\wtf\win\MainThreadWin.cpp
1&gt;..\wtf\win\MainThreadWin.cpp(69): error C2440: “=”: unable to convert from “const LPCWSTR”to“LPCSTR”
1&gt;..\wtf\win\MainThreadWin.cpp(78): error C2664: “CreateWindowExA”: unable to convert from “const LPCWSTR” to “LPCSTR”
1&gt;..\wtf\win\MainThreadWin.cpp(79): error C2664: “RegisterWindowMessageA”: unable to convert from “const wchar_t [33]”to“LPCSTR”</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>749370</commentid>
    <comment_count>1</comment_count>
      <attachid>170319</attachid>
    <who name="mizi.bug">mizi.bug</who>
    <bug_when>2012-10-23 22:53:45 -0700</bug_when>
    <thetext>Created attachment 170319
patch for this bug</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>749812</commentid>
    <comment_count>2</comment_count>
    <who name="Alexey Proskuryakov">ap</who>
    <bug_when>2012-10-24 10:42:04 -0700</bug_when>
    <thetext>Would you be willing to submit a patch for inclusion in WebKit? Please follow the steps in &lt;http://www.webkit.org/coding/contributing.html&gt; if so - in particular, every patch needs a ChangeLog, and it should be marked for review to be in review queue.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>750911</commentid>
    <comment_count>3</comment_count>
    <who name="mizi.bug">mizi.bug</who>
    <bug_when>2012-10-25 09:18:35 -0700</bug_when>
    <thetext>(In reply to comment #2)
&gt; Would you be willing to submit a patch for inclusion in WebKit? Please follow the steps in &lt;http://www.webkit.org/coding/contributing.html&gt; if so - in particular, every patch needs a ChangeLog, and it should be marked for review to be in review queue.

thx for reply. I should follow the contributing guide, but my network here is awful, so I can&apos;t check out the code with SVN or GIT, and the webkit-patch doesn&apos;t work, so I thought this may be an easy way.
I will try again, anymore advises?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>752086</commentid>
    <comment_count>4</comment_count>
      <attachid>170936</attachid>
    <who name="mizi.bug">mizi.bug</who>
    <bug_when>2012-10-26 08:46:55 -0700</bug_when>
    <thetext>Created attachment 170936
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>758050</commentid>
    <comment_count>5</comment_count>
      <attachid>170936</attachid>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2012-11-03 22:57:20 -0700</bug_when>
    <thetext>Comment on attachment 170936
Patch

Rejecting attachment 170936 from commit-queue.

Failed to run &quot;[&apos;/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch&apos;, &apos;--status-host=queues.webkit.org&apos;, &apos;-...&quot; exit_code: 2

Last 500 characters of output:
code: 1 cwd: /mnt/git/webkit-commit-queue

Parsed 2 diffs from patch file(s).
patching file source/wtf/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file source/wtf/wtf/win/MainThreadWin.cpp
Hunk #1 FAILED at 40.
Hunk #2 FAILED at 76.
2 out of 2 hunks FAILED -- saving rejects to file source/wtf/wtf/win/MainThreadWin.cpp.rej

Failed to run &quot;[u&apos;/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply&apos;, u&apos;--force&apos;, u&apos;--reviewer&apos;, u&apos;Ryosuke Ni...&quot; exit_code: 1 cwd: /mnt/git/webkit-commit-queue

Full output: http://queues.webkit.org/results/14719409</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>758133</commentid>
    <comment_count>6</comment_count>
      <attachid>170936</attachid>
    <who name="Darin Adler">darin</who>
    <bug_when>2012-11-04 08:54:44 -0800</bug_when>
    <thetext>Comment on attachment 170936
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=170936&amp;action=review

&gt; source/wtf/wtf/win/MainThreadWin.cpp:44
&gt; +const LPTSTR kThreadingWindowMessge = TEXT(&quot;com.apple.WebKit.MainThreadFired&quot;);

Messge here is a typo, with a missing &quot;a&quot;.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>763631</commentid>
    <comment_count>7</comment_count>
      <attachid>173444</attachid>
    <who name="mizi.bug">mizi.bug</who>
    <bug_when>2012-11-10 05:01:01 -0800</bug_when>
    <thetext>Created attachment 173444
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>763633</commentid>
    <comment_count>8</comment_count>
    <who name="mizi.bug">mizi.bug</who>
    <bug_when>2012-11-10 05:12:07 -0800</bug_when>
    <thetext>(In reply to comment #6)
&gt; (From update of attachment 170936 [details])
&gt; View in context: https://bugs.webkit.org/attachment.cgi?id=170936&amp;action=review
&gt; 
&gt; &gt; source/wtf/wtf/win/MainThreadWin.cpp:44
&gt; &gt; +const LPTSTR kThreadingWindowMessge = TEXT(&quot;com.apple.WebKit.MainThreadFired&quot;);
&gt; 
&gt; Messge here is a typo, with a missing &quot;a&quot;.

You mean &quot;RegisterWindowMessage&quot; should change to &quot;RegisterWindowMessageA&quot;?
It seems ok with VC 2010 in my machine.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>765810</commentid>
    <comment_count>9</comment_count>
      <attachid>173444</attachid>
    <who name="Brent Fulgham">bfulgham</who>
    <bug_when>2012-11-13 10:54:45 -0800</bug_when>
    <thetext>Comment on attachment 173444
Patch

Why do you need to provide TEXT macros here.  Are you trying to build in non-UNICODE?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>767027</commentid>
    <comment_count>10</comment_count>
    <who name="mizi.bug">mizi.bug</who>
    <bug_when>2012-11-14 10:32:36 -0800</bug_when>
    <thetext>(In reply to comment #9)
&gt; (From update of attachment 173444 [details])
&gt; Why do you need to provide TEXT macros here.  Are you trying to build in non-UNICODE?

Since I compiled the WTF seperately and it failed. And why not use &quot;TEXT&quot; here? I think it is more reasonable and error-proofing.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>768787</commentid>
    <comment_count>11</comment_count>
    <who name="Brent Fulgham">bfulgham</who>
    <bug_when>2012-11-15 18:05:19 -0800</bug_when>
    <thetext>(In reply to comment #10)
&gt; (In reply to comment #9)
&gt; &gt; (From update of attachment 173444 [details] [details])
&gt; &gt; Why do you need to provide TEXT macros here.  Are you trying to build in non-UNICODE?
&gt; 
&gt; Since I compiled the WTF seperately and it failed. And why not use &quot;TEXT&quot; here? I think it is more reasonable and error-proofing.

It seems like you built WTF in ANSI mode, which I do not think is supported.  If you built with -DUNICODE, none of these changes should have been necessary.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>768949</commentid>
    <comment_count>12</comment_count>
    <who name="mizi.bug">mizi.bug</who>
    <bug_when>2012-11-15 22:56:58 -0800</bug_when>
    <thetext>(In reply to comment #11)
&gt; (In reply to comment #10)
&gt; &gt; (In reply to comment #9)
&gt; &gt; &gt; (From update of attachment 173444 [details] [details] [details])
&gt; &gt; &gt; Why do you need to provide TEXT macros here.  Are you trying to build in non-UNICODE?
&gt; &gt; 
&gt; &gt; Since I compiled the WTF seperately and it failed. And why not use &quot;TEXT&quot; here? I think it is more reasonable and error-proofing.
&gt; 
&gt; It seems like you built WTF in ANSI mode, which I do not think is supported.  If you built with -DUNICODE, none of these changes should have been necessary.

I knew everything will be fine if I used the UNICODE mode. But why not use more compatible code if we can? If we are compelled to use the UNICODE mode, we can still put some warning or macro somewhere else.
And with my experience I think WTF can work well in ANSI mode, even it cannot, the reason is definitely not because of the code here. So I think that should be another topic.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>786648</commentid>
    <comment_count>13</comment_count>
      <attachid>173444</attachid>
    <who name="Patrick R. Gansterer">paroga</who>
    <bug_when>2012-12-08 16:12:50 -0800</bug_when>
    <thetext>Comment on attachment 173444
Patch

You need to define UNICODE in your buildsystem. WebKit does not support compiling without UNICODE.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>786650</commentid>
    <comment_count>14</comment_count>
    <who name="Patrick R. Gansterer">paroga</who>
    <bug_when>2012-12-08 16:17:35 -0800</bug_when>
    <thetext>(In reply to comment #13)
&gt; (From update of attachment 173444 [details])
&gt; You need to define UNICODE in your buildsystem. WebKit does not support compiling without UNICODE.

If you want to support non-UNICODE builds outside of WebKit you should change the code to use the Unicode function of the Windows API directly (e.g. RegisterClassW instead of RegisterClass).</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>786654</commentid>
    <comment_count>15</comment_count>
      <attachid>178387</attachid>
    <who name="Patrick R. Gansterer">paroga</who>
    <bug_when>2012-12-08 16:53:24 -0800</bug_when>
    <thetext>Created attachment 178387
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>786666</commentid>
    <comment_count>16</comment_count>
      <attachid>178387</attachid>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2012-12-08 18:31:37 -0800</bug_when>
    <thetext>Comment on attachment 178387
Patch

Clearing flags on attachment: 178387

Committed r137054: &lt;http://trac.webkit.org/changeset/137054&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>786667</commentid>
    <comment_count>17</comment_count>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2012-12-08 18:31:41 -0800</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="0"
              isprivate="0"
          >
            <attachid>170319</attachid>
            <date>2012-10-23 22:53:45 -0700</date>
            <delta_ts>2012-10-26 08:53:41 -0700</delta_ts>
            <desc>patch for this bug</desc>
            <filename>MainThreadWin.patch</filename>
            <type>text/plain</type>
            <size>973</size>
            <attacher name="mizi.bug">mizi.bug</attacher>
            
              <data encoding="base64">LS0tIEQ6XHBpZXJcV1RGXHd0Zlx3aW5cTWFpblRocmVhZFdpbi5jcHAJV2VkIE9jdCAyNCAxMzo0
NToxMCAyMDEyDQorKysgZjpcb3NcV2ViS2l0LXIxMzIwNDdcU291cmNlXFdURlx3dGZcd2luXE1h
aW5UaHJlYWRXaW4uY3BwCUZyaSBNYXIgMjMgMDc6MTE6MDkgMjAxMg0KQEAgLTQwLDggKzQwLDcg
QEANCiANCiBzdGF0aWMgSFdORCB0aHJlYWRpbmdXaW5kb3dIYW5kbGU7DQogc3RhdGljIFVJTlQg
dGhyZWFkaW5nRmlyZWRNZXNzYWdlOw0KLWNvbnN0IExQVFNUUiBrVGhyZWFkaW5nV2luZG93Q2xh
c3NOYW1lID0gVEVYVCgiVGhyZWFkaW5nV2luZG93Q2xhc3MiKTsNCi1jb25zdCBMUFRTVFIga1Ro
cmVhZGluZ1dpbmRvd01lc3NnZSA9IFRFWFQoImNvbS5hcHBsZS5XZWJLaXQuTWFpblRocmVhZEZp
cmVkIik7DQorY29uc3QgTFBDV1NUUiBrVGhyZWFkaW5nV2luZG93Q2xhc3NOYW1lID0gTCJUaHJl
YWRpbmdXaW5kb3dDbGFzcyI7DQogDQogTFJFU1VMVCBDQUxMQkFDSyBUaHJlYWRpbmdXaW5kb3dX
bmRQcm9jKEhXTkQgaFduZCwgVUlOVCBtZXNzYWdlLCBXUEFSQU0gd1BhcmFtLCBMUEFSQU0gbFBh
cmFtKQ0KIHsNCkBAIC03Nyw3ICs3Niw3IEBADQogDQogICAgIHRocmVhZGluZ1dpbmRvd0hhbmRs
ZSA9IENyZWF0ZVdpbmRvdyhrVGhyZWFkaW5nV2luZG93Q2xhc3NOYW1lLCAwLCAwLA0KICAgICAg
ICBDV19VU0VERUZBVUxULCAwLCBDV19VU0VERUZBVUxULCAwLCBoV25kUGFyZW50LCAwLCAwLCAw
KTsNCi0gICAgdGhyZWFkaW5nRmlyZWRNZXNzYWdlID0gUmVnaXN0ZXJXaW5kb3dNZXNzYWdlKGtU
aHJlYWRpbmdXaW5kb3dNZXNzZ2UpOw0KKyAgICB0aHJlYWRpbmdGaXJlZE1lc3NhZ2UgPSBSZWdp
c3RlcldpbmRvd01lc3NhZ2UoTCJjb20uYXBwbGUuV2ViS2l0Lk1haW5UaHJlYWRGaXJlZCIpOw0K
IA0KICAgICBpbml0aWFsaXplQ3VycmVudFRocmVhZEludGVybmFsKCJNYWluIFRocmVhZCIpOw0K
IH0NCg==
</data>
<flag name="review"
          id="184709"
          type_id="1"
          status="-"
          setter="mizi.bug"
    />
          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>170936</attachid>
            <date>2012-10-26 08:46:55 -0700</date>
            <delta_ts>2012-11-10 05:00:42 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-100201-20121026234523.patch</filename>
            <type>text/plain</type>
            <size>1738</size>
            <attacher name="mizi.bug">mizi.bug</attacher>
            
              <data encoding="base64">SW5kZXg6IHNvdXJjZS93dGYvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIHNvdXJjZS93dGYvQ2hh
bmdlTG9nCShyZXZpc2lvbiAxMzI2NjIpCisrKyBzb3VyY2Uvd3RmL0NoYW5nZUxvZwkod29ya2lu
ZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDEyLTEwLTI2ICBNaSBaaSAgPG1pemkuYnVnQGdt
YWlsLmNvbT4KKworICAgICAgICBDb21waWxpbmcgV1RGIGZhaWxlZCBvbiBXaW5kb3dzCisgICAg
ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDAyMDEKKworICAg
ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBDaGFuZ2UgdHdvIHN0
cmluZyBjb25zdGFudHMgdHlwZXMgdG8gZml0IFdpbmRvd3MgQVBJLgorCisgICAgICAgICogd3Rm
L3dpbi9NYWluVGhyZWFkV2luLmNwcDoKKyAgICAgICAgKFdURik6CisgICAgICAgIChXVEY6Omlu
aXRpYWxpemVNYWluVGhyZWFkUGxhdGZvcm0pOgorCiAyMDEyLTEwLTI2ICBHYWJvciBCYWxsYWJh
cyAgPGdhYm9yYkBpbmYudS1zemVnZWQuaHU+CiAKICAgICAgICAgW1F0XSBFbmFibGUgSlNDJ3Mg
ZGlzYXNzZW1ibGVyIG9uIHg4NiwgeDg2XzY0IExpbnV4CkluZGV4OiBzb3VyY2Uvd3RmL3d0Zi93
aW4vTWFpblRocmVhZFdpbi5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gc291cmNlL3d0Zi93dGYvd2luL01h
aW5UaHJlYWRXaW4uY3BwCShyZXZpc2lvbiAxMzI1NjEpCisrKyBzb3VyY2Uvd3RmL3d0Zi93aW4v
TWFpblRocmVhZFdpbi5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTQwLDcgKzQwLDggQEAgbmFtZXNw
YWNlIFdURiB7CiAKIHN0YXRpYyBIV05EIHRocmVhZGluZ1dpbmRvd0hhbmRsZTsKIHN0YXRpYyBV
SU5UIHRocmVhZGluZ0ZpcmVkTWVzc2FnZTsKLWNvbnN0IExQQ1dTVFIga1RocmVhZGluZ1dpbmRv
d0NsYXNzTmFtZSA9IEwiVGhyZWFkaW5nV2luZG93Q2xhc3MiOworY29uc3QgTFBUU1RSIGtUaHJl
YWRpbmdXaW5kb3dDbGFzc05hbWUgPSBURVhUKCJUaHJlYWRpbmdXaW5kb3dDbGFzcyIpOworY29u
c3QgTFBUU1RSIGtUaHJlYWRpbmdXaW5kb3dNZXNzZ2UgPSBURVhUKCJjb20uYXBwbGUuV2ViS2l0
Lk1haW5UaHJlYWRGaXJlZCIpOwogCiBMUkVTVUxUIENBTExCQUNLIFRocmVhZGluZ1dpbmRvd1du
ZFByb2MoSFdORCBoV25kLCBVSU5UIG1lc3NhZ2UsIFdQQVJBTSB3UGFyYW0sIExQQVJBTSBsUGFy
YW0pCiB7CkBAIC03Niw3ICs3Nyw3IEBAIHZvaWQgaW5pdGlhbGl6ZU1haW5UaHJlYWRQbGF0Zm9y
bSgpCiAKICAgICB0aHJlYWRpbmdXaW5kb3dIYW5kbGUgPSBDcmVhdGVXaW5kb3coa1RocmVhZGlu
Z1dpbmRvd0NsYXNzTmFtZSwgMCwgMCwKICAgICAgICBDV19VU0VERUZBVUxULCAwLCBDV19VU0VE
RUZBVUxULCAwLCBoV25kUGFyZW50LCAwLCAwLCAwKTsKLSAgICB0aHJlYWRpbmdGaXJlZE1lc3Nh
Z2UgPSBSZWdpc3RlcldpbmRvd01lc3NhZ2UoTCJjb20uYXBwbGUuV2ViS2l0Lk1haW5UaHJlYWRG
aXJlZCIpOworICAgIHRocmVhZGluZ0ZpcmVkTWVzc2FnZSA9IFJlZ2lzdGVyV2luZG93TWVzc2Fn
ZShrVGhyZWFkaW5nV2luZG93TWVzc2dlKTsKIAogICAgIGluaXRpYWxpemVDdXJyZW50VGhyZWFk
SW50ZXJuYWwoIk1haW4gVGhyZWFkIik7CiB9Cg==
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>173444</attachid>
            <date>2012-11-10 05:01:01 -0800</date>
            <delta_ts>2012-12-08 16:53:24 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-100201-20121110205901.patch</filename>
            <type>text/plain</type>
            <size>1754</size>
            <attacher name="mizi.bug">mizi.bug</attacher>
            
              <data encoding="base64">SW5kZXg6IHNvdXJjZS9XVEYvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIHNvdXJjZS9XVEYvQ2hh
bmdlTG9nCShyZXZpc2lvbiAxMzQxNTQpCisrKyBzb3VyY2UvV1RGL0NoYW5nZUxvZwkod29ya2lu
ZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDEyLTExLTEwICBNaSBaaSAgPG1pemkuYnVnQGdt
YWlsLmNvbT4KKworICAgICAgICBDb21waWxpbmcgV1RGIGZhaWxlZCBvbiBXaW5kb3dzCisgICAg
ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDAyMDEKKworICAg
ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBDaGFuZ2UgdHdvIHN0
cmluZyBjb25zdGFudHMnIHR5cGVzIHRvIGZpdCBXaW5kb3dzIEFQSS4KKworICAgICAgICAqIHd0
Zi93aW4vTWFpblRocmVhZFdpbi5jcHA6CisgICAgICAgIChXVEYpOgorICAgICAgICAoV1RGOjpp
bml0aWFsaXplTWFpblRocmVhZFBsYXRmb3JtKToKKwogMjAxMi0xMS0wOSAgQWxleGVpIEZpbGlw
cG92ICA8YWxwaEBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgV2ViIEluc3BlY3RvcjogRml4IGhl
YXAgc25hcHNob3RzIGNvdW50ZWQgc2V2ZXJhbCB0aW1lcyBieSBOTUkKSW5kZXg6IHNvdXJjZS9X
VEYvd3RmL3dpbi9NYWluVGhyZWFkV2luLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBzb3VyY2UvV1RGL3d0
Zi93aW4vTWFpblRocmVhZFdpbi5jcHAJKHJldmlzaW9uIDEzNDE1NCkKKysrIHNvdXJjZS9XVEYv
d3RmL3dpbi9NYWluVGhyZWFkV2luLmNwcAkod29ya2luZyBjb3B5KQpAQCAtNDAsNyArNDAsOCBA
QCBuYW1lc3BhY2UgV1RGIHsKIAogc3RhdGljIEhXTkQgdGhyZWFkaW5nV2luZG93SGFuZGxlOwog
c3RhdGljIFVJTlQgdGhyZWFkaW5nRmlyZWRNZXNzYWdlOwotY29uc3QgTFBDV1NUUiBrVGhyZWFk
aW5nV2luZG93Q2xhc3NOYW1lID0gTCJUaHJlYWRpbmdXaW5kb3dDbGFzcyI7Citjb25zdCBMUFRT
VFIga1RocmVhZGluZ1dpbmRvd0NsYXNzTmFtZSA9IFRFWFQoIlRocmVhZGluZ1dpbmRvd0NsYXNz
Iik7Citjb25zdCBMUFRTVFIga1RocmVhZGluZ0ZpcmVkTWVzc2FnZU5hbWUgPSBURVhUKCJjb20u
YXBwbGUuV2ViS2l0Lk1haW5UaHJlYWRGaXJlZCIpOwogCiBMUkVTVUxUIENBTExCQUNLIFRocmVh
ZGluZ1dpbmRvd1duZFByb2MoSFdORCBoV25kLCBVSU5UIG1lc3NhZ2UsIFdQQVJBTSB3UGFyYW0s
IExQQVJBTSBsUGFyYW0pCiB7CkBAIC03Niw3ICs3Nyw3IEBAIHZvaWQgaW5pdGlhbGl6ZU1haW5U
aHJlYWRQbGF0Zm9ybSgpCiAKICAgICB0aHJlYWRpbmdXaW5kb3dIYW5kbGUgPSBDcmVhdGVXaW5k
b3coa1RocmVhZGluZ1dpbmRvd0NsYXNzTmFtZSwgMCwgMCwKICAgICAgICBDV19VU0VERUZBVUxU
LCAwLCBDV19VU0VERUZBVUxULCAwLCBoV25kUGFyZW50LCAwLCAwLCAwKTsKLSAgICB0aHJlYWRp
bmdGaXJlZE1lc3NhZ2UgPSBSZWdpc3RlcldpbmRvd01lc3NhZ2UoTCJjb20uYXBwbGUuV2ViS2l0
Lk1haW5UaHJlYWRGaXJlZCIpOworICAgIHRocmVhZGluZ0ZpcmVkTWVzc2FnZSA9IFJlZ2lzdGVy
V2luZG93TWVzc2FnZShrVGhyZWFkaW5nRmlyZWRNZXNzYWdlTmFtZSk7CiAKICAgICBpbml0aWFs
aXplQ3VycmVudFRocmVhZEludGVybmFsKCJNYWluIFRocmVhZCIpOwogfQo=
</data>
<flag name="review"
          id="188138"
          type_id="1"
          status="-"
          setter="paroga"
    />
    <flag name="commit-queue"
          id="188139"
          type_id="3"
          status="-"
          setter="paroga"
    />
          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>178387</attachid>
            <date>2012-12-08 16:53:24 -0800</date>
            <delta_ts>2012-12-08 18:31:37 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-100201.patch</filename>
            <type>text/plain</type>
            <size>2138</size>
            <attacher name="Patrick R. Gansterer">paroga</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nIGIvU291cmNlL1dURi9DaGFuZ2VMb2cK
aW5kZXggZDY5NWE3YS4uNDViMGYyOCAxMDA2NDQKLS0tIGEvU291cmNlL1dURi9DaGFuZ2VMb2cK
KysrIGIvU291cmNlL1dURi9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAxMi0xMi0wOCAg
UGF0cmljayBHYW5zdGVyZXIgIDxwYXJvZ2FAd2Via2l0Lm9yZz4KKworICAgICAgICBDb21waWxp
bmcgV1RGIG91dHNpZGUgb2YgV2ViS2l0IGZhaWxlZCBvbiBXaW5kb3dzCisgICAgICAgIGh0dHBz
Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDAyMDEKKworICAgICAgICBSZXZp
ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBFeHBsaWNpdGx5IHVzZSB0aGUgVW5p
Y29kZSB2YXJpYW50cyBvZiB0aGUgV2luZG93cyBBUEkgdG8KKyAgICAgICAgYWxsb3cgYnVpbGRp
bmcgdGhlIFdURiBsaWJyYXJ5IHdpdGhvdXQgdGhlIFVOSUNPREUgZGVmaW5lLgorCisgICAgICAg
ICogd3RmL3dpbi9NYWluVGhyZWFkV2luLmNwcDoKKyAgICAgICAgKFdURjo6aW5pdGlhbGl6ZU1h
aW5UaHJlYWRQbGF0Zm9ybSk6CisKIDIwMTItMTItMDggIEd1c3Rhdm8gTm9yb25oYSBTaWx2YSAg
PGduc0Bnbm9tZS5vcmc+CiAKICAgICAgICAgVW5yZXZpZXdlZCB0cml2aWFsIHNwYWNlIGZpeCB0
byBzaWxlbmNlIGFuIGF1dG9tYWtlIHdhcm5pbmcuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL3d0
Zi93aW4vTWFpblRocmVhZFdpbi5jcHAgYi9Tb3VyY2UvV1RGL3d0Zi93aW4vTWFpblRocmVhZFdp
bi5jcHAKaW5kZXggZWUzYTI3My4uNzVmMWRlZSAxMDA2NDQKLS0tIGEvU291cmNlL1dURi93dGYv
d2luL01haW5UaHJlYWRXaW4uY3BwCisrKyBiL1NvdXJjZS9XVEYvd3RmL3dpbi9NYWluVGhyZWFk
V2luLmNwcApAQCAtMzIsOSArMzIsNyBAQAogCiAjaW5jbHVkZSAiQXNzZXJ0aW9ucy5oIgogI2lu
Y2x1ZGUgIlRocmVhZGluZy5oIgotI2lmICFPUyhXSU5DRSkKICNpbmNsdWRlIDx3aW5kb3dzLmg+
Ci0jZW5kaWYKIAogbmFtZXNwYWNlIFdURiB7CiAKQEAgLTU3LDI2ICs1NSwxOCBAQCB2b2lkIGlu
aXRpYWxpemVNYWluVGhyZWFkUGxhdGZvcm0oKQogICAgICAgICByZXR1cm47CiAKICAgICBIV05E
IGhXbmRQYXJlbnQgPSAwOwotI2lmIE9TKFdJTkNFKQotICAgIFdORENMQVNTIHdjZXg7Ci0gICAg
bWVtc2V0KCZ3Y2V4LCAwLCBzaXplb2YoV05EQ0xBU1MpKTsKLSNlbHNlCi0gICAgV05EQ0xBU1NF
WCB3Y2V4OwotICAgIG1lbXNldCgmd2NleCwgMCwgc2l6ZW9mKFdORENMQVNTRVgpKTsKLSAgICB3
Y2V4LmNiU2l6ZSA9IHNpemVvZihXTkRDTEFTU0VYKTsKLSNlbmRpZgorICAgIFdORENMQVNTVyB3
Y2V4OworICAgIG1lbXNldCgmd2NleCwgMCwgc2l6ZW9mKFdORENMQVNTVykpOwogICAgIHdjZXgu
bHBmblduZFByb2MgICAgPSBUaHJlYWRpbmdXaW5kb3dXbmRQcm9jOwogICAgIHdjZXgubHBzekNs
YXNzTmFtZSAgPSBrVGhyZWFkaW5nV2luZG93Q2xhc3NOYW1lOwotI2lmIE9TKFdJTkNFKQotICAg
IFJlZ2lzdGVyQ2xhc3MoJndjZXgpOwotI2Vsc2UKLSAgICBSZWdpc3RlckNsYXNzRXgoJndjZXgp
OworICAgIFJlZ2lzdGVyQ2xhc3NXKCZ3Y2V4KTsKKyNpZiAhT1MoV0lOQ0UpCiAgICAgaFduZFBh
cmVudCA9IEhXTkRfTUVTU0FHRTsKICNlbmRpZgogCi0gICAgdGhyZWFkaW5nV2luZG93SGFuZGxl
ID0gQ3JlYXRlV2luZG93KGtUaHJlYWRpbmdXaW5kb3dDbGFzc05hbWUsIDAsIDAsCisgICAgdGhy
ZWFkaW5nV2luZG93SGFuZGxlID0gQ3JlYXRlV2luZG93VyhrVGhyZWFkaW5nV2luZG93Q2xhc3NO
YW1lLCAwLCAwLAogICAgICAgIENXX1VTRURFRkFVTFQsIDAsIENXX1VTRURFRkFVTFQsIDAsIGhX
bmRQYXJlbnQsIDAsIDAsIDApOwotICAgIHRocmVhZGluZ0ZpcmVkTWVzc2FnZSA9IFJlZ2lzdGVy
V2luZG93TWVzc2FnZShMImNvbS5hcHBsZS5XZWJLaXQuTWFpblRocmVhZEZpcmVkIik7CisgICAg
dGhyZWFkaW5nRmlyZWRNZXNzYWdlID0gUmVnaXN0ZXJXaW5kb3dNZXNzYWdlVyhMImNvbS5hcHBs
ZS5XZWJLaXQuTWFpblRocmVhZEZpcmVkIik7CiAKICAgICBpbml0aWFsaXplQ3VycmVudFRocmVh
ZEludGVybmFsKCJNYWluIFRocmVhZCIpOwogfQo=
</data>

          </attachment>
      

    </bug>

</bugzilla>