100182 2012-10-23 19:38:55 -0700 Fix windowRect calculation for webplugin due to page scale factors 2012-11-12 18:10:13 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 qinmin webkit-unassigned abarth aelias webkit.review.bot oldest_to_newest 749250 0 qinmin 2012-10-23 19:38:55 -0700 Fix windowRect calculation for webplugin due to page scale factors 749257 1 170296 qinmin 2012-10-23 19:52:14 -0700 Created attachment 170296 Patch 749400 2 170296 abarth 2012-10-23 23:44:36 -0700 Comment on attachment 170296 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=170296&action=review > Source/WebKit/chromium/ChangeLog:12 > + No test for this as the code for page scale factor will soon be deprecated. Can we add tests that will continue to pass even after we deprecate page scale factor? If this code is worth changing, it is worth writing tests for. 750280 3 qinmin 2012-10-24 18:33:23 -0700 I am looking into adding a layout test for this, but the TestWebPlugin failed miserably on this case. Whenever I put a x-webkit-test-webplugin in an iframe, i got a context lost error when running the layout test. I will take a look into this 764691 4 aelias 2012-11-12 12:46:16 -0800 Hi Adam, this is difficult to write a test for because it's pixel-based, and plugin placeholder is managed on the Chromium side (so we can't make it render in a layout test). Could we land without test? 764724 5 170296 abarth 2012-11-12 13:10:38 -0800 Comment on attachment 170296 Patch Ok. Can you change the explanation in the ChangeLog entry? That's a much better reason than the code being deprecated soon. :) 764747 6 173706 qinmin 2012-11-12 13:29:30 -0800 Created attachment 173706 Patch 764748 7 qinmin 2012-11-12 13:30:06 -0800 Done, ChangeLog updated. (In reply to comment #5) > (From update of attachment 170296 [details]) > Ok. Can you change the explanation in the ChangeLog entry? That's a much better reason than the code being deprecated soon. :) 764760 8 173706 abarth 2012-11-12 13:37:58 -0800 Comment on attachment 173706 Patch Thanks. 764908 9 173706 webkit.review.bot 2012-11-12 15:54:12 -0800 Comment on attachment 173706 Patch Rejecting attachment 173706 from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1 ERROR: /mnt/git/webkit-commit-queue/LayoutTests/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://queues.webkit.org/results/14809620 765076 10 173706 webkit.review.bot 2012-11-12 18:10:09 -0800 Comment on attachment 173706 Patch Clearing flags on attachment: 173706 Committed r134334: <http://trac.webkit.org/changeset/134334> 765077 11 webkit.review.bot 2012-11-12 18:10:13 -0800 All reviewed patches have been landed. Closing bug. 170296 2012-10-23 19:52:14 -0700 2012-11-12 13:29:23 -0800 Patch bug-100182-20121023195050.patch text/plain 3136 qinmin U3VidmVyc2lvbiBSZXZpc2lvbjogMTMyMTI5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IDM4OWU1YmJkOWZmMzc1NzE1ZmE2NTU1ODZjNjE3NGFjZjE1ZTgyOGIuLjQ3ZDdhMDAzYTExZjQx YzM4MzljODM1NDRmZjc1YWZlZjkzMTczNGMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTkgQEAKKzIwMTItMTAtMjMgIE1pbiBRaW4gIDxxaW5taW5AY2hyb21pdW0ub3Jn PgorCisgICAgICAgIEZpeCB3aW5kb3dSZWN0IGNhbGN1bGF0aW9uIGZvciB3ZWJwbHVnaW4gZHVl IHRvIHBhZ2Ugc2NhbGUgZmFjdG9ycworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTAwMTgyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgVGhlIGN1cnJlbnQgY2FsY3VsYXRvbiBvZiB3aW5kb3dSZWN0IGluIFdl YlBsdWdpbkNvbnRhaW5lckltcGwgaXMgd3JvbmcuIEV2ZW4gYWZ0ZXIgc29tZSBvZiBvdXIgbGF0 ZXN0IGNoYW5nZXMuCisgICAgICAgIFRoZSBwcm9ibGVtIGlzIGNhdXNlZCBieSBwYWdlIHNjYWxl IGZhY3Rvci4KKyAgICAgICAgRm9yIGV4YW1wbGUsIHdpbmRvd1RvQ29udGVudHMoSW50UG9pbnQp IHdpbGwgcmV0dXJuIGFuIHVuc2NhbGVkIG9mZnNldCBmb3IgYW4gaWZyYW1lLCBidXQgd2lsbCBy ZXR1cm4gYSBzY2FsZWQgb2Zmc2V0IGZvciB0aGUgbWFpbiBmcmFtZS4gU28gaW4gb3JkZXIgdG8g b2J0YWluIHRoZSBjb3JyZWN0IHdpbmRvdyBjb29yZGluYXRlLCB3ZSBuZWVkIHRvIHVzZSBjb250 ZW50c1RvV2luZG93KCkuCisgICAgICAgIFNpbmNlIHdlYnZpZXdfcGx1Z2luLmNjIGlzIGV4cGVj dGluZyB3aW5kb3cgY29vcmRpbmF0ZXMsIHdlIG5lZWQgdG8gdXNlIGNvbnRlbnRzVG9XaW5kb3co SW50UmVjdCkgdHAgY2FsY3VsYXRpbmcgdGhlIHdpbmRvd1JlY3Qgc28gdGhhdCB0aGUgcmVjdCBz aXplIGNhbiBnZXQgY29ycmVjdGx5IHNjYWxlZC4KKyAgICAgICAgTm8gdGVzdCBmb3IgdGhpcyBh cyB0aGUgY29kZSBmb3IgcGFnZSBzY2FsZSBmYWN0b3Igd2lsbCBzb29uIGJlIGRlcHJlY2F0ZWQu CisKKyAgICAgICAgKiBzcmMvV2ViUGx1Z2luQ29udGFpbmVySW1wbC5jcHA6CisgICAgICAgIChX ZWJLaXQ6OldlYlBsdWdpbkNvbnRhaW5lckltcGw6OnBhaW50KToKKwogMjAxMi0xMC0yMiAgU2hl cmlmZiBCb3QgIDx3ZWJraXQucmV2aWV3LmJvdEBnbWFpbC5jb20+CiAKICAgICAgICAgVW5yZXZp ZXdlZCwgcm9sbGluZyBvdXQgcjEzMjExOS4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vc3JjL1dlYlBsdWdpbkNvbnRhaW5lckltcGwuY3BwIGIvU291cmNlL1dlYktpdC9jaHJv bWl1bS9zcmMvV2ViUGx1Z2luQ29udGFpbmVySW1wbC5jcHAKaW5kZXggODdhNjYwMTU2OWJhNTll MWY0ZjJiNDk3ZjZmOTIwNjgyYjE3MTMxOC4uNzM4NDJhMTlmOGJlNWNmNDk2Yzk4MGY1MDg2MzEz MGRjMDNiODFkYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViUGx1 Z2luQ29udGFpbmVySW1wbC5jcHAKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2Vi UGx1Z2luQ29udGFpbmVySW1wbC5jcHAKQEAgLTEzMywxMyArMTMzLDEyIEBAIHZvaWQgV2ViUGx1 Z2luQ29udGFpbmVySW1wbDo6cGFpbnQoR3JhcGhpY3NDb250ZXh0KiBnYywgY29uc3QgSW50UmVj dCYgZGFtYWdlUmVjCiAKICAgICAvLyBUaGUgcGx1Z2luIGlzIHBvc2l0aW9uZWQgaW4gd2luZG93 IGNvb3JkaW5hdGVzLCBzbyBpdCBuZWVkcyB0byBiZSBwYWludGVkCiAgICAgLy8gaW4gd2luZG93 IGNvb3JkaW5hdGVzLgotICAgIEludFBvaW50IG9yaWdpbiA9IHZpZXctPndpbmRvd1RvQ29udGVu dHMoSW50UG9pbnQoMCwgMCkpOwotICAgIGdjLT50cmFuc2xhdGUoc3RhdGljX2Nhc3Q8ZmxvYXQ+ KG9yaWdpbi54KCkpLCBzdGF0aWNfY2FzdDxmbG9hdD4ob3JpZ2luLnkoKSkpOworICAgIEludFBv aW50IG9yaWdpbiA9IHZpZXctPmNvbnRlbnRzVG9XaW5kb3coSW50UG9pbnQoMCwgMCkpOworICAg IGdjLT50cmFuc2xhdGUoc3RhdGljX2Nhc3Q8ZmxvYXQ+KC1vcmlnaW4ueCgpKSwgc3RhdGljX2Nh c3Q8ZmxvYXQ+KC1vcmlnaW4ueSgpKSk7CiAKICAgICBXZWJDYW52YXMqIGNhbnZhcyA9IGdjLT5w bGF0Zm9ybUNvbnRleHQoKS0+Y2FudmFzKCk7CiAKLSAgICBJbnRSZWN0IHdpbmRvd1JlY3QgPQot ICAgICAgICBJbnRSZWN0KHZpZXctPmNvbnRlbnRzVG9XaW5kb3coZW5jbG9zaW5nSW50UmVjdChz Y2FsZWREYW1hZ2VSZWN0KS5sb2NhdGlvbigpKSwgZW5jbG9zaW5nSW50UmVjdChzY2FsZWREYW1h Z2VSZWN0KS5zaXplKCkpOworICAgIEludFJlY3Qgd2luZG93UmVjdCA9IHZpZXctPmNvbnRlbnRz VG9XaW5kb3coZW5jbG9zaW5nSW50UmVjdChzY2FsZWREYW1hZ2VSZWN0KSk7CiAgICAgbV93ZWJQ bHVnaW4tPnBhaW50KGNhbnZhcywgd2luZG93UmVjdCk7CiAKICAgICBnYy0+cmVzdG9yZSgpOwpA QCAtODE4LDggKzgxNyw3IEBAIHZvaWQgV2ViUGx1Z2luQ29udGFpbmVySW1wbDo6Y2FsY3VsYXRl R2VvbWV0cnkoY29uc3QgSW50UmVjdCYgZnJhbWVSZWN0LAogICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICBJbnRSZWN0JiBjbGlwUmVjdCwKICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgVmVjdG9yPEludFJlY3Q+JiBjdXRP dXRSZWN0cykKIHsKLSAgICB3aW5kb3dSZWN0ID0gSW50UmVjdCgKLSAgICAgICAgcGFyZW50KCkt PmNvbnRlbnRzVG9XaW5kb3coZnJhbWVSZWN0LmxvY2F0aW9uKCkpLCBmcmFtZVJlY3Quc2l6ZSgp KTsKKyAgICB3aW5kb3dSZWN0ID0gcGFyZW50KCktPmNvbnRlbnRzVG9XaW5kb3coZnJhbWVSZWN0 KTsKIAogICAgIC8vIENhbGN1bGF0ZSBhIGNsaXAtcmVjdCBzbyB0aGF0IHdlIGRvbid0IG92ZXJs YXAgdGhlIHNjcm9sbGJhcnMsIGV0Yy4KICAgICBjbGlwUmVjdCA9IHdpbmRvd0NsaXBSZWN0KCk7 Cg== 173706 2012-11-12 13:29:30 -0800 2012-11-12 18:10:09 -0800 Patch bug-100182-20121112132727.patch text/plain 3232 qinmin U3VidmVyc2lvbiBSZXZpc2lvbjogMTMyNDk4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IGYwZWRjNWI2YzU5Mzk3MGU3MmRlOGMyMjIwMjQ5MzBkODI4ZTNhYTUuLmZmMjMwOGVjN2ZlYTI5 ZmFkMWY4NzEyYTMyZGMyNTdmZmJmMjcyYjAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTkgQEAKKzIwMTItMTAtMjMgIE1pbiBRaW4gIDxxaW5taW5AY2hyb21pdW0ub3Jn PgorCisgICAgICAgIEZpeCB3aW5kb3dSZWN0IGNhbGN1bGF0aW9uIGZvciB3ZWJwbHVnaW4gZHVl IHRvIHBhZ2Ugc2NhbGUgZmFjdG9ycworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTAwMTgyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgVGhlIGN1cnJlbnQgY2FsY3VsYXRvbiBvZiB3aW5kb3dSZWN0IGluIFdl YlBsdWdpbkNvbnRhaW5lckltcGwgaXMgd3JvbmcuIEV2ZW4gYWZ0ZXIgc29tZSBvZiBvdXIgbGF0 ZXN0IGNoYW5nZXMuCisgICAgICAgIFRoZSBwcm9ibGVtIGlzIGNhdXNlZCBieSBwYWdlIHNjYWxl IGZhY3Rvci4KKyAgICAgICAgRm9yIGV4YW1wbGUsIHdpbmRvd1RvQ29udGVudHMoSW50UG9pbnQp IHdpbGwgcmV0dXJuIGFuIHVuc2NhbGVkIG9mZnNldCBmb3IgYW4gaWZyYW1lLCBidXQgd2lsbCBy ZXR1cm4gYSBzY2FsZWQgb2Zmc2V0IGZvciB0aGUgbWFpbiBmcmFtZS4gU28gaW4gb3JkZXIgdG8g b2J0YWluIHRoZSBjb3JyZWN0IHdpbmRvdyBjb29yZGluYXRlLCB3ZSBuZWVkIHRvIHVzZSBjb250 ZW50c1RvV2luZG93KCkuCisgICAgICAgIFNpbmNlIHdlYnZpZXdfcGx1Z2luLmNjIGlzIGV4cGVj dGluZyB3aW5kb3cgY29vcmRpbmF0ZXMsIHdlIG5lZWQgdG8gdXNlIGNvbnRlbnRzVG9XaW5kb3co SW50UmVjdCkgdG8gY2FsY3VsYXRlIHRoZSB3aW5kb3dSZWN0IHNvIHRoYXQgdGhlIHJlY3Qgc2l6 ZSBjYW4gZ2V0IGNvcnJlY3RseSBzY2FsZWQuCisgICAgICAgIEl0IGlzIGRpZmZpY3VsdCB0byB3 cml0ZSBhIHRlc3QgZm9yIHRoaXMgYmVjYXVzZSBpdCdzIHBpeGVsLWJhc2VkLCBhbmQgcGx1Z2lu IHBsYWNlaG9sZGVyIGlzIG1hbmFnZWQgb24gdGhlIENocm9taXVtIHNpZGUgKHdlYnZpZXdfcGx1 Z2luLmNjKS4KKworICAgICAgICAqIHNyYy9XZWJQbHVnaW5Db250YWluZXJJbXBsLmNwcDoKKyAg ICAgICAgKFdlYktpdDo6V2ViUGx1Z2luQ29udGFpbmVySW1wbDo6cGFpbnQpOgorCiAyMDEyLTEw LTIyICBNaWtoYWlsIE5hZ2Fub3YgIDxtbmFnYW5vdkBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAg W0Nocm9taXVtXSBBZGQgc3VwcG9ydE11bHRpcGxlV2luZG93cyBzZXR0aW5nLCBuZWVkZWQgZm9y IEFuZHJvaWQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYlBsdWdp bkNvbnRhaW5lckltcGwuY3BwIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViUGx1Z2lu Q29udGFpbmVySW1wbC5jcHAKaW5kZXggODdhNjYwMTU2OWJhNTllMWY0ZjJiNDk3ZjZmOTIwNjgy YjE3MTMxOC4uNzM4NDJhMTlmOGJlNWNmNDk2Yzk4MGY1MDg2MzEzMGRjMDNiODFkYyAxMDA2NDQK LS0tIGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViUGx1Z2luQ29udGFpbmVySW1wbC5j cHAKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViUGx1Z2luQ29udGFpbmVySW1w bC5jcHAKQEAgLTEzMywxMyArMTMzLDEyIEBAIHZvaWQgV2ViUGx1Z2luQ29udGFpbmVySW1wbDo6 cGFpbnQoR3JhcGhpY3NDb250ZXh0KiBnYywgY29uc3QgSW50UmVjdCYgZGFtYWdlUmVjCiAKICAg ICAvLyBUaGUgcGx1Z2luIGlzIHBvc2l0aW9uZWQgaW4gd2luZG93IGNvb3JkaW5hdGVzLCBzbyBp dCBuZWVkcyB0byBiZSBwYWludGVkCiAgICAgLy8gaW4gd2luZG93IGNvb3JkaW5hdGVzLgotICAg IEludFBvaW50IG9yaWdpbiA9IHZpZXctPndpbmRvd1RvQ29udGVudHMoSW50UG9pbnQoMCwgMCkp OwotICAgIGdjLT50cmFuc2xhdGUoc3RhdGljX2Nhc3Q8ZmxvYXQ+KG9yaWdpbi54KCkpLCBzdGF0 aWNfY2FzdDxmbG9hdD4ob3JpZ2luLnkoKSkpOworICAgIEludFBvaW50IG9yaWdpbiA9IHZpZXct PmNvbnRlbnRzVG9XaW5kb3coSW50UG9pbnQoMCwgMCkpOworICAgIGdjLT50cmFuc2xhdGUoc3Rh dGljX2Nhc3Q8ZmxvYXQ+KC1vcmlnaW4ueCgpKSwgc3RhdGljX2Nhc3Q8ZmxvYXQ+KC1vcmlnaW4u eSgpKSk7CiAKICAgICBXZWJDYW52YXMqIGNhbnZhcyA9IGdjLT5wbGF0Zm9ybUNvbnRleHQoKS0+ Y2FudmFzKCk7CiAKLSAgICBJbnRSZWN0IHdpbmRvd1JlY3QgPQotICAgICAgICBJbnRSZWN0KHZp ZXctPmNvbnRlbnRzVG9XaW5kb3coZW5jbG9zaW5nSW50UmVjdChzY2FsZWREYW1hZ2VSZWN0KS5s b2NhdGlvbigpKSwgZW5jbG9zaW5nSW50UmVjdChzY2FsZWREYW1hZ2VSZWN0KS5zaXplKCkpOwor ICAgIEludFJlY3Qgd2luZG93UmVjdCA9IHZpZXctPmNvbnRlbnRzVG9XaW5kb3coZW5jbG9zaW5n SW50UmVjdChzY2FsZWREYW1hZ2VSZWN0KSk7CiAgICAgbV93ZWJQbHVnaW4tPnBhaW50KGNhbnZh cywgd2luZG93UmVjdCk7CiAKICAgICBnYy0+cmVzdG9yZSgpOwpAQCAtODE4LDggKzgxNyw3IEBA IHZvaWQgV2ViUGx1Z2luQ29udGFpbmVySW1wbDo6Y2FsY3VsYXRlR2VvbWV0cnkoY29uc3QgSW50 UmVjdCYgZnJhbWVSZWN0LAogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICBJbnRSZWN0JiBjbGlwUmVjdCwKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgVmVjdG9yPEludFJlY3Q+JiBjdXRPdXRSZWN0cykKIHsKLSAgICB3 aW5kb3dSZWN0ID0gSW50UmVjdCgKLSAgICAgICAgcGFyZW50KCktPmNvbnRlbnRzVG9XaW5kb3co ZnJhbWVSZWN0LmxvY2F0aW9uKCkpLCBmcmFtZVJlY3Quc2l6ZSgpKTsKKyAgICB3aW5kb3dSZWN0 ID0gcGFyZW50KCktPmNvbnRlbnRzVG9XaW5kb3coZnJhbWVSZWN0KTsKIAogICAgIC8vIENhbGN1 bGF0ZSBhIGNsaXAtcmVjdCBzbyB0aGF0IHdlIGRvbid0IG92ZXJsYXAgdGhlIHNjcm9sbGJhcnMs IGV0Yy4KICAgICBjbGlwUmVjdCA9IHdpbmRvd0NsaXBSZWN0KCk7Cg==