100180 2012-10-23 19:17:22 -0700 Stop using NSHomeDirectory() to get the home directory, it doesn't always return what we want 2012-10-24 07:58:02 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 sam sam oldest_to_newest 749240 0 sam 2012-10-23 19:17:22 -0700 Stop using NSHomeDirectory() to get the home directory, it doesn't always return what we want 749241 1 170293 sam 2012-10-23 19:19:10 -0700 Created attachment 170293 Patch 749242 2 170293 andersca 2012-10-23 19:22:36 -0700 Comment on attachment 170293 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=170293&action=review > Source/WebKit2/WebProcess/mac/WebProcessMac.mm:214 > + int bufferSize = 4096; > + char buffer[4096]; Please write this as char buffer[4096]; int bufferSize = sizeof(buffer); 749259 3 sam 2012-10-23 19:53:12 -0700 Committed r132294: <http://trac.webkit.org/changeset/132294> 749679 4 170293 darin 2012-10-24 07:58:02 -0700 Comment on attachment 170293 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=170293&action=review >> Source/WebKit2/WebProcess/mac/WebProcessMac.mm:214 >> + char buffer[4096]; > > Please write this as > > char buffer[4096]; > int bufferSize = sizeof(buffer); Is 4096 better than PATH_MAX or MAXPATHLEN? 170293 2012-10-23 19:19:10 -0700 2012-10-24 07:58:02 -0700 Patch bug-100180-20121023191752.patch text/plain 4241 sam SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDEzMjI5MikKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIwIEBACisyMDEyLTEwLTIzICBTYW0gV2Vp bmlnICA8c2FtQHdlYmtpdC5vcmc+CisKKyAgICAgICAgU3RvcCB1c2luZyBOU0hvbWVEaXJlY3Rv cnkoKSB0byBnZXQgdGhlIGhvbWUgZGlyZWN0b3J5LCBpdCBkb2Vzbid0IGFsd2F5cyByZXR1cm4g d2hhdCB3ZSB3YW50CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xMDAxODAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBOU0hvbWVEaXJlY3RvcnkoKSBkb2Vzbid0IHJldHVybiB0aGUgcmVhbCBob21lIGRpcmVj dG9yeSBpZiB0aGUgaG9zdCBwcm9jZXNzCisgICAgICAgIGlzIEFwcCBTYW5kYm94ZWQsIHNvIGRy b3AgZG93biBhbmQgdXNlIGdldHB3dWlkX3IgaW5zdGVhZC4KKworICAgICAgICAqIFdlYlByb2Nl c3MvbWFjL1dlYlByb2Nlc3NNYWMubW06CisgICAgICAgIChXZWJLaXQ6OmFwcGVuZFJlYWR3cml0 ZVNhbmRib3hEaXJlY3RvcnkpOgorICAgICAgICBUaGVyZSBpcyBubyByZWFzb24gYW55bW9yZSB0 byB0cnkgdG8gY3JlYXRlIHRoZSBkaXJlY3RvcnkuCisKKyAgICAgICAgKFdlYktpdDo6V2ViUHJv Y2Vzczo6aW5pdGlhbGl6ZVNhbmRib3gpOgorICAgICAgICBTd2l0Y2ggdG8gZ2V0cHd1aWRfci4K KwogMjAxMi0xMC0yMyAgTWFydGluIFJvYmluc29uICA8bXJvYmluc29uQGlnYWxpYS5jb20+CiAK ICAgICAgICAgW0dUS11bU291cF0gSW1wbGVtZW50IHRoZSBkZWZhdWx0IGF1dGhlbnRpY2F0aW9u IGRpYWxvZyB2aWEgV2ViQ29yZVN1cHBvcnQKSW5kZXg6IFNvdXJjZS9XZWJLaXQyL1dlYlByb2Nl c3MvbWFjL1dlYlByb2Nlc3NNYWMubW0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdDIvV2Vi UHJvY2Vzcy9tYWMvV2ViUHJvY2Vzc01hYy5tbQkocmV2aXNpb24gMTMyMjg0KQorKysgU291cmNl L1dlYktpdDIvV2ViUHJvY2Vzcy9tYWMvV2ViUHJvY2Vzc01hYy5tbQkod29ya2luZyBjb3B5KQpA QCAtNTMsNiArNTMsNyBAQAogI2VuZGlmCiAKICNpZiBFTkFCTEUoV0VCX1BST0NFU1NfU0FOREJP WCkKKyNpbXBvcnQgPHB3ZC5oPgogI2ltcG9ydCA8c3RkbGliLmg+CiAjaW1wb3J0IDxzeXNleGl0 cy5oPgogCkBAIC0xNjgsMTUgKzE2OSw5IEBAIHN0YXRpYyB2b2lkIGFwcGVuZFJlYWRvbmx5U2Fu ZGJveERpcmVjdG8KICAgICBhcHBlbmRTYW5kYm94UGFyYW1ldGVyUGF0aEludGVybmFsKHZlY3Rv ciwgbmFtZSwgW3BhdGggbGVuZ3RoXSA/IFsoTlNTdHJpbmcgKilwYXRoIGZpbGVTeXN0ZW1SZXBy ZXNlbnRhdGlvbl0gOiAiIik7CiB9CiAKLXN0YXRpYyB2b2lkIGFwcGVuZFJlYWR3cml0ZVNhbmRi b3hEaXJlY3RvcnkoVmVjdG9yPGNvbnN0IGNoYXIqPiYgdmVjdG9yLCBjb25zdCBjaGFyKiBuYW1l LCBOU1N0cmluZyAqcGF0aCkKK3N0YXRpYyB2b2lkIGFwcGVuZFJlYWR3cml0ZVNhbmRib3hEaXJl Y3RvcnkoVmVjdG9yPGNvbnN0IGNoYXIqPiYgdmVjdG9yLCBjb25zdCBjaGFyKiBuYW1lLCBjb25z dCBjaGFyKiBwYXRoKQogewotICAgIE5TRXJyb3IgKmVycm9yID0gbmlsOwotCi0gICAgLy8gVGhp cyBpcyB2ZXJ5IHVubGlrZWx5IHRvIGZhaWwsIGJ1dCBpbiBjYXNlIGl0IGFjdHVhbGx5IGhhcHBl bnMsIHdlJ2QgbGlrZSBzb21lIHNvcnQgb2Ygb3V0cHV0IGluIHRoZSBjb25zb2xlLgotICAgIGlm ICghW1tOU0ZpbGVNYW5hZ2VyIGRlZmF1bHRNYW5hZ2VyXSBjcmVhdGVEaXJlY3RvcnlBdFBhdGg6 cGF0aCB3aXRoSW50ZXJtZWRpYXRlRGlyZWN0b3JpZXM6WUVTIGF0dHJpYnV0ZXM6bmlsIGVycm9y OiZlcnJvcl0pCi0gICAgICAgIE5TTG9nKEAiY291bGQgbm90IGNyZWF0ZSBcIiVAXCIsIGVycm9y ICVAIiwgcGF0aCwgZXJyb3IpOwotCi0gICAgYXBwZW5kU2FuZGJveFBhcmFtZXRlclBhdGhJbnRl cm5hbCh2ZWN0b3IsIG5hbWUsIFsoTlNTdHJpbmcgKilwYXRoIGZpbGVTeXN0ZW1SZXByZXNlbnRh dGlvbl0pOworICAgIGFwcGVuZFNhbmRib3hQYXJhbWV0ZXJQYXRoSW50ZXJuYWwodmVjdG9yLCBu YW1lLCBwYXRoKTsKIH0KIAogI2VuZGlmCkBAIC0yMTUsOCArMjEwLDE3IEBAIHZvaWQgV2ViUHJv Y2Vzczo6aW5pdGlhbGl6ZVNhbmRib3goY29uc3QKICAgICBhcHBlbmRSZWFkd3JpdGVDb25mRGly ZWN0b3J5KHNhbmRib3hQYXJhbWV0ZXJzLCAiREFSV0lOX1VTRVJfVEVNUF9ESVIiLCBfQ1NfREFS V0lOX1VTRVJfVEVNUF9ESVIpOwogICAgIGFwcGVuZFJlYWR3cml0ZUNvbmZEaXJlY3Rvcnkoc2Fu ZGJveFBhcmFtZXRlcnMsICJEQVJXSU5fVVNFUl9DQUNIRV9ESVIiLCBfQ1NfREFSV0lOX1VTRVJf Q0FDSEVfRElSKTsKIAorICAgIGludCBidWZmZXJTaXplID0gNDA5NjsKKyAgICBjaGFyIGJ1ZmZl cls0MDk2XTsKKyAgICBzdHJ1Y3QgcGFzc3dkIHB3ZDsKKyAgICBzdHJ1Y3QgcGFzc3dkKiByZXN1 bHQgPSAwOworICAgIGlmIChnZXRwd3VpZF9yKGdldHVpZCgpLCAmcHdkLCBidWZmZXIsIGJ1ZmZl clNpemUsICZyZXN1bHQpIHx8ICFyZXN1bHQpIHsKKyAgICAgICAgV1RGTG9nQWx3YXlzKCJXZWJQ cm9jZXNzOiBDb3VsZG4ndCBmaW5kIGhvbWUgZGlyZWN0b3J5XG4iKTsKKyAgICAgICAgZXhpdChF WF9OT1BFUk0pOworICAgIH0KKwogICAgIC8vIFRoZXNlIGFyZSByZWFkLXdyaXRlIHBhdGhzLgot ICAgIGFwcGVuZFJlYWR3cml0ZVNhbmRib3hEaXJlY3Rvcnkoc2FuZGJveFBhcmFtZXRlcnMsICJI T01FX0RJUiIsIE5TSG9tZURpcmVjdG9yeSgpKTsKKyAgICBhcHBlbmRSZWFkd3JpdGVTYW5kYm94 RGlyZWN0b3J5KHNhbmRib3hQYXJhbWV0ZXJzLCAiSE9NRV9ESVIiLCBwd2QucHdfZGlyKTsKIAog ICAgIHNhbmRib3hQYXJhbWV0ZXJzLmFwcGVuZChzdGF0aWNfY2FzdDxjb25zdCBjaGFyKj4oMCkp OwogCkBAIC0yMjQsNyArMjI4LDcgQEAgdm9pZCBXZWJQcm9jZXNzOjppbml0aWFsaXplU2FuZGJv eChjb25zdAogCiAgICAgY2hhciogZXJyb3JCdWY7CiAgICAgaWYgKHNhbmRib3hfaW5pdF93aXRo X3BhcmFtZXRlcnMocHJvZmlsZVBhdGgsIFNBTkRCT1hfTkFNRURfRVhURVJOQUwsIHNhbmRib3hQ YXJhbWV0ZXJzLmRhdGEoKSwgJmVycm9yQnVmKSkgewotICAgICAgICBXVEZMb2dBbHdheXMoIldl YlByb2Nlc3M6IGNvdWxkbid0IGluaXRpYWxpemUgc2FuZGJveCBwcm9maWxlIFslc10gZXJyb3Ig JyVzJ1xuIiwgcHJvZmlsZVBhdGgsIGVycm9yQnVmKTsKKyAgICAgICAgV1RGTG9nQWx3YXlzKCJX ZWJQcm9jZXNzOiBDb3VsZG4ndCBpbml0aWFsaXplIHNhbmRib3ggcHJvZmlsZSBbJXNdIGVycm9y ICclcydcbiIsIHByb2ZpbGVQYXRoLCBlcnJvckJ1Zik7CiAgICAgICAgIGZvciAoc2l6ZV90IGkg PSAwOyBzYW5kYm94UGFyYW1ldGVyc1tpXTsgaSArPSAyKQogICAgICAgICAgICAgV1RGTG9nQWx3 YXlzKCIlcz0lc1xuIiwgc2FuZGJveFBhcmFtZXRlcnNbaV0sIHNhbmRib3hQYXJhbWV0ZXJzW2kg KyAxXSk7CiAgICAgICAgIGV4aXQoRVhfTk9QRVJNKTsKQEAgLTIzNiw3ICsyNDAsNyBAQCB2b2lk IFdlYlByb2Nlc3M6OmluaXRpYWxpemVTYW5kYm94KGNvbnN0CiAgICAgLy8gVGhpcyB3aWxsIG92 ZXJyaWRlIExTRmlsZVF1YXJhbnRpbmVFbmFibGVkIGZyb20gSW5mby5wbGlzdCB1bmxlc3Mgc2Fu ZGJveCBxdWFyYW50aW5lIGlzIGdsb2JhbGx5IGRpc2FibGVkLgogICAgIE9TU3RhdHVzIGVycm9y ID0gV0tFbmFibGVTYW5kYm94U3R5bGVGaWxlUXVhcmFudGluZSgpOwogICAgIGlmIChlcnJvcikg ewotICAgICAgICBXVEZMb2dBbHdheXMoIldlYlByb2Nlc3M6IGNvdWxkbid0IGVuYWJsZSBzYW5k Ym94IHN0eWxlIGZpbGUgcXVhcmFudGluZTogJWxkXG4iLCAobG9uZyllcnJvcik7CisgICAgICAg IFdURkxvZ0Fsd2F5cygiV2ViUHJvY2VzczogQ291bGRuJ3QgZW5hYmxlIHNhbmRib3ggc3R5bGUg ZmlsZSBxdWFyYW50aW5lOiAlbGRcbiIsIChsb25nKWVycm9yKTsKICAgICAgICAgZXhpdChFWF9O T1BFUk0pOwogICAgIH0KICNlbmRpZgo=