100172 2012-10-23 17:23:22 -0700 Store the loaded file locally in measurePageLoadTime 2012-10-23 23:43:46 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 zoltan zoltan ossy rniwa webkit.review.bot oldest_to_newest 749148 0 zoltan 2012-10-23 17:23:22 -0700 Store the loaded file as a local variable instead of attaching it to the test object. 749157 1 170277 zoltan 2012-10-23 17:30:39 -0700 Created attachment 170277 proposed patch 749386 2 170277 ossy 2012-10-23 23:25:58 -0700 Comment on attachment 170277 proposed patch LGTM, r=me. 749398 3 170277 webkit.review.bot 2012-10-23 23:43:42 -0700 Comment on attachment 170277 proposed patch Clearing flags on attachment: 170277 Committed r132316: <http://trac.webkit.org/changeset/132316> 749399 4 webkit.review.bot 2012-10-23 23:43:46 -0700 All reviewed patches have been landed. Closing bug. 170277 2012-10-23 17:30:39 -0700 2012-10-23 23:43:42 -0700 proposed patch localstore.patch text/plain 2717 zoltan ZGlmZiAtLWdpdCBhL1BlcmZvcm1hbmNlVGVzdHMvQ2hhbmdlTG9nIGIvUGVyZm9ybWFuY2VUZXN0 cy9DaGFuZ2VMb2cKaW5kZXggNjE3YmNlNC4uY2JjMTZhMCAxMDA2NDQKLS0tIGEvUGVyZm9ybWFu Y2VUZXN0cy9DaGFuZ2VMb2cKKysrIGIvUGVyZm9ybWFuY2VUZXN0cy9DaGFuZ2VMb2cKQEAgLTEs NSArMSwxOCBAQAogMjAxMi0xMC0yMyAgWm9sdGFuIEhvcnZhdGggIDx6b2x0YW5Ad2Via2l0Lm9y Zz4KIAorICAgICAgICBTdG9yZSB0aGUgbG9hZGVkIGZpbGUgbG9jYWxseSBpbiBtZWFzdXJlUGFn ZUxvYWRUaW1lCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xMDAxNzIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBTdG9yZSB0aGUgbG9hZGVkIGZpbGUgYXMgYSBsb2NhbCB2YXJpYWJsZSBpbnN0ZWFkIG9mIGF0 dGFjaGluZyBpdCB0byB0aGUgdGVzdCBvYmplY3QuCisgICAgICAgIEhhbmRsZSBjaHVua1NpemUg aW5zaWRlIHRlc3QucnVuLgorCisgICAgICAgICogcmVzb3VyY2VzL3J1bm5lci5qczoKKyAgICAg ICAgKC4pOgorCisyMDEyLTEwLTIzICBab2x0YW4gSG9ydmF0aCAgPHpvbHRhbkB3ZWJraXQub3Jn PgorCiAgICAgICAgIEFkZCBtZWFzdXJlUGFnZUxvYWRUaW1lIGZ1bmN0aW9uIHRvIFBlcmZUZXN0 UnVubmVyCiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x MDAwMjkKIApkaWZmIC0tZ2l0IGEvUGVyZm9ybWFuY2VUZXN0cy9yZXNvdXJjZXMvcnVubmVyLmpz IGIvUGVyZm9ybWFuY2VUZXN0cy9yZXNvdXJjZXMvcnVubmVyLmpzCmluZGV4IDZkZjNiOWYuLjI3 OGMxNzYgMTAwNzU1Ci0tLSBhL1BlcmZvcm1hbmNlVGVzdHMvcmVzb3VyY2VzL3J1bm5lci5qcwor KysgYi9QZXJmb3JtYW5jZVRlc3RzL3Jlc291cmNlcy9ydW5uZXIuanMKQEAgLTMwNiwxOCArMzA2 LDIyIEBAIGlmICh3aW5kb3cudGVzdFJ1bm5lcikgewogCiAgICAgUGVyZlRlc3RSdW5uZXIubWVh c3VyZVBhZ2VMb2FkVGltZSA9IGZ1bmN0aW9uKHRlc3QpIHsKICAgICAgICAgdGVzdC5ydW4gPSBm dW5jdGlvbigpIHsKKyAgICAgICAgICAgIHZhciBmaWxlID0gUGVyZlRlc3RSdW5uZXIubG9hZEZp bGUodGVzdC5wYXRoKTsKKyAgICAgICAgICAgIGlmICghdGVzdC5jaHVua1NpemUpCisgICAgICAg ICAgICAgICAgdGhpcy5jaHVua1NpemUgPSA1MDAwMDsKKwogICAgICAgICAgICAgdmFyIGNodW5r cyA9IFtdOwogICAgICAgICAgICAgLy8gVGhlIHNtYWxsZXIgdGhlIGNodW5rcyB0aGUgbW9yZSBz dHlsZSByZXNvbHZlcyB3ZSBkby4KICAgICAgICAgICAgIC8vIFNtYWxsZXIgY2h1bmsgc2l6ZXMg d2lsbCBzaG93IG1vcmUgc2FtcGxlcyBpbiBzdHlsZSByZXNvbHV0aW9uLgogICAgICAgICAgICAg Ly8gTGFyZ2VyIGNodW5rIHNpemVzIHdpbGwgc2hvdyBtb3JlIHNhbXBsZXMgaW4gbGluZSBsYXlv dXQuCiAgICAgICAgICAgICAvLyBTbWFsbGVyIGNodW5rIHNpemVzIHJ1biBzbG93ZXIgb3ZlcmFs bCwgYXMgdGhlIHBlci1jaHVuayBvdmVyaGVhZCBpcyBoaWdoLgotICAgICAgICAgICAgdmFyIGNo dW5rQ291bnQgPSBNYXRoLmNlaWwodGhpcy5maWxlLmxlbmd0aCAvIHRoaXMuY2h1bmtTaXplKTsK KyAgICAgICAgICAgIHZhciBjaHVua0NvdW50ID0gTWF0aC5jZWlsKGZpbGUubGVuZ3RoIC8gdGhp cy5jaHVua1NpemUpOwogICAgICAgICAgICAgZm9yICh2YXIgY2h1bmtJbmRleCA9IDA7IGNodW5r SW5kZXggPCBjaHVua0NvdW50OyBjaHVua0luZGV4KyspIHsKLSAgICAgICAgICAgICAgICB2YXIg Y2h1bmsgPSB0aGlzLmZpbGUuc3Vic3RyKGNodW5rSW5kZXggKiB0aGlzLmNodW5rU2l6ZSwgdGhp cy5jaHVua1NpemUpOworICAgICAgICAgICAgICAgIHZhciBjaHVuayA9IGZpbGUuc3Vic3RyKGNo dW5rSW5kZXggKiB0aGlzLmNodW5rU2l6ZSwgdGhpcy5jaHVua1NpemUpOwogICAgICAgICAgICAg ICAgIGNodW5rcy5wdXNoKGNodW5rKTsKICAgICAgICAgICAgIH0KIAotICAgICAgICAgICAgUGVy ZlRlc3RSdW5uZXIubG9nSW5mbygiVGVzdGluZyAiICsgdGhpcy5maWxlLmxlbmd0aCArICIgYnl0 ZSBkb2N1bWVudCBpbiAiICsgY2h1bmtDb3VudCArICIgIiArIHRoaXMuY2h1bmtTaXplICsgIiBi eXRlIGNodW5rcy4iKTsKKyAgICAgICAgICAgIFBlcmZUZXN0UnVubmVyLmxvZ0luZm8oIlRlc3Rp bmcgIiArIGZpbGUubGVuZ3RoICsgIiBieXRlIGRvY3VtZW50IGluICIgKyBjaHVua0NvdW50ICsg IiAiICsgdGhpcy5jaHVua1NpemUgKyAiIGJ5dGUgY2h1bmtzLiIpOwogCiAgICAgICAgICAgICB2 YXIgaWZyYW1lID0gZG9jdW1lbnQuY3JlYXRlRWxlbWVudCgiaWZyYW1lIik7CiAgICAgICAgICAg ICBkb2N1bWVudC5ib2R5LmFwcGVuZENoaWxkKGlmcmFtZSk7CkBAIC0zNDEsMTAgKzM0NSw2IEBA IGlmICh3aW5kb3cudGVzdFJ1bm5lcikgewogICAgICAgICAgICAgZG9jdW1lbnQuYm9keS5yZW1v dmVDaGlsZChpZnJhbWUpOwogICAgICAgICB9OwogCi0gICAgICAgIHRoaXMuZmlsZSA9IFBlcmZU ZXN0UnVubmVyLmxvYWRGaWxlKHRlc3QucGF0aCk7Ci0gICAgICAgIGlmICghdGVzdC5jaHVua1Np emUpCi0gICAgICAgICAgICB0aGlzLmNodW5rU2l6ZSA9IDUwMDAwOwotCiAgICAgICAgIFBlcmZU ZXN0UnVubmVyLm1lYXN1cmVUaW1lKHRlc3QpOwogICAgIH0KIAo=