100158 2012-10-23 13:40:24 -0700 popup menus don't behave correctly when using multiple monitors 2012-11-28 11:36:00 -0800 1 1 1 Unclassified WebKit Forms 528+ (Nightly build) PC Windows 7 RESOLVED FIXED P2 Normal --- 1 roger_fong webkit-unassigned roger_fong thorton oldest_to_newest 748927 0 roger_fong 2012-10-23 13:40:24 -0700 Need to add screen.x() to the popup menu position check to account for having multiple monitors. 748951 1 170229 roger_fong 2012-10-23 13:54:19 -0700 Created attachment 170229 patch 748984 2 170229 thorton 2012-10-23 14:27:41 -0700 Comment on attachment 170229 patch View in context: https://bugs.webkit.org/attachment.cgi?id=170229&action=review > Source/WebCore/ChangeLog:7 > + A few more words here would be nice. > Source/WebCore/ChangeLog:8 > + * platform/win/PopupMenuWin.cpp: You should say why this isn’t testable (No new tests because...) 778114 3 thorton 2012-11-28 11:36:00 -0800 http://trac.webkit.org/changeset/132271 170229 2012-10-23 13:54:19 -0700 2012-10-23 14:27:40 -0700 patch patch.txt text/plain 1310 roger_fong SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEzMjI1OCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDEyLTEwLTIzICBSb2dlciBG b25nICA8cm9nZXJfZm9uZ0BhcHBsZS5jb20+CisKKyAgICAgICAgUG9wdXAgbWVudXMgcG9zaXRp b25pbmcgbmVlZHMgdG8gdGFrZSBtdWx0aXBsZSBtb25pdG9ycyBpbnRvIGFjY291bnQuCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDAxNTgKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHBsYXRmb3JtL3dp bi9Qb3B1cE1lbnVXaW4uY3BwOgorICAgICAgICAoV2ViQ29yZTo6UG9wdXBNZW51V2luOjpjYWxj dWxhdGVQb3NpdGlvbkFuZFNpemUpOgorCiAyMDEyLTEwLTIzICBBbGVjIEZsZXR0ICA8YWxlY2Zs ZXR0QGNocm9taXVtLm9yZz4KIAogICAgICAgICBJbmRleGVkREI6IHJlZmFjdG9yIGJhY2tlbmQg dG8gdXNlIElEQipNZXRhZGF0YQpJbmRleDogU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vd2luL1Bv cHVwTWVudVdpbi5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vd2lu L1BvcHVwTWVudVdpbi5jcHAJKHJldmlzaW9uIDEzMjExMSkKKysrIFNvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL3dpbi9Qb3B1cE1lbnVXaW4uY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0zNzgsNyArMzc4 LDcgQEAgdm9pZCBQb3B1cE1lbnVXaW46OmNhbGN1bGF0ZVBvc2l0aW9uQW5kUwogICAgIH0KIAog ICAgIC8vIENoZWNrIHRoYXQgd2UgZG9uJ3QgZ28gb2ZmIHRoZSBzY3JlZW4gaG9yaXpvbnRhbGx5 Ci0gICAgaWYgKHBvcHVwUmVjdC54KCkgKyBwb3B1cFJlY3Qud2lkdGgoKSA+IHNjcmVlbi53aWR0 aCgpKQorICAgIGlmIChwb3B1cFJlY3QueCgpICsgcG9wdXBSZWN0LndpZHRoKCkgPiBzY3JlZW4u d2lkdGgoKSArIHNjcmVlbi54KCkpCiAgICAgICAgIHBvcHVwUmVjdC5zZXRYKHNjcmVlbi54KCkg KyBzY3JlZW4ud2lkdGgoKSAtIHBvcHVwUmVjdC53aWR0aCgpKTsKICAgICBpZiAocG9wdXBSZWN0 LngoKSA8IHNjcmVlbi54KCkpCiAgICAgICAgIHBvcHVwUmVjdC5zZXRYKHNjcmVlbi54KCkpOwo=