100156 2012-10-23 13:06:06 -0700 isLinkVisited is unnecessarily convoluted 2013-05-13 18:46:20 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED INVALID P2 Normal --- 1 abarth abarth allan.jensen ap cmarcelo darin eric macpherson menard mjs webkit.review.bot oldest_to_newest 748881 0 abarth 2012-10-23 13:06:06 -0700 isLinkVisited is unnecessarily convoluted 748882 1 170212 abarth 2012-10-23 13:08:02 -0700 Created attachment 170212 Patch 748883 2 abarth 2012-10-23 13:08:46 -0700 This patch is based on the discussion in bug 99483. 748889 3 170212 eric 2012-10-23 13:15:22 -0700 Comment on attachment 170212 Patch LGTM. 749029 4 170212 ap 2012-10-23 15:00:34 -0700 Comment on attachment 170212 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=170212&action=review > Source/WebCore/css/SelectorChecker.cpp:261 > +#error "Chromium is the only port that doesn't USE(PLATFORM_STRATEGIES)." Aren't Blackberry and Wx another two? 749032 5 abarth 2012-10-23 15:03:14 -0700 (In reply to comment #4) > (From update of attachment 170212 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=170212&action=review > > > Source/WebCore/css/SelectorChecker.cpp:261 > > +#error "Chromium is the only port that doesn't USE(PLATFORM_STRATEGIES)." > > Aren't Blackberry and Wx another two? /me will check before landing. 888636 6 170212 darin 2013-05-13 18:46:05 -0700 Comment on attachment 170212 Patch Patch is Chromium-specific, hence obsolete. 170212 2012-10-23 13:08:02 -0700 2013-05-13 18:46:05 -0700 Patch bug-100156-20121023130638.patch text/plain 3132 abarth U3VidmVyc2lvbiBSZXZpc2lvbjogMTMyMjU2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMjViNmVhMTIyMDczMzIx OTlhOThjMDkwOWZmZTY5YmU0OGFlZjQyMS4uOGQzMDMwYzg0OThiMTRiMjk0YjA3NDhkYzc1NTgx ZDZjMjhiMjJiZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDEyLTEwLTIzICBBZGFt IEJhcnRoICA8YWJhcnRoQHdlYmtpdC5vcmc+CisKKyAgICAgICAgaXNMaW5rVmlzaXRlZCBpcyB1 bm5lY2Vzc2FyaWx5IGNvbnZvbHV0ZWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTEwMDE1NgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIE5vdyB0aGF0IGFsbCBub24tQ2hyb21pdW0gcG9ydHMgaW5kaXJlY3Qg dGhlIGlzTGlua1Zpc2l0ZWQgdGhyb3VnaAorICAgICAgICBwbGF0Zm9ybVN0cmF0ZWdpZXMsIHdl IGNhbiBtb3ZlIHRoZSBQTEFURk9STShDSFJPTUlVTSkgaWZkZWYgdG8gdGhlCisgICAgICAgIHNh bWUgcG9pbnQgaW4gdGhlIGNvZGUuIFRoYXQgbWFrZXMgdGhlIGNvZGUgcGF0aHMgbW9yZSBzaW1p bGFyIChldmVuIGlmCisgICAgICAgIHRoZXkgYXJlbid0IHlldCBpZGVudGljYWwpLgorCisgICAg ICAgICogY3NzL1NlbGVjdG9yQ2hlY2tlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpTZWxlY3Rv ckNoZWNrZXI6OmRldGVybWluZUxpbmtTdGF0ZVNsb3dDYXNlKToKKyAgICAgICAgKiBwYWdlL1Bh Z2VHcm91cC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpQYWdlR3JvdXA6OmlzTGlua1Zpc2l0ZWQp OgorCiAyMDEyLTEwLTIzICBEb21pbmlrIFLDtnR0c2NoZXMgIDxkb21pbmlrLnJvdHRzY2hlc0Bp bnRlbC5jb20+CiAKICAgICAgICAgQWRkIHRpbWVvdXQgc3VwcG9ydCB0byBYTUxIdHRwUmVxdWVz dApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvY3NzL1NlbGVjdG9yQ2hlY2tlci5jcHAgYi9T b3VyY2UvV2ViQ29yZS9jc3MvU2VsZWN0b3JDaGVja2VyLmNwcAppbmRleCBlYjViOWYzODdiZTlh YmU1Y2VmMjM0MjY1MWQwNDIwZTAwZDdiZTMzLi40ZTQ1Mjc5NzY2ODVkM2VhMGY3Yjg4N2RlODky ZGY5ZWI2NmM5NTZhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9jc3MvU2VsZWN0b3JDaGVj a2VyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9jc3MvU2VsZWN0b3JDaGVja2VyLmNwcApAQCAt NTQsNiArNTQsNyBAQAogI2luY2x1ZGUgIlNpYmxpbmdUcmF2ZXJzYWxTdHJhdGVnaWVzLmgiCiAj aW5jbHVkZSAiU3R5bGVkRWxlbWVudC5oIgogI2luY2x1ZGUgIlRleHQuaCIKKyNpbmNsdWRlICJW aXNpdGVkTGlua3MuaCIKICNpbmNsdWRlICJYTGlua05hbWVzLmgiCiAKICNpZiBVU0UoUExBVEZP Uk1fU1RSQVRFR0lFUykKQEAgLTI1NCw4ICsyNTUsMTAgQEAgRUluc2lkZUxpbmsgU2VsZWN0b3JD aGVja2VyOjpkZXRlcm1pbmVMaW5rU3RhdGVTbG93Q2FzZShFbGVtZW50KiBlbGVtZW50KSBjb25z dAogCiAjaWYgVVNFKFBMQVRGT1JNX1NUUkFURUdJRVMpCiAgICAgcmV0dXJuIHBsYXRmb3JtU3Ry YXRlZ2llcygpLT52aXNpdGVkTGlua1N0cmF0ZWd5KCktPmlzTGlua1Zpc2l0ZWQocGFnZSwgaGFz aCwgbV9kb2N1bWVudC0+YmFzZVVSTCgpLCAqYXR0cmlidXRlKSA/IEluc2lkZVZpc2l0ZWRMaW5r IDogSW5zaWRlVW52aXNpdGVkTGluazsKKyNlbGlmIFBMQVRGT1JNKENIUk9NSVVNKQorICAgIHJl dHVybiBWaXNpdGVkTGlua3M6OmlzTGlua1Zpc2l0ZWQoaGFzaCkgPyBJbnNpZGVWaXNpdGVkTGlu ayA6IEluc2lkZVVudmlzaXRlZExpbms7CiAjZWxzZQotICAgIHJldHVybiBwYWdlLT5ncm91cCgp LmlzTGlua1Zpc2l0ZWQoaGFzaCkgPyBJbnNpZGVWaXNpdGVkTGluayA6IEluc2lkZVVudmlzaXRl ZExpbms7CisjZXJyb3IgIkNocm9taXVtIGlzIHRoZSBvbmx5IHBvcnQgdGhhdCBkb2Vzbid0IFVT RShQTEFURk9STV9TVFJBVEVHSUVTKS4iCiAjZW5kaWYKIH0KIApkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkNvcmUvcGFnZS9QYWdlR3JvdXAuY3BwIGIvU291cmNlL1dlYkNvcmUvcGFnZS9QYWdlR3Jv dXAuY3BwCmluZGV4IDc3OTI4Y2U2NDRlN2NhYTdiNGVkNTZlYTI1NzliNmUzOTRiNTViNTkuLjZh YjM0NzlhZjIyNTMwMTY4MTE3MWU1ZGI2YmJjYjlkNzRiMzlmNWYgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL3BhZ2UvUGFnZUdyb3VwLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL1Bh Z2VHcm91cC5jcHAKQEAgLTM4LDEwICszOCw2IEBACiAjaW5jbHVkZSAiU2V0dGluZ3MuaCIKICNp bmNsdWRlICJTdG9yYWdlTmFtZXNwYWNlLmgiCiAKLSNpZiBQTEFURk9STShDSFJPTUlVTSkKLSNp bmNsdWRlICJWaXNpdGVkTGlua3MuaCIKLSNlbmRpZgotCiBuYW1lc3BhY2UgV2ViQ29yZSB7CiAK IHN0YXRpYyB1bnNpZ25lZCBnZXRVbmlxdWVJZGVudGlmaWVyKCkKQEAgLTE3NSwxNyArMTcxLDEy IEBAIHZvaWQgUGFnZUdyb3VwOjpyZW1vdmVQYWdlKFBhZ2UqIHBhZ2UpCiAKIGJvb2wgUGFnZUdy b3VwOjppc0xpbmtWaXNpdGVkKExpbmtIYXNoIHZpc2l0ZWRMaW5rSGFzaCkKIHsKLSNpZiBQTEFU Rk9STShDSFJPTUlVTSkKLSAgICAvLyBVc2UgQ2hyb21pdW0ncyBidWlsdC1pbiB2aXNpdGVkIGxp bmsgZGF0YWJhc2UuCi0gICAgcmV0dXJuIFZpc2l0ZWRMaW5rczo6aXNMaW5rVmlzaXRlZCh2aXNp dGVkTGlua0hhc2gpOwotI2Vsc2UKICAgICBpZiAoIW1fdmlzaXRlZExpbmtzUG9wdWxhdGVkKSB7 CiAgICAgICAgIG1fdmlzaXRlZExpbmtzUG9wdWxhdGVkID0gdHJ1ZTsKICAgICAgICAgQVNTRVJU KCFtX3BhZ2VzLmlzRW1wdHkoKSk7CiAgICAgICAgICgqbV9wYWdlcy5iZWdpbigpKS0+Y2hyb21l KCktPmNsaWVudCgpLT5wb3B1bGF0ZVZpc2l0ZWRMaW5rcygpOwogICAgIH0KICAgICByZXR1cm4g bV92aXNpdGVkTGlua0hhc2hlcy5jb250YWlucyh2aXNpdGVkTGlua0hhc2gpOwotI2VuZGlmCiB9 CiAKIHZvaWQgUGFnZUdyb3VwOjphZGRWaXNpdGVkTGlua0hhc2goTGlua0hhc2ggaGFzaCkK