100140 2012-10-23 09:57:40 -0700 [V8] Replace SetGlobalGCPrologueCallback() with AddGCPrologueCallback() 2013-01-23 01:50:50 -0800 1 1 1 Unclassified WebKit WebCore JavaScript 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 107425 1 haraken haraken abarth japhet webkit.review.bot oldest_to_newest 748749 0 haraken 2012-10-23 09:57:40 -0700 SetGlobalGCPrologueCallback() and SetGlobalGCEpilogueCallback() are deprecated (See http://code.google.com/codesearch#OAMlx_jo-ck/src/v8/include/v8.h&exact_package=chromium&q=v8.h&type=cs&l=3149) Instead we should use AddGCPrologueCallback() and AddGCEpilogueCallback(). 748752 1 170185 haraken 2012-10-23 10:02:13 -0700 Created attachment 170185 Patch 748794 2 170185 webkit.review.bot 2012-10-23 10:57:21 -0700 Comment on attachment 170185 Patch Clearing flags on attachment: 170185 Committed r132243: <http://trac.webkit.org/changeset/132243> 748795 3 webkit.review.bot 2012-10-23 10:57:24 -0700 All reviewed patches have been landed. Closing bug. 170185 2012-10-23 10:02:13 -0700 2012-10-23 10:57:21 -0700 Patch bug-100140-20121023190049.patch text/plain 5486 haraken U3VidmVyc2lvbiBSZXZpc2lvbjogMTMyMDg3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOTg1ZjZmZDdhZDRmNGQ0 MTM4Y2I0NmUzOWVmZjQ2MjEwZjAxM2VlZi4uOTEwYmVmMTM0NmIzNjBhODlmNjE0MGZmNDQ1ODZi MzFmNzdiNmFkZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDMyIEBACisyMDEyLTEwLTIzICBLZW50 YXJvIEhhcmEgIDxoYXJha2VuQGNocm9taXVtLm9yZz4KKworICAgICAgICBbVjhdIFJlcGxhY2Ug U2V0R2xvYmFsR0NQcm9sb2d1ZUNhbGxiYWNrKCkgd2l0aCBBZGRHQ1Byb2xvZ3VlQ2FsbGJhY2so KQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTAwMTQw CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgU2V0R2xv YmFsR0NQcm9sb2d1ZUNhbGxiYWNrKCkgYW5kIFNldEdsb2JhbEdDRXBpbG9ndWVDYWxsYmFjaygp CisgICAgICAgIGFyZSBkZXByZWNhdGVkIChTZWUgaHR0cDovL2NvZGUuZ29vZ2xlLmNvbS9jb2Rl c2VhcmNoI09BTWx4X2pvLWNrL3NyYy92OC9pbmNsdWRlL3Y4LmgmZXhhY3RfcGFja2FnZT1jaHJv bWl1bSZxPXY4LmgmdHlwZT1jcyZsPTMxNDkpCisgICAgICAgIEluc3RlYWQgd2Ugc2hvdWxkIHVz ZSBBZGRHQ1Byb2xvZ3VlQ2FsbGJhY2soKQorICAgICAgICBhbmQgQWRkR0NFcGlsb2d1ZUNhbGxi YWNrKCkuCisKKyAgICAgICAgTm8gdGVzdHMuIE5vIGNoYW5nZSBpbiBiZWhhdmlvci4KKworICAg ICAgICAqIGJpbmRpbmdzL3Y4L1Y4RE9NV2luZG93U2hlbGwuY3BwOgorICAgICAgICAoV2ViQ29y ZTo6aW5pdGlhbGl6ZVY4SWZOZWVkZWQpOgorICAgICAgICAqIGJpbmRpbmdzL3Y4L1Y4R0NDb250 cm9sbGVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlY4R0NDb250cm9sbGVyOjpnY1Byb2xvZ3Vl KToKKyAgICAgICAgKFdlYkNvcmUpOgorICAgICAgICAoV2ViQ29yZTo6VjhHQ0NvbnRyb2xsZXI6 Om1pbm9yR0NQcm9sb2d1ZSk6CisgICAgICAgIChXZWJDb3JlOjpWOEdDQ29udHJvbGxlcjo6bWFq b3JHQ1Byb2xvZ3VlKToKKyAgICAgICAgKFdlYkNvcmU6OlY4R0NDb250cm9sbGVyOjpnY0VwaWxv Z3VlKToKKyAgICAgICAgKFdlYkNvcmU6OlY4R0NDb250cm9sbGVyOjptaW5vckdDRXBpbG9ndWUp OgorICAgICAgICAoV2ViQ29yZTo6VjhHQ0NvbnRyb2xsZXI6Om1ham9yR0NFcGlsb2d1ZSk6Cisg ICAgICAgICogYmluZGluZ3MvdjgvVjhHQ0NvbnRyb2xsZXIuaDoKKyAgICAgICAgKFY4R0NDb250 cm9sbGVyKToKKyAgICAgICAgKiBiaW5kaW5ncy92OC9Xb3JrZXJDb250ZXh0RXhlY3V0aW9uUHJv eHkuY3BwOgorICAgICAgICAoV2ViQ29yZTo6V29ya2VyQ29udGV4dEV4ZWN1dGlvblByb3h5Ojpp bml0SXNvbGF0ZSk6CisKIDIwMTItMTAtMjIgIEphbiBLZXJvbW5lcyAgPGphbnhAbGludXguY29t PgogCiAgICAgICAgIE1vdmVkIGNtZGV2dG9vbHMuanMgdG8gZm9sZGVyIGNtLwpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvVjhET01XaW5kb3dTaGVsbC5jcHAgYi9Tb3Vy Y2UvV2ViQ29yZS9iaW5kaW5ncy92OC9WOERPTVdpbmRvd1NoZWxsLmNwcAppbmRleCBkZTY1NzIx YTMzMzI1ODVkZjEwNmU5ZTZhNGNmNjMwOTY1N2E3N2ZhLi40ZDM3ZmM5M2NhM2IzNDc5NTYwMDY2 NzMyMmJkYjczYmJlZTJjOTA4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92 OC9WOERPTVdpbmRvd1NoZWxsLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9W OERPTVdpbmRvd1NoZWxsLmNwcApAQCAtMTUwLDggKzE1MCw4IEBAIHN0YXRpYyB2b2lkIGluaXRp YWxpemVWOElmTmVlZGVkKCkKIAogICAgIHY4OjpWODo6SWdub3JlT3V0T2ZNZW1vcnlFeGNlcHRp b24oKTsKICAgICB2ODo6Vjg6OlNldEZhdGFsRXJyb3JIYW5kbGVyKHJlcG9ydEZhdGFsRXJyb3Ip OwotICAgIHY4OjpWODo6U2V0R2xvYmFsR0NQcm9sb2d1ZUNhbGxiYWNrKCZWOEdDQ29udHJvbGxl cjo6Z2NQcm9sb2d1ZSk7Ci0gICAgdjg6OlY4OjpTZXRHbG9iYWxHQ0VwaWxvZ3VlQ2FsbGJhY2so JlY4R0NDb250cm9sbGVyOjpnY0VwaWxvZ3VlKTsKKyAgICB2ODo6Vjg6OkFkZEdDUHJvbG9ndWVD YWxsYmFjaygmVjhHQ0NvbnRyb2xsZXI6OmdjUHJvbG9ndWUpOworICAgIHY4OjpWODo6QWRkR0NF cGlsb2d1ZUNhbGxiYWNrKCZWOEdDQ29udHJvbGxlcjo6Z2NFcGlsb2d1ZSk7CiAgICAgdjg6OlY4 OjpBZGRNZXNzYWdlTGlzdGVuZXIoJnJlcG9ydFVuY2F1Z2h0RXhjZXB0aW9uKTsKICAgICB2ODo6 Vjg6OlNldEZhaWxlZEFjY2Vzc0NoZWNrQ2FsbGJhY2tGdW5jdGlvbihyZXBvcnRVbnNhZmVKYXZh U2NyaXB0QWNjZXNzKTsKICNpZiBFTkFCTEUoSkFWQVNDUklQVF9ERUJVR0dFUikKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4R0NDb250cm9sbGVyLmNwcCBiL1NvdXJj ZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4R0NDb250cm9sbGVyLmNwcAppbmRleCA5MDA3ZGFiOTdk ZTdlZDMwMDM1YzlhNWQ4MDFkZTAzOWIxMjY3YWUzLi44MDBlZTBhZTk3MzliNWRjMWJlMDY0NDYy NzkzNjUzNDQzZDRmZDQzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9W OEdDQ29udHJvbGxlci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvVjhHQ0Nv bnRyb2xsZXIuY3BwCkBAIC0yOTYsOCArMjk2LDIwIEBAIHByaXZhdGU6CiAgICAgR3JvdXBlckxp c3QgbV9ncm91cGVyOwogfTsKIAordm9pZCBWOEdDQ29udHJvbGxlcjo6Z2NQcm9sb2d1ZSh2ODo6 R0NUeXBlIHR5cGUsIHY4OjpHQ0NhbGxiYWNrRmxhZ3MgZmxhZ3MpCit7CisgICAgaWYgKHR5cGUg PT0gdjg6OmtHQ1R5cGVTY2F2ZW5nZSkKKyAgICAgICAgbWlub3JHQ1Byb2xvZ3VlKCk7CisgICAg ZWxzZSBpZiAodHlwZSA9PSB2ODo6a0dDVHlwZU1hcmtTd2VlcENvbXBhY3QpCisgICAgICAgIG1h am9yR0NQcm9sb2d1ZSgpOworfQorCit2b2lkIFY4R0NDb250cm9sbGVyOjptaW5vckdDUHJvbG9n dWUoKQoreworfQorCiAvLyBDcmVhdGUgb2JqZWN0IGdyb3VwcyBmb3IgRE9NIHRyZWUgbm9kZXMu Ci12b2lkIFY4R0NDb250cm9sbGVyOjpnY1Byb2xvZ3VlKCkKK3ZvaWQgVjhHQ0NvbnRyb2xsZXI6 Om1ham9yR0NQcm9sb2d1ZSgpCiB7CiAgICAgVFJBQ0VfRVZFTlRfQkVHSU4wKCJ2OCIsICJHQyIp OwogCkBAIC0zNzksNyArMzkxLDE5IEBAIHN0YXRpYyBNdXRleCYgd29ya2luZ1NldEVzdGltYXRl TUJNdXRleCgpCiB9CiAjZW5kaWYKIAotdm9pZCBWOEdDQ29udHJvbGxlcjo6Z2NFcGlsb2d1ZSgp Cit2b2lkIFY4R0NDb250cm9sbGVyOjpnY0VwaWxvZ3VlKHY4OjpHQ1R5cGUgdHlwZSwgdjg6OkdD Q2FsbGJhY2tGbGFncyBmbGFncykKK3sKKyAgICBpZiAodHlwZSA9PSB2ODo6a0dDVHlwZVNjYXZl bmdlKQorICAgICAgICBtaW5vckdDRXBpbG9ndWUoKTsKKyAgICBlbHNlIGlmICh0eXBlID09IHY4 OjprR0NUeXBlTWFya1N3ZWVwQ29tcGFjdCkKKyAgICAgICAgbWFqb3JHQ0VwaWxvZ3VlKCk7Cit9 CisKK3ZvaWQgVjhHQ0NvbnRyb2xsZXI6Om1pbm9yR0NFcGlsb2d1ZSgpCit7Cit9CisKK3ZvaWQg VjhHQ0NvbnRyb2xsZXI6Om1ham9yR0NFcGlsb2d1ZSgpCiB7CiAgICAgdjg6OkhhbmRsZVNjb3Bl IHNjb3BlOwogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9WOEdDQ29u dHJvbGxlci5oIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvVjhHQ0NvbnRyb2xsZXIuaApp bmRleCBlMmQ0ZDc0NWY2MWI4NjEyNTdjMDI1Mjk5OWVkMzViMmIwNzljZTVlLi41NDRkMzlmYTM4 ZWE4NTU0NWY4OTQ0NzJjZDJjNzg0NjE0MDVmZGJmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9iaW5kaW5ncy92OC9WOEdDQ29udHJvbGxlci5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL2JpbmRp bmdzL3Y4L1Y4R0NDb250cm9sbGVyLmgKQEAgLTM3LDggKzM3LDEyIEBAIG5hbWVzcGFjZSBXZWJD b3JlIHsKIAogY2xhc3MgVjhHQ0NvbnRyb2xsZXIgewogcHVibGljOgotICAgIHN0YXRpYyB2b2lk IGdjUHJvbG9ndWUoKTsKLSAgICBzdGF0aWMgdm9pZCBnY0VwaWxvZ3VlKCk7CisgICAgc3RhdGlj IHZvaWQgZ2NQcm9sb2d1ZSh2ODo6R0NUeXBlLCB2ODo6R0NDYWxsYmFja0ZsYWdzKTsKKyAgICBz dGF0aWMgdm9pZCBnY0VwaWxvZ3VlKHY4OjpHQ1R5cGUsIHY4OjpHQ0NhbGxiYWNrRmxhZ3MpOwor ICAgIHN0YXRpYyB2b2lkIG1pbm9yR0NQcm9sb2d1ZSgpOworICAgIHN0YXRpYyB2b2lkIG1pbm9y R0NFcGlsb2d1ZSgpOworICAgIHN0YXRpYyB2b2lkIG1ham9yR0NQcm9sb2d1ZSgpOworICAgIHN0 YXRpYyB2b2lkIG1ham9yR0NFcGlsb2d1ZSgpOwogCiAgICAgc3RhdGljIHZvaWQgY2hlY2tNZW1v cnlVc2FnZSgpOwogICAgIHN0YXRpYyB2b2lkIGhpbnRGb3JDb2xsZWN0R2FyYmFnZSgpOwpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvV29ya2VyQ29udGV4dEV4ZWN1dGlv blByb3h5LmNwcCBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1dvcmtlckNvbnRleHRFeGVj dXRpb25Qcm94eS5jcHAKaW5kZXggZWUyN2ViZjI3YTA2MGRkMWYzMzMwNWMzNjFlNzVlMWNiNzg4 OGVkMy4uOTM1NGJiM2IyZWE5ZDJjYTI3MDAxMGM3NGM0YWMxNDIzOGFkYzlkZSAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvV29ya2VyQ29udGV4dEV4ZWN1dGlvblByb3h5 LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9Xb3JrZXJDb250ZXh0RXhlY3V0 aW9uUHJveHkuY3BwCkBAIC0xMjIsOCArMTIyLDggQEAgdm9pZCBXb3JrZXJDb250ZXh0RXhlY3V0 aW9uUHJveHk6OmluaXRJc29sYXRlKCkKICAgICB2ODo6Vjg6Oklnbm9yZU91dE9mTWVtb3J5RXhj ZXB0aW9uKCk7CiAgICAgdjg6OlY4OjpTZXRGYXRhbEVycm9ySGFuZGxlcihyZXBvcnRGYXRhbEVy cm9ySW5WOCk7CiAKLSAgICB2ODo6Vjg6OlNldEdsb2JhbEdDUHJvbG9ndWVDYWxsYmFjaygmVjhH Q0NvbnRyb2xsZXI6OmdjUHJvbG9ndWUpOwotICAgIHY4OjpWODo6U2V0R2xvYmFsR0NFcGlsb2d1 ZUNhbGxiYWNrKCZWOEdDQ29udHJvbGxlcjo6Z2NFcGlsb2d1ZSk7CisgICAgdjg6OlY4OjpBZGRH Q1Byb2xvZ3VlQ2FsbGJhY2soJlY4R0NDb250cm9sbGVyOjpnY1Byb2xvZ3VlKTsKKyAgICB2ODo6 Vjg6OkFkZEdDRXBpbG9ndWVDYWxsYmFjaygmVjhHQ0NvbnRyb2xsZXI6OmdjRXBpbG9ndWUpOwog CiAgICAgLy8gRklYTUU6IFJlbW92ZSB0aGUgZm9sbG93aW5nIDIgbGluZXMgd2hlbiBWOCBkZWZh dWx0IGhhcyBjaGFuZ2VkLgogICAgIGNvbnN0IGNoYXIgZXM1UmVhZG9ubHlGbGFnW10gPSAiLS1l czVfcmVhZG9ubHkiOwo=