100135 2012-10-23 09:22:17 -0700 Code cleanup after r132165 2012-10-24 11:00:49 -0700 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 msaboff msaboff webkit.review.bot oldest_to_newest 748713 0 msaboff 2012-10-23 09:22:17 -0700 From comment https://bugs.webkit.org/show_bug.cgi?id=99889#c4: (From update of attachment 169729 [details]) View in context: https://bugs.webkit.org/attachment.cgi?id=169729&action=review > Source/WebCore/xml/parser/MarkupTokenBase.h:148 > + void beginEndTag(Vector<LChar, 32> characters) This argument type should be const Vector&, unless we want to copy a vector each time for some reason! > Source/WebCore/xml/parser/MarkupTokenBase.h:396 > + inline const String nameString() const The const in this return type “const String” doesn’t add value and should be removed. The inline keyword also adds nothing. Not sure why surrounding functions are using it. --- There is another Vector argument that should be made a reference. 748894 1 170215 msaboff 2012-10-23 13:20:25 -0700 Created attachment 170215 Patch 749823 2 170215 ggaren 2012-10-24 10:54:32 -0700 Comment on attachment 170215 Patch r=me 749829 3 170215 webkit.review.bot 2012-10-24 11:00:46 -0700 Comment on attachment 170215 Patch Clearing flags on attachment: 170215 Committed r132373: <http://trac.webkit.org/changeset/132373> 749830 4 webkit.review.bot 2012-10-24 11:00:49 -0700 All reviewed patches have been landed. Closing bug. 170215 2012-10-23 13:20:25 -0700 2012-10-24 11:00:45 -0700 Patch 100135.patch text/plain 2465 msaboff SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEzMjIzMykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIxIEBACisyMDEyLTEwLTIzICBNaWNoYWVs IFNhYm9mZiAgPG1zYWJvZmZAYXBwbGUuY29tPgorCisgICAgICAgIENvZGUgY2xlYW51cCBhZnRl ciByMTMyMTY1CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xMDAxMzUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBGaXhlZCB1cCBzb21lIHVubmVjY2VzYXJ5IGFuZCBpbmVmZmljaWVudCBjb25zdHJ1Y3RzIGlu IE1hcmt1cFRva2VuQmFzZS5oLgorCisgICAgICAgIENvZGUgY2xlYW4gdXAgd2l0aG91dCBmdW5j dGlvbmFsIGNoYW5nZXMsIHRoZXJlZm9yZSBubyBuZXcgdGVzdHMuCisKKyAgICAgICAgKiB4bWwv cGFyc2VyL01hcmt1cFRva2VuQmFzZS5oOgorICAgICAgICAoV2ViQ29yZTo6TWFya3VwVG9rZW5C YXNlOjpiZWdpbkVuZFRhZyk6IENoYW5nZWQgYXJndW1lbnQgdG8gYmUgY29uc3QgVmVjdG9yPExD aGFyLCAzMj4mLgorICAgICAgICAoV2ViQ29yZTo6TWFya3VwVG9rZW5CYXNlOjphcHBlbmRUb0No YXJhY3Rlcik6IENoYW5nZWQgYXJndW1lbnQgdG8gYmUgY29uc3QgVmVjdG9yPExDaGFyLCAzMj4m LgorICAgICAgICAoV2ViQ29yZTo6TWFya3VwVG9rZW5CYXNlOjphcHBlbmRUb05hbWUpOiBFbGlt aW50YXRlZCBpbmxpbmUuCisgICAgICAgIChXZWJDb3JlOjpNYXJrdXBUb2tlbkJhc2U6Om5hbWUp OiBFbGltaW50YXRlZCBpbmxpbmUuCisgICAgICAgIChXZWJDb3JlOjpNYXJrdXBUb2tlbkJhc2U6 Om5hbWVTdHJpbmcpOiBFbGltaW50YXRlZCBpbmxpbmUuCisKIDIwMTItMTAtMjMgIEVtaWwgQSBF a2x1bmQgIDxlYWVAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJlbW92ZSB1bm5lY2Vzc2FyeSBt X2xheW91dERlbHRhW1hZXVNhdHVyYXRlZCBpbml0aWFsaXphdGlvbgpJbmRleDogU291cmNlL1dl YkNvcmUveG1sL3BhcnNlci9NYXJrdXBUb2tlbkJhc2UuaAo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv V2ViQ29yZS94bWwvcGFyc2VyL01hcmt1cFRva2VuQmFzZS5oCShyZXZpc2lvbiAxMzIxNjUpCisr KyBTb3VyY2UvV2ViQ29yZS94bWwvcGFyc2VyL01hcmt1cFRva2VuQmFzZS5oCSh3b3JraW5nIGNv cHkpCkBAIC0xNDUsNyArMTQ1LDcgQEAgcHVibGljOgogICAgICAgICBtX2RhdGEuYXBwZW5kKGNo YXJhY3Rlcik7CiAgICAgfQogCi0gICAgdm9pZCBiZWdpbkVuZFRhZyhWZWN0b3I8TENoYXIsIDMy PiBjaGFyYWN0ZXJzKQorICAgIHZvaWQgYmVnaW5FbmRUYWcoY29uc3QgVmVjdG9yPExDaGFyLCAz Mj4mIGNoYXJhY3RlcnMpCiAgICAgewogICAgICAgICBBU1NFUlQobV90eXBlID09IFR5cGVTZXQ6 OlVuaW5pdGlhbGl6ZWQpOwogICAgICAgICBtX3R5cGUgPSBUeXBlU2V0OjpFbmRUYWc7CkBAIC0x OTgsNyArMTk4LDcgQEAgcHVibGljOgogICAgICAgICBtX29yQWxsRGF0YSB8PSBjaGFyYWN0ZXI7 CiAgICAgfQogCi0gICAgdm9pZCBhcHBlbmRUb0NoYXJhY3RlcihWZWN0b3I8TENoYXIsIDMyPiBj aGFyYWN0ZXJzKQorICAgIHZvaWQgYXBwZW5kVG9DaGFyYWN0ZXIoY29uc3QgVmVjdG9yPExDaGFy LCAzMj4mIGNoYXJhY3RlcnMpCiAgICAgewogICAgICAgICBBU1NFUlQobV90eXBlID09IFR5cGVT ZXQ6OkNoYXJhY3Rlcik7CiAgICAgICAgIG1fZGF0YS5hcHBlbmRWZWN0b3IoY2hhcmFjdGVycyk7 CkBAIC0zODEsMTkgKzM4MSwxOSBAQCBwcm90ZWN0ZWQ6CiAgICAgfQogI2VuZGlmIC8vIE5ERUJV RwogCi0gICAgaW5saW5lIHZvaWQgYXBwZW5kVG9OYW1lKFVDaGFyIGNoYXJhY3RlcikKKyAgICB2 b2lkIGFwcGVuZFRvTmFtZShVQ2hhciBjaGFyYWN0ZXIpCiAgICAgewogICAgICAgICBBU1NFUlQo Y2hhcmFjdGVyKTsKICAgICAgICAgbV9kYXRhLmFwcGVuZChjaGFyYWN0ZXIpOwogICAgICAgICBt X29yQWxsRGF0YSB8PSBjaGFyYWN0ZXI7CiAgICAgfQogCi0gICAgaW5saW5lIGNvbnN0IERhdGFW ZWN0b3ImIG5hbWUoKSBjb25zdAorICAgIGNvbnN0IERhdGFWZWN0b3ImIG5hbWUoKSBjb25zdAog ICAgIHsKICAgICAgICAgcmV0dXJuIG1fZGF0YTsKICAgICB9CiAKLSAgICBpbmxpbmUgY29uc3Qg U3RyaW5nIG5hbWVTdHJpbmcoKSBjb25zdAorICAgIFN0cmluZyBuYW1lU3RyaW5nKCkgY29uc3QK ICAgICB7CiAgICAgICAgIGlmICghbV9kYXRhLnNpemUoKSkKICAgICAgICAgICAgIHJldHVybiBl bXB0eVN0cmluZygpOwo=