100129 2012-10-23 08:49:20 -0700 Move appendAsLDMLLiteral in LocaleWin.cpp to a common place 2012-10-23 19:17:08 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 100128 1 tkent tkent haraken yutak oldest_to_newest 748680 0 tkent 2012-10-23 08:49:20 -0700 Move appendAsLDMLLiteral in LocaleWin.cpp to a common place 748682 1 170174 tkent 2012-10-23 08:54:24 -0700 Created attachment 170174 Patch 748690 2 170174 haraken 2012-10-23 08:58:34 -0700 Comment on attachment 170174 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=170174&action=review OK > Source/WebCore/ChangeLog:9 > + related to DateTimeFormat class. So we move it to DateTimeForma Typo: DateTimeForma => DateTimeFormat. > Source/WebCore/ChangeLog:10 > + class as quoteAndAppendLiteral. Nit: I would slightly prefer appendLiteralAndQuote(). (It's up to you.) 749239 3 tkent 2012-10-23 19:17:08 -0700 Committed r132292: <http://trac.webkit.org/changeset/132292> 170174 2012-10-23 08:54:24 -0700 2012-10-23 08:58:34 -0700 Patch bug-100129-20121024005300.patch text/plain 4761 tkent U3VidmVyc2lvbiBSZXZpc2lvbjogMTMyMjI3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYTg1MjU0ZTkxNjA1OWFh ZTJjN2JlOTBiNTU0YTAxYTAxMTdkNDVlZi4uZWNkYjRlOWFmYjhhZDU3OGRjMGVjYmZlNGNmNDNh YWUzODBlOGM5MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI3IEBACisyMDEyLTEwLTIzICBLZW50 IFRhbXVyYSAgPHRrZW50QGNocm9taXVtLm9yZz4KKworICAgICAgICBNb3ZlIGFwcGVuZEFzTERN TExpdGVyYWwgaW4gTG9jYWxlV2luLmNwcCB0byBhIGNvbW1vbiBwbGFjZQorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTAwMTI5CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV2UncmUgZ29pbmcgdG8gdXNlIGFw cGVuZEFzTERNTExpdGVyYWwgaW4gb3RoZXIgY29kZSwgYW5kIGl0IGlzCisgICAgICAgIHJlbGF0 ZWQgdG8gRGF0ZVRpbWVGb3JtYXQgY2xhc3MuICBTbyB3ZSBtb3ZlIGl0IHRvIERhdGVUaW1lRm9y bWEKKyAgICAgICAgY2xhc3MgYXMgcXVvdGVBbmRBcHBlbmRMaXRlcmFsLgorCisgICAgICAgIE5v IG5ldyB0ZXN0cyBiZWNhdXNlIG9mIG5vIGJlaGF2aW9yIGNoYW5nZS4KKworICAgICAgICAqIHBs YXRmb3JtL3RleHQvRGF0ZVRpbWVGb3JtYXQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6RGF0ZVRp bWVGb3JtYXQ6OnF1b3RlQW5kQXBwZW5kTGl0ZXJhbCk6CisgICAgICAgIE1vdmVkIGZyb20gTG9j YWxlV2luLmNwcAorICAgICAgICAqIHBsYXRmb3JtL3RleHQvRGF0ZVRpbWVGb3JtYXQuaDoKKyAg ICAgICAgRGVjbGFyZSBTdHJpbmdCdWlsZGVyIGJ5IHd0Zi9Gb3J3YXJkLmguIEl0IGFsc28gZGVj bGFyZXMgU3RyaW5nLgorICAgICAgICAoRGF0ZVRpbWVGb3JtYXQpOiBEZWNsYXJlIHF1b3RlQW5k QXBwZW5kTGl0ZXJhbC4KKyAgICAgICAgKiBwbGF0Zm9ybS90ZXh0L0xvY2FsZVdpbi5jcHA6Cisg ICAgICAgIChXZWJDb3JlKTogTW92ZSBhcHBlbmRMRE1MTGl0ZXJhbCB0byBEYXRlVGltZUZvcm1h dC4KKyAgICAgICAgKFdlYkNvcmU6OmNvbnZlcnRXaW5kb3dzRGF0ZUZvcm1hdFRvTERNTCk6Cisg ICAgICAgIEZvbGxvdyB0aGUgbW92aW5nLgorCiAyMDEyLTEwLTE1ICBLZW5uZXRoIFJvaGRlIENo cmlzdGlhbnNlbiAgPGtlbm5ldGhAd2Via2l0Lm9yZz4KIAogICAgICAgICBBZGQgc3VwcG9ydCBm b3IgcmVzb2x1dGlvbiBtZWRpYSBxdWVyeQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vdGV4dC9EYXRlVGltZUZvcm1hdC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS90 ZXh0L0RhdGVUaW1lRm9ybWF0LmNwcAppbmRleCAyYjFjMjhjNjhhOTIyYWU2ZmE5YjY0MTI3OGNl ZDkzOTk0N2JhYWM4Li42ZTVmZTY4ODMxMjk5NGJjMzI4MDc3YWQwYjVhMTY0NDA4Y2ZlNjQwIDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS90ZXh0L0RhdGVUaW1lRm9ybWF0LmNw cAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS90ZXh0L0RhdGVUaW1lRm9ybWF0LmNwcApA QCAtMjQxLDYgKzI0MSwzMiBAQCBib29sIERhdGVUaW1lRm9ybWF0OjpwYXJzZShjb25zdCBTdHJp bmcmIHNvdXJjZSwgVG9rZW5IYW5kbGVyJiB0b2tlbkhhbmRsZXIpCiAgICAgcmV0dXJuIGZhbHNl OwogfQogCit2b2lkIERhdGVUaW1lRm9ybWF0OjpxdW90ZUFuZEFwcGVuZExpdGVyYWwoY29uc3Qg U3RyaW5nJiBsaXRlcmFsLCBTdHJpbmdCdWlsZGVyJiBidWZmZXIpCit7CisgICAgaWYgKGxpdGVy YWwubGVuZ3RoKCkgPD0gMCkKKyAgICAgICAgcmV0dXJuOworICAgIAorICAgIGlmIChsaXRlcmFs LmZpbmQoJ1wnJykgPT0gbm90Rm91bmQpIHsKKyAgICAgICAgYnVmZmVyLmFwcGVuZCgiJyIpOwor ICAgICAgICBidWZmZXIuYXBwZW5kKGxpdGVyYWwpOworICAgICAgICBidWZmZXIuYXBwZW5kKCIn Iik7CisgICAgICAgIHJldHVybjsKKyAgICB9CisKKyAgICBmb3IgKHVuc2lnbmVkIGkgPSAwOyBp IDwgbGl0ZXJhbC5sZW5ndGgoKTsgKytpKSB7CisgICAgICAgIGlmIChsaXRlcmFsW2ldID09ICdc JycpCisgICAgICAgICAgICBidWZmZXIuYXBwZW5kKCInJyIpOworICAgICAgICBlbHNlIHsKKyAg ICAgICAgICAgIFN0cmluZyBlc2NhcGVkID0gbGl0ZXJhbC5zdWJzdHJpbmcoaSk7CisgICAgICAg ICAgICBlc2NhcGVkLnJlcGxhY2UoQVNDSUlMaXRlcmFsKCInIiksIEFTQ0lJTGl0ZXJhbCgiJyci KSk7CisgICAgICAgICAgICBidWZmZXIuYXBwZW5kKCInIik7CisgICAgICAgICAgICBidWZmZXIu YXBwZW5kKGVzY2FwZWQpOworICAgICAgICAgICAgYnVmZmVyLmFwcGVuZCgiJyIpOworICAgICAg ICAgICAgcmV0dXJuOworICAgICAgICB9CisgICAgfQorfQorCiB9IC8vIG5hbWVzcGFjZSBXZWJD b3JlCiAKICNlbmRpZgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vdGV4dC9E YXRlVGltZUZvcm1hdC5oIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vdGV4dC9EYXRlVGltZUZv cm1hdC5oCmluZGV4IGY1ZmYwMDM4ZjczNTQyMWIwZjJkNjVhZWFkZjY0YTI5YTBmMzY1ODguLmM5 OTZlNzZmODBkNTI1ZjQ5YWY5M2ExMTg5ZWVjODllZTdlZGE1MmIgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL3RleHQvRGF0ZVRpbWVGb3JtYXQuaAorKysgYi9Tb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS90ZXh0L0RhdGVUaW1lRm9ybWF0LmgKQEAgLTI3LDcgKzI3LDcgQEAKICNk ZWZpbmUgRGF0ZVRpbWVGb3JtYXRfaAogCiAjaWYgRU5BQkxFKElOUFVUX01VTFRJUExFX0ZJRUxE U19VSSkKLSNpbmNsdWRlIDx3dGYvdGV4dC9XVEZTdHJpbmcuaD4KKyNpbmNsdWRlIDx3dGYvRm9y d2FyZC5oPgogCiBuYW1lc3BhY2UgV2ViQ29yZSB7CiAKQEAgLTEwMyw2ICsxMDMsNyBAQCBwdWJs aWM6CiAKICAgICAvLyBSZXR1cm5zIHRydWUgaWYgc3VjY2VlZGVkLCBmYWxzZSBpZiBmYWlsZWQu CiAgICAgc3RhdGljIGJvb2wgcGFyc2UoY29uc3QgU3RyaW5nJiwgVG9rZW5IYW5kbGVyJik7Cisg ICAgc3RhdGljIHZvaWQgcXVvdGVBbmRBcHBlbmRMaXRlcmFsKGNvbnN0IFN0cmluZyYsIFN0cmlu Z0J1aWxkZXImKTsKIH07CiAKIH0gLy8gbmFtZXNwYWNlIFdlYkNvcmUKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL3RleHQvTG9jYWxlV2luLmNwcCBiL1NvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL3RleHQvTG9jYWxlV2luLmNwcAppbmRleCBlZGVmZGEyOTk4NDU3OGY2NDE5MDc3 OWQ3OTU4ZTQzNzEwYjQwZWRmLi5jMTFjMzc5ODRlY2EzMmQ3ZTI4ZTY0YzdjMDg5MGZjMmY5YzUx MjMzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS90ZXh0L0xvY2FsZVdpbi5j cHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vdGV4dC9Mb2NhbGVXaW4uY3BwCkBAIC01 NzksMzkgKzU3OSwxMyBAQCBib29sIExvY2FsZVdpbjo6aXNSVEwoKQogI2VuZGlmCiAKICNpZiBF TkFCTEUoSU5QVVRfTVVMVElQTEVfRklFTERTX1VJKQotc3RhdGljIHZvaWQgYXBwZW5kQXNMRE1M TGl0ZXJhbChjb25zdCBTdHJpbmcmIGxpdGVyYWwsIFN0cmluZ0J1aWxkZXImIGJ1ZmZlcikKLXsK LSAgICBpZiAobGl0ZXJhbC5sZW5ndGgoKSA8PSAwKQotICAgICAgICByZXR1cm47Ci0gICAgCi0g ICAgaWYgKGxpdGVyYWwuZmluZCgnXCcnKSA9PSBub3RGb3VuZCkgewotICAgICAgICBidWZmZXIu YXBwZW5kKCInIik7Ci0gICAgICAgIGJ1ZmZlci5hcHBlbmQobGl0ZXJhbCk7Ci0gICAgICAgIGJ1 ZmZlci5hcHBlbmQoIiciKTsKLSAgICAgICAgcmV0dXJuOwotICAgIH0KLQotICAgIGZvciAodW5z aWduZWQgaSA9IDA7IGkgPCBsaXRlcmFsLmxlbmd0aCgpOyArK2kpIHsKLSAgICAgICAgaWYgKGxp dGVyYWxbaV0gPT0gJ1wnJykKLSAgICAgICAgICAgIGJ1ZmZlci5hcHBlbmQoIicnIik7Ci0gICAg ICAgIGVsc2UgewotICAgICAgICAgICAgU3RyaW5nIGVzY2FwZWQgPSBsaXRlcmFsLnN1YnN0cmlu ZyhpKTsKLSAgICAgICAgICAgIGVzY2FwZWQucmVwbGFjZShBU0NJSUxpdGVyYWwoIiciKSwgQVND SUlMaXRlcmFsKCInJyIpKTsKLSAgICAgICAgICAgIGJ1ZmZlci5hcHBlbmQoIiciKTsKLSAgICAg ICAgICAgIGJ1ZmZlci5hcHBlbmQoZXNjYXBlZCk7Ci0gICAgICAgICAgICBidWZmZXIuYXBwZW5k KCInIik7Ci0gICAgICAgICAgICByZXR1cm47Ci0gICAgICAgIH0KLSAgICB9Ci19Ci0KIHN0YXRp YyBTdHJpbmcgY29udmVydFdpbmRvd3NEYXRlRm9ybWF0VG9MRE1MKGNvbnN0IFZlY3RvcjxEYXRl Rm9ybWF0VG9rZW4+JiB0b2tlbnMpCiB7CiAgICAgU3RyaW5nQnVpbGRlciBidWZmZXI7CiAgICAg Zm9yICh1bnNpZ25lZCBpID0gMDsgaSA8IHRva2Vucy5zaXplKCk7ICsraSkgewogICAgICAgICBz d2l0Y2ggKHRva2Vuc1tpXS50eXBlKSB7CiAgICAgICAgIGNhc2UgRGF0ZUZvcm1hdFRva2VuOjpM aXRlcmFsOgotICAgICAgICAgICAgYXBwZW5kQXNMRE1MTGl0ZXJhbCh0b2tlbnNbaV0uZGF0YSwg YnVmZmVyKTsKKyAgICAgICAgICAgIERhdGVUaW1lRm9ybWF0OjpxdW90ZUFuZEFwcGVuZExpdGVy YWwodG9rZW5zW2ldLmRhdGEsIGJ1ZmZlcik7CiAgICAgICAgICAgICBicmVhazsKIAogICAgICAg ICBjYXNlIERhdGVGb3JtYXRUb2tlbjo6RGF5MjoK