100126 2012-10-23 08:05:34 -0700 [EFL] Add baselines for non problematic tests in editing subcategories: deleting, inserting, selection and style. 2012-10-25 14:58:18 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 mariusz.g webkit-unassigned cdumez gyuyoung.kim kangil.han rakuco ryuan.choi webkit.review.bot oldest_to_newest 748657 0 mariusz.g 2012-10-23 08:05:34 -0700 Add missing expectations in editing subcategories: deleting, inserting, selection and style. 748659 1 170169 mariusz.g 2012-10-23 08:10:12 -0700 Created attachment 170169 patch 748764 2 rakuco 2012-10-23 10:18:00 -0700 Do you know what's needed for the remaining editing tests in that big list to be unskipped? 749337 3 170169 gyuyoung.kim 2012-10-23 21:58:56 -0700 Comment on attachment 170169 patch View in context: https://bugs.webkit.org/attachment.cgi?id=170169&action=review > LayoutTests/ChangeLog:3 I think this patch is close to rebaseline or add new test case. Please add meaningful bug title. And, "Unreviewed" keyword is used in Reviewer name field, not bug title. 749454 4 mariusz.g 2012-10-24 01:10:03 -0700 (In reply to comment #2) > Do you know what's needed for the remaining editing tests in that big list to be unskipped? My plan was to split gardening into 2 steps: first - big gardening with non problematic tests(current patch), second - describe and supply baselines for other tests(will need more investigation) 749461 5 170341 mariusz.g 2012-10-24 01:19:28 -0700 Created attachment 170341 Applied GyuYoung's comments 750511 6 170341 webkit.review.bot 2012-10-25 00:50:38 -0700 Comment on attachment 170341 Applied GyuYoung's comments Rejecting attachment 170341 from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1 Last 500 characters of output: mand(args, input=patch.contents(), cwd=self._scm.checkout_root) File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/common/system/executive.py", line 406, in run_command output = process.communicate(string_to_communicate)[0] File "/usr/lib/python2.6/subprocess.py", line 701, in communicate return self._communicate(input) File "/usr/lib/python2.6/subprocess.py", line 1210, in _communicate bytes_written = os.write(self.stdin.fileno(), chunk) OSError: [Errno 32] Broken pipe Full output: http://queues.webkit.org/results/14554561 750515 7 170577 mariusz.g 2012-10-25 01:01:25 -0700 Created attachment 170577 patch with --binary option 750527 8 170577 ryuan.choi 2012-10-25 01:12:19 -0700 Comment on attachment 170577 patch with --binary option OK, try once more. 750602 9 170577 webkit.review.bot 2012-10-25 02:54:22 -0700 Comment on attachment 170577 patch with --binary option Rejecting attachment 170577 from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: ternals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' 50>At revision 12787. ________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' ________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' Updating webkit projects from gyp files... LayoutTests/platform/efl-wk1/TestExpectations:317: Path does not exist. [test/expectations] [5] Total errors found: 1 in 2 files Full output: http://queues.webkit.org/results/14555549 750884 10 170577 webkit.review.bot 2012-10-25 08:57:05 -0700 Comment on attachment 170577 patch with --binary option Rejecting attachment 170577 from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: WebKit/chromium/v8 --revision 12787 --non-interactive --force --accept theirs-conflict --ignore-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' 50>At revision 12787. ________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' ________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' Updating webkit projects from gyp files... Total errors found: 0 in 2 files Full output: http://queues.webkit.org/results/14546658 751203 11 170577 webkit.review.bot 2012-10-25 14:19:17 -0700 Comment on attachment 170577 patch with --binary option Rejecting attachment 170577 from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: ore/ChangeLog CONFLICT (content): Merge conflict in Source/WebCore/ChangeLog Failed to merge in the changes. Patch failed at 0001 CHROMIUM: Add a method to WebLayerTreeView API When you have resolved this problem run "git rebase --continue". If you would prefer to skip this patch, instead run "git rebase --skip". To restore the original branch and stop rebasing run "git rebase --abort". rebase refs/remotes/origin/master: command returned error: 1 Died at Tools/Scripts/update-webkit line 154. Full output: http://queues.webkit.org/results/14569709 751241 12 170577 webkit.review.bot 2012-10-25 14:58:14 -0700 Comment on attachment 170577 patch with --binary option Clearing flags on attachment: 170577 Committed r132536: <http://trac.webkit.org/changeset/132536> 751242 13 webkit.review.bot 2012-10-25 14:58:18 -0700 All reviewed patches have been landed. Closing bug. 170169 2012-10-23 08:10:12 -0700 2012-10-24 01:19:28 -0700 patch patch-[20121022]-[mariusz.g@samsung.com]-[Unreviewed EFL gardening].patch text/plain 0 mariusz.g 170341 2012-10-24 01:19:28 -0700 2012-10-25 01:01:25 -0700 Applied GyuYoung's comments patch-[20121022]-[mariusz.g@samsung.com]-[Unreviewed EFL gardening].patch text/plain 0 mariusz.g 170577 2012-10-25 01:01:25 -0700 2012-10-25 14:58:14 -0700 patch with --binary option patch-[20121022]-[mariusz.g@samsung.com]-[Unreviewed EFL gardening].patch text/plain 0 mariusz.g