100115 2012-10-23 06:22:33 -0700 [Qt] Text with zero font size renders as X px sometimes, causing fast/text/zero-font-size-2.html to fail 2012-10-29 07:47:58 -0700 1 1 1 Unclassified WebKit New Bugs 420+ All All RESOLVED FIXED Qt, QtTriaged P2 Normal --- 87008 99918 1 ossy webkit-unassigned dglazkov ggaren mitz noam ossy webkit.review.bot oldest_to_newest 748564 0 ossy 2012-10-23 06:22:33 -0700 fast/text/zero-font-size-2.html intoduced in https://trac.webkit.org/changeset/131995 and fails on Qt, because r131995 fixed the bug for Mac only. diff: http://build.webkit.sed.hu/results/x86-64%20Linux%20Qt%20Release/r132209%20%2844199%29/fast/text/zero-font-size-2-diffs.html Original bug: https://bugs.webkit.org/show_bug.cgi?id=99918 Similar Chomium bug: https://bugs.webkit.org/show_bug.cgi?id=99920 748567 1 170143 ossy 2012-10-23 06:27:26 -0700 Created attachment 170143 copy/paste fix I don't know anything about font handling, but copy/pasting the code from https://bugs.webkit.org/show_bug.cgi?id=100115 fixed this test. (And it didn't cause new layout test failures of course.) 748574 2 170143 webkit.review.bot 2012-10-23 06:34:31 -0700 Comment on attachment 170143 copy/paste fix Attachment 170143 did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/14482970 748576 3 170143 ossy 2012-10-23 06:36:16 -0700 Comment on attachment 170143 copy/paste fix CQ again, chromium EWS is buggy. 748614 4 170158 ossy 2012-10-23 07:17:06 -0700 Created attachment 170158 patch 750623 5 ossy 2012-10-25 03:42:03 -0700 ping? 753432 6 ossy 2012-10-29 07:37:31 -0700 ping? 753442 7 170158 webkit.review.bot 2012-10-29 07:47:54 -0700 Comment on attachment 170158 patch Clearing flags on attachment: 170158 Committed r132802: <http://trac.webkit.org/changeset/132802> 753443 8 webkit.review.bot 2012-10-29 07:47:58 -0700 All reviewed patches have been landed. Closing bug. 170143 2012-10-23 06:27:26 -0700 2012-10-23 07:17:06 -0700 copy/paste fix 1.patch text/plain 1305 ossy ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA1NGU0OTkwLi4zZmEwMGFkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMg QEAKKzIwMTItMTAtMjMgIENzYWJhIE9zenRyb2dvbsOhYyAgPG9zc3lAd2Via2l0Lm9yZz4KKwor ICAgICAgICBbUXRdIFRleHQgd2l0aCB6ZXJvIGZvbnQgc2l6ZSByZW5kZXJzIGFzIFggcHggc29t ZXRpbWVzLCBjYXVzaW5nIGZhc3QvdGV4dC96ZXJvLWZvbnQtc2l6ZS0yLmh0bWwgdG8gZmFpbAor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTAwMTE1CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBwbGF0Zm9y bS9ncmFwaGljcy9xdC9Gb250UXQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6Rm9udDo6ZHJhd0ds eXBocyk6CisKIDIwMTItMTAtMjMgIEFsbGFuIFNhbmRmZWxkIEplbnNlbiAgPGFsbGFuLmplbnNl bkBkaWdpYS5jb20+CiAKICAgICAgICAgW1F0XSBSRUdSRVNTSU9OIChyMTMwODUxKTogZmFzdC90 ZXh0L3dvcmQtc3BhY2Utd2l0aC1rZXJuaW5nLmh0bWwgZmFpbHMKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3F0L0ZvbnRRdC5jcHAgYi9Tb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9ncmFwaGljcy9xdC9Gb250UXQuY3BwCmluZGV4IGQyMDdiMzQuLmUyY2RlNzYg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3F0L0ZvbnRRdC5j cHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvcXQvRm9udFF0LmNwcApA QCAtMjc4LDYgKzI3OCw5IEBAIHZvaWQgRm9udDo6ZHJhd0VtcGhhc2lzTWFya3NGb3JDb21wbGV4 VGV4dChHcmFwaGljc0NvbnRleHQqIC8qIGNvbnRleHQgKi8sIGNvbnN0CiAKIHZvaWQgRm9udDo6 ZHJhd0dseXBocyhHcmFwaGljc0NvbnRleHQqIGNvbnRleHQsIGNvbnN0IFNpbXBsZUZvbnREYXRh KiBmb250RGF0YSwgY29uc3QgR2x5cGhCdWZmZXImIGdseXBoQnVmZmVyLCBpbnQgZnJvbSwgaW50 IG51bUdseXBocywgY29uc3QgRmxvYXRQb2ludCYgcG9pbnQpIGNvbnN0CiB7CisgICAgaWYgKCFm b250RGF0YS0+cGxhdGZvcm1EYXRhKCkuc2l6ZSgpKQorICAgICAgICByZXR1cm47CisKICAgICBp ZiAoY29udGV4dC0+cGFpbnRpbmdEaXNhYmxlZCgpKQogICAgICAgICByZXR1cm47CiAK 170158 2012-10-23 07:17:06 -0700 2012-10-29 07:47:54 -0700 patch 1.patch text/plain 2922 ossy ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCA1NWRlNTgxLi44YTAyNTk3IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTQgQEAKIDIwMTItMTAt MjMgIENzYWJhIE9zenRyb2dvbsOhYyAgPG9zc3lAd2Via2l0Lm9yZz4KIAorICAgICAgICBbUXRd IFRleHQgd2l0aCB6ZXJvIGZvbnQgc2l6ZSByZW5kZXJzIGFzIFggcHggc29tZXRpbWVzLCBjYXVz aW5nIGZhc3QvdGV4dC96ZXJvLWZvbnQtc2l6ZS0yLmh0bWwgdG8gZmFpbAorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTAwMTE1CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9xdC9UZXN0RXhw ZWN0YXRpb25zOiBVbnNraXAgZmFzdC90ZXh0L3plcm8tZm9udC1zaXplLTIuaHRtbC4KKworMjAx Mi0xMC0yMyAgQ3NhYmEgT3N6dHJvZ29uw6FjICA8b3NzeUB3ZWJraXQub3JnPgorCiAgICAgICAg IFtRdF0gVW5yZXZpZXdlZCBob2xpZGF5IGdhcmRlbmluZyB0byBwYWludCB0aGUgYm90cyBncmVl bi4KIAogICAgICAgICAqIHBsYXRmb3JtL3F0LTUuMC13azIvaHR0cC90ZXN0cy9uYXZpZ2F0aW9u L2ZvcndhcmQtYW5kLWNhbmNlbC1leHBlY3RlZC50eHQ6IEFkZGVkIGFmdGVyIHIxMzIwNDEuCmRp ZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9xdC9UZXN0RXhwZWN0YXRpb25zIGIvTGF5 b3V0VGVzdHMvcGxhdGZvcm0vcXQvVGVzdEV4cGVjdGF0aW9ucwppbmRleCAxN2Y5MTU3Li44ZWU2 NGFhIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9xdC9UZXN0RXhwZWN0YXRpb25z CisrKyBiL0xheW91dFRlc3RzL3BsYXRmb3JtL3F0L1Rlc3RFeHBlY3RhdGlvbnMKQEAgLTI0NTgs OCArMjQ1OCw1IEBAIHdlYmtpdC5vcmcvYi85OTMwNiBhbmltYXRpb25zL29wYWNpdHktdHJhbnNm b3JtLWFuaW1hdGlvbi5odG1sIFsgSW1hZ2VPbmx5RmFpbHVyCiB3ZWJraXQub3JnL2IvOTkzMDYg Y3NzMy9maWx0ZXJzL2VmZmVjdC1ibHVyLWh3Lmh0bWwgWyBJbWFnZU9ubHlGYWlsdXJlIF0gIyBC bHVyIGVmZmVjdCByYWRpdXMgaXMgdG9vIHNtYWxsIG9uIFdlYktpdDEsIHRoZSBlZmZlY3Qgbm90 IGFwcGxpZWQgYXQgYWxsIG9uIFdlYktpdDIuCiB3ZWJraXQub3JnL2IvOTkzMDYgc3ZnL2hpeGll L3VzZS8wMDIueG1sIFsgSW1hZ2VPbmx5RmFpbHVyZSBdCiAKLSMgW1F0XSBUZXh0IHdpdGggemVy byBmb250IHNpemUgcmVuZGVycyBhcyBYIHB4IHNvbWV0aW1lcywgY2F1c2luZyBmYXN0L3RleHQv emVyby1mb250LXNpemUtMi5odG1sIHRvIGZhaWwKLXdlYmtpdC5vcmcvYi8xMDAxMTUgZmFzdC90 ZXh0L3plcm8tZm9udC1zaXplLTIuaHRtbAotCiAjIFJFR1JFU1NJT04ocjEzMjE0Myk6IEl0IG1h ZGUgZmFzdC94bWxodHRwcmVxdWVzdC94bWxodHRwcmVxdWVzdC1yZWN1cnNpdmUtc3luYy1ldmVu dC5odG1sIGZsYWtleQogd2Via2l0Lm9yZy9iLzEwMDExNyBmYXN0L3htbGh0dHByZXF1ZXN0L3ht bGh0dHByZXF1ZXN0LXJlY3Vyc2l2ZS1zeW5jLWV2ZW50Lmh0bWwKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBkMmZj MDkzLi4xY2I0YmFkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIv U291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTItMTAtMjMgIENz YWJhIE9zenRyb2dvbsOhYyAgPG9zc3lAd2Via2l0Lm9yZz4KKworICAgICAgICBbUXRdIFRleHQg d2l0aCB6ZXJvIGZvbnQgc2l6ZSByZW5kZXJzIGFzIFggcHggc29tZXRpbWVzLCBjYXVzaW5nIGZh c3QvdGV4dC96ZXJvLWZvbnQtc2l6ZS0yLmh0bWwgdG8gZmFpbAorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTAwMTE1CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9xdC9Gb250 UXQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6Rm9udDo6ZHJhd0dseXBocyk6CisKIDIwMTItMTAt MjMgICdQYXZlbCBGZWxkbWFuJyAgPHBmZWxkbWFuQGNocm9taXVtLm9yZz4KIAogICAgICAgICBO b3QgcmV2aWV3ZWQ6IGtpY2sgb3V0IG5vbi1jaHJvbWl1bSBmaWxlcyBmcm9tIFdlYkNvcmUuZ3lw aS4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3F0L0ZvbnRR dC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9xdC9Gb250UXQuY3BwCmlu ZGV4IGQyMDdiMzQuLmUyY2RlNzYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L2dyYXBoaWNzL3F0L0ZvbnRRdC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3Jh cGhpY3MvcXQvRm9udFF0LmNwcApAQCAtMjc4LDYgKzI3OCw5IEBAIHZvaWQgRm9udDo6ZHJhd0Vt cGhhc2lzTWFya3NGb3JDb21wbGV4VGV4dChHcmFwaGljc0NvbnRleHQqIC8qIGNvbnRleHQgKi8s IGNvbnN0CiAKIHZvaWQgRm9udDo6ZHJhd0dseXBocyhHcmFwaGljc0NvbnRleHQqIGNvbnRleHQs IGNvbnN0IFNpbXBsZUZvbnREYXRhKiBmb250RGF0YSwgY29uc3QgR2x5cGhCdWZmZXImIGdseXBo QnVmZmVyLCBpbnQgZnJvbSwgaW50IG51bUdseXBocywgY29uc3QgRmxvYXRQb2ludCYgcG9pbnQp IGNvbnN0CiB7CisgICAgaWYgKCFmb250RGF0YS0+cGxhdGZvcm1EYXRhKCkuc2l6ZSgpKQorICAg ICAgICByZXR1cm47CisKICAgICBpZiAoY29udGV4dC0+cGFpbnRpbmdEaXNhYmxlZCgpKQogICAg ICAgICByZXR1cm47CiAK