<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>100107</bug_id>
          
          <creation_ts>2012-10-23 04:11:40 -0700</creation_ts>
          <short_desc>[CSS Shaders] Remove m_contextSize from the CustomFilterRenderer.</short_desc>
          <delta_ts>2014-03-02 09:35:09 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Layout and Rendering</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>INVALID</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          <dependson>98989</dependson>
          
          <everconfirmed>0</everconfirmed>
          <reporter name="Dongseong Hwang">dongseong.hwang</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>krit</cc>
    
    <cc>ralpht+bugs</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>748479</commentid>
    <comment_count>0</comment_count>
    <who name="Dongseong Hwang">dongseong.hwang</who>
    <bug_when>2012-10-23 04:11:40 -0700</bug_when>
    <thetext>We would need something like CustomFilterRendererState that will contain the size and other parameters in the future. We should pass that to bindProgramBuffers instead of storing it.

There are two reasons.
1. Increase readability as separating changeable values from fixed values including shader program.
2. Be easy to reuse CustomFilterRenderer as making progress css shaders animation.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>914176</commentid>
    <comment_count>1</comment_count>
    <who name="Ralph T">ralpht+bugs</who>
    <bug_when>2013-08-02 09:29:26 -0700</bug_when>
    <thetext>In my port, I&apos;m now (sometimes) passing in a custom projection matrix so that I can avoid rendering to a texture and blending that to the framebuffer (which is needlessly wasteful of bandwidth and is too slow on some machines I target).

Is your idea that we could also avoid rebinding the attributes and setting uniforms that have not changed since the last render?</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>