100102 2012-10-23 03:43:37 -0700 [WK2] [GTK] TestWebKitAccessibility is not being run 2012-10-24 01:13:06 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED Gtk P2 Normal --- 1 mario webkit-unassigned apinheiro cgarcia jdiggs oldest_to_newest 748454 0 mario 2012-10-23 03:43:37 -0700 It seems a line got in run-gtk-tests by mistake along with SVN r120944, causing this test not to be run in WK2 bots: def _start_accessibility_daemons(self): return False spi_bus_launcher_path = self._lookup_atspi2_binary('at-spi-bus-launcher') spi_registryd_path = self._lookup_atspi2_binary('at-spi2-registryd') [...] Additionally, there seems to be a mistake in configure.ac as well, since the following block is now _after_ the definition of enable_webkit2, meaning that the PKG_CHECK_MODULES is never executed: # check if atspi2 is available (only needed for Webkit2 unit tests) if test "$enable_webkit2" = "yes"; then PKG_CHECK_MODULES([ATSPI2], [atspi-2 >= $ATSPI2_REQUIRED_VERSION], [have_atspi2=yes], [have_atspi2=no]) AC_SUBST([ATSPI2_CFLAGS]) AC_SUBST([ATSPI2_LIBS]) fi This needs to be fixed 748464 1 170110 mario 2012-10-23 03:53:02 -0700 Created attachment 170110 Patch proposal 749409 2 170110 cgarcia 2012-10-24 00:00:19 -0700 Comment on attachment 170110 Patch proposal Thanks! 749457 3 mario 2012-10-24 01:13:06 -0700 Committed r132328: <http://trac.webkit.org/changeset/132328> 170110 2012-10-23 03:53:02 -0700 2012-10-24 00:00:19 -0700 Patch proposal 0001-2012-10-23-Mario-Sanchez-Prada-mario-webkit.org.patch text/plain 4217 mario RnJvbSBkOGEwMDdhNjI4NjFhMzg2OTJlYTdiZTVhMTNmNTAwNGFkNWRjMWRkIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBNYXJpbyBTYW5jaGV6IFByYWRhIDxtYXJpb0BtYXJpb3Nwci5v cmc+CkRhdGU6IFR1ZSwgMjMgT2N0IDIwMTIgMTI6NTA6MzggKzAyMDAKU3ViamVjdDogW1BBVENI XSAyMDEyLTEwLTIzICBNYXJpbyBTYW5jaGV6IFByYWRhICA8bWFyaW9Ad2Via2l0Lm9yZz4KCiAg ICAgICAgW1dLMl0gW0dUS10gVGVzdFdlYktpdEFjY2Vzc2liaWxpdHkgaXMgbm90IGJlaW5nIHJ1 bgogICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDAxMDIK CiAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCgogICAgICAgIE1vdmVkIGNoZWNr IGZvciBhdC1zcGkyIGFmdGVyIHRoZSBkZWZpbml0aW9uIG9mIGVuYWJsZV93ZWJraXQyLAogICAg ICAgIHNpbmNlIGl0J3Mgb25seSBuZWVkZWQgZm9yIFdlYktpdDJHVEsgQVBJIHRlc3RzLgoKICAg ICAgICAqIGNvbmZpZ3VyZS5hYzogTW92ZWQgdGhlIGNoZWNrIGZvciBhdC1zcGkyIGRvd24gaW4g dGhlIGZpbGUuCgoyMDEyLTEwLTIzICBNYXJpbyBTYW5jaGV6IFByYWRhICA8bWFyaW9Ad2Via2l0 Lm9yZz4KCiAgICAgICAgW1dLMl0gW0dUS10gVGVzdFdlYktpdEFjY2Vzc2liaWxpdHkgaXMgbm90 IGJlaW5nIHJ1bgogICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xMDAxMDIKCiAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCgogICAgICAgIFJl bW92ZWQgd3JvbmcgZWFybHkgcmV0dXJuIGluIF9zdGFydF9hY2Nlc3NpYmlsaXR5X2RhZW1vbnMo KS4KCiAgICAgICAgKiBTY3JpcHRzL3J1bi1ndGstdGVzdHM6CiAgICAgICAgKFRlc3RSdW5uZXIu X2xvb2t1cF9hdHNwaTJfYmluYXJ5KTogUmVtb3ZlZCB3cm9uZyBsaW5lLgotLS0KIENoYW5nZUxv ZyAgICAgICAgICAgICAgICAgICB8IDEyICsrKysrKysrKysrKwogVG9vbHMvQ2hhbmdlTG9nICAg ICAgICAgICAgIHwgMTIgKysrKysrKysrKysrCiBUb29scy9TY3JpcHRzL3J1bi1ndGstdGVzdHMg fCAgMSAtCiBjb25maWd1cmUuYWMgICAgICAgICAgICAgICAgfCAyMCArKysrKysrKysrLS0tLS0t LS0tLQogNCBmaWxlcyBjaGFuZ2VkLCAzNCBpbnNlcnRpb25zKCspLCAxMSBkZWxldGlvbnMoLSkK CmRpZmYgLS1naXQgYS9DaGFuZ2VMb2cgYi9DaGFuZ2VMb2cKaW5kZXggMTJhNDFmYjYuLjg1Nzgx NDEgMTAwNjQ0Ci0tLSBhL0NoYW5nZUxvZworKysgYi9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBA QAorMjAxMi0xMC0yMyAgTWFyaW8gU2FuY2hleiBQcmFkYSAgPG1hcmlvQHdlYmtpdC5vcmc+CisK KyAgICAgICAgW1dLMl0gW0dUS10gVGVzdFdlYktpdEFjY2Vzc2liaWxpdHkgaXMgbm90IGJlaW5n IHJ1bgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTAw MTAyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTW92 ZWQgY2hlY2sgZm9yIGF0LXNwaTIgYWZ0ZXIgdGhlIGRlZmluaXRpb24gb2YgZW5hYmxlX3dlYmtp dDIsCisgICAgICAgIHNpbmNlIGl0J3Mgb25seSBuZWVkZWQgZm9yIFdlYktpdDJHVEsgQVBJIHRl c3RzLgorCisgICAgICAgICogY29uZmlndXJlLmFjOiBNb3ZlZCB0aGUgY2hlY2sgZm9yIGF0LXNw aTIgZG93biBpbiB0aGUgZmlsZS4KKwogMjAxMi0xMC0yMiAgUGF2ZWwgRmVsZG1hbiAgPHBmZWxk bWFuQGNocm9taXVtLm9yZz4KIAogICAgICAgICBXZWIgSW5zcGVjdG9yOiBtZXJnZSAiZG9ja2Vk IiBzdGF0ZSBpbnRvIHRoZSAiZG9jayBzaWRlIiBlbnVtLgpkaWZmIC0tZ2l0IGEvVG9vbHMvQ2hh bmdlTG9nIGIvVG9vbHMvQ2hhbmdlTG9nCmluZGV4IDIzNGJiODAuLjRmMmZlMDIgMTAwNjQ0Ci0t LSBhL1Rvb2xzL0NoYW5nZUxvZworKysgYi9Ub29scy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBA QAorMjAxMi0xMC0yMyAgTWFyaW8gU2FuY2hleiBQcmFkYSAgPG1hcmlvQHdlYmtpdC5vcmc+CisK KyAgICAgICAgW1dLMl0gW0dUS10gVGVzdFdlYktpdEFjY2Vzc2liaWxpdHkgaXMgbm90IGJlaW5n IHJ1bgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTAw MTAyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUmVt b3ZlZCB3cm9uZyBlYXJseSByZXR1cm4gaW4gX3N0YXJ0X2FjY2Vzc2liaWxpdHlfZGFlbW9ucygp LgorCisgICAgICAgICogU2NyaXB0cy9ydW4tZ3RrLXRlc3RzOgorICAgICAgICAoVGVzdFJ1bm5l ci5fbG9va3VwX2F0c3BpMl9iaW5hcnkpOiBSZW1vdmVkIHdyb25nIGxpbmUuCisKIDIwMTItMTAt MjIgIEpvY2hlbiBFaXNpbmdlciAgPGpvY2hlbkBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgW2No cm9taXVtXSBNb3ZlIHRoZSBjYWxsIHRvIFJlZ2lzdGVySXNvbGF0ZWRGaWxlU3lzdGVtIHRvIHRo ZSBXZWJUZXN0RGVsZWdhdGUgaW50ZXJmYWNlCmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3J1 bi1ndGstdGVzdHMgYi9Ub29scy9TY3JpcHRzL3J1bi1ndGstdGVzdHMKaW5kZXggMTI3NjU5Ni4u ZjVjYTRmNCAxMDA3NTUKLS0tIGEvVG9vbHMvU2NyaXB0cy9ydW4tZ3RrLXRlc3RzCisrKyBiL1Rv b2xzL1NjcmlwdHMvcnVuLWd0ay10ZXN0cwpAQCAtMTE5LDcgKzExOSw2IEBAIGNsYXNzIFRlc3RS dW5uZXI6CiAgICAgICAgIHJldHVybiBOb25lCiAKICAgICBkZWYgX3N0YXJ0X2FjY2Vzc2liaWxp dHlfZGFlbW9ucyhzZWxmKToKLSAgICAgICAgcmV0dXJuIEZhbHNlCiAgICAgICAgIHNwaV9idXNf bGF1bmNoZXJfcGF0aCA9IHNlbGYuX2xvb2t1cF9hdHNwaTJfYmluYXJ5KCdhdC1zcGktYnVzLWxh dW5jaGVyJykKICAgICAgICAgc3BpX3JlZ2lzdHJ5ZF9wYXRoID0gc2VsZi5fbG9va3VwX2F0c3Bp Ml9iaW5hcnkoJ2F0LXNwaTItcmVnaXN0cnlkJykKICAgICAgICAgaWYgbm90IHNwaV9idXNfbGF1 bmNoZXJfcGF0aCBvciBub3Qgc3BpX3JlZ2lzdHJ5ZF9wYXRoOgpkaWZmIC0tZ2l0IGEvY29uZmln dXJlLmFjIGIvY29uZmlndXJlLmFjCmluZGV4IDM3NjYzZTIuLjEwNWMzMWMgMTAwNjQ0Ci0tLSBh L2NvbmZpZ3VyZS5hYworKysgYi9jb25maWd1cmUuYWMKQEAgLTEwNDQsMTYgKzEwNDQsNiBAQCBp ZiB0ZXN0ICIkd2l0aF9hY2NlbGVyYXRpb25fYmFja2VuZCIgPSAib3BlbmdsIjsgdGhlbgogZmkK IEFDX1NVQlNUKFtPUEVOR0xfTElCU10pCiAKLSMgY2hlY2sgaWYgYXRzcGkyIGlzIGF2YWlsYWJs ZSAob25seSBuZWVkZWQgZm9yIFdlYmtpdDIgdW5pdCB0ZXN0cykKLWlmIHRlc3QgIiRlbmFibGVf d2Via2l0MiIgPSAieWVzIjsgdGhlbgotICAgUEtHX0NIRUNLX01PRFVMRVMoW0FUU1BJMl0sCi0g ICAgICAgICAgICAgICAgICAgICBbYXRzcGktMiA+PSAkQVRTUEkyX1JFUVVJUkVEX1ZFUlNJT05d LAotICAgICAgICAgICAgICAgICAgICAgW2hhdmVfYXRzcGkyPXllc10sIFtoYXZlX2F0c3BpMj1u b10pCi0KLSAgIEFDX1NVQlNUKFtBVFNQSTJfQ0ZMQUdTXSkKLSAgIEFDX1NVQlNUKFtBVFNQSTJf TElCU10pCi1maQotCiBpZiB0ZXN0ICIkZW5hYmxlX2dhbWVwYWQiID0gInllcyI7IHRoZW4KICAg IFBLR19DSEVDS19NT0RVTEVTKFtHQU1FUEFEXSwgW2dpby11bml4LTIuMCBndWRldi0xLjBdKQog CkBAIC0xMTE0LDYgKzExMDQsMTYgQEAgQUNfU1VCU1QoR1RLMl9MSUJTKQogCiBHVEtfRE9DX0NI RUNLKFsxLjEwXSkKIAorIyBXZSBuZWVkIGF0c3BpMiBmb3IgV2Via2l0MiB1bml0IHRlc3RzCitp ZiB0ZXN0ICIkZW5hYmxlX3dlYmtpdDIiID0gInllcyI7IHRoZW4KKyAgIFBLR19DSEVDS19NT0RV TEVTKFtBVFNQSTJdLAorICAgICAgICAgICAgICAgICAgICAgW2F0c3BpLTIgPj0gJEFUU1BJMl9S RVFVSVJFRF9WRVJTSU9OXSwKKyAgICAgICAgICAgICAgICAgICAgIFtoYXZlX2F0c3BpMj15ZXNd LCBbaGF2ZV9hdHNwaTI9bm9dKQorCisgICBBQ19TVUJTVChbQVRTUEkyX0NGTEFHU10pCisgICBB Q19TVUJTVChbQVRTUEkyX0xJQlNdKQorZmkKKwogIyBPUyBjb25kaXRpb25hbHMKIEFNX0NPTkRJ VElPTkFMKFtPU19XSU4zMl0sW3Rlc3QgIiRvc193aW4zMiIgPSAieWVzIl0pCiBBTV9DT05ESVRJ T05BTChbT1NfVU5JWF0sW3Rlc3QgIiRvc193aW4zMiIgPSAibm8iXSkKLS0gCjEuNy4xMS43Cgo=