100091 2012-10-23 01:42:04 -0700 Memory instrumentation: add reportMemoryUsage to ImageObserver interface 2012-10-25 08:29:15 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 yurys yurys apavlov keishi loislo pfeldman pmuellr vsevik web-inspector-bugs webkit.review.bot yurys oldest_to_newest 748378 0 yurys 2012-10-23 01:42:04 -0700 CachedImage is derived from both CachedResource and ImageObserver. When CachedImage is reported as ImageObserver* it is treated as standalone object and will be counted second time as CacnedImage. To avoid this we need to make sure ImageObserver has virtual method for reporting adjusted pointer. 750818 1 170649 yurys 2012-10-25 07:45:50 -0700 Created attachment 170649 Patch 750826 2 170649 yurys 2012-10-25 07:50:18 -0700 Comment on attachment 170649 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=170649&action=review > Source/WebKit/chromium/WebKit.gypi:89 > + 'tests/MemoryInstrumentationTest.cpp', I tried to add the test to Tools/TestWebKitAPI/Tests/WebCore/MemoryInstrumentation.cpp but gave up as it was failing in some very weird places during ResourceRequest construction. It looks like we have to add some dependencies to the corresponding build target(so that WebCore is properly initialized) but I failed to figure out which one and put the test under WebKit/chromium/tests for now. 750830 3 170649 loislo 2012-10-25 07:52:14 -0700 Comment on attachment 170649 Patch lgtm 750853 4 170649 webkit.review.bot 2012-10-25 08:29:12 -0700 Comment on attachment 170649 Patch Clearing flags on attachment: 170649 Committed r132486: <http://trac.webkit.org/changeset/132486> 750854 5 webkit.review.bot 2012-10-25 08:29:15 -0700 All reviewed patches have been landed. Closing bug. 170649 2012-10-25 07:45:50 -0700 2012-10-25 08:29:12 -0700 Patch bug-100091-20121025184423.patch text/plain 6006 yurys U3VidmVyc2lvbiBSZXZpc2lvbjogMTMyMzM0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYjIyYWYzZGU5ZjBlY2Fm NmVmZmQ0MGQ0NDRjM2YzZjI2MzUyOTYwOC4uNDZhMzNjYjA5NTZlODYwYWUyOTE2ZmFkZTZhYzdh YmNiMWJhMjQ3YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEyLTEwLTIzICBZdXJ5 IFNlbWlraGF0c2t5ICA8eXVyeXNAY2hyb21pdW0ub3JnPgorCisgICAgICAgIE1lbW9yeSBpbnN0 cnVtZW50YXRpb246IGFkZCByZXBvcnRNZW1vcnlVc2FnZSB0byBJbWFnZU9ic2VydmVyIGludGVy ZmFjZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTAw MDkxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRk ZWQgcmVwb3J0TWVtb3J5VXNhZ2UgbWV0aG9kIHRvIEltYWdlT2JzZXJ2ZXIgdG8gbWFrZSBzdXJl IGl0IGlzIHJlcG9ydGVkIGFzCisgICAgICAgIGFwcHJvcHJpYXRlIGRlc2NlbmRhbnQod2l0aCBw b2ludGVyIGFkanVzdGVkIGR1ZSB0byBvZmZzZXRzIGFkZGVkIGJ5IGluaGVyaXRhbmNlKQorICAg ICAgICByYXRoZXIgdGhhbiBhcyBhIHN0YW5kYWxvbmUgbWVtb3J5IGJsb2NrLgorCisgICAgICAg ICogcGxhdGZvcm0vZ3JhcGhpY3MvSW1hZ2VPYnNlcnZlci5oOgorICAgICAgICAoSW1hZ2VPYnNl cnZlcik6CisKIDIwMTItMDktMjcgIFl1cnkgU2VtaWtoYXRza3kgIDx5dXJ5c0BjaHJvbWl1bS5v cmc+CiAKICAgICAgICAgV2ViIEluc3BlY3RvcjogcHJvdmlkZSBtZW1vcnkgaW5zdHJ1bWVudGF0 aW9uIGZvciBMaXN0SGFzaFNldApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v Z3JhcGhpY3MvSW1hZ2VPYnNlcnZlci5oIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhp Y3MvSW1hZ2VPYnNlcnZlci5oCmluZGV4IDhiNjkzZDk4NDhlMmMwYjMwNTM1NGUwZWQxNmEzNTQ4 YWI1ZTE1ODUuLjgwNGNkZWI5N2FlZWJkMmVmMDE2ZDc4NDY0ZDRmNDRiOGZjYWRkNjYgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0ltYWdlT2JzZXJ2ZXIuaAor KysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9JbWFnZU9ic2VydmVyLmgKQEAg LTI2LDYgKzI2LDggQEAKICNpZm5kZWYgSW1hZ2VPYnNlcnZlcl9oCiAjZGVmaW5lIEltYWdlT2Jz ZXJ2ZXJfaAogCisjaW5jbHVkZSA8d3RmL0ZvcndhcmQuaD4KKwogbmFtZXNwYWNlIFdlYkNvcmUg ewogCiBjbGFzcyBJbWFnZTsKQEAgLTQ0LDYgKzQ2LDggQEAgcHVibGljOgogICAgIHZpcnR1YWwg dm9pZCBhbmltYXRpb25BZHZhbmNlZChjb25zdCBJbWFnZSopID0gMDsKIAogICAgIHZpcnR1YWwg dm9pZCBjaGFuZ2VkSW5SZWN0KGNvbnN0IEltYWdlKiwgY29uc3QgSW50UmVjdCYpID0gMDsKKwor ICAgIHZpcnR1YWwgdm9pZCByZXBvcnRNZW1vcnlVc2FnZShNZW1vcnlPYmplY3RJbmZvKikgY29u c3QgPSAwOwogfTsKIAogfQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9XZWJL aXQuZ3lwaSBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vV2ViS2l0Lmd5cGkKaW5kZXggNjQwNjNh MDIxYzQ2NzE0ZDlkNTk4NTZhY2VjNDIyZWY4N2JkZTk5ZS4uMzY5N2ZjZmUzM2RhZTUzMjA5YmM3 NThkZWUxMTM3Zjk4ZDZjYzdiNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9X ZWJLaXQuZ3lwaQorKysgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL1dlYktpdC5neXBpCkBAIC04 Niw2ICs4Niw3IEBACiAgICAgICAgICAgICAndGVzdHMvTGlua0hpZ2hsaWdodFRlc3QuY3BwJywK ICAgICAgICAgICAgICd0ZXN0cy9MaXN0ZW5lckxlYWtUZXN0LmNwcCcsCiAgICAgICAgICAgICAn dGVzdHMvTWVtb3J5SW5mby5jcHAnLAorICAgICAgICAgICAgJ3Rlc3RzL01lbW9yeUluc3RydW1l bnRhdGlvblRlc3QuY3BwJywKICAgICAgICAgICAgICd0ZXN0cy9PcGFxdWVSZWN0VHJhY2tpbmdD b250ZW50TGF5ZXJEZWxlZ2F0ZVRlc3QuY3BwJywKICAgICAgICAgICAgICd0ZXN0cy9PcGVuVHlw ZVZlcnRpY2FsRGF0YVRlc3QuY3BwJywKICAgICAgICAgICAgICd0ZXN0cy9QT0RBcmVuYVRlc3Qu Y3BwJywKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vdGVzdHMvTWVtb3J5SW5z dHJ1bWVudGF0aW9uVGVzdC5jcHAgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3Rlc3RzL01lbW9y eUluc3RydW1lbnRhdGlvblRlc3QuY3BwCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLjBjMDgxZWQ5YTI1ZDYyN2RlZDUz YjU4NWZmOGU1ZGQ3MGZiZTIyNTkKLS0tIC9kZXYvbnVsbAorKysgYi9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL3Rlc3RzL01lbW9yeUluc3RydW1lbnRhdGlvblRlc3QuY3BwCkBAIC0wLDAgKzEsOTIg QEAKKy8qCisgKiBDb3B5cmlnaHQgKEMpIDIwMTIgR29vZ2xlIEluYy4gQWxsIHJpZ2h0cyByZXNl cnZlZC4KKyAqCisgKiBSZWRpc3RyaWJ1dGlvbiBhbmQgdXNlIGluIHNvdXJjZSBhbmQgYmluYXJ5 IGZvcm1zLCB3aXRoIG9yIHdpdGhvdXQKKyAqIG1vZGlmaWNhdGlvbiwgYXJlIHBlcm1pdHRlZCBw cm92aWRlZCB0aGF0IHRoZSBmb2xsb3dpbmcgY29uZGl0aW9ucyBhcmUKKyAqIG1ldDoKKyAqCisg KiAgICAgKiBSZWRpc3RyaWJ1dGlvbnMgb2Ygc291cmNlIGNvZGUgbXVzdCByZXRhaW4gdGhlIGFi b3ZlIGNvcHlyaWdodAorICogbm90aWNlLCB0aGlzIGxpc3Qgb2YgY29uZGl0aW9ucyBhbmQgdGhl IGZvbGxvd2luZyBkaXNjbGFpbWVyLgorICogICAgICogUmVkaXN0cmlidXRpb25zIGluIGJpbmFy eSBmb3JtIG11c3QgcmVwcm9kdWNlIHRoZSBhYm92ZQorICogY29weXJpZ2h0IG5vdGljZSwgdGhp cyBsaXN0IG9mIGNvbmRpdGlvbnMgYW5kIHRoZSBmb2xsb3dpbmcgZGlzY2xhaW1lcgorICogaW4g dGhlIGRvY3VtZW50YXRpb24gYW5kL29yIG90aGVyIG1hdGVyaWFscyBwcm92aWRlZCB3aXRoIHRo ZQorICogZGlzdHJpYnV0aW9uLgorICogICAgICogTmVpdGhlciB0aGUgbmFtZSBvZiBHb29nbGUg SW5jLiBub3IgdGhlIG5hbWVzIG9mIGl0cworICogY29udHJpYnV0b3JzIG1heSBiZSB1c2VkIHRv IGVuZG9yc2Ugb3IgcHJvbW90ZSBwcm9kdWN0cyBkZXJpdmVkIGZyb20KKyAqIHRoaXMgc29mdHdh cmUgd2l0aG91dCBzcGVjaWZpYyBwcmlvciB3cml0dGVuIHBlcm1pc3Npb24uCisgKgorICogVEhJ UyBTT0ZUV0FSRSBJUyBQUk9WSURFRCBCWSBUSEUgQ09QWVJJR0hUIEhPTERFUlMgQU5EIENPTlRS SUJVVE9SUworICogIkFTIElTIiBBTkQgQU5ZIEVYUFJFU1MgT1IgSU1QTElFRCBXQVJSQU5USUVT LCBJTkNMVURJTkcsIEJVVCBOT1QKKyAqIExJTUlURUQgVE8sIFRIRSBJTVBMSUVEIFdBUlJBTlRJ RVMgT0YgTUVSQ0hBTlRBQklMSVRZIEFORCBGSVRORVNTIEZPUgorICogQSBQQVJUSUNVTEFSIFBV UlBPU0UgQVJFIERJU0NMQUlNRUQuIElOIE5PIEVWRU5UIFNIQUxMIFRIRSBDT1BZUklHSFQKKyAq IE9XTkVSIE9SIENPTlRSSUJVVE9SUyBCRSBMSUFCTEUgRk9SIEFOWSBESVJFQ1QsIElORElSRUNU LCBJTkNJREVOVEFMLAorICogU1BFQ0lBTCwgRVhFTVBMQVJZLCBPUiBDT05TRVFVRU5USUFMIERB TUFHRVMgKElOQ0xVRElORywgQlVUIE5PVAorICogTElNSVRFRCBUTywgUFJPQ1VSRU1FTlQgT0Yg U1VCU1RJVFVURSBHT09EUyBPUiBTRVJWSUNFUzsgTE9TUyBPRiBVU0UsCisgKiBEQVRBLCBPUiBQ Uk9GSVRTOyBPUiBCVVNJTkVTUyBJTlRFUlJVUFRJT04pIEhPV0VWRVIgQ0FVU0VEIEFORCBPTiBB TlkKKyAqIFRIRU9SWSBPRiBMSUFCSUxJVFksIFdIRVRIRVIgSU4gQ09OVFJBQ1QsIFNUUklDVCBM SUFCSUxJVFksIE9SIFRPUlQKKyAqIChJTkNMVURJTkcgTkVHTElHRU5DRSBPUiBPVEhFUldJU0Up IEFSSVNJTkcgSU4gQU5ZIFdBWSBPVVQgT0YgVEhFIFVTRQorICogT0YgVEhJUyBTT0ZUV0FSRSwg RVZFTiBJRiBBRFZJU0VEIE9GIFRIRSBQT1NTSUJJTElUWSBPRiBTVUNIIERBTUFHRS4KKyAqLwor CisjaW5jbHVkZSAiY29uZmlnLmgiCisKKyNpbmNsdWRlICJDYWNoZWRJbWFnZS5oIgorI2luY2x1 ZGUgIk1lbW9yeUluc3RydW1lbnRhdGlvbkltcGwuaCIKKyNpbmNsdWRlIDxndGVzdC9ndGVzdC5o PgorI2luY2x1ZGUgPHd0Zi9NZW1vcnlJbnN0cnVtZW50YXRpb24uaD4KKyNpbmNsdWRlIDx3dGYv T3duUHRyLmg+CisKK3VzaW5nIG5hbWVzcGFjZSBXZWJDb3JlOworCit1c2luZyBXVEY6Ok1lbW9y eU9iamVjdEluZm87Cit1c2luZyBXVEY6Ok1lbW9yeUNsYXNzSW5mbzsKK3VzaW5nIFdURjo6TWVt b3J5T2JqZWN0VHlwZTsKKworbmFtZXNwYWNlIHsKKworTWVtb3J5T2JqZWN0VHlwZSBUZXN0VHlw ZSA9ICJUZXN0VHlwZSI7CisKK2NsYXNzIEltYWdlT2JzZXJ2ZXJUZXN0SGVscGVyIHsKK3B1Ymxp YzoKKyAgICBJbWFnZU9ic2VydmVyVGVzdEhlbHBlcigpCisgICAgICAgIDogbV9jYWNoZWRJbWFn ZShhZG9wdFB0cihuZXcgQ2FjaGVkSW1hZ2UoMCkpKQorICAgICAgICAsIG1faW1hZ2VPYmVydmVy KG1fY2FjaGVkSW1hZ2UuZ2V0KCkpCisgICAgeworICAgIH0KKyAgICB2b2lkIHJlcG9ydE1lbW9y eVVzYWdlKE1lbW9yeU9iamVjdEluZm8qIG1lbW9yeU9iamVjdEluZm8pIGNvbnN0CisgICAgewor ICAgICAgICBNZW1vcnlDbGFzc0luZm8gaW5mbyhtZW1vcnlPYmplY3RJbmZvLCB0aGlzLCBUZXN0 VHlwZSk7CisgICAgICAgIGluZm8uYWRkTWVtYmVyKG1fY2FjaGVkSW1hZ2UpOworICAgICAgICBp bmZvLmFkZE1lbWJlcihtX2ltYWdlT2JlcnZlcik7CisgICAgfQorCisgICAgT3duUHRyPENhY2hl ZEltYWdlPiBtX2NhY2hlZEltYWdlOworICAgIEltYWdlT2JzZXJ2ZXIqIG1faW1hZ2VPYmVydmVy OworfTsKKworVEVTVChNZW1vcnlJbnN0cnVtZW50YXRpb25UZXN0LCBJbWFnZU9ic2VydmVyKQor eworICAgIEltYWdlT2JzZXJ2ZXJUZXN0SGVscGVyIGhlbHBlcjsKKyAgICBFWFBFQ1RfTkUoc3Rh dGljX2Nhc3Q8dm9pZCo+KGhlbHBlci5tX2NhY2hlZEltYWdlLmdldCgpKSwgc3RhdGljX2Nhc3Q8 dm9pZCo+KGhlbHBlci5tX2ltYWdlT2JlcnZlcikpOworCisgICAgY2xhc3MgVGVzdENsaWVudCA6 IHB1YmxpYyBNZW1vcnlJbnN0cnVtZW50YXRpb25DbGllbnRJbXBsIHsKKyAgICBwdWJsaWM6Cisg ICAgICAgIGV4cGxpY2l0IFRlc3RDbGllbnQoY29uc3Qgdm9pZCogdW5leHBlY3RlZFBvaW50ZXIp IDogbV91bmV4cGVjdGVkUG9pbnRlZCh1bmV4cGVjdGVkUG9pbnRlcikgeyB9CisgICAgICAgIHZp cnR1YWwgdm9pZCBjb3VudE9iamVjdFNpemUoY29uc3Qgdm9pZCogcG9pbnRlciwgTWVtb3J5T2Jq ZWN0VHlwZSB0eXBlLCBzaXplX3Qgc2l6ZSkgT1ZFUlJJREUKKyAgICAgICAgeworICAgICAgICAg ICAgRVhQRUNUX05FKG1fdW5leHBlY3RlZFBvaW50ZWQsIHBvaW50ZXIpOworICAgICAgICAgICAg TWVtb3J5SW5zdHJ1bWVudGF0aW9uQ2xpZW50SW1wbDo6Y291bnRPYmplY3RTaXplKHBvaW50ZXIs IHR5cGUsIHNpemUpOworICAgICAgICB9CisKKyAgICBwcml2YXRlOgorICAgICAgICBjb25zdCB2 b2lkKiBtX3VuZXhwZWN0ZWRQb2ludGVkOworICAgIH0gY2xpZW50KGhlbHBlci5tX2ltYWdlT2Jl cnZlcik7CisgICAgTWVtb3J5SW5zdHJ1bWVudGF0aW9uSW1wbCBpbnN0cnVtZW50YXRpb24oJmNs aWVudCk7CisgICAgaW5zdHJ1bWVudGF0aW9uLmFkZFJvb3RPYmplY3QoaGVscGVyKTsKKyAgICBF WFBFQ1RfRVEoc2l6ZW9mKENhY2hlZEltYWdlKSwgY2xpZW50LnJlcG9ydGVkU2l6ZUZvckFsbFR5 cGVzKCkpOworICAgIEVYUEVDVF9FUSgydSwgY2xpZW50LnZpc2l0ZWRPYmplY3RzKCkpOworfQor CisKK30gLy8gbmFtZXNwYWNlCisK