10009 2006-07-19 09:07:23 -0700 REGRESSION: Schubert-IT PDF Plug-in not working for full page (works in frames) 2006-07-24 08:55:59 -0700 1 1 1 Unclassified WebKit Plug-ins 420+ Mac OS X 10.4 RESOLVED FIXED Regression P1 Normal --- 1 dholschuh webkit-unassigned ap oldest_to_newest 50356 0 dholschuh 2006-07-19 09:07:23 -0700 The PDF plug-in works in regular Safari, but in the nightly builds (at least the last few that I've used), PDFs don't appear (just a missing graphic "X"). I'm not sure if the problem lies with WebKit or the plug-in itself, but I thought I should report it. 50412 1 ap 2006-07-19 21:59:50 -0700 Notably, the plugin works for OBJECTs embedded in HTML (see the second example at <http://acroeng.adobe.com/bugzilla/pdfbug.html>, but not for plain PDF files. This might turn out to be a WebKit issue indeed. 50620 2 9636 ap 2006-07-23 13:10:10 -0700 Created attachment 9636 proposed fix Couldn't find a way to make a layout test, suggestions are welcome! 50623 3 9636 darin 2006-07-23 13:39:56 -0700 Comment on attachment 9636 proposed fix Why is this PDF-specific? What if our image support extends to embrace something that a plug-in wants to handle better? 50625 4 ap 2006-07-23 13:43:21 -0700 (In reply to comment #3) > Why is this PDF-specific? I wanted to prevent QuickTime from taking over all images. 50656 5 9636 darin 2006-07-24 08:30:11 -0700 Comment on attachment 9636 proposed fix Looks OK for now. Would be better to have a comment since this logic is subtle. 50660 6 ap 2006-07-24 08:55:59 -0700 Committed revision 15598. (In reply to comment #5) > Would be better to have a comment since this logic is subtle. I absolutely agree, and have tried to come up with one, but couldn't produce anything concise :-/ 9636 2006-07-23 13:10:10 -0700 2006-07-24 08:30:11 -0700 proposed fix 10009r1_patch.txt text/plain 3451 ap SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiAxNTU4MikKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTQgQEAKKzIwMDYtMDctMjQgIEFsZXhleSBQcm9za3VyeWFrb3YgIDxhcEBueXBv cC5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg Rml4IGh0dHA6Ly9idWd6aWxsYS5vcGVuZGFyd2luLm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTAwMDkK KyAgICAgICAgUkVHUkVTU0lPTjogU2NodWJlcnQtSVQgUERGIFBsdWctaW4gbm90IHdvcmtpbmcg Zm9yIGZ1bGwgcGFnZSAod29ya3MgaW4gZnJhbWVzKQorCisgICAgICAgICogcGFnZS9GcmFtZS5j cHA6CisgICAgICAgIChXZWJDb3JlOjpGcmFtZTo6YmVnaW4pOiBHaXZlIFBERiBwbHVnaW5zIGEg Y2hhbmNlIHRvIGhhbmRsZSBmcmFtZSBjb250ZW50LCBiZWZvcmUgSW1hZ2VEb2N1bWVudAorICAg ICAgICBjbGFpbXMgaXQuCisKIDIwMDYtMDctMjMgIEFkZWxlIFBldGVyc29uICA8YWRlbGVAYXBw bGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERhcmluLgpJbmRleDogV2ViQ29yZS9wYWdl L0ZyYW1lLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL3BhZ2UvRnJhbWUuY3BwCShyZXZpc2lv biAxNTU4MikKKysrIFdlYkNvcmUvcGFnZS9GcmFtZS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTU4 OCw2ICs1ODgsOCBAQCB2b2lkIEZyYW1lOjpiZWdpbihjb25zdCBLVVJMJiB1cmwpCiAgICAgZC0+ bV9kb2MgPSBET01JbXBsZW1lbnRhdGlvbjo6aW5zdGFuY2UoKS0+Y3JlYXRlRG9jdW1lbnQoZC0+ bV92aWV3LmdldCgpKTsKICAgZWxzZSBpZiAoRE9NSW1wbGVtZW50YXRpb246OmlzVGV4dE1JTUVU eXBlKGQtPm1fcmVxdWVzdC5tX3Jlc3BvbnNlTUlNRVR5cGUpKQogICAgIGQtPm1fZG9jID0gbmV3 IFRleHREb2N1bWVudChET01JbXBsZW1lbnRhdGlvbjo6aW5zdGFuY2UoKSwgZC0+bV92aWV3Lmdl dCgpKTsKKyAgZWxzZSBpZiAoKGQtPm1fcmVxdWVzdC5tX3Jlc3BvbnNlTUlNRVR5cGUgPT0gImFw cGxpY2F0aW9uL3BkZiIgfHwgZC0+bV9yZXF1ZXN0Lm1fcmVzcG9uc2VNSU1FVHlwZSA9PSAidGV4 dC9wZGYiKSAmJiBQbHVnSW5JbmZvU3RvcmU6OnN1cHBvcnRzTUlNRVR5cGUoZC0+bV9yZXF1ZXN0 Lm1fcmVzcG9uc2VNSU1FVHlwZSkpCisgICAgZC0+bV9kb2MgPSBuZXcgUGx1Z2luRG9jdW1lbnQo RE9NSW1wbGVtZW50YXRpb246Omluc3RhbmNlKCksIGQtPm1fdmlldy5nZXQoKSk7CiAgIGVsc2Ug aWYgKEltYWdlOjpzdXBwb3J0c1R5cGUoZC0+bV9yZXF1ZXN0Lm1fcmVzcG9uc2VNSU1FVHlwZSkp CiAgICAgZC0+bV9kb2MgPSBuZXcgSW1hZ2VEb2N1bWVudChET01JbXBsZW1lbnRhdGlvbjo6aW5z dGFuY2UoKSwgZC0+bV92aWV3LmdldCgpKTsKICAgZWxzZSBpZiAoUGx1Z0luSW5mb1N0b3JlOjpz dXBwb3J0c01JTUVUeXBlKGQtPm1fcmVxdWVzdC5tX3Jlc3BvbnNlTUlNRVR5cGUpKQpJbmRleDog V2ViS2l0L0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXQvQ2hhbmdlTG9nCShyZXZpc2lv biAxNTU4MikKKysrIFdlYktpdC9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwx NCBAQAorMjAwNi0wNy0yNCAgQWxleGV5IFByb3NrdXJ5YWtvdiAgPGFwQG55cG9wLmNvbT4KKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBGaXggaHR0cDov L2J1Z3ppbGxhLm9wZW5kYXJ3aW4ub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDAwOQorICAgICAgICBS RUdSRVNTSU9OOiBTY2h1YmVydC1JVCBQREYgUGx1Zy1pbiBub3Qgd29ya2luZyBmb3IgZnVsbCBw YWdlICh3b3JrcyBpbiBmcmFtZXMpCisKKyAgICAgICAgKiBXZWJWaWV3L1dlYlZpZXcubToKKyAg ICAgICAgKCtbV2ViVmlldyBfdmlld0NsYXNzOmFuZFJlcHJlc2VudGF0aW9uQ2xhc3M6Zm9yTUlN RVR5cGU6XSk6IElmIHdlJ3ZlIGdvdCBhIHR5cGUgc3VwcG9ydGVkIGJ5IFdlYlBERlZpZXcsCisg ICAgICAgIG1ha2Ugc3VyZSB0byBpbml0aWFsaXplIHRoZSBwbHVnaW4gZGF0YWJhc2UsIGluIGNh c2UgYSBwbHVnaW4gd2FudHMgdG8gaGFuZGxlIGl0LgorCiAyMDA2LTA3LTIyICBUaW1vdGh5IEhh dGNoZXIgIDx0aW1vdGh5QGFwcGxlLmNvbT4KIAogICAgICAgICBSb2xsaW5nIG91dCByMTU1NzIu CkluZGV4OiBXZWJLaXQvV2ViVmlldy9XZWJWaWV3Lm0KPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L1dl YlZpZXcvV2ViVmlldy5tCShyZXZpc2lvbiAxNTU4MikKKysrIFdlYktpdC9XZWJWaWV3L1dlYlZp ZXcubQkod29ya2luZyBjb3B5KQpAQCAtNzQsNiArNzQsNyBAQAogI2ltcG9ydCAiV2ViTlNVc2Vy RGVmYXVsdHNFeHRyYXMuaCIKICNpbXBvcnQgIldlYk5TVmlld0V4dHJhcy5oIgogI2ltcG9ydCAi V2ViUGFnZUJyaWRnZS5oIgorI2ltcG9ydCAiV2ViUERGVmlldy5oIgogI2ltcG9ydCAiV2ViUGx1 Z2luRGF0YWJhc2UuaCIKICNpbXBvcnQgIldlYlBvbGljeURlbGVnYXRlLmgiCiAjaW1wb3J0ICJX ZWJQcmVmZXJlbmNlc1ByaXZhdGUuaCIKQEAgLTUyOCw3ICs1MjksNyBAQCBzdGF0aWMgYm9vbCBk ZWJ1Z1dpZGdldCA9IHRydWU7CiAgICAgQ2xhc3Mgdmlld0NsYXNzID0gW1tXZWJGcmFtZVZpZXcg X3ZpZXdUeXBlc0FsbG93SW1hZ2VUeXBlT21pc3Npb246WUVTXSBfd2Via2l0X29iamVjdEZvck1J TUVUeXBlOk1JTUVUeXBlXTsKICAgICBDbGFzcyByZXBDbGFzcyA9IFtbV2ViRGF0YVNvdXJjZSBf cmVwVHlwZXNBbGxvd0ltYWdlVHlwZU9taXNzaW9uOllFU10gX3dlYmtpdF9vYmplY3RGb3JNSU1F VHlwZTpNSU1FVHlwZV07CiAgICAgCi0gICAgaWYgKCF2aWV3Q2xhc3MgfHwgIXJlcENsYXNzKSB7 CisgICAgaWYgKCF2aWV3Q2xhc3MgfHwgIXJlcENsYXNzIHx8IFtbV2ViUERGVmlldyBzdXBwb3J0 ZWRNSU1FVHlwZXNdIGNvbnRhaW5zT2JqZWN0Ok1JTUVUeXBlXSkgewogICAgICAgICAvLyBPdXIg b3B0aW1pemF0aW9uIHRvIGF2b2lkIGxvYWRpbmcgdGhlIHBsdWctaW4gREIgYW5kIGltYWdlIHR5 cGVzIGZvciB0aGUgSFRNTCBjYXNlIGZhaWxlZC4KICAgICAgICAgLy8gTG9hZCB0aGUgcGx1Zy1p biBEQiBhbGxvd2luZyBwbHVnLWlucyB0byBpbnN0YWxsIHR5cGVzLgogICAgICAgICBbV2ViUGx1 Z2luRGF0YWJhc2UgaW5zdGFsbGVkUGx1Z2luc107Cg==