100080 2012-10-22 23:25:08 -0700 Web Inspector: ReferenceError: Can't find variable: bottom 2012-10-23 09:34:33 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 timothy timothy apavlov keishi loislo pfeldman pmuellr vsevik web-inspector-bugs webkit.review.bot yurys oldest_to_newest 748303 0 timothy 2012-10-22 23:25:08 -0700 ReferenceError: Can't find variable: bottom evaluateOnLoad(String::format("[\"setDockSide\", %s]", attached ? "bottom" : "undocked")); the %s needs quotes. caused by bug 99717 748306 1 170069 timothy 2012-10-22 23:31:15 -0700 Created attachment 170069 Proposed Change 748341 2 170069 webkit.review.bot 2012-10-23 00:54:05 -0700 Comment on attachment 170069 Proposed Change Clearing flags on attachment: 170069 Committed r132185: <http://trac.webkit.org/changeset/132185> 748342 3 webkit.review.bot 2012-10-23 00:54:09 -0700 All reviewed patches have been landed. Closing bug. 748723 4 pfeldman 2012-10-23 09:28:59 -0700 Reopening to attach new patch. 748724 5 170182 pfeldman 2012-10-23 09:29:03 -0700 Created attachment 170182 Patch 748730 6 170182 vsevik 2012-10-23 09:33:37 -0700 Comment on attachment 170182 Patch This is already landed :) 748732 7 pfeldman 2012-10-23 09:34:33 -0700 Sorry, I just found console with webkit-patch upload pending and hit Enter :) 170069 2012-10-22 23:31:15 -0700 2012-10-23 09:28:54 -0700 Proposed Change 0001-Docking-undocking-the-Web-Inspector-does-not-work-co.patch text/plain 2281 timothy RnJvbSA3ZGM3NTY2OTYwYzM0MGFlNDEwZTg5NzI5OGI2MDIzMjk2Y2FhYzlkIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBUaW1vdGh5IEhhdGNoZXIgPHRpbW90aHlAYXBwbGUuY29tPgpE YXRlOiBNb24sIDIyIE9jdCAyMDEyIDIzOjI4OjU1IC0wNzAwClN1YmplY3Q6IFtQQVRDSF0gRG9j a2luZy91bmRvY2tpbmcgdGhlIFdlYiBJbnNwZWN0b3IgZG9lcyBub3Qgd29yayBjb3JyZWN0bHkK IGluIFNhZmFyaS4KClRoZSAiZG9ja2VkIiBhbmQgImJvdHRvbSIgc3RyaW5ncyBuZWVkIHF1b3Rl ZCBpbnN0ZWFkIG9mIGJlaW5nIHBhc3NlZCBhcyBpZGVudGlmaWVycy4KCmh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDAwODAKClJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgoKKiBpbnNwZWN0b3IvSW5zcGVjdG9yRnJvbnRlbmRDbGllbnRMb2NhbC5jcHA6CihXZWJD b3JlOjpJbnNwZWN0b3JGcm9udGVuZENsaWVudExvY2FsOjpzZXRBdHRhY2hlZFdpbmRvdyk6IFB1 dCBxdW90ZXMgYXJvdW5kIHRoZSAlcy4KLS0tCiBTb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgfCAgIDEzICsrKysrKysrKysrKysKIFNvdXJj ZS9XZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0b3JGcm9udGVuZENsaWVudExvY2FsLmNwcCB8ICAg IDIgKy0KIDIgZmlsZXMgY2hhbmdlZCwgMTQgaW5zZXJ0aW9ucygrKSwgMSBkZWxldGlvbigtKQoK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCAzMDZhNWJkLi45M2JmNjVjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYg QEAKKzIwMTItMTAtMjIgIFRpbW90aHkgSGF0Y2hlciAgPHRpbW90aHlAYXBwbGUuY29tPgorCisg ICAgICAgIERvY2tpbmcvdW5kb2NraW5nIHRoZSBXZWIgSW5zcGVjdG9yIGRvZXMgbm90IHdvcmsg Y29ycmVjdGx5IGluIFNhZmFyaS4KKworICAgICAgICBUaGUgImRvY2tlZCIgYW5kICJib3R0b20i IHN0cmluZ3MgbmVlZCBxdW90ZWQgaW5zdGVhZCBvZiBiZWluZyBwYXNzZWQgYXMgaWRlbnRpZmll cnMuCisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEw MDA4MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICog aW5zcGVjdG9yL0luc3BlY3RvckZyb250ZW5kQ2xpZW50TG9jYWwuY3BwOgorICAgICAgICAoV2Vi Q29yZTo6SW5zcGVjdG9yRnJvbnRlbmRDbGllbnRMb2NhbDo6c2V0QXR0YWNoZWRXaW5kb3cpOiBQ dXQgcXVvdGVzIGFyb3VuZCB0aGUgJXMuCisKIDIwMTItMTAtMjIgIE1pY2hhZWwgU2Fib2ZmICA8 bXNhYm9mZkBhcHBsZS5jb20+CiAKICAgICAgICAgSFRNTCBQYXJzZXIgc2hvdWxkIHByb2R1Y2Ug OCBiaXQgc3RyaW5ncyBmb3IgZG9jdHlwZSwgY29tbWVudCBhbmQgdGFnTmFtZSB0b2tlbnMKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0b3JGcm9udGVuZENsaWVu dExvY2FsLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0b3JGcm9udGVuZENs aWVudExvY2FsLmNwcAppbmRleCBkYmVlNzA3Li5hYmM5MTY4IDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yRnJvbnRlbmRDbGllbnRMb2NhbC5jcHAKKysrIGIv U291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3RvckZyb250ZW5kQ2xpZW50TG9jYWwuY3Bw CkBAIC0yMTEsNyArMjExLDcgQEAgdm9pZCBJbnNwZWN0b3JGcm9udGVuZENsaWVudExvY2FsOjpt b3ZlV2luZG93QnkoZmxvYXQgeCwgZmxvYXQgeSkKIAogdm9pZCBJbnNwZWN0b3JGcm9udGVuZENs aWVudExvY2FsOjpzZXRBdHRhY2hlZFdpbmRvdyhib29sIGF0dGFjaGVkKQogewotICAgIGV2YWx1 YXRlT25Mb2FkKFN0cmluZzo6Zm9ybWF0KCJbXCJzZXREb2NrU2lkZVwiLCAlc10iLCBhdHRhY2hl ZCA/ICJib3R0b20iIDogInVuZG9ja2VkIikpOworICAgIGV2YWx1YXRlT25Mb2FkKFN0cmluZzo6 Zm9ybWF0KCJbXCJzZXREb2NrU2lkZVwiLCBcIiVzXCJdIiwgYXR0YWNoZWQgPyAiYm90dG9tIiA6 ICJ1bmRvY2tlZCIpKTsKIH0KIAogdm9pZCBJbnNwZWN0b3JGcm9udGVuZENsaWVudExvY2FsOjpy ZXN0b3JlQXR0YWNoZWRXaW5kb3dIZWlnaHQoKQotLSAKMS43LjEwLjIgKEFwcGxlIEdpdC0zMykK Cg== 170182 2012-10-23 09:29:03 -0700 2012-10-23 09:33:37 -0700 Patch bug-100080-20121023202739.patch text/plain 1607 pfeldman U3VidmVyc2lvbiBSZXZpc2lvbjogMTMyMTc3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMzVjZmQ1ZTIwNDMyODM0 OWQ3ODI5YjVkZjBkYmZiYzA4YjIzYmY4Ny4uMDBkZDcyZTU5ZjlmMGVhNzEyYTgwMmI2MmJmN2M2 YjIzZDVmNmI5NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEyLTEwLTIzICBQYXZl bCBGZWxkbWFuICA8cGZlbGRtYW5AY2hyb21pdW0ub3JnPgorCisgICAgICAgIFdlYiBJbnNwZWN0 b3I6IFJlZmVyZW5jZUVycm9yOiBDYW4ndCBmaW5kIHZhcmlhYmxlOiBib3R0b20KKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwMDA4MAorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIHRoZSAlcyBuZWVkZWQgcXVv dGVzLgorCisgICAgICAgICogaW5zcGVjdG9yL0luc3BlY3RvckZyb250ZW5kQ2xpZW50TG9jYWwu Y3BwOgorICAgICAgICAoV2ViQ29yZTo6SW5zcGVjdG9yRnJvbnRlbmRDbGllbnRMb2NhbDo6c2V0 QXR0YWNoZWRXaW5kb3cpOgorCiAyMDEyLTEwLTIyICBQZXRlciBXYW5nICA8cGV0ZXIud2FuZ0B0 b3JjaG1vYmlsZS5jb20uY24+CiAKICAgICAgICAgW0JsYWNrQmVycnldIE1pc3Npbmcgc29tZSBj b29raWVzIGluIEhUVFAgcmVzcG9uc2UgaGVhZGVyIHdoZW4gc2V0IHNldmVyYWwgY29va2llcyBp biBvbmUgIlNldC1Db29raWUiIGhlYWRlci4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2lu c3BlY3Rvci9JbnNwZWN0b3JGcm9udGVuZENsaWVudExvY2FsLmNwcCBiL1NvdXJjZS9XZWJDb3Jl L2luc3BlY3Rvci9JbnNwZWN0b3JGcm9udGVuZENsaWVudExvY2FsLmNwcAppbmRleCBkYmVlNzA3 YzVjOWMyNjYyOTA0OTVhNDE5OTIyODAyOGIwNmFkM2M5Li5hYmM5MTY4Yzc1ZDMwZGMyMWQ1ODVi MmI5ZDJiYTgxNTliNTE0M2Y3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3Iv SW5zcGVjdG9yRnJvbnRlbmRDbGllbnRMb2NhbC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvaW5z cGVjdG9yL0luc3BlY3RvckZyb250ZW5kQ2xpZW50TG9jYWwuY3BwCkBAIC0yMTEsNyArMjExLDcg QEAgdm9pZCBJbnNwZWN0b3JGcm9udGVuZENsaWVudExvY2FsOjptb3ZlV2luZG93QnkoZmxvYXQg eCwgZmxvYXQgeSkKIAogdm9pZCBJbnNwZWN0b3JGcm9udGVuZENsaWVudExvY2FsOjpzZXRBdHRh Y2hlZFdpbmRvdyhib29sIGF0dGFjaGVkKQogewotICAgIGV2YWx1YXRlT25Mb2FkKFN0cmluZzo6 Zm9ybWF0KCJbXCJzZXREb2NrU2lkZVwiLCAlc10iLCBhdHRhY2hlZCA/ICJib3R0b20iIDogInVu ZG9ja2VkIikpOworICAgIGV2YWx1YXRlT25Mb2FkKFN0cmluZzo6Zm9ybWF0KCJbXCJzZXREb2Nr U2lkZVwiLCBcIiVzXCJdIiwgYXR0YWNoZWQgPyAiYm90dG9tIiA6ICJ1bmRvY2tlZCIpKTsKIH0K IAogdm9pZCBJbnNwZWN0b3JGcm9udGVuZENsaWVudExvY2FsOjpyZXN0b3JlQXR0YWNoZWRXaW5k b3dIZWlnaHQoKQo=