100078 2012-10-22 23:16:40 -0700 [EFL][WK2] Crash when passing NULL instead of ewk_view instance 2012-10-24 04:59:08 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ryuan.choi ryuan.choi cdumez gyuyoung.kim lucas.de.marchi rakuco webkit.review.bot oldest_to_newest 748300 0 ryuan.choi 2012-10-22 23:16:40 -0700 Although it is abnormal to pass null as first argument of ewk_view_XXX(), I think that the crash is not acceptable because WebKit/efl has macro to check the type of smart object and return from code safely. 749284 1 170303 ryuan.choi 2012-10-23 20:51:14 -0700 Created attachment 170303 Patch 749287 2 170305 ryuan.choi 2012-10-23 20:55:08 -0700 Created attachment 170305 Patch 749506 3 170305 rakuco 2012-10-24 03:41:28 -0700 Comment on attachment 170305 Patch I'd say just return earlier in the macro if ewkView is 0. Plus it's better to create a new test "section" for this. 749528 4 170360 ryuan.choi 2012-10-24 04:31:35 -0700 Created attachment 170360 Patch 749530 5 ryuan.choi 2012-10-24 04:34:13 -0700 (In reply to comment #3) > (From update of attachment 170305 [details]) > I'd say just return earlier in the macro if ewkView is 0. Plus it's better to create a new test "section" for this. Thanks, I added break to exit from this macro and created new test. 749532 6 cdumez 2012-10-24 04:34:35 -0700 BTW, we are starting to Ewk_View refactoring to C++ via Bug 100226 so this code is going to change a lot over the next couple of days. 749541 7 170360 gyuyoung.kim 2012-10-24 04:42:51 -0700 Comment on attachment 170360 Patch It looks those patches don't touch this section yet. I think this patch can be landed first. 749551 8 ryuan.choi 2012-10-24 04:57:59 -0700 Committed r132336: <http://trac.webkit.org/changeset/132336> 170303 2012-10-23 20:51:14 -0700 2012-10-23 20:55:01 -0700 Patch bug-100078-20121024124949.patch text/plain 5549 ryuan.choi U3VidmVyc2lvbiBSZXZpc2lvbjogMTMyMjkyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggYzMzYjcxODRiMDQ1MjAx YjBmMjhiYmYzYzliYjE0ODJmMGVkNjExNi4uODA5NjM0ZTI2N2VmZDMzN2QwOWFjMzU5N2E5ZGEy NDY0NDFkOTNiOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEyLTEwLTIzICBSeXVh biBDaG9pICA8cnl1YW4uY2hvaUBnbWFpbC5jb20+CisKKyAgICAgICAgW0VGTF1bV0syXSBDcmFz aCB3aGVuIHBhc3NpbmcgTlVMTCBpbnN0ZWFkIG9mIGV3a192aWV3IGluc3RhbmNlCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDAwNzgKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBbHRob3VnaCBhcHBsaWNh dGlvbnMgc2hvdWxkIHBhc3MgdmFsaWQgZXdrX3ZpZXcgdG8gY2FsbCBld2tfdmlld19YWFgsCisg ICAgICAgIGV3a192aWV3X1hYWCBzaG91bGQgbm90IGJlIGNyYXNoZWQuCisKKyAgICAgICAgVGhp cyBwYXRjaCByZWZhY3RvciBtYWNyb3MgdG8gaW5saW5lIGZ1bmN0aW9ucyBhbmQgbW9kaWZpZWQg aXQgbm90IHRvIGNyYXNoCisgICAgICAgIHdoZW4gTlVMTCB2YWx1ZSBpcyBwYXNzZWQuCisKKyAg ICAgICAgKiBVSVByb2Nlc3MvQVBJL2VmbC9ld2tfdmlldy5jcHA6CisgICAgICAgICogVUlQcm9j ZXNzL0FQSS9lZmwvdGVzdHMvdGVzdF9ld2syX3ZpZXcuY3BwOiBBZGRlZCB0ZXN0IGNhc2UuCisK IDIwMTItMTAtMjMgIE1hcnRpbiBSb2JpbnNvbiAgPG1yb2JpbnNvbkBpZ2FsaWEuY29tPgogCiAg ICAgICAgIFtHVEtdW1NvdXBdIEltcGxlbWVudCB0aGUgZGVmYXVsdCBhdXRoZW50aWNhdGlvbiBk aWFsb2cgdmlhIFdlYkNvcmVTdXBwb3J0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVBy b2Nlc3MvQVBJL2VmbC9ld2tfdmlldy5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJ L2VmbC9ld2tfdmlldy5jcHAKaW5kZXggNzBlNjkxNWM1OTBhMmQ0YzI3Mzg1NDVhZmQzNTkxNDYw OTBhZGYwNi4uMjljNDIxODkyOTZkMjMzYzM1OGUyZWUxNGJjMGI3YWU2MGJhYjUyMyAxMDA2NDQK LS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9lZmwvZXdrX3ZpZXcuY3BwCisrKyBi L1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZsL2V3a192aWV3LmNwcApAQCAtMTk1LDM3 ICsxOTUsMzMgQEAgc3RydWN0IEV3a19WaWV3X1ByaXZhdGVfRGF0YSB7CiAgICAgfQogfTsKIAot I2RlZmluZSBFV0tfVklFV19UWVBFX0NIRUNLKGV3a1ZpZXcsIHJlc3VsdCkgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgIFwKLSAgICBib29sIHJlc3VsdCA9IHRydWU7ICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBcCi0gICAgZG8g eyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgXAotICAgICAgICBjb25zdCBjaGFyKiBfdG1wX290eXBlID0gZXZhc19v YmplY3RfdHlwZV9nZXQoZXdrVmlldyk7ICAgICAgICAgICAgICAgIFwKLSAgICAgICAgY29uc3Qg RXZhc19TbWFydCogX3RtcF9zID0gZXZhc19vYmplY3Rfc21hcnRfc21hcnRfZ2V0KGV3a1ZpZXcp OyAgICAgICBcCi0gICAgICAgIGlmIChFSU5BX1VOTElLRUxZKCFfdG1wX3MpKSB7ICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgXAotICAgICAgICAgICAgRUlOQV9MT0df Q1JJVCAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg IFwKLSAgICAgICAgICAgICAgICAoIiVwICglcykgaXMgbm90IGEgc21hcnQgb2JqZWN0ISIsICAg ICAgICAgICAgICAgICAgICAgICAgICAgICBcCi0gICAgICAgICAgICAgICAgIGV3a1ZpZXcsIF90 bXBfb3R5cGUgPyBfdG1wX290eXBlIDogIihudWxsKSIpOyAgICAgICAgICAgICAgICAgXAotICAg ICAgICAgICAgcmVzdWx0ID0gZmFsc2U7ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgIFwKLSAgICAgICAgfSAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBcCi0gICAgICAgIGNv bnN0IEV2YXNfU21hcnRfQ2xhc3MqIF90bXBfc2MgPSBldmFzX3NtYXJ0X2NsYXNzX2dldChfdG1w X3MpOyAgICAgICAgXAotICAgICAgICBpZiAoRUlOQV9VTkxJS0VMWSghX3RtcF9zYykpIHsgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIFwKLSAgICAgICAgICAgIEVJTkFf TE9HX0NSSVQgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICBcCi0gICAgICAgICAgICAgICAgKCIlcCAoJXMpIGlzIG5vdCBhIHNtYXJ0IG9iamVjdCEi LCAgICAgICAgICAgICAgICAgICAgICAgICAgICAgXAotICAgICAgICAgICAgICAgICBld2tWaWV3 LCBfdG1wX290eXBlID8gX3RtcF9vdHlwZSA6ICIobnVsbCkiKTsgICAgICAgICAgICAgICAgIFwK LSAgICAgICAgICAgIHJlc3VsdCA9IGZhbHNlOyAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICBcCi0gICAgICAgIH0gICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgXAotICAgICAg ICBpZiAoRUlOQV9VTkxJS0VMWShfdG1wX3NjLT5kYXRhICE9IEVXS19WSUVXX1RZUEVfU1RSKSkg eyAgICAgICAgICAgICAgIFwKLSAgICAgICAgICAgIEVJTkFfTE9HX0NSSVQgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBcCi0gICAgICAgICAgICAg ICAgKCIlcCAoJXMpIGlzIG5vdCBvZiBhbiBld2tfdmlldyAobmVlZCAlcCwgZ290ICVwKSEiLCAg ICAgICAgICAgXAotICAgICAgICAgICAgICAgICBld2tWaWV3LCBfdG1wX290eXBlID8gX3RtcF9v dHlwZSA6ICIobnVsbCkiLCAgICAgICAgICAgICAgICAgIFwKLSAgICAgICAgICAgICAgICAgRVdL X1ZJRVdfVFlQRV9TVFIsIF90bXBfc2MtPmRhdGEpOyAgICAgICAgICAgICAgICAgICAgICAgICAg ICBcCi0gICAgICAgICAgICByZXN1bHQgPSBmYWxzZTsgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgXAotICAgICAgICB9ICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIFwKLSAg ICB9IHdoaWxlICgwKQorc3RhdGljIGlubGluZSBib29sIGlzRXdrVmlldyhjb25zdCBFdmFzX09i amVjdCogZXdrVmlldykKK3sKKyAgICBjb25zdCBjaGFyKiBvYmplY3RUeXBlID0gZXZhc19vYmpl Y3RfdHlwZV9nZXQoZXdrVmlldyk7CisgICAgY29uc3QgRXZhc19TbWFydCogZXZhc1NtYXJ0ID0g ZXZhc19vYmplY3Rfc21hcnRfc21hcnRfZ2V0KGV3a1ZpZXcpOworICAgIGlmIChFSU5BX1VOTElL RUxZKCFldmFzU21hcnQpKSB7CisgICAgICAgIEVJTkFfTE9HX0NSSVQoIiVwICglcykgaXMgbm90 IGEgc21hcnQgb2JqZWN0ISIsIGV3a1ZpZXcsIG9iamVjdFR5cGUpOworICAgICAgICByZXR1cm4g ZmFsc2U7CisgICAgfQorCisgICAgY29uc3QgRXZhc19TbWFydF9DbGFzcyogZXZhc1NtYXJ0Q2xh c3MgPSBldmFzX3NtYXJ0X2NsYXNzX2dldChldmFzU21hcnQpOworICAgIGlmIChFSU5BX1VOTElL RUxZKCFldmFzU21hcnRDbGFzcykpIHsKKyAgICAgICAgRUlOQV9MT0dfQ1JJVCgiJXAgKCVzKSBp cyBub3QgYSBzbWFydCBvYmplY3QhIiwgZXdrVmlldywgb2JqZWN0VHlwZSk7CisgICAgICAgIHJl dHVybiBmYWxzZTsKKyAgICB9CisKKyAgICBpZiAoRUlOQV9VTkxJS0VMWShldmFzU21hcnRDbGFz cy0+ZGF0YSAhPSBFV0tfVklFV19UWVBFX1NUUikpIHsKKyAgICAgICAgRUlOQV9MT0dfQ1JJVCgi JXAgKCVzKSBpcyBub3QgYW4gZXdrX3ZpZXcgKG5lZWQgJXAsIGdvdCAlcCkhIiwKKyAgICAgICAg ICAgIGV3a1ZpZXcsIG9iamVjdFR5cGUsIEVXS19WSUVXX1RZUEVfU1RSLCBldmFzU21hcnRDbGFz cy0+ZGF0YSk7CisgICAgICAgIHJldHVybiBmYWxzZTsKKyAgICB9CisKKyAgICByZXR1cm4gdHJ1 ZTsKK30KIAogI2RlZmluZSBFV0tfVklFV19TRF9HRVQoZXdrVmlldywgc21hcnREYXRhKSAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIFwKLSAgICBFV0tfVklFV19UWVBFX0NIRUNL KGV3a1ZpZXcsIF90bXBfcmVzdWx0KTsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBc CiAgICAgRXdrX1ZpZXdfU21hcnRfRGF0YSogc21hcnREYXRhID0gMDsgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgXAotICAgIGlmIChfdG1wX3Jlc3VsdCkgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIFwKKyAgICBp ZiAoaXNFd2tWaWV3KGV3a1ZpZXcpKSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICBcCiAgICAgICAgIHNtYXJ0RGF0YSA9IChFd2tfVmlld19TbWFydF9E YXRhKilldmFzX29iamVjdF9zbWFydF9kYXRhX2dldChld2tWaWV3KQogCiAjZGVmaW5lIEVXS19W SUVXX1NEX0dFVF9PUl9SRVRVUk4oZXdrVmlldywgc21hcnREYXRhLCAuLi4pICAgICAgICAgICAg ICAgICAgICAgXApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9lZmwv dGVzdHMvdGVzdF9ld2syX3ZpZXcuY3BwIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9l ZmwvdGVzdHMvdGVzdF9ld2syX3ZpZXcuY3BwCmluZGV4IGQ0YmI3MGZiZjA0MjU4OTg4MzliNmY1 MWYyYjg3YWQ0ODNmN2Y0MzkuLjI2NDVlNTU1NzVjODBmNDBmMGU2YzFmMTU4ODBmNDkyZGQ2MmQ2 MGEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZsL3Rlc3RzL3Rl c3RfZXdrMl92aWV3LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2VmbC90 ZXN0cy90ZXN0X2V3azJfdmlldy5jcHAKQEAgLTQ2LDYgKzQ2LDggQEAgc3RhdGljIHZvaWQgb25M b2FkRmluaXNoZWRGb3JSZWRpcmVjdGlvbih2b2lkKiB1c2VyRGF0YSwgRXZhc19PYmplY3QqLCB2 b2lkKikKIAogVEVTVF9GKEVXSzJVbml0VGVzdEJhc2UsIGV3a192aWV3X3VybF9nZXQpCiB7Cisg ICAgQVNTRVJUX0ZBTFNFKGV3a192aWV3X3VybF9nZXQoMCkpOworCiAgICAgQVNTRVJUX1RSVUUo bG9hZFVybFN5bmMoZW52aXJvbm1lbnQtPmRlZmF1bHRUZXN0UGFnZVVybCgpKSk7CiAgICAgRVhQ RUNUX1NUUkVRKGVudmlyb25tZW50LT5kZWZhdWx0VGVzdFBhZ2VVcmwoKSwgZXdrX3ZpZXdfdXJs X2dldCh3ZWJWaWV3KCkpKTsKIAo= 170305 2012-10-23 20:55:08 -0700 2012-10-24 04:31:30 -0700 Patch bug-100078-20121024125343.patch text/plain 5609 ryuan.choi U3VidmVyc2lvbiBSZXZpc2lvbjogMTMyMjkyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggYzMzYjcxODRiMDQ1MjAx YjBmMjhiYmYzYzliYjE0ODJmMGVkNjExNi4uNTQ5MTBmNTY5MGFmNWYyM2QzNDhiMzljZmY4NTBk MTE1YjFlNjk1NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDEyLTEwLTIzICBSeXVh biBDaG9pICA8cnl1YW4uY2hvaUBnbWFpbC5jb20+CisKKyAgICAgICAgW0VGTF1bV0syXSBDcmFz aCB3aGVuIHBhc3NpbmcgTlVMTCBpbnN0ZWFkIG9mIGV3a192aWV3IGluc3RhbmNlCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDAwNzgKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBbHRob3VnaCBhcHBsaWNh dGlvbnMgc2hvdWxkIHBhc3MgdmFsaWQgZXdrX3ZpZXcgdG8gY2FsbCBld2tfdmlld19YWFgsCisg ICAgICAgIGV3a192aWV3X1hYWCBzaG91bGQgbm90IGJlIGNyYXNoZWQgd2hlbiBOVUxMIGlzIHBh c3NlZC4KKworICAgICAgICBUaGlzIHBhdGNoIHJlZmFjdG9ycyBFV0tfVklFV19UWVBFX0NIRUNL IHRvIGlubGluZSBmdW5jdGlvbiwgaXNFd2tWaWV3LCBhbmQKKyAgICAgICAgbW9kaWZpZWQgaXQg bm90IHRvIGNyYXNoIHdoZW4gTlVMTCBpcyBwYXNzZWQuCisKKyAgICAgICAgKiBVSVByb2Nlc3Mv QVBJL2VmbC9ld2tfdmlldy5jcHA6CisgICAgICAgIChpc0V3a1ZpZXcpCisgICAgICAgICogVUlQ cm9jZXNzL0FQSS9lZmwvdGVzdHMvdGVzdF9ld2syX3ZpZXcuY3BwOiBBZGRlZCB0ZXN0IGNhc2Uu CisKIDIwMTItMTAtMjMgIE1hcnRpbiBSb2JpbnNvbiAgPG1yb2JpbnNvbkBpZ2FsaWEuY29tPgog CiAgICAgICAgIFtHVEtdW1NvdXBdIEltcGxlbWVudCB0aGUgZGVmYXVsdCBhdXRoZW50aWNhdGlv biBkaWFsb2cgdmlhIFdlYkNvcmVTdXBwb3J0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9V SVByb2Nlc3MvQVBJL2VmbC9ld2tfdmlldy5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3Mv QVBJL2VmbC9ld2tfdmlldy5jcHAKaW5kZXggNzBlNjkxNWM1OTBhMmQ0YzI3Mzg1NDVhZmQzNTkx NDYwOTBhZGYwNi4uMjljNDIxODkyOTZkMjMzYzM1OGUyZWUxNGJjMGI3YWU2MGJhYjUyMyAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9lZmwvZXdrX3ZpZXcuY3BwCisr KyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZsL2V3a192aWV3LmNwcApAQCAtMTk1 LDM3ICsxOTUsMzMgQEAgc3RydWN0IEV3a19WaWV3X1ByaXZhdGVfRGF0YSB7CiAgICAgfQogfTsK IAotI2RlZmluZSBFV0tfVklFV19UWVBFX0NIRUNLKGV3a1ZpZXcsIHJlc3VsdCkgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgIFwKLSAgICBib29sIHJlc3VsdCA9IHRydWU7ICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBcCi0gICAg ZG8geyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgXAotICAgICAgICBjb25zdCBjaGFyKiBfdG1wX290eXBlID0gZXZh c19vYmplY3RfdHlwZV9nZXQoZXdrVmlldyk7ICAgICAgICAgICAgICAgIFwKLSAgICAgICAgY29u c3QgRXZhc19TbWFydCogX3RtcF9zID0gZXZhc19vYmplY3Rfc21hcnRfc21hcnRfZ2V0KGV3a1Zp ZXcpOyAgICAgICBcCi0gICAgICAgIGlmIChFSU5BX1VOTElLRUxZKCFfdG1wX3MpKSB7ICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgXAotICAgICAgICAgICAgRUlOQV9M T0dfQ1JJVCAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgIFwKLSAgICAgICAgICAgICAgICAoIiVwICglcykgaXMgbm90IGEgc21hcnQgb2JqZWN0ISIs ICAgICAgICAgICAgICAgICAgICAgICAgICAgICBcCi0gICAgICAgICAgICAgICAgIGV3a1ZpZXcs IF90bXBfb3R5cGUgPyBfdG1wX290eXBlIDogIihudWxsKSIpOyAgICAgICAgICAgICAgICAgXAot ICAgICAgICAgICAgcmVzdWx0ID0gZmFsc2U7ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgIFwKLSAgICAgICAgfSAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBcCi0gICAgICAg IGNvbnN0IEV2YXNfU21hcnRfQ2xhc3MqIF90bXBfc2MgPSBldmFzX3NtYXJ0X2NsYXNzX2dldChf dG1wX3MpOyAgICAgICAgXAotICAgICAgICBpZiAoRUlOQV9VTkxJS0VMWSghX3RtcF9zYykpIHsg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIFwKLSAgICAgICAgICAgIEVJ TkFfTE9HX0NSSVQgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICBcCi0gICAgICAgICAgICAgICAgKCIlcCAoJXMpIGlzIG5vdCBhIHNtYXJ0IG9iamVj dCEiLCAgICAgICAgICAgICAgICAgICAgICAgICAgICAgXAotICAgICAgICAgICAgICAgICBld2tW aWV3LCBfdG1wX290eXBlID8gX3RtcF9vdHlwZSA6ICIobnVsbCkiKTsgICAgICAgICAgICAgICAg IFwKLSAgICAgICAgICAgIHJlc3VsdCA9IGZhbHNlOyAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICBcCi0gICAgICAgIH0gICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgXAotICAg ICAgICBpZiAoRUlOQV9VTkxJS0VMWShfdG1wX3NjLT5kYXRhICE9IEVXS19WSUVXX1RZUEVfU1RS KSkgeyAgICAgICAgICAgICAgIFwKLSAgICAgICAgICAgIEVJTkFfTE9HX0NSSVQgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBcCi0gICAgICAgICAg ICAgICAgKCIlcCAoJXMpIGlzIG5vdCBvZiBhbiBld2tfdmlldyAobmVlZCAlcCwgZ290ICVwKSEi LCAgICAgICAgICAgXAotICAgICAgICAgICAgICAgICBld2tWaWV3LCBfdG1wX290eXBlID8gX3Rt cF9vdHlwZSA6ICIobnVsbCkiLCAgICAgICAgICAgICAgICAgIFwKLSAgICAgICAgICAgICAgICAg RVdLX1ZJRVdfVFlQRV9TVFIsIF90bXBfc2MtPmRhdGEpOyAgICAgICAgICAgICAgICAgICAgICAg ICAgICBcCi0gICAgICAgICAgICByZXN1bHQgPSBmYWxzZTsgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgXAotICAgICAgICB9ICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIFwK LSAgICB9IHdoaWxlICgwKQorc3RhdGljIGlubGluZSBib29sIGlzRXdrVmlldyhjb25zdCBFdmFz X09iamVjdCogZXdrVmlldykKK3sKKyAgICBjb25zdCBjaGFyKiBvYmplY3RUeXBlID0gZXZhc19v YmplY3RfdHlwZV9nZXQoZXdrVmlldyk7CisgICAgY29uc3QgRXZhc19TbWFydCogZXZhc1NtYXJ0 ID0gZXZhc19vYmplY3Rfc21hcnRfc21hcnRfZ2V0KGV3a1ZpZXcpOworICAgIGlmIChFSU5BX1VO TElLRUxZKCFldmFzU21hcnQpKSB7CisgICAgICAgIEVJTkFfTE9HX0NSSVQoIiVwICglcykgaXMg bm90IGEgc21hcnQgb2JqZWN0ISIsIGV3a1ZpZXcsIG9iamVjdFR5cGUpOworICAgICAgICByZXR1 cm4gZmFsc2U7CisgICAgfQorCisgICAgY29uc3QgRXZhc19TbWFydF9DbGFzcyogZXZhc1NtYXJ0 Q2xhc3MgPSBldmFzX3NtYXJ0X2NsYXNzX2dldChldmFzU21hcnQpOworICAgIGlmIChFSU5BX1VO TElLRUxZKCFldmFzU21hcnRDbGFzcykpIHsKKyAgICAgICAgRUlOQV9MT0dfQ1JJVCgiJXAgKCVz KSBpcyBub3QgYSBzbWFydCBvYmplY3QhIiwgZXdrVmlldywgb2JqZWN0VHlwZSk7CisgICAgICAg IHJldHVybiBmYWxzZTsKKyAgICB9CisKKyAgICBpZiAoRUlOQV9VTkxJS0VMWShldmFzU21hcnRD bGFzcy0+ZGF0YSAhPSBFV0tfVklFV19UWVBFX1NUUikpIHsKKyAgICAgICAgRUlOQV9MT0dfQ1JJ VCgiJXAgKCVzKSBpcyBub3QgYW4gZXdrX3ZpZXcgKG5lZWQgJXAsIGdvdCAlcCkhIiwKKyAgICAg ICAgICAgIGV3a1ZpZXcsIG9iamVjdFR5cGUsIEVXS19WSUVXX1RZUEVfU1RSLCBldmFzU21hcnRD bGFzcy0+ZGF0YSk7CisgICAgICAgIHJldHVybiBmYWxzZTsKKyAgICB9CisKKyAgICByZXR1cm4g dHJ1ZTsKK30KIAogI2RlZmluZSBFV0tfVklFV19TRF9HRVQoZXdrVmlldywgc21hcnREYXRhKSAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIFwKLSAgICBFV0tfVklFV19UWVBFX0NI RUNLKGV3a1ZpZXcsIF90bXBfcmVzdWx0KTsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICBcCiAgICAgRXdrX1ZpZXdfU21hcnRfRGF0YSogc21hcnREYXRhID0gMDsgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgXAotICAgIGlmIChfdG1wX3Jlc3VsdCkgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIFwKKyAg ICBpZiAoaXNFd2tWaWV3KGV3a1ZpZXcpKSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICBcCiAgICAgICAgIHNtYXJ0RGF0YSA9IChFd2tfVmlld19TbWFy dF9EYXRhKilldmFzX29iamVjdF9zbWFydF9kYXRhX2dldChld2tWaWV3KQogCiAjZGVmaW5lIEVX S19WSUVXX1NEX0dFVF9PUl9SRVRVUk4oZXdrVmlldywgc21hcnREYXRhLCAuLi4pICAgICAgICAg ICAgICAgICAgICAgXApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9l ZmwvdGVzdHMvdGVzdF9ld2syX3ZpZXcuY3BwIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQ SS9lZmwvdGVzdHMvdGVzdF9ld2syX3ZpZXcuY3BwCmluZGV4IGQ0YmI3MGZiZjA0MjU4OTg4Mzli NmY1MWYyYjg3YWQ0ODNmN2Y0MzkuLjI2NDVlNTU1NzVjODBmNDBmMGU2YzFmMTU4ODBmNDkyZGQ2 MmQ2MGEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZsL3Rlc3Rz L3Rlc3RfZXdrMl92aWV3LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2Vm bC90ZXN0cy90ZXN0X2V3azJfdmlldy5jcHAKQEAgLTQ2LDYgKzQ2LDggQEAgc3RhdGljIHZvaWQg b25Mb2FkRmluaXNoZWRGb3JSZWRpcmVjdGlvbih2b2lkKiB1c2VyRGF0YSwgRXZhc19PYmplY3Qq LCB2b2lkKikKIAogVEVTVF9GKEVXSzJVbml0VGVzdEJhc2UsIGV3a192aWV3X3VybF9nZXQpCiB7 CisgICAgQVNTRVJUX0ZBTFNFKGV3a192aWV3X3VybF9nZXQoMCkpOworCiAgICAgQVNTRVJUX1RS VUUobG9hZFVybFN5bmMoZW52aXJvbm1lbnQtPmRlZmF1bHRUZXN0UGFnZVVybCgpKSk7CiAgICAg RVhQRUNUX1NUUkVRKGVudmlyb25tZW50LT5kZWZhdWx0VGVzdFBhZ2VVcmwoKSwgZXdrX3ZpZXdf dXJsX2dldCh3ZWJWaWV3KCkpKTsKIAo= 170360 2012-10-24 04:31:35 -0700 2012-10-24 04:59:08 -0700 Patch bug-100078-20121024203010.patch text/plain 4312 ryuan.choi U3VidmVyc2lvbiBSZXZpc2lvbjogMTMyMzMxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggYTVmZTgzZTJjM2U0NzIx NTE1NmY5MWMyOGNmZmJmNzY3NjQ3YTYzNC4uMGFmMGZlNWI5MDRiMjZhNTU4MmNhNGRkYjk4ZmU3 ODIxMDEzYTgzZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEyLTEwLTI0ICBSeXVh biBDaG9pICA8cnl1YW4uY2hvaUBnbWFpbC5jb20+CisKKyAgICAgICAgW0VGTF1bV0syXSBDcmFz aCB3aGVuIHBhc3NpbmcgTlVMTCBpbnN0ZWFkIG9mIGV3a192aWV3IGluc3RhbmNlCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDAwNzgKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBbHRob3VnaCBhcHBsaWNh dGlvbnMgc2hvdWxkIHBhc3MgdmFsaWQgZXdrX3ZpZXcgdG8gY2FsbCBld2tfdmlld19YWFgsCisg ICAgICAgIGV3a192aWV3X1hYWCBzaG91bGQgbm90IGJlIGNyYXNoZWQuCisKKyAgICAgICAgKiBV SVByb2Nlc3MvQVBJL2VmbC9ld2tfdmlldy5jcHA6CisgICAgICAgIENoZWNrZWQgbnVsbCBhbmQg ZWFybHkgZXhpdGVkIGZyb20gRVdLX1ZJRVdfVFlQRV9DSEVDSyBpZiBlcnJvciBvY2N1cmVkLgor ICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvZWZsL3Rlc3RzL3Rlc3RfZXdrMl92aWV3LmNwcDogQWRk ZWQgdGVzdCBjYXNlLgorICAgICAgICAoVEVTVF9GKToKKwogMjAxMi0xMC0yNCAgWWFlbCBBaGFy b24gIDx5YWVsLmFoYXJvbkBpbnRlbC5jb20+CiAKICAgICAgICAgW0VGTF1bV0syXVtBQ10gQmxh Y2sgc2NyZWVuIGluIHdlYiBpbnNwZWN0b3Igd2luZG93IHdpdGggQUMgb24KZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZsL2V3a192aWV3LmNwcCBiL1NvdXJjZS9X ZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZsL2V3a192aWV3LmNwcAppbmRleCA3MGU2OTE1YzU5MGEy ZDRjMjczODU0NWFmZDM1OTE0NjA5MGFkZjA2Li41ZThiMmUwZGYzYmU2N2MzZjEyODA1YjEzMjBh OGM0ZDA2YzUzY2IzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2Vm bC9ld2tfdmlldy5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9lZmwvZXdr X3ZpZXcuY3BwCkBAIC0xOTgsNiArMTk4LDExIEBAIHN0cnVjdCBFd2tfVmlld19Qcml2YXRlX0Rh dGEgewogI2RlZmluZSBFV0tfVklFV19UWVBFX0NIRUNLKGV3a1ZpZXcsIHJlc3VsdCkgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgIFwKICAgICBib29sIHJlc3VsdCA9IHRydWU7ICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBcCiAg ICAgZG8geyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgXAorICAgICAgICBpZiAoIWV3a1ZpZXcpIHsgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIFwKKyAgICAgICAg ICAgIEVJTkFfTE9HX0NSSVQoIm51bGwgaXMgbm90IGEgZXdrX3ZpZXciKTsgICAgICAgICAgICAg ICAgICAgICAgICAgICBcCisgICAgICAgICAgICByZXN1bHQgPSBmYWxzZTsgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgXAorICAgICAgICAgICAgYnJl YWs7ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgIFwKKyAgICAgICAgfSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBcCiAgICAgICAgIGNvbnN0IGNoYXIqIF90 bXBfb3R5cGUgPSBldmFzX29iamVjdF90eXBlX2dldChld2tWaWV3KTsgICAgICAgICAgICAgICAg XAogICAgICAgICBjb25zdCBFdmFzX1NtYXJ0KiBfdG1wX3MgPSBldmFzX29iamVjdF9zbWFydF9z bWFydF9nZXQoZXdrVmlldyk7ICAgICAgIFwKICAgICAgICAgaWYgKEVJTkFfVU5MSUtFTFkoIV90 bXBfcykpIHsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBcCkBAIC0y MDUsNiArMjEwLDcgQEAgc3RydWN0IEV3a19WaWV3X1ByaXZhdGVfRGF0YSB7CiAgICAgICAgICAg ICAgICAgKCIlcCAoJXMpIGlzIG5vdCBhIHNtYXJ0IG9iamVjdCEiLCAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgXAogICAgICAgICAgICAgICAgICBld2tWaWV3LCBfdG1wX290eXBlID8gX3Rt cF9vdHlwZSA6ICIobnVsbCkiKTsgICAgICAgICAgICAgICAgIFwKICAgICAgICAgICAgIHJlc3Vs dCA9IGZhbHNlOyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICBcCisgICAgICAgICAgICBicmVhazsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgXAogICAgICAgICB9ICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIFwK ICAgICAgICAgY29uc3QgRXZhc19TbWFydF9DbGFzcyogX3RtcF9zYyA9IGV2YXNfc21hcnRfY2xh c3NfZ2V0KF90bXBfcyk7ICAgICAgICBcCiAgICAgICAgIGlmIChFSU5BX1VOTElLRUxZKCFfdG1w X3NjKSkgeyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgXApAQCAtMjEy LDYgKzIxOCw3IEBAIHN0cnVjdCBFd2tfVmlld19Qcml2YXRlX0RhdGEgewogICAgICAgICAgICAg ICAgICgiJXAgKCVzKSBpcyBub3QgYSBzbWFydCBvYmplY3QhIiwgICAgICAgICAgICAgICAgICAg ICAgICAgICAgIFwKICAgICAgICAgICAgICAgICAgZXdrVmlldywgX3RtcF9vdHlwZSA/IF90bXBf b3R5cGUgOiAiKG51bGwpIik7ICAgICAgICAgICAgICAgICBcCiAgICAgICAgICAgICByZXN1bHQg PSBmYWxzZTsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgXAorICAgICAgICAgICAgYnJlYWs7ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgIFwKICAgICAgICAgfSAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBcCiAg ICAgICAgIGlmIChFSU5BX1VOTElLRUxZKF90bXBfc2MtPmRhdGEgIT0gRVdLX1ZJRVdfVFlQRV9T VFIpKSB7ICAgICAgICAgICAgICAgXAogICAgICAgICAgICAgRUlOQV9MT0dfQ1JJVCAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIFwKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZsL3Rlc3RzL3Rlc3RfZXdrMl92aWV3 LmNwcCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZsL3Rlc3RzL3Rlc3RfZXdrMl92 aWV3LmNwcAppbmRleCBkNGJiNzBmYmYwNDI1ODk4ODM5YjZmNTFmMmI4N2FkNDgzZjdmNDM5Li4x MWFmZmQ5YzRlN2RiOGU2NGRkMDJlZmMwZTY3YzEwMzFkNzQyZTgxIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2VmbC90ZXN0cy90ZXN0X2V3azJfdmlldy5jcHAKKysr IGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9lZmwvdGVzdHMvdGVzdF9ld2syX3ZpZXcu Y3BwCkBAIC0zOCw2ICszOCwxNCBAQCB1c2luZyBuYW1lc3BhY2UgRVdLMlVuaXRUZXN0OwogZXh0 ZXJuIEVXSzJVbml0VGVzdEVudmlyb25tZW50KiBlbnZpcm9ubWVudDsKIGJvb2wgZnVsbFNjcmVl bkNhbGxiYWNrQ2FsbGVkOwogCitURVNUX0YoRVdLMlVuaXRUZXN0QmFzZSwgZXdrX3ZpZXdfdHlw ZV9jaGVjaykKK3sKKyAgICBBU1NFUlRfRkFMU0UoZXdrX3ZpZXdfY29udGV4dF9nZXQoMCkpOwor CisgICAgRXZhc19PYmplY3QqIHJlY3RhbmdsZSA9IGV2YXNfb2JqZWN0X3JlY3RhbmdsZV9hZGQo Y2FudmFzKCkpOworICAgIEFTU0VSVF9GQUxTRShld2tfdmlld191cmxfc2V0KHJlY3RhbmdsZSwg MCkpOworfQorCiBzdGF0aWMgdm9pZCBvbkxvYWRGaW5pc2hlZEZvclJlZGlyZWN0aW9uKHZvaWQq IHVzZXJEYXRhLCBFdmFzX09iamVjdCosIHZvaWQqKQogewogICAgIGludCogY291bnRMb2FkRmlu aXNoZWQgPSBzdGF0aWNfY2FzdDxpbnQqPih1c2VyRGF0YSk7Cg==