100076 2012-10-22 22:50:22 -0700 exif-orientation tests should use dumpAsText(true) 2012-10-23 21:31:41 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 100191 1 noel.gordon noel.gordon eric schenney thorton webkit.review.bot oldest_to_newest 748291 0 noel.gordon 2012-10-22 22:50:22 -0700 The fast/images/exif-orientation tests use dumpAsText(1). That's not supported by chromium DRT so NRWT --chromium won't compare the expected pixel results if/when we unskip these tests. 749190 1 170281 noel.gordon 2012-10-23 18:22:53 -0700 Created attachment 170281 Patch 749212 2 170281 eric 2012-10-23 18:42:11 -0700 Comment on attachment 170281 Patch Do some DRT implementations care? 749213 3 eric 2012-10-23 18:42:43 -0700 Seems reasonable to make chromium DRT support this. :) 749234 4 noel.gordon 2012-10-23 19:13:09 -0700 (In reply to comment #2) > Do some DRT implementations care? Chromium DRT doesn't understand an integer argument, it only handles booleans. http://trac.webkit.org/browser/trunk/Tools/DumpRenderTree/chromium/DRTTestRunner.cpp?rev=132138#L359 749237 5 noel.gordon 2012-10-23 19:15:38 -0700 (In reply to comment #3) > Seems reasonable to make chromium DRT support this. :) Yes, we could that after Stephen fixes the only remaining test using dumpAsText(1) per bug 100074 749249 6 noel.gordon 2012-10-23 19:36:34 -0700 After that, change the DRTTestRunner.cpp?rev=132138#L359 code to read - if (arguments.size() > 0 && arguments[0].isBool()) - m_generatePixelResults = arguments[0].value.boolValue; + if (arguments.size() > 0) + m_generatePixelResults = cppVariantToBool(arguments[0]); 749299 7 170281 webkit.review.bot 2012-10-23 21:09:28 -0700 Comment on attachment 170281 Patch Clearing flags on attachment: 170281 Committed r132297: <http://trac.webkit.org/changeset/132297> 749300 8 webkit.review.bot 2012-10-23 21:09:32 -0700 All reviewed patches have been landed. Closing bug. 170281 2012-10-23 18:22:53 -0700 2012-10-23 21:09:28 -0700 Patch bug-100076-20121024122128.patch text/plain 1776 noel.gordon U3VidmVyc2lvbiBSZXZpc2lvbjogMTMyMTcwCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggMmI4YjIxNmJhMzVkNjQ2NzU0OWYx M2JiNTVkYzM5ODkwNmE1MmJlMS4uMDZhOWJhZWZhNjJiYjkxZTRiZjlmNGE0ZWIwYTBiOTI5YTMy MzhiYyAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDEyLTEwLTIzICBOb2VsIEdvcmRvbiAgPG5v ZWwuZ29yZG9uQGdtYWlsLmNvbT4KKworICAgICAgICBleGlmLW9yaWVudGF0aW9uIHRlc3RzIHNo b3VsZCB1c2UgZHVtcEFzVGV4dCh0cnVlKSAKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTEwMDA3NgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgICogZmFzdC9pbWFnZXMvZXhpZi1vcmllbnRhdGlvbi1jc3MuaHRt bDogVXNlIGR1bXBBc1RleHQodHJ1ZSkuCisgICAgICAgICogZmFzdC9pbWFnZXMvZXhpZi1vcmll bnRhdGlvbi5odG1sOiBkaXR0by4KKwogMjAxMi0xMC0yMiAgRGlyayBQcmFua2UgIDxkcHJhbmtl QGNocm9taXVtLm9yZz4KIAogICAgICAgICBVbnJldmlld2VkLCBtb3JlIENocm9taXVtIE1MIGV4 cGVjdGF0aW9uIHVwZGF0aW5nLgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9pbWFnZXMv ZXhpZi1vcmllbnRhdGlvbi1jc3MuaHRtbCBiL0xheW91dFRlc3RzL2Zhc3QvaW1hZ2VzL2V4aWYt b3JpZW50YXRpb24tY3NzLmh0bWwKaW5kZXggY2RkNjBjYjUzYWVmZmJmMDUwNTY2MTIxZWZlYmQ4 YjNiMjMxNjk0Ny4uMjE4YTUzMjBhODBiNGI5OWQxMGYxMzAwY2YwNzhmMGYwNWMzYTNlZiAxMDA2 NDQKLS0tIGEvTGF5b3V0VGVzdHMvZmFzdC9pbWFnZXMvZXhpZi1vcmllbnRhdGlvbi1jc3MuaHRt bAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L2ltYWdlcy9leGlmLW9yaWVudGF0aW9uLWNzcy5odG1s CkBAIC0zLDcgKzMsNyBAQAogPHNjcmlwdD4KIGlmICh3aW5kb3cudGVzdFJ1bm5lcikgewogICAg IHRlc3RSdW5uZXIub3ZlcnJpZGVQcmVmZXJlbmNlKCdXZWJLaXRTaG91bGRSZXNwZWN0SW1hZ2VP cmllbnRhdGlvbicsIDEpOwotICAgIHRlc3RSdW5uZXIuZHVtcEFzVGV4dCgxKTsKKyAgICB0ZXN0 UnVubmVyLmR1bXBBc1RleHQodHJ1ZSk7CiB9CiAKIGZ1bmN0aW9uIGxvZyhzdHIpIHsKZGlmZiAt LWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvaW1hZ2VzL2V4aWYtb3JpZW50YXRpb24uaHRtbCBiL0xh eW91dFRlc3RzL2Zhc3QvaW1hZ2VzL2V4aWYtb3JpZW50YXRpb24uaHRtbAppbmRleCBmNzEzMjQw MGQ4MjVkYjFhZGUyMjhhZTU3ZGY5ZGY1MDc5ZjIyZWI4Li40NjJiNjVjZTJkYjQzNjY2ODRmZDVh NTkwZDY1ZDIxOWFmNzAxZmQ3IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9mYXN0L2ltYWdlcy9l eGlmLW9yaWVudGF0aW9uLmh0bWwKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9pbWFnZXMvZXhpZi1v cmllbnRhdGlvbi5odG1sCkBAIC0zLDcgKzMsNyBAQAogPHNjcmlwdD4KIGlmICh3aW5kb3cudGVz dFJ1bm5lcikgewogICAgIHRlc3RSdW5uZXIub3ZlcnJpZGVQcmVmZXJlbmNlKCdXZWJLaXRTaG91 bGRSZXNwZWN0SW1hZ2VPcmllbnRhdGlvbicsIDEpOwotICAgIHRlc3RSdW5uZXIuZHVtcEFzVGV4 dCgxKTsKKyAgICB0ZXN0UnVubmVyLmR1bXBBc1RleHQodHJ1ZSk7CiB9CiAKIGZ1bmN0aW9uIGxv ZyhzdHIpIHsK