100047 2012-10-22 16:22:20 -0700 Clear m_mediaSource reference when the MediaSource is closed 2012-10-23 16:15:35 -0700 1 1 1 Unclassified WebKit Media 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 acolwell acolwell eric.carlson feature-media-reviews webkit.review.bot oldest_to_newest 748044 0 acolwell 2012-10-22 16:22:20 -0700 The existing code in HTMLMediaElement holds the reference to m_mediaSource longer then it needs to. The object shouldn't be used again after it has transitioned to "closed" so I'm adding code to clear the reference when this transition happens. 748060 1 170019 acolwell 2012-10-22 16:35:11 -0700 Created attachment 170019 Patch 748092 2 170019 webkit-ews 2012-10-22 16:54:44 -0700 Comment on attachment 170019 Patch Attachment 170019 did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/14489715 748156 3 170019 darin 2012-10-22 18:23:29 -0700 Comment on attachment 170019 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=170019&action=review > Source/WebCore/ChangeLog:12 > + No new tests because the change isn't visible to JavaScript. Understood that it is not “visible to JavaScript”. What end user detectable effect does it have? 748622 4 acolwell 2012-10-23 07:26:06 -0700 (In reply to comment #3) > (From update of attachment 170019 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=170019&action=review > > > Source/WebCore/ChangeLog:12 > > + No new tests because the change isn't visible to JavaScript. > > Understood that it is not “visible to JavaScript”. What end user detectable effect does it have? I don't believe it has an end user detectable effect. This change simply makes the object state more consistent so code can't access the object when it isn't supposed to. 748625 5 170019 acolwell 2012-10-23 07:30:12 -0700 Comment on attachment 170019 Patch resetting commit-queue? since the qt-wk2 failure doesn't appear to be related to my change. 749102 6 170019 webkit.review.bot 2012-10-23 16:15:32 -0700 Comment on attachment 170019 Patch Clearing flags on attachment: 170019 Committed r132280: <http://trac.webkit.org/changeset/132280> 749103 7 webkit.review.bot 2012-10-23 16:15:35 -0700 All reviewed patches have been landed. Closing bug. 170019 2012-10-22 16:35:11 -0700 2012-10-23 16:15:32 -0700 Patch bug-100047-20121022163349.patch text/plain 2134 acolwell U3VidmVyc2lvbiBSZXZpc2lvbjogMTMyMTU0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYTFmM2YwY2E5MGM1NTE2 YTlmMzQwZGM0MWY2ZTBhODZlMzg3N2FiNS4uNDAxNDg2M2ViMTEzZTM4NDkwMzEzNmFjZGM2ZWRm YjBmYTY2ZDdiYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDEyLTEwLTIyICBBYXJv biBDb2x3ZWxsICA8YWNvbHdlbGxAY2hyb21pdW0ub3JnPgorCisgICAgICAgIENsZWFyIG1fbWVk aWFTb3VyY2UgcmVmZXJlbmNlIHdoZW4gdGhlIE1lZGlhU291cmNlIGlzIGNsb3NlZAorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTAwMDQ3CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhlIG1fbWVkaWFTb3Vy Y2Ugb2JqZWN0IHNob3VsZG4ndCBiZSBhY2Nlc3NlZCBhZnRlciB0aGUgb2JqZWN0CisgICAgICAg IHRyYW5zaXRpb25zIHRvIGNsb3NlZCBzbyB0aGlzIGNoYW5nZSBzaW1wbHkgY2xlYXJzIHRoZSBy ZWZlcmVuY2UKKyAgICAgICAgd2hlbiB0aGF0IHRyYW5zaXRpb24gaGFwcGVucy4KKworICAgICAg ICBObyBuZXcgdGVzdHMgYmVjYXVzZSB0aGUgY2hhbmdlIGlzbid0IHZpc2libGUgdG8gSmF2YVNj cmlwdC4KKworICAgICAgICAqIGh0bWwvSFRNTE1lZGlhRWxlbWVudC5jcHA6CisgICAgICAgIChX ZWJDb3JlOjpIVE1MTWVkaWFFbGVtZW50Ojpsb2FkUmVzb3VyY2UpOiBSZW1vdmVkIGEgY2xvc2Vk IHRyYW5zaXRpb24gdGhhdCBpcyBhY3R1YWxseSBkZWFkIGNvZGUuCisgICAgICAgIChXZWJDb3Jl OjpIVE1MTWVkaWFFbGVtZW50OjpzZXRTb3VyY2VTdGF0ZSk6IENsZWFyIHRoZSBtX21lZGlhU291 cmNlIHJlZmVyZW5jZSBvbiBjbG9zZWQgdHJhbnNpdGlvbi4KKwogMjAxMi0xMC0yMiAgQWRhbSBC YXJ0aCAgPGFiYXJ0aEB3ZWJraXQub3JnPgogCiAgICAgICAgIFtWOF0gV2Ugc2hvdWxkIGNhbGwg dGhlIGZhc3RlciB2ODo6SW50ZWdlcjo6TmV3IEFQSXMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL2h0bWwvSFRNTE1lZGlhRWxlbWVudC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxN ZWRpYUVsZW1lbnQuY3BwCmluZGV4IDc1MzI0MjExMGQ2NTI4NjI4MTc5MTRiYzNlZTlmOTFlN2Q1 MWIyYjIuLmU3YzNkZjVlYzhiYmNlNDIyMWRkNmQ3ZmIxZGRlNjc1NDc1YTE4Y2EgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTE1lZGlhRWxlbWVudC5jcHAKKysrIGIvU291cmNl L1dlYkNvcmUvaHRtbC9IVE1MTWVkaWFFbGVtZW50LmNwcApAQCAtOTI1LDEwICs5MjUsOSBAQCB2 b2lkIEhUTUxNZWRpYUVsZW1lbnQ6OmxvYWRSZXNvdXJjZShjb25zdCBLVVJMJiBpbml0aWFsVVJM LCBDb250ZW50VHlwZSYgY29udGVudAogICAgIH0KICAgICAKICNpZiBFTkFCTEUoTUVESUFfU09V UkNFKQotICAgIGlmICh1cmwucHJvdG9jb2xJcyhtZWRpYVNvdXJjZUJsb2JQcm90b2NvbCkpIHsK LSAgICAgICAgaWYgKG1fbWVkaWFTb3VyY2UpCi0gICAgICAgICAgICBtX21lZGlhU291cmNlLT5z ZXRSZWFkeVN0YXRlKE1lZGlhU291cmNlOjpjbG9zZWRLZXl3b3JkKCkpOworICAgIEFTU0VSVCgh bV9tZWRpYVNvdXJjZSk7CiAKKyAgICBpZiAodXJsLnByb3RvY29sSXMobWVkaWFTb3VyY2VCbG9i UHJvdG9jb2wpKSB7CiAgICAgICAgIG1fbWVkaWFTb3VyY2UgPSBNZWRpYVNvdXJjZVJlZ2lzdHJ5 OjpyZWdpc3RyeSgpLmxvb2t1cE1lZGlhU291cmNlKHVybC5zdHJpbmcoKSk7CiAKICAgICAgICAg aWYgKG1fbWVkaWFTb3VyY2UpIHsKQEAgLTIzOTYsNiArMjM5NSw4IEBAIHZvaWQgSFRNTE1lZGlh RWxlbWVudDo6c2V0U291cmNlU3RhdGUoY29uc3QgU3RyaW5nJiBzdGF0ZSkKICAgICAgICAgIHJl dHVybjsKIAogICAgIG1fbWVkaWFTb3VyY2UtPnNldFJlYWR5U3RhdGUoc3RhdGUpOworICAgIGlm IChzdGF0ZSA9PSBNZWRpYVNvdXJjZTo6Y2xvc2VkS2V5d29yZCgpKQorICAgICAgICBtX21lZGlh U291cmNlID0gMDsKIH0KICNlbmRpZgogCg==