100044 2012-10-22 15:57:02 -0700 [Mac] Remove extraneous conversion to String->NSString 2012-10-23 15:02:50 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 benjamin benjamin andersca apinheiro cfleizach dmazzoni japhet jdiggs webkit.review.bot oldest_to_newest 748014 0 benjamin 2012-10-22 15:57:02 -0700 Improve some unfortunate cases of implicit conversion. 748098 1 170029 benjamin 2012-10-22 16:59:30 -0700 Created attachment 170029 Patch 748159 2 170029 darin 2012-10-22 18:26:34 -0700 Comment on attachment 170029 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=170029&action=review > Source/WebCore/loader/mac/LoaderNSURLExtras.mm:75 > + if ((mimeType == "application/tar" || mimeType == "application/x-tar") Why is it OK for us to check something case insensitive (a MIME type) with a case sensitive comparison? 748991 3 benjamin 2012-10-23 14:32:27 -0700 > View in context: https://bugs.webkit.org/attachment.cgi?id=170029&action=review > > > Source/WebCore/loader/mac/LoaderNSURLExtras.mm:75 > > + if ((mimeType == "application/tar" || mimeType == "application/x-tar") > > Why is it OK for us to check something case insensitive (a MIME type) with a case sensitive comparison? I am not familiar with that code but it looks like MIMETypes are always compared lowercase in WebKit. I dug a little bit and it looks like NSURLResponse take care of converting the incoming bytes to a lowercase MIMEType. 749030 4 170029 benjamin 2012-10-23 15:02:47 -0700 Comment on attachment 170029 Patch Clearing flags on attachment: 170029 Committed r132272: <http://trac.webkit.org/changeset/132272> 749031 5 benjamin 2012-10-23 15:02:50 -0700 All reviewed patches have been landed. Closing bug. 170029 2012-10-22 16:59:30 -0700 2012-10-23 15:02:47 -0700 Patch bug-100044-20121022165808.patch text/plain 10061 benjamin U3VidmVyc2lvbiBSZXZpc2lvbjogMTMyMTIxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNjZhOTBlOWNmZWEyZmZk MDYwNWViMzY4MWNhNGViZGI3NTg5YTljYi4uMGEwNWM4NDM3MGZhMjhjMWI0YzVlZGE5ZTFhYTgx ODQyMDNmNmIyZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDMzIEBACisyMDEyLTEwLTIyICBCZW5q YW1pbiBQb3VsYWluICA8YmVuamFtaW5Ad2Via2l0Lm9yZz4KKworICAgICAgICBbTWFjXSBSZW1v dmUgZXh0cmFuZW91cyBjb252ZXJzaW9uIHRvIFN0cmluZy0+TlNTdHJpbmcKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwMDA0NAorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEltcHJvdmUgc29tZSB1bmZvcnR1 bmF0ZSB1c2Ugb2YgU3RyaW5nLT5OU1N0cmluZy4KKworICAgICAgICAqIGFjY2Vzc2liaWxpdHkv bWFjL0FYT2JqZWN0Q2FjaGVNYWMubW06CisgICAgICAgIChXZWJDb3JlOjpBWE9iamVjdENhY2hl Ojpwb3N0UGxhdGZvcm1Ob3RpZmljYXRpb24pOiBUaGUgdmFyaWFibGUgbWFjTm90aWZpY2F0aW9u IGlzIHVsdGltYXRlbHkKKyAgICAgICAgbmVlZGVkIGFzIE5TU3RyaW5nLCBhbmQgYWxsIGl0cyB2 YWx1ZSBhcmUgb3IgY2FuIGJlIE5TU3RyaW5nLgorICAgICAgICBDb252ZXJ0IHRoZSBsYXN0IDMg Y2hhciogdmFsdWVzIHRvIE5TU3RyaW5nIGxpdGVyYWwgYW5kIHVzZSBOU1N0cmluZyogYWxsIHRo ZSB3YXkuCisKKyAgICAgICAgKiBsb2FkZXIvbWFjL0xvYWRlck5TVVJMRXh0cmFzLmg6CisgICAg ICAgICogbG9hZGVyL21hYy9Mb2FkZXJOU1VSTEV4dHJhcy5tbToKKyAgICAgICAgKHN1Z2dlc3Rl ZEZpbGVuYW1lV2l0aE1JTUVUeXBlKToKKyAgICAgICAgV2UgY29udmVydGVkIHRoZSBTdHJpbmcg dG8gTlNTdHJpbmcgdG8gcGFzcyB0byBzdWdnZXN0ZWRGaWxlbmFtZVdpdGhNSU1FVHlwZS4gVGhl cmUgaXMgbm8gbmVlZAorICAgICAgICBmb3IgdGhlIHN0cmluZyB0byBiZSBhIE5TU1RyaW5nIHRo ZXJlLCB3ZSBjYW4gbGVhdmUgaXQgaW4gaXRzIG9yaWdpbmFsIHR5cGUuCisKKyAgICAgICAgVGhl IGNhc2UgY2hlY2tpbmcgZm9yIGEgbmlsIE1JTUVUeXBlIHdhcyBkZWFkIGNvZGUgYmVjYXVzZSB0 aGUgaW1wbGljaXQgY29udmVyc2lvbiBuZXZlciByZXR1cm5zIG5pbC4KKworICAgICAgICAqIHBs YXRmb3JtL21hYy9EcmFnSW1hZ2VNYWMubW06CisgICAgICAgIChXZWJDb3JlOjpjcmVhdGVEcmFn SW1hZ2VGb3JMaW5rKToKKyAgICAgICAgVXNlIFN0cmluZydzIG5zU3RyaW5nTmlsSWZFbXB0eSgp LgorCisgICAgICAgICogcGxhdGZvcm0vbWFjL0hUTUxDb252ZXJ0ZXIubW06CisgICAgICAgICgt W1dlYkhUTUxDb252ZXJ0ZXIgX2FkZEF0dGFjaG1lbnRGb3JFbGVtZW50OlVSTDpuZWVkc1BhcmFn cmFwaDp1c2VQbGFjZWhvbGRlcjpdKToKKyAgICAgICAgRml4IHRoZSBjb2Rpbmcgc3R5bGUuIERv IHRoZSBjb252ZXJzaW9uIHRvIE5TU3RyaW5nIG9ubHkgd2hlbiBuZWVkZWQuCisKIDIwMTItMTAt MjIgIFZhcnVuIEphaW4gIDx2YXJ1bmphaW5AY2hyb21pdW0ub3JnPgogCiAgICAgICAgIENvbnRl eHQgbWVudSBnZW5lcmF0ZWQgZnJvbSB0b3VjaCBnZXN0dXJlcyBvbiB0ZXh0YXJlYXMgaGFzCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L21hYy9BWE9iamVjdENhY2hl TWFjLm1tIGIvU291cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9tYWMvQVhPYmplY3RDYWNoZU1h Yy5tbQppbmRleCA3MmQ1NGZhOGRlZmFlNjQ2OTg1OWQ0MDVkZTkyNTBmMzBkMjhiZjRiLi45YTdk NzcyM2NjNzk2MGI5MGNjZTE3ZmVhYTBlNWM3NzA4OTJlMTUxIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViQ29yZS9hY2Nlc3NpYmlsaXR5L21hYy9BWE9iamVjdENhY2hlTWFjLm1tCisrKyBiL1NvdXJj ZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkvbWFjL0FYT2JqZWN0Q2FjaGVNYWMubW0KQEAgLTEsNSAr MSw1IEBACiAvKgotICogQ29weXJpZ2h0IChDKSAyMDAzLCAyMDA0LCAyMDA1LCAyMDA2LCAyMDA4 IEFwcGxlIEluYy4gQWxsIHJpZ2h0cyByZXNlcnZlZC4KKyAqIENvcHlyaWdodCAoQykgMjAwMywg MjAwNCwgMjAwNSwgMjAwNiwgMjAwOCwgMjAxMiBBcHBsZSBJbmMuIEFsbCByaWdodHMgcmVzZXJ2 ZWQuCiAgKgogICogUmVkaXN0cmlidXRpb24gYW5kIHVzZSBpbiBzb3VyY2UgYW5kIGJpbmFyeSBm b3Jtcywgd2l0aCBvciB3aXRob3V0CiAgKiBtb2RpZmljYXRpb24sIGFyZSBwZXJtaXR0ZWQgcHJv dmlkZWQgdGhhdCB0aGUgZm9sbG93aW5nIGNvbmRpdGlvbnMKQEAgLTYxLDcgKzYxLDcgQEAgdm9p ZCBBWE9iamVjdENhY2hlOjpwb3N0UGxhdGZvcm1Ob3RpZmljYXRpb24oQWNjZXNzaWJpbGl0eU9i amVjdCogb2JqLCBBWE5vdGlmaWMKICAgICAgICAgcmV0dXJuOwogICAgIAogICAgIC8vIFNvbWUg bm90aWZpY2F0aW9ucyBhcmUgdW5pcXVlIHRvIFNhZmFyaSBhbmQgZG8gbm90IGhhdmUgTlNBY2Nl c3NpYmlsaXR5IGVxdWl2YWxlbnRzLgotICAgIFN0cmluZyBtYWNOb3RpZmljYXRpb247CisgICAg TlNTdHJpbmcgKm1hY05vdGlmaWNhdGlvbjsKICAgICBzd2l0Y2ggKG5vdGlmaWNhdGlvbikgewog ICAgICAgICBjYXNlIEFYQWN0aXZlRGVzY2VuZGFudENoYW5nZWQ6CiAgICAgICAgICAgICAvLyBB biBhY3RpdmUgZGVzY2VuZGFudCBjaGFuZ2UgZm9yIHRyZWVzIG1lYW5zIGEgc2VsZWN0ZWQgcm93 cyBjaGFuZ2UuCkBAIC04MSwxMyArODEsMTMgQEAgdm9pZCBBWE9iamVjdENhY2hlOjpwb3N0UGxh dGZvcm1Ob3RpZmljYXRpb24oQWNjZXNzaWJpbGl0eU9iamVjdCogb2JqLCBBWE5vdGlmaWMKICAg ICAgICAgICAgIG1hY05vdGlmaWNhdGlvbiA9IE5TQWNjZXNzaWJpbGl0eUZvY3VzZWRVSUVsZW1l bnRDaGFuZ2VkTm90aWZpY2F0aW9uOwogICAgICAgICAgICAgYnJlYWs7CiAgICAgICAgIGNhc2Ug QVhMYXlvdXRDb21wbGV0ZToKLSAgICAgICAgICAgIG1hY05vdGlmaWNhdGlvbiA9ICJBWExheW91 dENvbXBsZXRlIjsKKyAgICAgICAgICAgIG1hY05vdGlmaWNhdGlvbiA9IEAiQVhMYXlvdXRDb21w bGV0ZSI7CiAgICAgICAgICAgICBicmVhazsKICAgICAgICAgY2FzZSBBWExvYWRDb21wbGV0ZToK LSAgICAgICAgICAgIG1hY05vdGlmaWNhdGlvbiA9ICJBWExvYWRDb21wbGV0ZSI7CisgICAgICAg ICAgICBtYWNOb3RpZmljYXRpb24gPSBAIkFYTG9hZENvbXBsZXRlIjsKICAgICAgICAgICAgIGJy ZWFrOwogICAgICAgICBjYXNlIEFYSW52YWxpZFN0YXR1c0NoYW5nZWQ6Ci0gICAgICAgICAgICBt YWNOb3RpZmljYXRpb24gPSAiQVhJbnZhbGlkU3RhdHVzQ2hhbmdlZCI7CisgICAgICAgICAgICBt YWNOb3RpZmljYXRpb24gPSBAIkFYSW52YWxpZFN0YXR1c0NoYW5nZWQiOwogICAgICAgICAgICAg YnJlYWs7CiAgICAgICAgIGNhc2UgQVhTZWxlY3RlZENoaWxkcmVuQ2hhbmdlZDoKICAgICAgICAg ICAgIGlmIChvYmotPmlzQWNjZXNzaWJpbGl0eVRhYmxlKCkpCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViQ29yZS9sb2FkZXIvbWFjL0xvYWRlck5TVVJMRXh0cmFzLmggYi9Tb3VyY2UvV2ViQ29yZS9s b2FkZXIvbWFjL0xvYWRlck5TVVJMRXh0cmFzLmgKaW5kZXggY2U1YTQ5MDlkMzZkZDczMzFkMWZm NWIwZjRlZmEyOTc2MDQwZDRhMC4uYTUwMGE4ZTAwZmQ2ZDdlYWQ3NjA0YzY2ZTkxNDczMjBjMGM0 YTE5NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvbG9hZGVyL21hYy9Mb2FkZXJOU1VSTEV4 dHJhcy5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL2xvYWRlci9tYWMvTG9hZGVyTlNVUkxFeHRyYXMu aApAQCAtMSw1ICsxLDUgQEAKIC8qCi0gKiBDb3B5cmlnaHQgKEMpIDIwMDUsIDIwMDYgQXBwbGUg Q29tcHV0ZXIsIEluYy4gIEFsbCByaWdodHMgcmVzZXJ2ZWQuCisgKiBDb3B5cmlnaHQgKEMpIDIw MDUsIDIwMDYsIDIwMTIgQXBwbGUgQ29tcHV0ZXIsIEluYy4gIEFsbCByaWdodHMgcmVzZXJ2ZWQu CiAgKgogICogUmVkaXN0cmlidXRpb24gYW5kIHVzZSBpbiBzb3VyY2UgYW5kIGJpbmFyeSBmb3Jt cywgd2l0aCBvciB3aXRob3V0CiAgKiBtb2RpZmljYXRpb24sIGFyZSBwZXJtaXR0ZWQgcHJvdmlk ZWQgdGhhdCB0aGUgZm9sbG93aW5nIGNvbmRpdGlvbnMKQEAgLTI4LDEyICsyOCwxMCBAQAogCiAj aW1wb3J0IDxGb3VuZGF0aW9uL0ZvdW5kYXRpb24uaD4KIAotI2lmZGVmIF9fY3BsdXNwbHVzCi1l eHRlcm4gIkMiIHsKLSNlbmRpZgotCi1OU1N0cmluZyAqc3VnZ2VzdGVkRmlsZW5hbWVXaXRoTUlN RVR5cGUoTlNVUkwgKnVybCwgTlNTdHJpbmcgKk1JTUVUeXBlKTsKK25hbWVzcGFjZSBXVEYgewor Y2xhc3MgU3RyaW5nOworfQogCi0jaWZkZWYgX19jcGx1c3BsdXMKK2V4dGVybiAiQyIgeworTlNT dHJpbmcgKnN1Z2dlc3RlZEZpbGVuYW1lV2l0aE1JTUVUeXBlKE5TVVJMICosIGNvbnN0IFdURjo6 U3RyaW5nJiBNSU1FVHlwZSk7CiB9Ci0jZW5kaWYKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3Jl L2xvYWRlci9tYWMvTG9hZGVyTlNVUkxFeHRyYXMubW0gYi9Tb3VyY2UvV2ViQ29yZS9sb2FkZXIv bWFjL0xvYWRlck5TVVJMRXh0cmFzLm1tCmluZGV4IDJjYjEzYWY0MWFkOThiYTcxYThiOGY1Y2Q2 YWMxODZhYzcxMTdjNjcuLjA4M2IxZTYwMzM2OWE5ODNiZmFkMTgzMGJkZTIxMDFhZjA0YjQ3NDMg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2xvYWRlci9tYWMvTG9hZGVyTlNVUkxFeHRyYXMu bW0KKysrIGIvU291cmNlL1dlYkNvcmUvbG9hZGVyL21hYy9Mb2FkZXJOU1VSTEV4dHJhcy5tbQpA QCAtMSw1ICsxLDUgQEAKIC8qCi0gKiBDb3B5cmlnaHQgKEMpIDIwMDUsIDIwMDggQXBwbGUgSW5j LiBBbGwgcmlnaHRzIHJlc2VydmVkLgorICogQ29weXJpZ2h0IChDKSAyMDA1LCAyMDA4LCAyMDEy IEFwcGxlIEluYy4gQWxsIHJpZ2h0cyByZXNlcnZlZC4KICAqIENvcHlyaWdodCAoQykgMjAwNiBB bGV4ZXkgUHJvc2t1cnlha292IChhcEBueXBvcC5jb20pCiAgKgogICogUmVkaXN0cmlidXRpb24g YW5kIHVzZSBpbiBzb3VyY2UgYW5kIGJpbmFyeSBmb3Jtcywgd2l0aCBvciB3aXRob3V0CkBAIC00 OSw3ICs0OSw3IEBAIHN0YXRpYyBib29sIHZlY3RvckNvbnRhaW5zU3RyaW5nKGNvbnN0IFZlY3Rv cjxTdHJpbmc+JiB2ZWN0b3IsIGNvbnN0IFN0cmluZyYgc3RyCiAgICAgcmV0dXJuIGZhbHNlOwog fQogCi1OU1N0cmluZyAqc3VnZ2VzdGVkRmlsZW5hbWVXaXRoTUlNRVR5cGUoTlNVUkwgKnVybCwg TlNTdHJpbmcgKk1JTUVUeXBlKQorTlNTdHJpbmcgKnN1Z2dlc3RlZEZpbGVuYW1lV2l0aE1JTUVU eXBlKE5TVVJMICp1cmwsIGNvbnN0IFN0cmluZyYgbWltZVR5cGUpCiB7CiAgICAgLy8gR2V0IHRo ZSBmaWxlbmFtZSBmcm9tIHRoZSBVUkwuIFRyeSB0aGUgbGFzdFBhdGhDb21wb25lbnQgZmlyc3Qu CiAgICAgTlNTdHJpbmcgKmxhc3RQYXRoQ29tcG9uZW50ID0gW1t1cmwgcGF0aF0gbGFzdFBhdGhD b21wb25lbnRdOwpAQCAtNzAsMTQgKzcwLDkgQEAgTlNTdHJpbmcgKnN1Z2dlc3RlZEZpbGVuYW1l V2l0aE1JTUVUeXBlKE5TVVJMICp1cmwsIE5TU3RyaW5nICpNSU1FVHlwZSkKICAgICAgICAgZXh0 ZW5zaW9uID0gW2ZpbGVuYW1lIHBhdGhFeHRlbnNpb25dOwogICAgIH0KIAotICAgIC8vIE5vIG1p bWUgdHlwZSByZXBvcnRlZC4gSnVzdCByZXR1cm4gdGhlIGZpbGVuYW1lIHdlIGhhdmUgbm93Lgot ICAgIGlmICghTUlNRVR5cGUpIHsKLSAgICAgICAgcmV0dXJuIGZpbGVuYW1lOwotICAgIH0KLQog ICAgIC8vIERvIG5vdCBjb3JyZWN0IGZpbGVuYW1lcyB0aGF0IGFyZSByZXBvcnRlZCB3aXRoIGEg bWltZSB0eXBlIG9mIHRhciwgYW5kIAogICAgIC8vIGhhdmUgYSBmaWxlbmFtZSB3aGljaCBoYXMg LnRhciBpbiBpdCBvciBlbmRzIGluIC50Z3oKLSAgICBpZiAoKFtNSU1FVHlwZSBpc0VxdWFsVG9T dHJpbmc6QCJhcHBsaWNhdGlvbi90YXIiXSB8fCBbTUlNRVR5cGUgaXNFcXVhbFRvU3RyaW5nOkAi YXBwbGljYXRpb24veC10YXIiXSkgCisgICAgaWYgKChtaW1lVHlwZSA9PSAiYXBwbGljYXRpb24v dGFyIiB8fCBtaW1lVHlwZSA9PSAiYXBwbGljYXRpb24veC10YXIiKQogICAgICAgICAmJiAoaGFz Q2FzZUluc2Vuc2l0aXZlU3Vic3RyaW5nKGZpbGVuYW1lLCBAIi50YXIiKQogICAgICAgICB8fCBo YXNDYXNlSW5zZW5zaXRpdmVTdWZmaXgoZmlsZW5hbWUsIEAiLnRneiIpKSkgewogICAgICAgICBy ZXR1cm4gZmlsZW5hbWU7CkBAIC04NSwxMiArODAsMTIgQEAgTlNTdHJpbmcgKnN1Z2dlc3RlZEZp bGVuYW1lV2l0aE1JTUVUeXBlKE5TVVJMICp1cmwsIE5TU3RyaW5nICpNSU1FVHlwZSkKIAogICAg IC8vIEkgZG9uJ3QgdGhpbmsgd2UgbmVlZCB0byB3b3JyeSBhYm91dCB0aGlzIGZvciB0aGUgaW1h Z2UgY2FzZQogICAgIC8vIElmIHRoZSB0eXBlIGlzIGtub3duLCBjaGVjayB0aGUgZXh0ZW5zaW9u IGFuZCBjb3JyZWN0IGl0IGlmIG5lY2Vzc2FyeS4KLSAgICBpZiAoIVtNSU1FVHlwZSBpc0VxdWFs VG9TdHJpbmc6QCJhcHBsaWNhdGlvbi9vY3RldC1zdHJlYW0iXSAmJiAhW01JTUVUeXBlIGlzRXF1 YWxUb1N0cmluZzpAInRleHQvcGxhaW4iXSkgewotICAgICAgICBWZWN0b3I8U3RyaW5nPiBleHRl bnNpb25zID0gTUlNRVR5cGVSZWdpc3RyeTo6Z2V0RXh0ZW5zaW9uc0Zvck1JTUVUeXBlKE1JTUVU eXBlKTsKKyAgICBpZiAobWltZVR5cGUgIT0gImFwcGxpY2F0aW9uL29jdGV0LXN0cmVhbSIgJiYg bWltZVR5cGUgIT0gInRleHQvcGxhaW4iKSB7CisgICAgICAgIFZlY3RvcjxTdHJpbmc+IGV4dGVu c2lvbnMgPSBNSU1FVHlwZVJlZ2lzdHJ5OjpnZXRFeHRlbnNpb25zRm9yTUlNRVR5cGUobWltZVR5 cGUpOwogCiAgICAgICAgIGlmIChleHRlbnNpb25zLmlzRW1wdHkoKSB8fCAhdmVjdG9yQ29udGFp bnNTdHJpbmcoZXh0ZW5zaW9ucywgZXh0ZW5zaW9uKSkgewogICAgICAgICAgICAgLy8gVGhlIGV4 dGVuc2lvbiBkb2Vzbid0IG1hdGNoIHRoZSBNSU1FIHR5cGUuIENvcnJlY3QgdGhpcy4KLSAgICAg ICAgICAgIE5TU3RyaW5nICpjb3JyZWN0RXh0ZW5zaW9uID0gTUlNRVR5cGVSZWdpc3RyeTo6Z2V0 UHJlZmVycmVkRXh0ZW5zaW9uRm9yTUlNRVR5cGUoTUlNRVR5cGUpOworICAgICAgICAgICAgTlNT dHJpbmcgKmNvcnJlY3RFeHRlbnNpb24gPSBNSU1FVHlwZVJlZ2lzdHJ5OjpnZXRQcmVmZXJyZWRF eHRlbnNpb25Gb3JNSU1FVHlwZShtaW1lVHlwZSk7CiAgICAgICAgICAgICBpZiAoW2NvcnJlY3RF eHRlbnNpb24gbGVuZ3RoXSAhPSAwKSB7CiAgICAgICAgICAgICAgICAgLy8gQXBwZW5kIHRoZSBj b3JyZWN0IGV4dGVuc2lvbi4KICAgICAgICAgICAgICAgICBmaWxlbmFtZSA9IFtmaWxlbmFtZSBz dHJpbmdCeUFwcGVuZGluZ1BhdGhFeHRlbnNpb246Y29ycmVjdEV4dGVuc2lvbl07CmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tYWMvRHJhZ0ltYWdlTWFjLm1tIGIvU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vbWFjL0RyYWdJbWFnZU1hYy5tbQppbmRleCAzMzc5ZjM5Y2FiZDI3 ZThlZDQwMTYyMjdmOWEzMjg5YjU0ZWZhMjQ2Li5hMzQ4MDkyMWEyYTA0ZTkxZWRmNWZlZWJhZjIx MmQxYmUxZGY5OGQzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tYWMvRHJh Z0ltYWdlTWFjLm1tCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21hYy9EcmFnSW1hZ2VN YWMubW0KQEAgLTEsNSArMSw1IEBACiAvKgotICogQ29weXJpZ2h0IChDKSAyMDA3LCAyMDA5IEFw cGxlIEluYy4gQWxsIHJpZ2h0cyByZXNlcnZlZC4KKyAqIENvcHlyaWdodCAoQykgMjAwNywgMjAw OSwgMjAxMiBBcHBsZSBJbmMuIEFsbCByaWdodHMgcmVzZXJ2ZWQuCiAgKgogICogUmVkaXN0cmli dXRpb24gYW5kIHVzZSBpbiBzb3VyY2UgYW5kIGJpbmFyeSBmb3Jtcywgd2l0aCBvciB3aXRob3V0 CiAgKiBtb2RpZmljYXRpb24sIGFyZSBwZXJtaXR0ZWQgcHJvdmlkZWQgdGhhdCB0aGUgZm9sbG93 aW5nIGNvbmRpdGlvbnMKQEAgLTI3MCw5ICsyNzAsNyBAQCBEcmFnSW1hZ2VSZWYgY3JlYXRlRHJh Z0ltYWdlRm9yTGluayhLVVJMJiB1cmwsIGNvbnN0IFN0cmluZyYgdGl0bGUsIEZyYW1lKiBmcmFt ZQogewogICAgIGlmICghZnJhbWUpCiAgICAgICAgIHJldHVybiBuaWw7Ci0gICAgTlNTdHJpbmcg KmxhYmVsID0gMDsKLSAgICBpZiAoIXRpdGxlLmlzRW1wdHkoKSkKLSAgICAgICAgbGFiZWwgPSB0 aXRsZTsKKyAgICBOU1N0cmluZyAqbGFiZWwgPSBuc1N0cmluZ05pbElmRW1wdHkodGl0bGUpOwog ICAgIE5TVVJMICpjb2NvYVVSTCA9IHVybDsKICAgICBOU1N0cmluZyAqdXJsU3RyaW5nID0gW2Nv Y29hVVJMIGFic29sdXRlU3RyaW5nXTsKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vbWFjL0hUTUxDb252ZXJ0ZXIubW0gYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tYWMv SFRNTENvbnZlcnRlci5tbQppbmRleCBiYjZlNzQzYjY5MTkyZDA4M2Y5ZjgwZTY0ZjZjYjczOThj ZjM5YzMxLi42NTE2YTJkMmNiYmMxMWI1OTlkNTMxMmZkODE4ODhmOGYyMjI0Y2U5IDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tYWMvSFRNTENvbnZlcnRlci5tbQorKysgYi9T b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tYWMvSFRNTENvbnZlcnRlci5tbQpAQCAtMSw1ICsxLDUg QEAKIC8qCi0gKiBDb3B5cmlnaHQgKEMpIDIwMTEgQXBwbGUgSW5jLiBBbGwgcmlnaHRzIHJlc2Vy dmVkLgorICogQ29weXJpZ2h0IChDKSAyMDExLCAyMDEyIEFwcGxlIEluYy4gQWxsIHJpZ2h0cyBy ZXNlcnZlZC4KICAqCiAgKiBSZWRpc3RyaWJ1dGlvbiBhbmQgdXNlIGluIHNvdXJjZSBhbmQgYmlu YXJ5IGZvcm1zLCB3aXRoIG9yIHdpdGhvdXQKICAqIG1vZGlmaWNhdGlvbiwgYXJlIHBlcm1pdHRl ZCBwcm92aWRlZCB0aGF0IHRoZSBmb2xsb3dpbmcgY29uZGl0aW9ucwpAQCAtNzk4LDExICs3OTgs MTUgQEAgc3RhdGljIGlubGluZSBOU1NoYWRvdyAqX3NoYWRvd0ZvclNoYWRvd1N0eWxlKE5TU3Ry aW5nICpzaGFkb3dTdHlsZSkKICAgICB9CiAgICAgaWYgKCFmaWxlV3JhcHBlcikgewogICAgICAg ICBSZWZQdHI8QXJjaGl2ZVJlc291cmNlPiByZXNvdXJjZSA9IGRhdGFTb3VyY2UtPnN1YnJlc291 cmNlKHVybCk7Ci0gICAgICAgIGlmICghcmVzb3VyY2UpIHJlc291cmNlID0gZGF0YVNvdXJjZS0+ c3VicmVzb3VyY2UodXJsKTsKLSAgICAgICAgaWYgKGZsYWcgJiYgcmVzb3VyY2UgJiYgW0AidGV4 dC9odG1sIiBpc0VxdWFsOnJlc291cmNlLT5taW1lVHlwZSgpXSkgbm90Rm91bmQgPSBZRVM7Cisg ICAgICAgIGlmICghcmVzb3VyY2UpCisgICAgICAgICAgICByZXNvdXJjZSA9IGRhdGFTb3VyY2Ut PnN1YnJlc291cmNlKHVybCk7CisKKyAgICAgICAgY29uc3QgU3RyaW5nJiBtaW1lVHlwZSA9IHJl c291cmNlLT5taW1lVHlwZSgpOworICAgICAgICBpZiAoZmxhZyAmJiByZXNvdXJjZSAmJiBtaW1l VHlwZSA9PSAidGV4dC9odG1sIikKKyAgICAgICAgICAgIG5vdEZvdW5kID0gWUVTOwogICAgICAg ICBpZiAocmVzb3VyY2UgJiYgIW5vdEZvdW5kKSB7CiAgICAgICAgICAgICBmaWxlV3JhcHBlciA9 IFtbW05TRmlsZVdyYXBwZXIgYWxsb2NdIGluaXRSZWd1bGFyRmlsZVdpdGhDb250ZW50czpbcmVz b3VyY2UtPmRhdGEoKS0+Y3JlYXRlTlNEYXRhKCkgYXV0b3JlbGVhc2VdXSBhdXRvcmVsZWFzZV07 Ci0gICAgICAgICAgICBbZmlsZVdyYXBwZXIgc2V0UHJlZmVycmVkRmlsZW5hbWU6c3VnZ2VzdGVk RmlsZW5hbWVXaXRoTUlNRVR5cGUodXJsLCByZXNvdXJjZS0+bWltZVR5cGUoKSldOworICAgICAg ICAgICAgW2ZpbGVXcmFwcGVyIHNldFByZWZlcnJlZEZpbGVuYW1lOnN1Z2dlc3RlZEZpbGVuYW1l V2l0aE1JTUVUeXBlKHVybCwgbWltZVR5cGUpXTsKICAgICAgICAgfQogICAgIH0KICAgICBpZiAo IWZpbGVXcmFwcGVyICYmICFub3RGb3VuZCkgewo=