100042 2012-10-22 15:42:53 -0700 [chromium] Add textureWidth() and textureHeight() to WebVideoFrame 2012-10-24 23:32:09 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 sheu sheu abarth dglazkov eric.carlson feature-media-reviews fischman fishd jamesr peter+ews skaslev tkent+wkapi webkit.review.bot oldest_to_newest 747988 0 sheu 2012-10-22 15:42:53 -0700 [chromium] Add textureWidth() and textureHeight() to WebVideoFrame 747990 1 170005 sheu 2012-10-22 15:43:36 -0700 Created attachment 170005 Patch 747997 2 webkit.review.bot 2012-10-22 15:47:41 -0700 Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI. 748001 3 sheu 2012-10-22 15:50:26 -0700 Just an interface change at the moment. I'd like to remove stride() eventually, but only after I land the Chromium-side changes as wekk, 748007 4 170005 jamesr 2012-10-22 15:51:30 -0700 Comment on attachment 170005 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=170005&action=review > Source/Platform/ChangeLog:8 > + Additional information of the change such as approach, rationale. Please add per-function descriptions below (OOPS!). You have to fill something out here. For this, when would textureWidth/textureHight be different from the frame's width/height? Why do we need separate fields? 748015 5 170009 sheu 2012-10-22 15:57:04 -0700 Created attachment 170009 Patch 748141 6 sheu 2012-10-22 17:57:58 -0700 Please take a look here. 748221 7 jamesr 2012-10-22 20:18:27 -0700 I can't find any equivalent in media/base/video_frame.h. Perhaps there's some context here I'm missing? Is there a crbug or chromium-side code review that goes along with this? 748223 8 sheu 2012-10-22 20:24:13 -0700 The Chromium bug lives at http://crbug.com/155416, and the Chromium-side change is WIP on my checkout. I can't actually checkin for Chromium until this interface change lands, so this one's going first. (As the interface change just adds two accessors, it's safe to do first.) 748230 9 fischman 2012-10-22 20:30:22 -0700 (In reply to comment #8) > The Chromium bug lives at http://crbug.com/155416, and the Chromium-side change is WIP on my checkout. I can't actually checkin for Chromium until this interface change lands, so this one's going first. (As the interface change just adds two accessors, it's safe to do first.) @sheu: actually, this is http://crbug.com/140509 :) You taking that over? (that'd be great, since I haven't had time to touch it) (155416 describes a symptom; 140509 describes the root cause and a plan for fixing it) 748233 10 170009 jamesr 2012-10-22 20:35:32 -0700 Comment on attachment 170009 Patch Thanks for the info. Slavomir (cc'd) is working on moving the dependency from media -> cc down to not need the WebVideoFrame intermediate data structure, so hopefully this won't be needed in WebKit for long. But for now it definitely is. 750135 11 170491 sheu 2012-10-24 15:40:53 -0700 Created attachment 170491 Patch 750138 12 sheu 2012-10-24 15:42:49 -0700 Updated patch. I have a question on naming in the interface. To wit: is visibleX/visibleY/visibleWidth/visibleHeight the right name to use for the added interface functions, in WebKit style? 750177 13 jamesr 2012-10-24 16:20:02 -0700 (In reply to comment #12) > Updated patch. > > I have a question on naming in the interface. To wit: is visibleX/visibleY/visibleWidth/visibleHeight the right name to use for the added interface functions, in WebKit style? The naming is correct - accessors should match the variable name they are accessing - but it'd be better to have the whole thing be one accessor that returns type WebRect instead of 4 individual methods. 750253 14 170523 sheu 2012-10-24 17:46:13 -0700 Created attachment 170523 Patch 750266 15 170523 peter+ews 2012-10-24 18:07:48 -0700 Comment on attachment 170523 Patch Attachment 170523 did not pass cr-android-ews (chromium-android): Output: http://queues.webkit.org/results/14554451 750268 16 170530 sheu 2012-10-24 18:15:32 -0700 Created attachment 170530 Patch 750270 17 170530 jamesr 2012-10-24 18:19:02 -0700 Comment on attachment 170530 Patch Great, R=me 750425 18 170530 webkit.review.bot 2012-10-24 23:32:05 -0700 Comment on attachment 170530 Patch Clearing flags on attachment: 170530 Committed r132448: <http://trac.webkit.org/changeset/132448> 750426 19 webkit.review.bot 2012-10-24 23:32:09 -0700 All reviewed patches have been landed. Closing bug. 170005 2012-10-22 15:43:36 -0700 2012-10-22 15:57:01 -0700 Patch bug-100042-20121022154214.patch text/plain 1509 sheu U3VidmVyc2lvbiBSZXZpc2lvbjogMTMyMTQ0CmRpZmYgLS1naXQgYS9Tb3VyY2UvUGxhdGZvcm0v Q2hhbmdlTG9nIGIvU291cmNlL1BsYXRmb3JtL0NoYW5nZUxvZwppbmRleCA4ZGFlNWQ0OGI1NGRj YWVmOTY5MzI3NzgxODAxYTQzMGNjZDE5OTIwLi41YTA4NmM1ZjE0NTc4NWFlNDk2NDgyOGUxODNj M2ZkZWY3N2JkNjAzIDEwMDY0NAotLS0gYS9Tb3VyY2UvUGxhdGZvcm0vQ2hhbmdlTG9nCisrKyBi L1NvdXJjZS9QbGF0Zm9ybS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAxMi0xMC0yMiAg Sm9obiBTaGV1ICA8c2hldUBnb29nbGUuY29tPgorCisgICAgICAgIFtjaHJvbWl1bV0gQWRkIHRl eHR1cmVXaWR0aCgpIGFuZCB0ZXh0dXJlSGVpZ2h0KCkgdG8gV2ViVmlkZW9GcmFtZQorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTAwMDQyCisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkaXRpb25hbCBpbmZv cm1hdGlvbiBvZiB0aGUgY2hhbmdlIHN1Y2ggYXMgYXBwcm9hY2gsIHJhdGlvbmFsZS4gUGxlYXNl IGFkZCBwZXItZnVuY3Rpb24gZGVzY3JpcHRpb25zIGJlbG93IChPT1BTISkuCisKKyAgICAgICAg KiBjaHJvbWl1bS9wdWJsaWMvV2ViVmlkZW9GcmFtZS5oOgorICAgICAgICAoV2ViS2l0OjpXZWJW aWRlb0ZyYW1lOjp0ZXh0dXJlV2lkdGgpOgorICAgICAgICAoV2ViS2l0OjpXZWJWaWRlb0ZyYW1l Ojp0ZXh0dXJlSGVpZ2h0KToKKwogMjAxMi0xMC0yMiAgS2Vpc2hpIEhhdHRvcmkgIDxrZWlzaGlA d2Via2l0Lm9yZz4KIAogICAgICAgICBSZW1vdmUgbW9udGhGb3JtYXRJbkxETUwKZGlmZiAtLWdp dCBhL1NvdXJjZS9QbGF0Zm9ybS9jaHJvbWl1bS9wdWJsaWMvV2ViVmlkZW9GcmFtZS5oIGIvU291 cmNlL1BsYXRmb3JtL2Nocm9taXVtL3B1YmxpYy9XZWJWaWRlb0ZyYW1lLmgKaW5kZXggNzQ3OTli YjcxNzFjZjI2YmQ1NTc4ZTY0YTEzM2UxMTgyOWE2Mjk2NS4uZDhkNDVhYWE1ZTVlNTViZGNlNmE3 OTgyOGY1MjljZDc1MWVjM2E3OCAxMDA2NDQKLS0tIGEvU291cmNlL1BsYXRmb3JtL2Nocm9taXVt L3B1YmxpYy9XZWJWaWRlb0ZyYW1lLmgKKysrIGIvU291cmNlL1BsYXRmb3JtL2Nocm9taXVtL3B1 YmxpYy9XZWJWaWRlb0ZyYW1lLmgKQEAgLTY5LDYgKzY5LDggQEAgcHVibGljOgogICAgIHZpcnR1 YWwgY29uc3Qgdm9pZCogZGF0YSh1bnNpZ25lZCBwbGFuZSkgY29uc3QgeyByZXR1cm4gMDsgfQog ICAgIHZpcnR1YWwgdW5zaWduZWQgdGV4dHVyZUlkKCkgY29uc3QgeyByZXR1cm4gMDsgfQogICAg IHZpcnR1YWwgdW5zaWduZWQgdGV4dHVyZVRhcmdldCgpIGNvbnN0IHsgcmV0dXJuIDA7IH0KKyAg ICB2aXJ0dWFsIHVuc2lnbmVkIHRleHR1cmVXaWR0aCgpIGNvbnN0IHsgcmV0dXJuIDA7IH0KKyAg ICB2aXJ0dWFsIHVuc2lnbmVkIHRleHR1cmVIZWlnaHQoKSBjb25zdCB7IHJldHVybiAwOyB9CiB9 OwogCiB9IC8vIG5hbWVzcGFjZSBXZWJLaXQK 170009 2012-10-22 15:57:04 -0700 2012-10-24 15:40:50 -0700 Patch bug-100042-20121022155542.patch text/plain 1677 sheu U3VidmVyc2lvbiBSZXZpc2lvbjogMTMyMTQ0CmRpZmYgLS1naXQgYS9Tb3VyY2UvUGxhdGZvcm0v Q2hhbmdlTG9nIGIvU291cmNlL1BsYXRmb3JtL0NoYW5nZUxvZwppbmRleCA4ZGFlNWQ0OGI1NGRj YWVmOTY5MzI3NzgxODAxYTQzMGNjZDE5OTIwLi41YTUxNmI1YTEwZTE5NTAzOTM5ZTYyNzUzMmIw ZjNjNjcyM2RjNTljIDEwMDY0NAotLS0gYS9Tb3VyY2UvUGxhdGZvcm0vQ2hhbmdlTG9nCisrKyBi L1NvdXJjZS9QbGF0Zm9ybS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOSBAQAorMjAxMi0xMC0yMiAg Sm9obiBTaGV1ICA8c2hldUBnb29nbGUuY29tPgorCisgICAgICAgIFtjaHJvbWl1bV0gQWRkIHRl eHR1cmVXaWR0aCgpIGFuZCB0ZXh0dXJlSGVpZ2h0KCkgdG8gV2ViVmlkZW9GcmFtZQorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTAwMDQyCisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgSXQgbWlnaHQgYmUgdGhl IGNhc2UgdGhhdCB0aGUgdmlzaWJsZSBwb3J0aW9uIG9mIGEgdmlkZW8gZnJhbWUgaXNuJ3QgdGhl IGVudGlyZQorICAgICAgICB0ZXh0dXJlIHNpemUsIGUuZy4gZm9yIGNyb3BwaW5nLiAgV2UnbGwg bmVlZCBhY2Nlc3NvcnMgaW4gV2ViVmlkZW9GcmFtZSBmb3IKKyAgICAgICAgYm90aCB0aGUgdmlz aWJsZSBkaW1lbnNpb25zICh3aWR0aCgpL2hlaWdodCgpKSBhbmQgdGV4dHVyZSBkaW1lbnNpb25z CisgICAgICAgICh0ZXh0dXJlV2lkdGgoKS90ZXh0dXJlSGVpZ2h0KCkpCisKKyAgICAgICAgKiBj aHJvbWl1bS9wdWJsaWMvV2ViVmlkZW9GcmFtZS5oOgorICAgICAgICAoV2ViS2l0OjpXZWJWaWRl b0ZyYW1lOjp0ZXh0dXJlV2lkdGgpOgorICAgICAgICAoV2ViS2l0OjpXZWJWaWRlb0ZyYW1lOjp0 ZXh0dXJlSGVpZ2h0KToKKwogMjAxMi0xMC0yMiAgS2Vpc2hpIEhhdHRvcmkgIDxrZWlzaGlAd2Vi a2l0Lm9yZz4KIAogICAgICAgICBSZW1vdmUgbW9udGhGb3JtYXRJbkxETUwKZGlmZiAtLWdpdCBh L1NvdXJjZS9QbGF0Zm9ybS9jaHJvbWl1bS9wdWJsaWMvV2ViVmlkZW9GcmFtZS5oIGIvU291cmNl L1BsYXRmb3JtL2Nocm9taXVtL3B1YmxpYy9XZWJWaWRlb0ZyYW1lLmgKaW5kZXggNzQ3OTliYjcx NzFjZjI2YmQ1NTc4ZTY0YTEzM2UxMTgyOWE2Mjk2NS4uZDhkNDVhYWE1ZTVlNTViZGNlNmE3OTgy OGY1MjljZDc1MWVjM2E3OCAxMDA2NDQKLS0tIGEvU291cmNlL1BsYXRmb3JtL2Nocm9taXVtL3B1 YmxpYy9XZWJWaWRlb0ZyYW1lLmgKKysrIGIvU291cmNlL1BsYXRmb3JtL2Nocm9taXVtL3B1Ymxp Yy9XZWJWaWRlb0ZyYW1lLmgKQEAgLTY5LDYgKzY5LDggQEAgcHVibGljOgogICAgIHZpcnR1YWwg Y29uc3Qgdm9pZCogZGF0YSh1bnNpZ25lZCBwbGFuZSkgY29uc3QgeyByZXR1cm4gMDsgfQogICAg IHZpcnR1YWwgdW5zaWduZWQgdGV4dHVyZUlkKCkgY29uc3QgeyByZXR1cm4gMDsgfQogICAgIHZp cnR1YWwgdW5zaWduZWQgdGV4dHVyZVRhcmdldCgpIGNvbnN0IHsgcmV0dXJuIDA7IH0KKyAgICB2 aXJ0dWFsIHVuc2lnbmVkIHRleHR1cmVXaWR0aCgpIGNvbnN0IHsgcmV0dXJuIDA7IH0KKyAgICB2 aXJ0dWFsIHVuc2lnbmVkIHRleHR1cmVIZWlnaHQoKSBjb25zdCB7IHJldHVybiAwOyB9CiB9Owog CiB9IC8vIG5hbWVzcGFjZSBXZWJLaXQK 170491 2012-10-24 15:40:53 -0700 2012-10-24 17:46:10 -0700 Patch bug-100042-20121024153928.patch text/plain 2237 sheu U3VidmVyc2lvbiBSZXZpc2lvbjogMTMyMTQ0CmRpZmYgLS1naXQgYS9Tb3VyY2UvUGxhdGZvcm0v Q2hhbmdlTG9nIGIvU291cmNlL1BsYXRmb3JtL0NoYW5nZUxvZwppbmRleCA4ZGFlNWQ0OGI1NGRj YWVmOTY5MzI3NzgxODAxYTQzMGNjZDE5OTIwLi4zOGEwMGJkNTZlZDE4MjUwN2RmMDBhN2MyZDFl MWM5NGExY2U4Y2U5IDEwMDY0NAotLS0gYS9Tb3VyY2UvUGxhdGZvcm0vQ2hhbmdlTG9nCisrKyBi L1NvdXJjZS9QbGF0Zm9ybS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyNiBAQAorMjAxMi0xMC0yMiAg Sm9obiBTaGV1ICA8c2hldUBnb29nbGUuY29tPgorCisgICAgICAgIFtjaHJvbWl1bV0gQWRkIHRl eHR1cmVXaWR0aCgpIGFuZCB0ZXh0dXJlSGVpZ2h0KCkgdG8gV2ViVmlkZW9GcmFtZQorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTAwMDQyCisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgSXQgbWlnaHQgYmUgdGhl IGNhc2UgdGhhdCB0aGUgdmlzaWJsZSBwb3J0aW9uIG9mIGEgdmlkZW8gZnJhbWUgaXNuJ3QgdGhl CisgICAgICAgIGVudGlyZSB0ZXh0dXJlIHNpemUsIGUuZy4gZm9yIGNyb3BwaW5nLiAgV2UnbGwg bmVlZCBhY2Nlc3NvcnMgaW4KKyAgICAgICAgV2ViVmlkZW9GcmFtZSB0byBiZSBhYmxlIHRvIHF1 ZXJ5IGJvdGggdGhlIHVuZGVybHlpbmcgdGV4dHVyZSBkaW1lbnNpb25zCisgICAgICAgIGFuZCB0 aGUgc3VicmVjdCB3aGljaCBpcyBzdXBwb3NlZCB0byBiZSB2aXNpYmxlLgorCisgICAgICAgIFRo aXMgaXMgcHJlc2VudGx5IGEgbm8tb3AgY2hhbmdlLiAgT25jZSBDaHJvbWl1bSBjaGFuZ2VzIGFy ZSBpbiwgSSB3aWxsCisgICAgICAgIHJlbW92ZSB0aGUgc3VwZXJzZWRlZCBwYXJ0cyBvZiB0aGUg V2ViVmlkZW9GcmFtZSBpbnRlcmZjYWUuCisKKyAgICAgICAgKiBjaHJvbWl1bS9wdWJsaWMvV2Vi VmlkZW9GcmFtZS5oOgorICAgICAgICAoV2ViS2l0OjpXZWJWaWRlb0ZyYW1lOjp2aXNpYmxlWCk6 CisgICAgICAgIChXZWJLaXQ6OldlYlZpZGVvRnJhbWU6OnZpc2libGVZKToKKyAgICAgICAgKFdl YktpdDo6V2ViVmlkZW9GcmFtZTo6dmlzaWJsZVdpZHRoKToKKyAgICAgICAgKFdlYktpdDo6V2Vi VmlkZW9GcmFtZTo6dmlzaWJsZUhlaWdodCk6CisgICAgICAgIChXZWJLaXQ6OldlYlZpZGVvRnJh bWU6OnRleHR1cmVXaWR0aCk6CisgICAgICAgIChXZWJLaXQ6OldlYlZpZGVvRnJhbWU6OnRleHR1 cmVIZWlnaHQpOgorCiAyMDEyLTEwLTIyICBLZWlzaGkgSGF0dG9yaSAgPGtlaXNoaUB3ZWJraXQu b3JnPgogCiAgICAgICAgIFJlbW92ZSBtb250aEZvcm1hdEluTERNTApkaWZmIC0tZ2l0IGEvU291 cmNlL1BsYXRmb3JtL2Nocm9taXVtL3B1YmxpYy9XZWJWaWRlb0ZyYW1lLmggYi9Tb3VyY2UvUGxh dGZvcm0vY2hyb21pdW0vcHVibGljL1dlYlZpZGVvRnJhbWUuaAppbmRleCA3NDc5OWJiNzE3MWNm MjZiZDU1NzhlNjRhMTMzZTExODI5YTYyOTY1Li5jYzE1YzcwMjU4MzUzOTVjNDkzNjFlNTVhNTc3 Y2Y2MjZiZDFjZjM5IDEwMDY0NAotLS0gYS9Tb3VyY2UvUGxhdGZvcm0vY2hyb21pdW0vcHVibGlj L1dlYlZpZGVvRnJhbWUuaAorKysgYi9Tb3VyY2UvUGxhdGZvcm0vY2hyb21pdW0vcHVibGljL1dl YlZpZGVvRnJhbWUuaApAQCAtNjksNiArNjksMTIgQEAgcHVibGljOgogICAgIHZpcnR1YWwgY29u c3Qgdm9pZCogZGF0YSh1bnNpZ25lZCBwbGFuZSkgY29uc3QgeyByZXR1cm4gMDsgfQogICAgIHZp cnR1YWwgdW5zaWduZWQgdGV4dHVyZUlkKCkgY29uc3QgeyByZXR1cm4gMDsgfQogICAgIHZpcnR1 YWwgdW5zaWduZWQgdGV4dHVyZVRhcmdldCgpIGNvbnN0IHsgcmV0dXJuIDA7IH0KKyAgICB2aXJ0 dWFsIHVuc2lnbmVkIHZpc2libGVYKCkgY29uc3QgeyByZXR1cm4gMDsgfQorICAgIHZpcnR1YWwg dW5zaWduZWQgdmlzaWJsZVkoKSBjb25zdCB7IHJldHVybiAwOyB9CisgICAgdmlydHVhbCB1bnNp Z25lZCB2aXNpYmxlV2lkdGgoKSBjb25zdCB7IHJldHVybiAwOyB9CisgICAgdmlydHVhbCB1bnNp Z25lZCB2aXNpYmxlSGVpZ2h0KCkgY29uc3QgeyByZXR1cm4gMDsgfQorICAgIHZpcnR1YWwgdW5z aWduZWQgdGV4dHVyZVdpZHRoKCkgY29uc3QgeyByZXR1cm4gMDsgfQorICAgIHZpcnR1YWwgdW5z aWduZWQgdGV4dHVyZUhlaWdodCgpIGNvbnN0IHsgcmV0dXJuIDA7IH0KIH07CiAKIH0gLy8gbmFt ZXNwYWNlIFdlYktpdAo= 170523 2012-10-24 17:46:13 -0700 2012-10-24 18:15:29 -0700 Patch bug-100042-20121024174448.patch text/plain 1870 sheu U3VidmVyc2lvbiBSZXZpc2lvbjogMTMyMTQ0CmRpZmYgLS1naXQgYS9Tb3VyY2UvUGxhdGZvcm0v Q2hhbmdlTG9nIGIvU291cmNlL1BsYXRmb3JtL0NoYW5nZUxvZwppbmRleCA4ZGFlNWQ0OGI1NGRj YWVmOTY5MzI3NzgxODAxYTQzMGNjZDE5OTIwLi5lYTFlNmVjNDM5ZTU1ODU1ZWQ2MTRkMmZmMjhj ZjMyOGE0MjI5NDRjIDEwMDY0NAotLS0gYS9Tb3VyY2UvUGxhdGZvcm0vQ2hhbmdlTG9nCisrKyBi L1NvdXJjZS9QbGF0Zm9ybS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMiBAQAorMjAxMi0xMC0yMiAg Sm9obiBTaGV1ICA8c2hldUBnb29nbGUuY29tPgorCisgICAgICAgIFtjaHJvbWl1bV0gQWRkIHRl eHR1cmVXaWR0aCgpIGFuZCB0ZXh0dXJlSGVpZ2h0KCkgdG8gV2ViVmlkZW9GcmFtZQorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTAwMDQyCisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgSXQgbWlnaHQgYmUgdGhl IGNhc2UgdGhhdCB0aGUgdmlzaWJsZSBwb3J0aW9uIG9mIGEgdmlkZW8gZnJhbWUgaXNuJ3QgdGhl CisgICAgICAgIGVudGlyZSB0ZXh0dXJlIHNpemUsIGUuZy4gZm9yIGNyb3BwaW5nLiAgV2UnbGwg bmVlZCBhY2Nlc3NvcnMgaW4KKyAgICAgICAgV2ViVmlkZW9GcmFtZSB0byBiZSBhYmxlIHRvIHF1 ZXJ5IGJvdGggdGhlIHVuZGVybHlpbmcgdGV4dHVyZSBkaW1lbnNpb25zCisgICAgICAgIGFuZCB0 aGUgc3VicmVjdCB3aGljaCBpcyBzdXBwb3NlZCB0byBiZSB2aXNpYmxlLgorCisgICAgICAgIFRo aXMgaXMgcHJlc2VudGx5IGEgbm8tb3AgY2hhbmdlLiAgT25jZSBDaHJvbWl1bSBjaGFuZ2VzIGFy ZSBpbiwgSSB3aWxsCisgICAgICAgIHJlbW92ZSB0aGUgc3VwZXJzZWRlZCBwYXJ0cyBvZiB0aGUg V2ViVmlkZW9GcmFtZSBpbnRlcmZhY2UuCisKKyAgICAgICAgKiBjaHJvbWl1bS9wdWJsaWMvV2Vi VmlkZW9GcmFtZS5oOgorICAgICAgICAoV2ViS2l0OjpXZWJWaWRlb0ZyYW1lOjp2aXNpYmxlUmVj dCk6CisgICAgICAgIChXZWJLaXQ6OldlYlZpZGVvRnJhbWU6OnRleHR1cmVTaXplKToKKwogMjAx Mi0xMC0yMiAgS2Vpc2hpIEhhdHRvcmkgIDxrZWlzaGlAd2Via2l0Lm9yZz4KIAogICAgICAgICBS ZW1vdmUgbW9udGhGb3JtYXRJbkxETUwKZGlmZiAtLWdpdCBhL1NvdXJjZS9QbGF0Zm9ybS9jaHJv bWl1bS9wdWJsaWMvV2ViVmlkZW9GcmFtZS5oIGIvU291cmNlL1BsYXRmb3JtL2Nocm9taXVtL3B1 YmxpYy9XZWJWaWRlb0ZyYW1lLmgKaW5kZXggNzQ3OTliYjcxNzFjZjI2YmQ1NTc4ZTY0YTEzM2Ux MTgyOWE2Mjk2NS4uN2U3MWE0MWIwZTRiYjczNDg4ZjJjMmFmZDUwZDE5MjFlNDRmMTRhNSAxMDA2 NDQKLS0tIGEvU291cmNlL1BsYXRmb3JtL2Nocm9taXVtL3B1YmxpYy9XZWJWaWRlb0ZyYW1lLmgK KysrIGIvU291cmNlL1BsYXRmb3JtL2Nocm9taXVtL3B1YmxpYy9XZWJWaWRlb0ZyYW1lLmgKQEAg LTY5LDYgKzY5LDggQEAgcHVibGljOgogICAgIHZpcnR1YWwgY29uc3Qgdm9pZCogZGF0YSh1bnNp Z25lZCBwbGFuZSkgY29uc3QgeyByZXR1cm4gMDsgfQogICAgIHZpcnR1YWwgdW5zaWduZWQgdGV4 dHVyZUlkKCkgY29uc3QgeyByZXR1cm4gMDsgfQogICAgIHZpcnR1YWwgdW5zaWduZWQgdGV4dHVy ZVRhcmdldCgpIGNvbnN0IHsgcmV0dXJuIDA7IH0KKyAgICB2aXJ0dWFsIFdlYktpdDo6V2ViUmVj dCB2aXNpYmxlUmVjdCgpIGNvbnN0IHsgcmV0dXJuIFdlYktpdDo6V2ViUmVjdCgpOyB9CisgICAg dmlydHVhbCBXZWJLaXQ6OldlYlNpemUgdGV4dHVyZVNpemUoKSBjb25zdCB7IHJldHVybiBXZWJL aXQ6OldlYlNpemUoKTsgfQogfTsKIAogfSAvLyBuYW1lc3BhY2UgV2ViS2l0Cg== 170530 2012-10-24 18:15:32 -0700 2012-10-24 23:32:04 -0700 Patch bug-100042-20121024181407.patch text/plain 2085 sheu U3VidmVyc2lvbiBSZXZpc2lvbjogMTMyMTQ0CmRpZmYgLS1naXQgYS9Tb3VyY2UvUGxhdGZvcm0v Q2hhbmdlTG9nIGIvU291cmNlL1BsYXRmb3JtL0NoYW5nZUxvZwppbmRleCA4ZGFlNWQ0OGI1NGRj YWVmOTY5MzI3NzgxODAxYTQzMGNjZDE5OTIwLi44YTIzMWEyNmM2MWYwM2Y3ZDZmZjAwNjg1ODMx ZGY4ZTA5ZWM2NWY0IDEwMDY0NAotLS0gYS9Tb3VyY2UvUGxhdGZvcm0vQ2hhbmdlTG9nCisrKyBi L1NvdXJjZS9QbGF0Zm9ybS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMiBAQAorMjAxMi0xMC0yMiAg Sm9obiBTaGV1ICA8c2hldUBnb29nbGUuY29tPgorCisgICAgICAgIFtjaHJvbWl1bV0gQWRkIHRl eHR1cmVXaWR0aCgpIGFuZCB0ZXh0dXJlSGVpZ2h0KCkgdG8gV2ViVmlkZW9GcmFtZQorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTAwMDQyCisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgSXQgbWlnaHQgYmUgdGhl IGNhc2UgdGhhdCB0aGUgdmlzaWJsZSBwb3J0aW9uIG9mIGEgdmlkZW8gZnJhbWUgaXNuJ3QgdGhl CisgICAgICAgIGVudGlyZSB0ZXh0dXJlIHNpemUsIGUuZy4gZm9yIGNyb3BwaW5nLiAgV2UnbGwg bmVlZCBhY2Nlc3NvcnMgaW4KKyAgICAgICAgV2ViVmlkZW9GcmFtZSB0byBiZSBhYmxlIHRvIHF1 ZXJ5IGJvdGggdGhlIHVuZGVybHlpbmcgdGV4dHVyZSBkaW1lbnNpb25zCisgICAgICAgIGFuZCB0 aGUgc3VicmVjdCB3aGljaCBpcyBzdXBwb3NlZCB0byBiZSB2aXNpYmxlLgorCisgICAgICAgIFRo aXMgaXMgcHJlc2VudGx5IGEgbm8tb3AgY2hhbmdlLiAgT25jZSBDaHJvbWl1bSBjaGFuZ2VzIGFy ZSBpbiwgSSB3aWxsCisgICAgICAgIHJlbW92ZSB0aGUgc3VwZXJzZWRlZCBwYXJ0cyBvZiB0aGUg V2ViVmlkZW9GcmFtZSBpbnRlcmZhY2UuCisKKyAgICAgICAgKiBjaHJvbWl1bS9wdWJsaWMvV2Vi VmlkZW9GcmFtZS5oOgorICAgICAgICAoV2ViS2l0OjpXZWJWaWRlb0ZyYW1lOjp2aXNpYmxlUmVj dCk7CisgICAgICAgIChXZWJLaXQ6OldlYlZpZGVvRnJhbWU6OnRleHR1cmVTaXplKTsKKwogMjAx Mi0xMC0yMiAgS2Vpc2hpIEhhdHRvcmkgIDxrZWlzaGlAd2Via2l0Lm9yZz4KIAogICAgICAgICBS ZW1vdmUgbW9udGhGb3JtYXRJbkxETUwKZGlmZiAtLWdpdCBhL1NvdXJjZS9QbGF0Zm9ybS9jaHJv bWl1bS9wdWJsaWMvV2ViVmlkZW9GcmFtZS5oIGIvU291cmNlL1BsYXRmb3JtL2Nocm9taXVtL3B1 YmxpYy9XZWJWaWRlb0ZyYW1lLmgKaW5kZXggNzQ3OTliYjcxNzFjZjI2YmQ1NTc4ZTY0YTEzM2Ux MTgyOWE2Mjk2NS4uOTA4MDA5NTkxMTllMWNiMjg4NWNhYmUyYzQyOGFkN2NjMWI5ODNmMSAxMDA2 NDQKLS0tIGEvU291cmNlL1BsYXRmb3JtL2Nocm9taXVtL3B1YmxpYy9XZWJWaWRlb0ZyYW1lLmgK KysrIGIvU291cmNlL1BsYXRmb3JtL2Nocm9taXVtL3B1YmxpYy9XZWJWaWRlb0ZyYW1lLmgKQEAg LTMxLDYgKzMxLDkgQEAKICNpZm5kZWYgV2ViVmlkZW9GcmFtZV9oCiAjZGVmaW5lIFdlYlZpZGVv RnJhbWVfaAogCisjaW5jbHVkZSAiV2ViUmVjdC5oIgorI2luY2x1ZGUgIldlYlNpemUuaCIKKwog bmFtZXNwYWNlIFdlYktpdCB7CiAKIC8vIEEgcHJveHkgdmlkZW8gZnJhbWUgaW50ZXJmYWNlIHRv IGNvbW11bmljYXRlIGZyYW1lIGRhdGEgYmV0d2VlbiBjaHJvbWl1bQpAQCAtNjksNiArNzIsOCBA QCBwdWJsaWM6CiAgICAgdmlydHVhbCBjb25zdCB2b2lkKiBkYXRhKHVuc2lnbmVkIHBsYW5lKSBj b25zdCB7IHJldHVybiAwOyB9CiAgICAgdmlydHVhbCB1bnNpZ25lZCB0ZXh0dXJlSWQoKSBjb25z dCB7IHJldHVybiAwOyB9CiAgICAgdmlydHVhbCB1bnNpZ25lZCB0ZXh0dXJlVGFyZ2V0KCkgY29u c3QgeyByZXR1cm4gMDsgfQorICAgIHZpcnR1YWwgV2ViS2l0OjpXZWJSZWN0IHZpc2libGVSZWN0 KCkgY29uc3QgeyByZXR1cm4gV2ViS2l0OjpXZWJSZWN0KCk7IH0KKyAgICB2aXJ0dWFsIFdlYktp dDo6V2ViU2l6ZSB0ZXh0dXJlU2l6ZSgpIGNvbnN0IHsgcmV0dXJuIFdlYktpdDo6V2ViU2l6ZSgp OyB9CiB9OwogCiB9IC8vIG5hbWVzcGFjZSBXZWJLaXQK