100033 2012-10-22 14:39:12 -0700 [V8] Enumerate Nodes via the V8 heap rather than via a list in WebCore 2012-10-23 10:34:54 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 97974 1 abarth abarth eric haraken japhet ojan webkit.review.bot oldest_to_newest 747900 0 abarth 2012-10-22 14:39:12 -0700 [V8] Enumerate Nodes via the V8 heap rather than via a list in WebCore 747902 1 169989 abarth 2012-10-22 14:40:32 -0700 Created attachment 169989 Patch 747913 2 169989 eric 2012-10-22 14:45:14 -0700 Comment on attachment 169989 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=169989&action=review LGTM. You may wish to have Kentaro look too, as he's undoubtably more versed in this than I. > Source/WebCore/bindings/v8/V8DOMMap.cpp:119 > + v8::Persistent<v8::Object> wrapper = v8::Persistent<v8::Object>::Cast(value); I assume this ASSERTs, etc. that this is an Object? 747925 3 abarth 2012-10-22 14:54:08 -0700 Performance results in https://bugs.webkit.org/show_bug.cgi?id=97974#c24 747948 4 169989 abarth 2012-10-22 15:14:56 -0700 Comment on attachment 169989 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=169989&action=review >> Source/WebCore/bindings/v8/V8DOMMap.cpp:119 >> + ASSERT(V8Node::HasInstance(value)); >> + ASSERT(value->IsObject()); >> + ASSERT(!value.IsIndependent()); >> + v8::Persistent<v8::Object> wrapper = v8::Persistent<v8::Object>::Cast(value); > > I assume this ASSERTs, etc. that this is an Object? It doesn't, but that's why I have the ASSERT on line 117. :) 748315 5 169989 haraken 2012-10-23 00:08:20 -0700 Comment on attachment 169989 Patch LGTM. 748778 6 169989 webkit.review.bot 2012-10-23 10:34:50 -0700 Comment on attachment 169989 Patch Clearing flags on attachment: 169989 Committed r132242: <http://trac.webkit.org/changeset/132242> 748779 7 webkit.review.bot 2012-10-23 10:34:54 -0700 All reviewed patches have been landed. Closing bug. 169989 2012-10-22 14:40:32 -0700 2012-10-23 10:34:50 -0700 Patch bug-100033-20121022143910.patch text/plain 15153 abarth U3VidmVyc2lvbiBSZXZpc2lvbjogMTMyMTE2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNjhhMTFlNjJmYTQxYzA0 YTBkMTMyNjRiMGFjMzljZDgzNzU0YWZjYS4uOTNlNDgzMmJiNDliNzI2NmEyZDMxNzYzYjI1ZTYy N2RhYTYwZjM5OCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDQ5IEBACisyMDEyLTEwLTIyICBBZGFt IEJhcnRoICA8YWJhcnRoQHdlYmtpdC5vcmc+CisKKyAgICAgICAgW1Y4XSBFbnVtZXJhdGUgTm9k ZXMgdmlhIHRoZSBWOCBoZWFwIHJhdGhlciB0aGFuIHZpYSBhIGxpc3QgaW4gV2ViQ29yZQorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTAwMDMzCisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhpcyBwYXRjaCBj aGFuZ2VzIGhvdyB3ZSBlbnVtZXJhdGUgbm9kZXMgZHVyaW5nIGdhcmJhZ2UgY29sbGVjdGlvbi4K KyAgICAgICAgQWZ0ZXIgdGhpcyBwYXRjaCwgd2UgdXNlIFY4J3MgbGlzdCBvZiBvcGVuIGhhbmRs ZXMgdG8gZW51bWVyYXRlIG5vZGUKKyAgICAgICAgd3JhcHBlcnMgcmF0aGVyIHRoYW4gdXNpbmcg YSBzZXBhcmF0ZSBsaXN0IHRoYXQgd2UgbWFpbnRhaW4gaW4gV2ViQ29yZQorICAgICAgICBmb3Ig dGhpcyBwdXJwb3NlLiBBIGZ1dHVyZSBwYXRjaCB3aWxsIHJlbW92ZSB0aGUgbGlzdCBpbiBXZWJD b3JlIGZvciBhCisgICAgICAgIERPTSBwZXJmb3JtYW5jZSBnYWluLgorCisgICAgICAgICogYmlu ZGluZ3MvanMvU2NyaXB0UHJvZmlsZXIuaDoKKyAgICAgICAgKFdlYkNvcmUpOgorICAgICAgICAo V2ViQ29yZTo6U2NyaXB0UHJvZmlsZXI6OnZpc2l0Tm9kZVdyYXBwZXJzKToKKyAgICAgICAgKiBi aW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JWOC5wbToKKyAgICAgICAgKEdlbmVyYXRlVG9W OENvbnZlcnRlcnMpOgorICAgICAgICAqIGJpbmRpbmdzL3NjcmlwdHMvdGVzdC9WOC9WOFRlc3RO b2RlLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlY4VGVzdE5vZGU6OndyYXBTbG93KToKKyAgICAg ICAgKiBiaW5kaW5ncy92OC9JbnRydXNpdmVET01XcmFwcGVyTWFwLmg6CisgICAgICAgIChXZWJD b3JlOjpJbnRydXNpdmVET01XcmFwcGVyTWFwOjpzZXQpOgorICAgICAgICAqIGJpbmRpbmdzL3Y4 L1NjcmlwdFByb2ZpbGVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlNjcmlwdFByb2ZpbGVyOjp2 aXNpdE5vZGVXcmFwcGVycyk6CisgICAgICAgICogYmluZGluZ3MvdjgvU2NyaXB0UHJvZmlsZXIu aDoKKyAgICAgICAgKFdlYkNvcmUpOgorICAgICAgICAoU2NyaXB0UHJvZmlsZXIpOgorICAgICAg ICAqIGJpbmRpbmdzL3Y4L1Y4RE9NTWFwLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6Ok5vZGVXcmFw cGVyVmlzaXRvcjo6fk5vZGVXcmFwcGVyVmlzaXRvcik6CisgICAgICAgIChXZWJDb3JlKToKKyAg ICAgICAgKFdlYkNvcmU6OnZpc2l0QWxsRE9NTm9kZXMpOgorICAgICAgICAqIGJpbmRpbmdzL3Y4 L1Y4RE9NTWFwLmg6CisgICAgICAgIChXZWJDb3JlKToKKyAgICAgICAgKE5vZGVXcmFwcGVyVmlz aXRvcik6CisgICAgICAgICogYmluZGluZ3MvdjgvVjhET01XcmFwcGVyLmNwcDoKKyAgICAgICAg KFdlYkNvcmU6OlY4RE9NV3JhcHBlcjo6c2V0SlNXcmFwcGVyRm9yRE9NTm9kZSk6CisgICAgICAg IChXZWJDb3JlOjpWOERPTVdyYXBwZXI6OnNldEpTV3JhcHBlckZvckFjdGl2ZURPTU5vZGUpOgor ICAgICAgICAqIGJpbmRpbmdzL3Y4L1Y4R0NDb250cm9sbGVyLmNwcDoKKyAgICAgICAgKFdlYkNv cmU6Ok5vZGVWaXNpdG9yOjp2aXNpdE5vZGVXcmFwcGVyKToKKyAgICAgICAgKFdlYkNvcmU6OlY4 R0NDb250cm9sbGVyOjpnY1Byb2xvZ3VlKToKKyAgICAgICAgKFdlYkNvcmU6OlY4R0NDb250cm9s bGVyOjpnY0VwaWxvZ3VlKToKKyAgICAgICAgKiBpbnNwZWN0b3IvQmluZGluZ1Zpc2l0b3JzLmg6 CisgICAgICAgIChXZWJDb3JlOjpXcmFwcGVkTm9kZVZpc2l0b3I6On5XcmFwcGVkTm9kZVZpc2l0 b3IpOgorICAgICAgICAqIGluc3BlY3Rvci9JbnNwZWN0b3JNZW1vcnlBZ2VudC5jcHA6CisgICAg ICAgIChXZWJDb3JlKToKKwogMjAxMi0xMC0yMiAgTWljaGFlbCBTYWJvZmYgIDxtc2Fib2ZmQGFw cGxlLmNvbT4KIAogICAgICAgICByMTMxOTU1IGlzIGhhcyBpbXByb3BlciBmdW5jdGlvbiBjYWxs IGluIExpbmtIYXNoQ2hyb21pdW0uY3BwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9iaW5k aW5ncy9qcy9TY3JpcHRQcm9maWxlci5oIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvanMvU2Ny aXB0UHJvZmlsZXIuaAppbmRleCAxOWRjMTkyNzdhOTlkZDRjMzY3MzFhMzk3YWZiYWY5N2U2MzAz NGRlLi5jZTQ4NzBlMmZjMWMwOWQwNDNkNTBkNTYxYjU4OTNjODU3NmY2ZGEyIDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9qcy9TY3JpcHRQcm9maWxlci5oCisrKyBiL1NvdXJj ZS9XZWJDb3JlL2JpbmRpbmdzL2pzL1NjcmlwdFByb2ZpbGVyLmgKQEAgLTM4LDcgKzM4LDcgQEAg bmFtZXNwYWNlIFdlYkNvcmUgewogCiBjbGFzcyBFeHRlcm5hbEFycmF5VmlzaXRvcjsKIGNsYXNz IEV4dGVybmFsU3RyaW5nVmlzaXRvcjsKLWNsYXNzIE5vZGVXcmFwcGVyVmlzaXRvcjsKK2NsYXNz IFdyYXBwZWROb2RlVmlzaXRvcjsKIGNsYXNzIFBhZ2U7CiBjbGFzcyBTY3JpcHRPYmplY3Q7CiBj bGFzcyBTY3JpcHRWYWx1ZTsKQEAgLTc0LDcgKzc0LDcgQEAgcHVibGljOgogICAgIHN0YXRpYyBi b29sIGlzU2FtcGxpbmcoKSB7IHJldHVybiBmYWxzZTsgfQogICAgIHN0YXRpYyBib29sIGhhc0hl YXBQcm9maWxlcigpIHsgcmV0dXJuIGZhbHNlOyB9CiAgICAgLy8gRklYTUU6IEltcGxlbWVudCB0 aGlzIGNvdW50ZXIgZm9yIEpTQy4gU2VlIGJ1ZyA3MzkzNiBmb3IgbW9yZSBkZXRhaWxzLgotICAg IHN0YXRpYyB2b2lkIHZpc2l0Tm9kZVdyYXBwZXJzKE5vZGVXcmFwcGVyVmlzaXRvciopIHsgfQor ICAgIHN0YXRpYyB2b2lkIHZpc2l0Tm9kZVdyYXBwZXJzKFdyYXBwZWROb2RlVmlzaXRvciopIHsg fQogICAgIC8vIEZJWE1FOiBTdXBwb3J0IHRoZXNlIG1ldGhvZHMgZm9yIEpTQy4gU2VlIGJ1ZyA5 MDM1OC4KICAgICBzdGF0aWMgdm9pZCB2aXNpdEV4dGVybmFsU3RyaW5ncyhFeHRlcm5hbFN0cmlu Z1Zpc2l0b3IqKSB7IH0KICAgICBzdGF0aWMgdm9pZCB2aXNpdEV4dGVybmFsQXJyYXlzKEV4dGVy bmFsQXJyYXlWaXNpdG9yKikgeyB9CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5n cy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JWOC5wbSBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Nj cmlwdHMvQ29kZUdlbmVyYXRvclY4LnBtCmluZGV4IGE5MDMwNmNkNGM3ZTcxMmZhNzQ2NzhlY2Nm OGFiN2Y5NTk1NDRmZTUuLjg1YjhiMDFkMzllOTNmOTUxNGY0NGI2MjM0YjVhNjQxMDBjNDVhYmMg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRv clY4LnBtCisrKyBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRv clY4LnBtCkBAIC0zNDU2LDE5ICszNDU2LDkgQEAgRU5ECiAgICAgICAgIHJldHVybiB3cmFwcGVy OwogCiAgICAgaW5zdGFsbFBlckNvbnRleHRQcm9wZXJ0aWVzKHdyYXBwZXIsIGltcGwuZ2V0KCkp OwotRU5ECi0KLSAgICBwdXNoKEBpbXBsQ29udGVudCwgPDxFTkQpOwogICAgIHY4OjpQZXJzaXN0 ZW50PHY4OjpPYmplY3Q+IHdyYXBwZXJIYW5kbGUgPSBWOERPTVdyYXBwZXI6OnNldEpTV3JhcHBl ckZvciR7ZG9tTWFwTmFtZX0oaW1wbCwgd3JhcHBlciwgaXNvbGF0ZSk7CiAgICAgaWYgKCFoYXNE ZXBlbmRlbnRMaWZldGltZSkKICAgICAgICAgd3JhcHBlckhhbmRsZS5NYXJrSW5kZXBlbmRlbnQo KTsKLUVORAotICAgIGlmIChJc05vZGVTdWJUeXBlKCRkYXRhTm9kZSkpIHsKLSAgICAgICAgcHVz aChAaW1wbENvbnRlbnQsIDw8RU5EKTsKLSAgICB3cmFwcGVySGFuZGxlLlNldFdyYXBwZXJDbGFz c0lkKHY4RE9NU3VidHJlZUNsYXNzSWQpOwotRU5ECi0gICAgfQotICAgIHB1c2goQGltcGxDb250 ZW50LCA8PEVORCk7CiAgICAgcmV0dXJuIHdyYXBwZXI7CiB9CiBFTkQKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvdGVzdC9WOC9WOFRlc3ROb2RlLmNwcCBiL1Nv dXJjZS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvdGVzdC9WOC9WOFRlc3ROb2RlLmNwcAppbmRl eCA4OWJmZWRjNDdhYzhlMDkzN2UzYzJmMjRjNjA0ZDU1ZDA4MzlkNWFkLi5hNWRlNGI2M2E3NDlm NTk4ODZhNzU0NGI5YzIxZjJkNTljM2NmMTYwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9i aW5kaW5ncy9zY3JpcHRzL3Rlc3QvVjgvVjhUZXN0Tm9kZS5jcHAKKysrIGIvU291cmNlL1dlYkNv cmUvYmluZGluZ3Mvc2NyaXB0cy90ZXN0L1Y4L1Y4VGVzdE5vZGUuY3BwCkBAIC0xMzgsNyArMTM4 LDYgQEAgdjg6OkhhbmRsZTx2ODo6T2JqZWN0PiBWOFRlc3ROb2RlOjp3cmFwU2xvdyhQYXNzUmVm UHRyPFRlc3ROb2RlPiBpbXBsLCB2ODo6SGFuZGwKICAgICB2ODo6UGVyc2lzdGVudDx2ODo6T2Jq ZWN0PiB3cmFwcGVySGFuZGxlID0gVjhET01XcmFwcGVyOjpzZXRKU1dyYXBwZXJGb3JET01Ob2Rl KGltcGwsIHdyYXBwZXIsIGlzb2xhdGUpOwogICAgIGlmICghaGFzRGVwZW5kZW50TGlmZXRpbWUp CiAgICAgICAgIHdyYXBwZXJIYW5kbGUuTWFya0luZGVwZW5kZW50KCk7Ci0gICAgd3JhcHBlckhh bmRsZS5TZXRXcmFwcGVyQ2xhc3NJZCh2OERPTVN1YnRyZWVDbGFzc0lkKTsKICAgICByZXR1cm4g d3JhcHBlcjsKIH0KIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvSW50 cnVzaXZlRE9NV3JhcHBlck1hcC5oIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvSW50cnVz aXZlRE9NV3JhcHBlck1hcC5oCmluZGV4IGFlMjBkMDM2OWIzNDEwM2EyODM0NTgzMGRhYjlmYjdj OGQ0YmFmZDAuLjY3NjA1MGFkNWQ1MTAxOWQ5OTYzNTFlNmIzZGQwNjExMTZmM2RiNWUgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L0ludHJ1c2l2ZURPTVdyYXBwZXJNYXAu aAorKysgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9JbnRydXNpdmVET01XcmFwcGVyTWFw LmgKQEAgLTE0OSw2ICsxNDksNyBAQCBwdWJsaWM6CiAgICAgewogICAgICAgICBBU1NFUlQob2Jq KTsKICAgICAgICAgQVNTRVJUKCFvYmotPndyYXBwZXIoKSk7CisgICAgICAgIEFTU0VSVCh3cmFw cGVyLldyYXBwZXJDbGFzc0lkKCkgPT0gdjhET01TdWJ0cmVlQ2xhc3NJZCk7CiAgICAgICAgIHY4 OjpQZXJzaXN0ZW50PHY4OjpPYmplY3Q+KiBlbnRyeSA9IG1fdGFibGUuYWRkKHdyYXBwZXIpOwog ICAgICAgICBvYmotPnNldFdyYXBwZXIoZW50cnkpOwogICAgICAgICB3cmFwcGVyLk1ha2VXZWFr KG9iaiwgd2Vha1JlZmVyZW5jZUNhbGxiYWNrKCkpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv cmUvYmluZGluZ3MvdjgvU2NyaXB0UHJvZmlsZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvYmluZGlu Z3MvdjgvU2NyaXB0UHJvZmlsZXIuY3BwCmluZGV4IDAxODY4MzlhNzEwMWI1MDg2OWYwN2Q2OTRk MmMyZmYxNTQ4Njc0ZGQuLmI1MzkyOWE5YmQ0OTUwZmE3ZTIxZjQ2YWM0OTUzNjE5MDVmMTIyYTgg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1NjcmlwdFByb2ZpbGVyLmNw cAorKysgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9TY3JpcHRQcm9maWxlci5jcHAKQEAg LTE3NywyMCArMTc3LDI1IEBAIHZvaWQgU2NyaXB0UHJvZmlsZXI6OmluaXRpYWxpemUoKQogICAg IHY4OjpIZWFwUHJvZmlsZXI6OkRlZmluZVdyYXBwZXJDbGFzcyh2OERPTVN1YnRyZWVDbGFzc0lk LCAmcmV0YWluZWRET01JbmZvKTsKIH0KIAotdm9pZCBTY3JpcHRQcm9maWxlcjo6dmlzaXROb2Rl V3JhcHBlcnMoTm9kZVdyYXBwZXJWaXNpdG9yKiB2aXNpdG9yKQordm9pZCBTY3JpcHRQcm9maWxl cjo6dmlzaXROb2RlV3JhcHBlcnMoV3JhcHBlZE5vZGVWaXNpdG9yKiB2aXNpdG9yKQogewotICAg IGNsYXNzIFZpc2l0b3JBZGFwdGVyIDogcHVibGljIERPTVdyYXBwZXJNYXA8Tm9kZT46OlZpc2l0 b3IgeworICAgIGNsYXNzIFZpc2l0b3JBZGFwdGVyIDogcHVibGljIE5vZGVXcmFwcGVyVmlzaXRv ciB7CiAgICAgcHVibGljOgotICAgICAgICBWaXNpdG9yQWRhcHRlcihOb2RlV3JhcHBlclZpc2l0 b3IqIHZpc2l0b3IpIDogbV92aXNpdG9yKHZpc2l0b3IpIHsgfQorICAgICAgICBWaXNpdG9yQWRh cHRlcihXcmFwcGVkTm9kZVZpc2l0b3IqIHZpc2l0b3IpCisgICAgICAgICAgICA6IG1fdmlzaXRv cih2aXNpdG9yKQorICAgICAgICB7CisgICAgICAgIH0KIAotICAgICAgICB2aXJ0dWFsIHZvaWQg dmlzaXRET01XcmFwcGVyKERPTURhdGFTdG9yZSosIE5vZGUqIG5vZGUsIHY4OjpQZXJzaXN0ZW50 PHY4OjpPYmplY3Q+KQorICAgICAgICB2aXJ0dWFsIHZvaWQgdmlzaXROb2RlV3JhcHBlcihOb2Rl KiBub2RlLCB2ODo6UGVyc2lzdGVudDx2ODo6T2JqZWN0PikKICAgICAgICAgewogICAgICAgICAg ICAgbV92aXNpdG9yLT52aXNpdE5vZGUobm9kZSk7CiAgICAgICAgIH0KKwogICAgIHByaXZhdGU6 Ci0gICAgICAgIE5vZGVXcmFwcGVyVmlzaXRvciogbV92aXNpdG9yOworICAgICAgICBXcmFwcGVk Tm9kZVZpc2l0b3IqIG1fdmlzaXRvcjsKICAgICB9IGFkYXB0ZXIodmlzaXRvcik7Ci0gICAgdmlz aXRET01Ob2RlcygmYWRhcHRlcik7CisKKyAgICB2aXNpdEFsbERPTU5vZGVzKCZhZGFwdGVyKTsK IH0KIAogdm9pZCBTY3JpcHRQcm9maWxlcjo6dmlzaXRFeHRlcm5hbFN0cmluZ3MoRXh0ZXJuYWxT dHJpbmdWaXNpdG9yKiB2aXNpdG9yKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvYmluZGlu Z3MvdjgvU2NyaXB0UHJvZmlsZXIuaCBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1Njcmlw dFByb2ZpbGVyLmgKaW5kZXggNzZhNGYyYTQ4OTM4YzAzNTEyYjdkMDIzMDM1NGY0NzY1Y2YwMTg1 Yy4uZjg0NTk0MWE4NmYzNzk5M2FmOTUzMTJkYjdmMWQzYzM4M2E2MDkwMyAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvU2NyaXB0UHJvZmlsZXIuaAorKysgYi9Tb3VyY2Uv V2ViQ29yZS9iaW5kaW5ncy92OC9TY3JpcHRQcm9maWxlci5oCkBAIC00Myw3ICs0Myw3IEBAIG5h bWVzcGFjZSBXZWJDb3JlIHsKIAogY2xhc3MgRXh0ZXJuYWxBcnJheVZpc2l0b3I7CiBjbGFzcyBF eHRlcm5hbFN0cmluZ1Zpc2l0b3I7Ci1jbGFzcyBOb2RlV3JhcHBlclZpc2l0b3I7CitjbGFzcyBX cmFwcGVkTm9kZVZpc2l0b3I7CiBjbGFzcyBQYWdlOwogY2xhc3MgU2NyaXB0T2JqZWN0OwogY2xh c3MgU2NyaXB0VmFsdWU7CkBAIC03OSw3ICs3OSw3IEBAIHB1YmxpYzoKICAgICBzdGF0aWMgYm9v bCBpc1NhbXBsaW5nKCkgeyByZXR1cm4gdHJ1ZTsgfQogICAgIHN0YXRpYyBib29sIGhhc0hlYXBQ cm9maWxlcigpIHsgcmV0dXJuIHRydWU7IH0KICAgICBzdGF0aWMgdm9pZCBpbml0aWFsaXplKCk7 Ci0gICAgc3RhdGljIHZvaWQgdmlzaXROb2RlV3JhcHBlcnMoTm9kZVdyYXBwZXJWaXNpdG9yKik7 CisgICAgc3RhdGljIHZvaWQgdmlzaXROb2RlV3JhcHBlcnMoV3JhcHBlZE5vZGVWaXNpdG9yKik7 CiAgICAgc3RhdGljIHZvaWQgdmlzaXRFeHRlcm5hbFN0cmluZ3MoRXh0ZXJuYWxTdHJpbmdWaXNp dG9yKik7CiAgICAgc3RhdGljIHZvaWQgdmlzaXRFeHRlcm5hbEFycmF5cyhFeHRlcm5hbEFycmF5 VmlzaXRvciopOwogICAgIHN0YXRpYyB2b2lkIGNvbGxlY3RCaW5kaW5nTWVtb3J5SW5mbyhNZW1v cnlJbnN0cnVtZW50YXRpb24qKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdz L3Y4L1Y4RE9NTWFwLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4RE9NTWFwLmNw cAppbmRleCA1MDkyNWE4MmUxZTQ2NGQyOGIzMjVkNjg0NDcwZGNjZjNmMzM2YTExLi4xYWE2NGI2 ZTkxMzJhM2FkMGEwMDExYzk5MzVkNmM5NWI3ZjUyOTczIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi Q29yZS9iaW5kaW5ncy92OC9WOERPTU1hcC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvYmluZGlu Z3MvdjgvVjhET01NYXAuY3BwCkBAIC01Miw2ICs1MiwxMCBAQCBET01EYXRhU3RvcmVIYW5kbGU6 On5ET01EYXRhU3RvcmVIYW5kbGUoKQogICAgICAgICBWOFBlcklzb2xhdGVEYXRhOjpjdXJyZW50 KCktPnVucmVnaXN0ZXJET01EYXRhU3RvcmUobV9zdG9yZS5nZXQoKSk7CiB9CiAKK05vZGVXcmFw cGVyVmlzaXRvcjo6fk5vZGVXcmFwcGVyVmlzaXRvcigpCit7Cit9CisKIERPTU5vZGVNYXBwaW5n JiBnZXRET01Ob2RlTWFwKHY4OjpJc29sYXRlKiBpc29sYXRlKQogewogICAgIHJldHVybiBET01E YXRhOjpnZXRDdXJyZW50U3RvcmUoaXNvbGF0ZSkuZG9tTm9kZU1hcCgpOwpAQCAtOTQsMTYgKzk4 LDMzIEBAIHZvaWQgcmVtb3ZlQWxsRE9NT2JqZWN0cygpCiAgICAgRE9NRGF0YTo6cmVtb3ZlT2Jq ZWN0c0Zyb21XcmFwcGVyTWFwPHZvaWQ+KCZzdG9yZSwgc3RvcmUuYWN0aXZlRG9tT2JqZWN0TWFw KCkpOwogfQogCi12b2lkIHZpc2l0RE9NTm9kZXMoRE9NV3JhcHBlck1hcDxOb2RlPjo6VmlzaXRv ciogdmlzaXRvcikKK3ZvaWQgdmlzaXRBbGxET01Ob2RlcyhOb2RlV3JhcHBlclZpc2l0b3IqIHZp c2l0b3IpCiB7CiAgICAgdjg6OkhhbmRsZVNjb3BlIHNjb3BlOwogCi0gICAgRE9NRGF0YUxpc3Qm IGxpc3QgPSBET01EYXRhU3RvcmU6OmFsbFN0b3JlcygpOwotICAgIGZvciAoc2l6ZV90IGkgPSAw OyBpIDwgbGlzdC5zaXplKCk7ICsraSkgewotICAgICAgICBET01EYXRhU3RvcmUqIHN0b3JlID0g bGlzdFtpXTsKLQotICAgICAgICBzdG9yZS0+ZG9tTm9kZU1hcCgpLnZpc2l0KHN0b3JlLCB2aXNp dG9yKTsKLSAgICB9CisgICAgY2xhc3MgVmlzaXRvckFkYXB0ZXIgOiBwdWJsaWMgdjg6OlBlcnNp c3RlbnRIYW5kbGVWaXNpdG9yIHsKKyAgICBwdWJsaWM6CisgICAgICAgIGV4cGxpY2l0IFZpc2l0 b3JBZGFwdGVyKE5vZGVXcmFwcGVyVmlzaXRvciogdmlzaXRvcikKKyAgICAgICAgICAgIDogbV92 aXNpdG9yKHZpc2l0b3IpCisgICAgICAgIHsKKyAgICAgICAgfQorCisgICAgICAgIHZpcnR1YWwg dm9pZCBWaXNpdFBlcnNpc3RlbnRIYW5kbGUodjg6OlBlcnNpc3RlbnQ8djg6OlZhbHVlPiB2YWx1 ZSwgdWludDE2X3QgY2xhc3NJZCkKKyAgICAgICAgeworICAgICAgICAgICAgaWYgKGNsYXNzSWQg IT0gdjhET01TdWJ0cmVlQ2xhc3NJZCkKKyAgICAgICAgICAgICAgICByZXR1cm47CisgICAgICAg ICAgICBBU1NFUlQoVjhOb2RlOjpIYXNJbnN0YW5jZSh2YWx1ZSkpOworICAgICAgICAgICAgQVNT RVJUKHZhbHVlLT5Jc09iamVjdCgpKTsKKyAgICAgICAgICAgIEFTU0VSVCghdmFsdWUuSXNJbmRl cGVuZGVudCgpKTsKKyAgICAgICAgICAgIHY4OjpQZXJzaXN0ZW50PHY4OjpPYmplY3Q+IHdyYXBw ZXIgPSB2ODo6UGVyc2lzdGVudDx2ODo6T2JqZWN0Pjo6Q2FzdCh2YWx1ZSk7CisgICAgICAgICAg ICBtX3Zpc2l0b3ItPnZpc2l0Tm9kZVdyYXBwZXIoVjhOb2RlOjp0b05hdGl2ZSh3cmFwcGVyKSwg d3JhcHBlcik7CisgICAgICAgIH0KKworICAgIHByaXZhdGU6CisgICAgICAgIE5vZGVXcmFwcGVy VmlzaXRvciogbV92aXNpdG9yOworICAgIH0gdmlzaXRvckFkYXB0ZXIodmlzaXRvcik7CisKKyAg ICB2ODo6Vjg6OlZpc2l0SGFuZGxlc1dpdGhDbGFzc0lkcygmdmlzaXRvckFkYXB0ZXIpOwogfQog CiB2b2lkIHZpc2l0QWN0aXZlRE9NTm9kZXMoRE9NV3JhcHBlck1hcDxOb2RlPjo6VmlzaXRvciog dmlzaXRvcikKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4RE9NTWFw LmggYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9WOERPTU1hcC5oCmluZGV4IGNhNDVkZmRj M2NkMTRjZmY5OTYwMDQ3ZDE3MGY0YmFiMDc0ZjZlOTYuLmM3MTZmMzBhYTk4M2FhMzFjMWZjNmM0 MDMyMDU5MGYyZTM1YzYwYTMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4 L1Y4RE9NTWFwLmgKKysrIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvVjhET01NYXAuaApA QCAtMTY1LDkgKzE2NSwxNiBAQCBuYW1lc3BhY2UgV2ViQ29yZSB7CiAgICAgLy8gQSBtYXAgZnJv bSBET00gbm9kZSB0byBpdHMgSlMgd3JhcHBlci4KICAgICBET01Ob2RlTWFwcGluZyYgZ2V0RE9N Tm9kZU1hcCh2ODo6SXNvbGF0ZSogPSAwKTsKICAgICBET01Ob2RlTWFwcGluZyYgZ2V0QWN0aXZl RE9NTm9kZU1hcCh2ODo6SXNvbGF0ZSogPSAwKTsKLSAgICB2b2lkIHZpc2l0RE9NTm9kZXMoRE9N V3JhcHBlck1hcDxOb2RlPjo6VmlzaXRvciopOwogICAgIHZvaWQgdmlzaXRBY3RpdmVET01Ob2Rl cyhET01XcmFwcGVyTWFwPE5vZGU+OjpWaXNpdG9yKik7CiAKKworICAgIGNsYXNzIE5vZGVXcmFw cGVyVmlzaXRvciB7CisgICAgcHVibGljOgorICAgICAgICB2aXJ0dWFsIH5Ob2RlV3JhcHBlclZp c2l0b3IoKTsKKyAgICAgICAgdmlydHVhbCB2b2lkIHZpc2l0Tm9kZVdyYXBwZXIoTm9kZSosIHY4 OjpQZXJzaXN0ZW50PHY4OjpPYmplY3Q+IHdyYXBwZXIpID0gMDsKKyAgICB9OworICAgIHZvaWQg dmlzaXRBbGxET01Ob2RlcyhOb2RlV3JhcHBlclZpc2l0b3IqKTsKKwogICAgIC8vIEEgbWFwIGZy b20gYSBET00gb2JqZWN0IChub24tbm9kZSkgdG8gaXRzIEpTIHdyYXBwZXIuIFRoaXMgbWFwIGRv ZXMgbm90IGNvbnRhaW4gdGhlIERPTSBvYmplY3RzIHdoaWNoIGNhbiBoYXZlIHBlbmRpbmcgYWN0 aXZpdHkgKGFjdGl2ZSBkb20gb2JqZWN0cykuCiAgICAgRE9NV3JhcHBlck1hcDx2b2lkPiYgZ2V0 RE9NT2JqZWN0TWFwKHY4OjpJc29sYXRlKiA9IDApOwogICAgIHZvaWQgdmlzaXRET01PYmplY3Rz KERPTVdyYXBwZXJNYXA8dm9pZD46OlZpc2l0b3IqKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL2JpbmRpbmdzL3Y4L1Y4RE9NV3JhcHBlci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5n cy92OC9WOERPTVdyYXBwZXIuY3BwCmluZGV4IGM3NjhkYTg5MjM1N2I4MTE0NjNjYzNmNDVjYjU2 OGFhODUwMTcwNjEuLjE3MjgzNTgxODM5YTE1NTc4YmNmYTc5NGU5NjVmYjg5ODE2ODQ2MmYgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4RE9NV3JhcHBlci5jcHAKKysr IGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvVjhET01XcmFwcGVyLmNwcApAQCAtNzMsNiAr NzMsNyBAQCB2ODo6UGVyc2lzdGVudDx2ODo6T2JqZWN0PiBWOERPTVdyYXBwZXI6OnNldEpTV3Jh cHBlckZvckRPTU5vZGUoUGFzc1JlZlB0cjxOb2RlPgogICAgIHY4OjpQZXJzaXN0ZW50PHY4OjpP YmplY3Q+IHdyYXBwZXJIYW5kbGUgPSB2ODo6UGVyc2lzdGVudDx2ODo6T2JqZWN0Pjo6TmV3KHdy YXBwZXIpOwogICAgIEFTU0VSVChtYXliZURPTVdyYXBwZXIod3JhcHBlckhhbmRsZSkpOwogICAg IEFTU0VSVCghbm9kZS0+aXNBY3RpdmVOb2RlKCkpOworICAgIHdyYXBwZXJIYW5kbGUuU2V0V3Jh cHBlckNsYXNzSWQodjhET01TdWJ0cmVlQ2xhc3NJZCk7CiAgICAgZ2V0RE9NTm9kZU1hcChpc29s YXRlKS5zZXQobm9kZS5sZWFrUmVmKCksIHdyYXBwZXJIYW5kbGUpOwogICAgIHJldHVybiB3cmFw cGVySGFuZGxlOwogfQpAQCAtODIsNiArODMsNyBAQCB2ODo6UGVyc2lzdGVudDx2ODo6T2JqZWN0 PiBWOERPTVdyYXBwZXI6OnNldEpTV3JhcHBlckZvckFjdGl2ZURPTU5vZGUoUGFzc1JlZlB0cgog ICAgIHY4OjpQZXJzaXN0ZW50PHY4OjpPYmplY3Q+IHdyYXBwZXJIYW5kbGUgPSB2ODo6UGVyc2lz dGVudDx2ODo6T2JqZWN0Pjo6TmV3KHdyYXBwZXIpOwogICAgIEFTU0VSVChtYXliZURPTVdyYXBw ZXIod3JhcHBlckhhbmRsZSkpOwogICAgIEFTU0VSVChub2RlLT5pc0FjdGl2ZU5vZGUoKSk7Cisg ICAgd3JhcHBlckhhbmRsZS5TZXRXcmFwcGVyQ2xhc3NJZCh2OERPTVN1YnRyZWVDbGFzc0lkKTsK ICAgICBnZXRBY3RpdmVET01Ob2RlTWFwKGlzb2xhdGUpLnNldChub2RlLmxlYWtSZWYoKSwgd3Jh cHBlckhhbmRsZSk7CiAgICAgcmV0dXJuIHdyYXBwZXJIYW5kbGU7CiB9CmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9WOEdDQ29udHJvbGxlci5jcHAgYi9Tb3VyY2UvV2Vi Q29yZS9iaW5kaW5ncy92OC9WOEdDQ29udHJvbGxlci5jcHAKaW5kZXggOTVkOTFlMjdmZWFjMjI2 N2Q2MDgwZjgzMmFlMTJmZTJjYWI0M2UwZC4uM2E0ZDQ4NmY4NzRmNDY1ZmZjOWZiZWNmNGM1ZTgy MjkyZTQyNzAwMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvVjhHQ0Nv bnRyb2xsZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4R0NDb250cm9s bGVyLmNwcApAQCAtMTY5LDkgKzE2OSw5IEBAIGJvb2wgb3BlcmF0b3I8KGNvbnN0IEltcGxpY2l0 Q29ubmVjdGlvbiYgbGVmdCwgY29uc3QgSW1wbGljaXRDb25uZWN0aW9uJiByaWdodCkKICAgICBy ZXR1cm4gbGVmdC5yb290KCkgPCByaWdodC5yb290KCk7CiB9CiAKLWNsYXNzIE5vZGVWaXNpdG9y IDogcHVibGljIERPTVdyYXBwZXJNYXA8Tm9kZT46OlZpc2l0b3IgeworY2xhc3MgTm9kZVZpc2l0 b3IgOiBwdWJsaWMgTm9kZVdyYXBwZXJWaXNpdG9yIHsKIHB1YmxpYzoKLSAgICB2b2lkIHZpc2l0 RE9NV3JhcHBlcihET01EYXRhU3RvcmUqLCBOb2RlKiBub2RlLCB2ODo6UGVyc2lzdGVudDx2ODo6 T2JqZWN0PiB3cmFwcGVyKQorICAgIHZvaWQgdmlzaXROb2RlV3JhcHBlcihOb2RlKiBub2RlLCB2 ODo6UGVyc2lzdGVudDx2ODo6T2JqZWN0PiB3cmFwcGVyKQogICAgIHsKICAgICAgICAgaWYgKG5v ZGUtPmhhc0V2ZW50TGlzdGVuZXJzKCkpCiAgICAgICAgICAgICBhZGRJbXBsaWNpdFJlZmVyZW5j ZXNGb3JOb2RlV2l0aEV2ZW50TGlzdGVuZXJzKG5vZGUsIHdyYXBwZXIpOwpAQCAtMjE4LDggKzIx OCw3IEBAIHZvaWQgVjhHQ0NvbnRyb2xsZXI6OmdjUHJvbG9ndWUoKQogICAgIHZpc2l0QWN0aXZl RE9NTm9kZXMoJmFjdGl2ZU5vZGVWaXNpdG9yKTsKIAogICAgIE5vZGVWaXNpdG9yIG5vZGVWaXNp dG9yOwotICAgIHZpc2l0RE9NTm9kZXMoJm5vZGVWaXNpdG9yKTsKLSAgICB2aXNpdEFjdGl2ZURP TU5vZGVzKCZub2RlVmlzaXRvcik7CisgICAgdmlzaXRBbGxET01Ob2Rlcygmbm9kZVZpc2l0b3Ip OwogICAgIG5vZGVWaXNpdG9yLmFwcGx5R3JvdXBpbmcoKTsKIAogICAgIE9iamVjdFZpc2l0b3Ig b2JqZWN0VmlzaXRvcjsKQEAgLTMwNywxMSArMzA2LDYgQEAgdm9pZCBWOEdDQ29udHJvbGxlcjo6 Z2NFcGlsb2d1ZSgpCiAgICAgfQogI2VuZGlmCiAKLSNpZm5kZWYgTkRFQlVHCi0gICAgRW5zdXJl V2Vha0RPTU5vZGVWaXNpdG9yIHdlYWtET01Ob2RlVmlzaXRvcjsKLSAgICB2aXNpdERPTU5vZGVz KCZ3ZWFrRE9NTm9kZVZpc2l0b3IpOwotI2VuZGlmCi0KICAgICBUUkFDRV9FVkVOVF9FTkQwKCJ2 OCIsICJHQyIpOwogfQogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvQmlu ZGluZ1Zpc2l0b3JzLmggYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvQmluZGluZ1Zpc2l0b3Jz LmgKaW5kZXggNzUzMGM5MjQ3MzJhNjNmODkzODQ3OWI2NWU0NTQ3MzhkZDViMWYyOC4uYzg4NTcw M2FjNzU1Yzk0M2I1NDg0MmY0ZmEzOTNhZDJiNGFjMzUzZiAxMDA2NDQKLS0tIGEvU291cmNlL1dl YkNvcmUvaW5zcGVjdG9yL0JpbmRpbmdWaXNpdG9ycy5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL2lu c3BlY3Rvci9CaW5kaW5nVmlzaXRvcnMuaApAQCAtMzgsMTEgKzM4LDExIEBAIG5hbWVzcGFjZSBX ZWJDb3JlIHsKIAogY2xhc3MgTm9kZTsKIAotY2xhc3MgTm9kZVdyYXBwZXJWaXNpdG9yIHsKK2Ns YXNzIFdyYXBwZWROb2RlVmlzaXRvciB7CiBwdWJsaWM6CiAgICAgdmlydHVhbCB2b2lkIHZpc2l0 Tm9kZShOb2RlKikgPSAwOwogcHJvdGVjdGVkOgotICAgIHZpcnR1YWwgfk5vZGVXcmFwcGVyVmlz aXRvcigpIHsgfQorICAgIHZpcnR1YWwgfldyYXBwZWROb2RlVmlzaXRvcigpIHsgfQogfTsKIAog Y2xhc3MgRXh0ZXJuYWxTdHJpbmdWaXNpdG9yIHsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3Jl L2luc3BlY3Rvci9JbnNwZWN0b3JNZW1vcnlBZ2VudC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9pbnNw ZWN0b3IvSW5zcGVjdG9yTWVtb3J5QWdlbnQuY3BwCmluZGV4IGZkYzcyYWZlYjEzNWIzNzA3ZmM0 OGYwOWRlNmVjNzJkMTg5MDlmMGQuLmQ2ZWUzYTBkYTAyOWUyYTJlMDFhOGZiMDAwNTQwMzc3ZTMy ZTBiMTQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0b3JNZW1v cnlBZ2VudC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3Rvck1lbW9y eUFnZW50LmNwcApAQCAtMjc2LDcgKzI3Niw3IEBAIHByaXZhdGU6CiAgICAgQ2hhcmFjdGVyRGF0 YVN0YXRpc3RpY3MmIG1fY2hhcmFjdGVyRGF0YVN0YXRpc3RpY3M7CiB9OwogCi1jbGFzcyBDb3Vu dGVyVmlzaXRvciA6IHB1YmxpYyBOb2RlV3JhcHBlclZpc2l0b3IsIHB1YmxpYyBFeHRlcm5hbFN0 cmluZ1Zpc2l0b3IgeworY2xhc3MgQ291bnRlclZpc2l0b3IgOiBwdWJsaWMgV3JhcHBlZE5vZGVW aXNpdG9yLCBwdWJsaWMgRXh0ZXJuYWxTdHJpbmdWaXNpdG9yIHsKIHB1YmxpYzoKICAgICBDb3Vu dGVyVmlzaXRvcihQYWdlKiBwYWdlKQogICAgICAgICA6IG1fcGFnZShwYWdlKQpAQCAtNDUwLDcg KzQ1MCw3IEBAIHN0YXRpYyB2b2lkIHJlcG9ydFJlbmRlclRyZWVJbmZvKFdURjo6TWVtb3J5SW5z dHJ1bWVudGF0aW9uQ2xpZW50JiBtZW1vcnlJbnN0cnVtCiAKIG5hbWVzcGFjZSB7CiAKLWNsYXNz IERPTVRyZWVzSXRlcmF0b3IgOiBwdWJsaWMgTm9kZVdyYXBwZXJWaXNpdG9yIHsKK2NsYXNzIERP TVRyZWVzSXRlcmF0b3IgOiBwdWJsaWMgV3JhcHBlZE5vZGVWaXNpdG9yIHsKIHB1YmxpYzoKICAg ICBET01UcmVlc0l0ZXJhdG9yKE1lbW9yeUluc3RydW1lbnRhdGlvbkltcGwmIG1lbW9yeUluc3Ry dW1lbnRhdGlvbiwgUGFnZSogcGFnZSkKICAgICAgICAgOiBtX3BhZ2UocGFnZSkK