100018 2012-10-22 13:13:44 -0700 Remove unnecessary m_layoutDelta[XY]Saturated initialization 2012-10-23 09:23:47 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 eae eae eric simon.fraser webkit.review.bot oldest_to_newest 747806 0 eae 2012-10-22 13:13:44 -0700 From comment on bug 98692: > Source/WebCore/rendering/LayoutState.cpp:43 > +#if !ASSERT_DISABLED && ENABLE(SATURATED_LAYOUT_ARITHMETIC) > + , m_layoutDeltaXSaturated(false) > + , m_layoutDeltaYSaturated(false) > +#endif Why initialize these here since they are unconditionally set in the function body below? This makes things more ugly for no real reason. 747811 1 169962 eae 2012-10-22 13:15:11 -0700 Created attachment 169962 Patch 748171 2 169962 jchaffraix 2012-10-22 19:00:57 -0700 Comment on attachment 169962 Patch r=me, would have been nice to put a bit of context in the ChangeLog. 748714 3 eae 2012-10-23 09:22:50 -0700 Committed r132233: <http://trac.webkit.org/changeset/132233> 169962 2012-10-22 13:15:11 -0700 2012-10-23 09:23:47 -0700 Patch bug-100018-20121022131349.patch text/plain 1393 eae SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEzMjEyNikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDEyLTEwLTIyICBFbWlsIEEg RWtsdW5kICA8ZWFlQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZW1vdmUgdW5uZWNlc3Nhcnkg bV9sYXlvdXREZWx0YVtYWV1TYXR1cmF0ZWQgaW5pdGlhbGl6YXRpb24KKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwMDAxOAorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cywgbm8gY2hhbmdl IGluIGZ1bmN0aW9uYWxpdHkuCisKKyAgICAgICAgKiByZW5kZXJpbmcvTGF5b3V0U3RhdGUuY3Bw OgorICAgICAgICAoV2ViQ29yZTo6TGF5b3V0U3RhdGU6OkxheW91dFN0YXRlKToKKwogMjAxMi0x MC0yMiAgQ2hyaXMgUm9nZXJzICA8Y3JvZ2Vyc0Bnb29nbGUuY29tPgogCiAgICAgICAgIFVwZGF0 ZSBzb21lIEF1ZGlvQ29udGV4dCBjcmVhdGUoKSBtZXRob2QgbmFtZXMgdG8gbGF0ZXN0IFdlYiBB dWRpbyBzcGVjCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvTGF5b3V0U3RhdGUuY3Bw Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9MYXlvdXRTdGF0ZS5jcHAJ KHJldmlzaW9uIDEzMjEyMCkKKysrIFNvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9MYXlvdXRTdGF0 ZS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTM3LDEwICszNyw2IEBAIG5hbWVzcGFjZSBXZWJDb3Jl IHsKIAogTGF5b3V0U3RhdGU6OkxheW91dFN0YXRlKExheW91dFN0YXRlKiBwcmV2LCBSZW5kZXJC b3gqIHJlbmRlcmVyLCBjb25zdCBMYXlvdXRTaXplJiBvZmZzZXQsIExheW91dFVuaXQgcGFnZUxv Z2ljYWxIZWlnaHQsIGJvb2wgcGFnZUxvZ2ljYWxIZWlnaHRDaGFuZ2VkLCBDb2x1bW5JbmZvKiBj b2x1bW5JbmZvKQogICAgIDogbV9jbGlwcGVkKGZhbHNlKQotI2lmICFBU1NFUlRfRElTQUJMRUQg JiYgRU5BQkxFKFNBVFVSQVRFRF9MQVlPVVRfQVJJVEhNRVRJQykKLSAgICAsIG1fbGF5b3V0RGVs dGFYU2F0dXJhdGVkKGZhbHNlKQotICAgICwgbV9sYXlvdXREZWx0YVlTYXR1cmF0ZWQoZmFsc2Up Ci0jZW5kaWYKICAgICAsIG1fY29sdW1uSW5mbyhjb2x1bW5JbmZvKQogICAgICwgbV9saW5lR3Jp ZCgwKQogICAgICwgbV9uZXh0KHByZXYpCg==