100013 2012-10-22 10:33:43 -0700 [chromium] Expose setAutomaticallyComputeRasterScale on the WebLayer API 2012-10-23 07:51:45 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 danakj danakj abarth cc-bugs dglazkov fishd jamesr peter+ews tkent+wkapi webkit.review.bot oldest_to_newest 747670 0 danakj 2012-10-22 10:33:43 -0700 [chromium] Expose setInitialCssScale on the WebLayer API 747673 1 169937 danakj 2012-10-22 10:34:31 -0700 Created attachment 169937 Patch 747680 2 danakj 2012-10-22 10:37:14 -0700 This depends on https://codereview.chromium.org/11227031/ and blocks relanding https://codereview.chromium.org/10915313 747681 3 webkit.review.bot 2012-10-22 10:38:31 -0700 Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI. 747682 4 169937 webkit.review.bot 2012-10-22 10:43:07 -0700 Comment on attachment 169937 Patch Attachment 169937 did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/14486577 747697 5 169937 peter+ews 2012-10-22 11:05:24 -0700 Comment on attachment 169937 Patch Attachment 169937 did not pass cr-android-ews (chromium-android): Output: http://queues.webkit.org/results/14489580 747790 6 169960 danakj 2012-10-22 12:58:03 -0700 Created attachment 169960 Patch 747791 7 danakj 2012-10-22 12:59:12 -0700 updated to opt-in 747800 8 169960 enne 2012-10-22 13:06:20 -0700 Comment on attachment 169960 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=169960&action=review > Source/Platform/chromium/public/WebLayer.h:108 > + virtual void setAutomaticallyComputeRasterScale(bool) = 0; I feel like this is more of a WebContentLayer concern than a general WebLayer one. 747808 9 169960 webkit.review.bot 2012-10-22 13:14:09 -0700 Comment on attachment 169960 Patch Attachment 169960 did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/14514001 747816 10 169960 peter+ews 2012-10-22 13:18:21 -0700 Comment on attachment 169960 Patch Attachment 169960 did not pass cr-android-ews (chromium-android): Output: http://queues.webkit.org/results/14516001 747819 11 169965 danakj 2012-10-22 13:21:54 -0700 Created attachment 169965 Patch Moved to WebContentLayer 747836 12 169965 webkit.review.bot 2012-10-22 13:39:57 -0700 Comment on attachment 169965 Patch Attachment 169965 did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/14487555 747858 13 169965 peter+ews 2012-10-22 13:59:36 -0700 Comment on attachment 169965 Patch Attachment 169965 did not pass cr-android-ews (chromium-android): Output: http://queues.webkit.org/results/14496378 747952 14 169965 jamesr 2012-10-22 15:16:15 -0700 Comment on attachment 169965 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=169965&action=review > Source/Platform/chromium/public/WebContentLayer.h:54 > + virtual void setAutomaticallyComputeRasterScale(bool) = 0; If you provide a default implementation instead of having it be pure virtual here landing will be a lot easier. Please document the default (false, I presume) 747959 15 169965 danakj 2012-10-22 15:24:17 -0700 Comment on attachment 169965 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=169965&action=review >> Source/Platform/chromium/public/WebContentLayer.h:54 >> + virtual void setAutomaticallyComputeRasterScale(bool) = 0; > > If you provide a default implementation instead of having it be pure virtual here landing will be a lot easier. > > Please document the default (false, I presume) Oh, sure. 2 patches instead of 1. Or will I need to come back here and remove the default implementation after? False, yep. k. 747989 16 jamesr 2012-10-22 15:42:56 -0700 (In reply to comment #15) > (From update of attachment 169965 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=169965&action=review > > >> Source/Platform/chromium/public/WebContentLayer.h:54 > >> + virtual void setAutomaticallyComputeRasterScale(bool) = 0; > > > > If you provide a default implementation instead of having it be pure virtual here landing will be a lot easier. > > > > Please document the default (false, I presume) > > Oh, sure. 2 patches instead of 1. Or will I need to come back here and remove the default implementation after? Wouldn't necessarily need to. It'd be good to be consistent, but might be better to just have all of these have default impls to make changing other APIs easier as well. Even if you did you wouldn't have to worry about synchronizing it with anything else. 747998 17 170008 danakj 2012-10-22 15:48:28 -0700 Created attachment 170008 Patch Default impl and document return value 748646 18 170008 webkit.review.bot 2012-10-23 07:51:40 -0700 Comment on attachment 170008 Patch Clearing flags on attachment: 170008 Committed r132223: <http://trac.webkit.org/changeset/132223> 748647 19 webkit.review.bot 2012-10-23 07:51:45 -0700 All reviewed patches have been landed. Closing bug. 169937 2012-10-22 10:34:31 -0700 2012-10-22 12:58:00 -0700 Patch bug-100013-20121022133310.patch text/plain 1800 danakj U3VidmVyc2lvbiBSZXZpc2lvbjogMTMyMDc1CmRpZmYgLS1naXQgYS9Tb3VyY2UvUGxhdGZvcm0v Q2hhbmdlTG9nIGIvU291cmNlL1BsYXRmb3JtL0NoYW5nZUxvZwppbmRleCA4ZGFlNWQ0OGI1NGRj YWVmOTY5MzI3NzgxODAxYTQzMGNjZDE5OTIwLi4xZjVlYjQ4MzJiYmI0MDRhMTQzZjBiNjkwYzM1 OTVjY2Y1MDViOTgxIDEwMDY0NAotLS0gYS9Tb3VyY2UvUGxhdGZvcm0vQ2hhbmdlTG9nCisrKyBi L1NvdXJjZS9QbGF0Zm9ybS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMSBAQAorMjAxMi0xMC0yMiAg RGFuYSBKYW5zZW5zICA8ZGFuYWtqQGNocm9taXVtLm9yZz4KKworICAgICAgICBbY2hyb21pdW1d IEV4cG9zZSBzZXRJbml0aWFsQ3NzU2NhbGUgb24gdGhlIFdlYkxheWVyIEFQSQorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTAwMDEzCisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhpcyBpcyBuZWVkZWQgdG8g YWxsb3cgVUkgbGF5ZXJzIHRvIHNldCB0aGUgc2NhbGUgYXQgd2hpY2ggdGhleSB3aWxsIGJlCisg ICAgICAgIHJhc3RlcmVkLiBVSSBsYXllcnMgdXNlIHNvbWUgY3JhenkgdHJhbnNmb3JtcyBzdWNo IGFzIGEgMXg2NCBsYXllciB3aXRoIGEKKyAgICAgICAgMTAwMCB4LXNjYWxlLiBTbyB3ZSBzaG91 bGQgbm90IGNob29zZSBhIGNvbnRlbnRzU2NhbGUgZnJvbSB0aGUgdHJhbnNmb3JtcworICAgICAg ICB1bmxlc3MgdGhlIFVJIHJlYWxseSB3YW50cyB1cyB0by4gRm9yIG5vdywgdGhleSBhbHdheXMg d2FudCBhIHNjYWxlIG9mIDEKKyAgICAgICAgKGlnbm9yaW5nIGRldmljZSBzY2FsZSkuCisKKyAg ICAgICAgU3VwcG9ydHMgaHR0cDovL2NyYnVnLmNvbS8xNDk5NDMKKworICAgICAgICAqIGNocm9t aXVtL3B1YmxpYy9XZWJMYXllci5oOgorICAgICAgICAoV2ViTGF5ZXIpOgorCiAyMDEyLTEwLTIy ICBLZWlzaGkgSGF0dG9yaSAgPGtlaXNoaUB3ZWJraXQub3JnPgogCiAgICAgICAgIFJlbW92ZSBt b250aEZvcm1hdEluTERNTApkaWZmIC0tZ2l0IGEvU291cmNlL1BsYXRmb3JtL2Nocm9taXVtL3B1 YmxpYy9XZWJMYXllci5oIGIvU291cmNlL1BsYXRmb3JtL2Nocm9taXVtL3B1YmxpYy9XZWJMYXll ci5oCmluZGV4IDdlYzUxNjU1NWVkMzlkODFlZDA5ODI5ZTNiZjIxNDMwNGQ0NGYwZmYuLmY0OThh NThjZDU5OWRlODYzZWIzMGQ1OTM5NjQ4ZTUzNTgyNGUyNTEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9Q bGF0Zm9ybS9jaHJvbWl1bS9wdWJsaWMvV2ViTGF5ZXIuaAorKysgYi9Tb3VyY2UvUGxhdGZvcm0v Y2hyb21pdW0vcHVibGljL1dlYkxheWVyLmgKQEAgLTEwMyw2ICsxMDMsMTAgQEAgcHVibGljOgog ICAgIHZpcnR1YWwgdm9pZCBzZXRUcmFuc2Zvcm0oY29uc3QgV2ViVHJhbnNmb3JtYXRpb25NYXRy aXgmKSA9IDA7CiAgICAgdmlydHVhbCBTa01hdHJpeDQ0IHRyYW5zZm9ybSgpIGNvbnN0ID0gMDsK IAorICAgIC8vIFNldCB0aGUgc2NhbGUgYXQgd2hpY2ggdGhlIGxheWVyIHNob3VsZCBiZSByYXN0 ZXJlZCwgaWdub3JpbmcgZGV2aWNlCisgICAgLy8gYW5kIHBhZ2Ugc2NhbGUgZmFjdG9ycy4KKyAg ICB2aXJ0dWFsIHZvaWQgc2V0SW5pdGlhbENzc1NjYWxlKGZsb2F0KSA9IDA7CisKICAgICAvLyBT ZXRzIHdoZXRoZXIgdGhlIGxheWVyIGRyYXdzIGl0cyBjb250ZW50IHdoZW4gY29tcG9zaXRpbmcu CiAgICAgdmlydHVhbCB2b2lkIHNldERyYXdzQ29udGVudChib29sKSA9IDA7CiAgICAgdmlydHVh bCBib29sIGRyYXdzQ29udGVudCgpIGNvbnN0ID0gMDsK 169960 2012-10-22 12:58:03 -0700 2012-10-22 13:21:51 -0700 Patch bug-100013-20121022155642.patch text/plain 3128 danakj U3VidmVyc2lvbiBSZXZpc2lvbjogMTMyMDc1CmRpZmYgLS1naXQgYS9Tb3VyY2UvUGxhdGZvcm0v Q2hhbmdlTG9nIGIvU291cmNlL1BsYXRmb3JtL0NoYW5nZUxvZwppbmRleCA4ZGFlNWQ0OGI1NGRj YWVmOTY5MzI3NzgxODAxYTQzMGNjZDE5OTIwLi4wYjY3NjU3NTFlYTg0MTU4Zjc4YmY4YmQ1ZWQz ZTVmY2Q3NDg5YThmIDEwMDY0NAotLS0gYS9Tb3VyY2UvUGxhdGZvcm0vQ2hhbmdlTG9nCisrKyBi L1NvdXJjZS9QbGF0Zm9ybS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOSBAQAorMjAxMi0xMC0yMiAg RGFuYSBKYW5zZW5zICA8ZGFuYWtqQGNocm9taXVtLm9yZz4KKworICAgICAgICBbY2hyb21pdW1d IEV4cG9zZSBzZXRBdXRvbWF0aWNhbGx5Q29tcHV0ZVJhc3RlclNjYWxlIG9uIHRoZSBXZWJMYXll ciBBUEkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEw MDAxMworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRo aXMgYWxsb3dzIHdlYiBjb250ZW50IHRvIG9wdC1pbiB0byBoYXZpbmcgdGhlaXIgY29udGVudHNT Y2FsZQorICAgICAgICBkZXRlcm1pbmVkIGZyb20gdGhlaXIgQ1NTIHRyYW5zZm9ybXMsIHdpdGhv dXQgaGF2aW5nIHRoaXMgYmVoYXZpb3VyCisgICAgICAgIHVuY29uZGl0aW9uYWxseSBlbmFibGVk IGdsb2JhbGx5LgorCisgICAgICAgIFN1cHBvcnRzIGh0dHA6Ly9jcmJ1Zy5jb20vMTQ5OTQzCisK KyAgICAgICAgKiBjaHJvbWl1bS9wdWJsaWMvV2ViTGF5ZXIuaDoKKyAgICAgICAgKFdlYkxheWVy KToKKwogMjAxMi0xMC0yMiAgS2Vpc2hpIEhhdHRvcmkgIDxrZWlzaGlAd2Via2l0Lm9yZz4KIAog ICAgICAgICBSZW1vdmUgbW9udGhGb3JtYXRJbkxETUwKZGlmZiAtLWdpdCBhL1NvdXJjZS9QbGF0 Zm9ybS9jaHJvbWl1bS9wdWJsaWMvV2ViTGF5ZXIuaCBiL1NvdXJjZS9QbGF0Zm9ybS9jaHJvbWl1 bS9wdWJsaWMvV2ViTGF5ZXIuaAppbmRleCA3ZWM1MTY1NTVlZDM5ZDgxZWQwOTgyOWUzYmYyMTQz MDRkNDRmMGZmLi43YzQyZjkxMjQ4ODQ5Mjg3NjUzNDA3YTlmMDI4NjYxOTg2NzI2ZWY4IDEwMDY0 NAotLS0gYS9Tb3VyY2UvUGxhdGZvcm0vY2hyb21pdW0vcHVibGljL1dlYkxheWVyLmgKKysrIGIv U291cmNlL1BsYXRmb3JtL2Nocm9taXVtL3B1YmxpYy9XZWJMYXllci5oCkBAIC0xMDMsNiArMTAz LDEwIEBAIHB1YmxpYzoKICAgICB2aXJ0dWFsIHZvaWQgc2V0VHJhbnNmb3JtKGNvbnN0IFdlYlRy YW5zZm9ybWF0aW9uTWF0cml4JikgPSAwOwogICAgIHZpcnR1YWwgU2tNYXRyaXg0NCB0cmFuc2Zv cm0oKSBjb25zdCA9IDA7CiAKKyAgICAvLyBBbGxvdyB0aGUgY29tcG9zaXRvciB0byBkZXRlcm1p bmUgdGhlIHNjYWxlIGF0IHdoaWNoIHRoZSBsYXllciBzaG91bGQKKyAgICAvLyBiZSByYXN0ZXJp emVkIGJhc2VkIG9uIHRoZSBsYXllcidzIGhpZXJhcmNoeSBhbmQgdHJhbnNmb3JtLgorICAgIHZp cnR1YWwgdm9pZCBzZXRBdXRvbWF0aWNhbGx5Q29tcHV0ZVJhc3RlclNjYWxlKGJvb2wpID0gMDsK KwogICAgIC8vIFNldHMgd2hldGhlciB0aGUgbGF5ZXIgZHJhd3MgaXRzIGNvbnRlbnQgd2hlbiBj b21wb3NpdGluZy4KICAgICB2aXJ0dWFsIHZvaWQgc2V0RHJhd3NDb250ZW50KGJvb2wpID0gMDsK ICAgICB2aXJ0dWFsIGJvb2wgZHJhd3NDb250ZW50KCkgY29uc3QgPSAwOwpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vR3JhcGhpY3NMYXllckNo cm9taXVtLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL0dy YXBoaWNzTGF5ZXJDaHJvbWl1bS5jcHAKaW5kZXggMDc1NzQ5ZTlhMWI4ZWM2MTdmZGVjYTg5Y2Zm ZDJlNDlhODgyOTY4ZC4uY2U1NzcxZDQzMWQ4MTc2OTI2OThjMjkxZmE3NGVhMDU5ZDA0NzMzOSAx MDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vR3Jh cGhpY3NMYXllckNocm9taXVtLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFw aGljcy9jaHJvbWl1bS9HcmFwaGljc0xheWVyQ2hyb21pdW0uY3BwCkBAIC0xMDUsNiArMTA1LDcg QEAgR3JhcGhpY3NMYXllckNocm9taXVtOjpHcmFwaGljc0xheWVyQ2hyb21pdW0oR3JhcGhpY3NM YXllckNsaWVudCogY2xpZW50KQogICAgIG1fbGF5ZXIgPSBhZG9wdFB0cihQbGF0Zm9ybTo6Y3Vy cmVudCgpLT5jb21wb3NpdG9yU3VwcG9ydCgpLT5jcmVhdGVDb250ZW50TGF5ZXIobV9vcGFxdWVS ZWN0VHJhY2tpbmdDb250ZW50TGF5ZXJEZWxlZ2F0ZS5nZXQoKSkpOwogICAgIG1fbGF5ZXItPmxh eWVyKCktPnNldERyYXdzQ29udGVudChtX2RyYXdzQ29udGVudCAmJiBtX2NvbnRlbnRzVmlzaWJs ZSk7CiAgICAgbV9sYXllci0+bGF5ZXIoKS0+c2V0U2Nyb2xsQ2xpZW50KHRoaXMpOworICAgIG1f bGF5ZXItPmxheWVyKCktPnNldEF1dG9tYXRpY2FsbHlDb21wdXRlUmFzdGVyU2NhbGUodHJ1ZSk7 CiAgICAgdXBkYXRlRGVidWdJbmRpY2F0b3JzKCk7CiB9CiAKQEAgLTgzNiw2ICs4MzcsNyBAQCB2 b2lkIEdyYXBoaWNzTGF5ZXJDaHJvbWl1bTo6c2V0dXBDb250ZW50c0xheWVyKFdlYkxheWVyKiBj b250ZW50c0xheWVyKQogICAgICAgICAvLyBJdCBpcyBuZWNlc3NhcnkgdG8gY2FsbCBzZXREcmF3 c0NvbnRlbnQgYXMgc29vbiBhcyB3ZSByZWNlaXZlIHRoZSBuZXcgY29udGVudHNMYXllciwgZm9y CiAgICAgICAgIC8vIHRoZSBjb3JyZWN0bmVzcyBvZiBlYXJseSBleGl0IGNvbmRpdGlvbnMgaW4g c2V0RHJhd3NDb250ZW50KCkgYW5kIHNldENvbnRlbnRzVmlzaWJsZSgpLgogICAgICAgICBtX2Nv bnRlbnRzTGF5ZXItPnNldERyYXdzQ29udGVudChtX2NvbnRlbnRzVmlzaWJsZSk7CisgICAgICAg IG1fY29udGVudHNMYXllci0+c2V0QXV0b21hdGljYWxseUNvbXB1dGVSYXN0ZXJTY2FsZSh0cnVl KTsKIAogICAgICAgICAvLyBJbnNlcnQgdGhlIGNvbnRlbnQgbGF5ZXIgZmlyc3QuIFZpZGVvIGVs ZW1lbnRzIHJlcXVpcmUgdGhpcywgYmVjYXVzZSB0aGV5IGhhdmUKICAgICAgICAgLy8gc2hhZG93 IGNvbnRlbnQgdGhhdCBtdXN0IGRpc3BsYXkgaW4gZnJvbnQgb2YgdGhlIHZpZGVvLgo= 169965 2012-10-22 13:21:54 -0700 2012-10-22 15:48:25 -0700 Patch bug-100013-20121022162032.patch text/plain 2635 danakj U3VidmVyc2lvbiBSZXZpc2lvbjogMTMyMDc1CmRpZmYgLS1naXQgYS9Tb3VyY2UvUGxhdGZvcm0v Q2hhbmdlTG9nIGIvU291cmNlL1BsYXRmb3JtL0NoYW5nZUxvZwppbmRleCA4ZGFlNWQ0OGI1NGRj YWVmOTY5MzI3NzgxODAxYTQzMGNjZDE5OTIwLi4wYjY3NjU3NTFlYTg0MTU4Zjc4YmY4YmQ1ZWQz ZTVmY2Q3NDg5YThmIDEwMDY0NAotLS0gYS9Tb3VyY2UvUGxhdGZvcm0vQ2hhbmdlTG9nCisrKyBi L1NvdXJjZS9QbGF0Zm9ybS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOSBAQAorMjAxMi0xMC0yMiAg RGFuYSBKYW5zZW5zICA8ZGFuYWtqQGNocm9taXVtLm9yZz4KKworICAgICAgICBbY2hyb21pdW1d IEV4cG9zZSBzZXRBdXRvbWF0aWNhbGx5Q29tcHV0ZVJhc3RlclNjYWxlIG9uIHRoZSBXZWJMYXll ciBBUEkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEw MDAxMworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRo aXMgYWxsb3dzIHdlYiBjb250ZW50IHRvIG9wdC1pbiB0byBoYXZpbmcgdGhlaXIgY29udGVudHNT Y2FsZQorICAgICAgICBkZXRlcm1pbmVkIGZyb20gdGhlaXIgQ1NTIHRyYW5zZm9ybXMsIHdpdGhv dXQgaGF2aW5nIHRoaXMgYmVoYXZpb3VyCisgICAgICAgIHVuY29uZGl0aW9uYWxseSBlbmFibGVk IGdsb2JhbGx5LgorCisgICAgICAgIFN1cHBvcnRzIGh0dHA6Ly9jcmJ1Zy5jb20vMTQ5OTQzCisK KyAgICAgICAgKiBjaHJvbWl1bS9wdWJsaWMvV2ViTGF5ZXIuaDoKKyAgICAgICAgKFdlYkxheWVy KToKKwogMjAxMi0xMC0yMiAgS2Vpc2hpIEhhdHRvcmkgIDxrZWlzaGlAd2Via2l0Lm9yZz4KIAog ICAgICAgICBSZW1vdmUgbW9udGhGb3JtYXRJbkxETUwKZGlmZiAtLWdpdCBhL1NvdXJjZS9QbGF0 Zm9ybS9jaHJvbWl1bS9wdWJsaWMvV2ViQ29udGVudExheWVyLmggYi9Tb3VyY2UvUGxhdGZvcm0v Y2hyb21pdW0vcHVibGljL1dlYkNvbnRlbnRMYXllci5oCmluZGV4IGEwZWQwZTRlYjZhN2UwYmEw YTEzZmU2YTQwYThlNTk2MTJkNjg5NTQuLjU1OGZkNzU3ZDEyZjdkOGIwZjM0NmNlMzcyNzRmOTNl ZmFjOTAwOTQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9QbGF0Zm9ybS9jaHJvbWl1bS9wdWJsaWMvV2Vi Q29udGVudExheWVyLmgKKysrIGIvU291cmNlL1BsYXRmb3JtL2Nocm9taXVtL3B1YmxpYy9XZWJD b250ZW50TGF5ZXIuaApAQCAtNDksNiArNDksMTAgQEAgcHVibGljOgogICAgIHZpcnR1YWwgdm9p ZCBzZXRCb3VuZHNDb250YWluUGFnZVNjYWxlKGJvb2wpID0gMDsKICAgICB2aXJ0dWFsIGJvb2wg Ym91bmRzQ29udGFpblBhZ2VTY2FsZSgpIGNvbnN0ID0gMDsKIAorICAgIC8vIEFsbG93IHRoZSBj b21wb3NpdG9yIHRvIGRldGVybWluZSB0aGUgc2NhbGUgYXQgd2hpY2ggdGhlIGxheWVyIHNob3Vs ZAorICAgIC8vIGJlIHJhc3Rlcml6ZWQgYmFzZWQgb24gdGhlIGxheWVyJ3MgaGllcmFyY2h5IGFu ZCB0cmFuc2Zvcm0uCisgICAgdmlydHVhbCB2b2lkIHNldEF1dG9tYXRpY2FsbHlDb21wdXRlUmFz dGVyU2NhbGUoYm9vbCkgPSAwOworCiAgICAgLy8gU2V0IHRvIHJlbmRlciB0ZXh0IGluIHRoaXMg bGF5ZXIgd2l0aCBMQ0QgYW50aWFsaWFzaW5nLiBPbmx5IHNldCBpZiB5b3Uga25vdyB0aGF0IHRo aXMgbGF5ZXIgd2lsbCBiZQogICAgIC8vIGRyYXduIGluIGEgd2F5IHdoZXJlIHRoaXMgbWFrZXMg c2Vuc2UgLSBpLmUuIG9wYXF1ZSBiYWNrZ3JvdW5kLCBub3Qgcm90YXRlZCBvciBzY2FsZWQsIGV0 Yy4KICAgICAvLyBEZWZhdWx0cyB0byBmYWxzZTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL0dyYXBoaWNzTGF5ZXJDaHJvbWl1bS5jcHAgYi9T b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9HcmFwaGljc0xheWVyQ2hy b21pdW0uY3BwCmluZGV4IDA3NTc0OWU5YTFiOGVjNjE3ZmRlY2E4OWNmZmQyZTQ5YTg4Mjk2OGQu LmE1OTVkZjI4ZGExNmE0MDVlNGZjNDgzNDY3NzMwYzcyZjVjZWE2ZWYgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL0dyYXBoaWNzTGF5ZXJDaHJv bWl1bS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0v R3JhcGhpY3NMYXllckNocm9taXVtLmNwcApAQCAtMTA1LDYgKzEwNSw3IEBAIEdyYXBoaWNzTGF5 ZXJDaHJvbWl1bTo6R3JhcGhpY3NMYXllckNocm9taXVtKEdyYXBoaWNzTGF5ZXJDbGllbnQqIGNs aWVudCkKICAgICBtX2xheWVyID0gYWRvcHRQdHIoUGxhdGZvcm06OmN1cnJlbnQoKS0+Y29tcG9z aXRvclN1cHBvcnQoKS0+Y3JlYXRlQ29udGVudExheWVyKG1fb3BhcXVlUmVjdFRyYWNraW5nQ29u dGVudExheWVyRGVsZWdhdGUuZ2V0KCkpKTsKICAgICBtX2xheWVyLT5sYXllcigpLT5zZXREcmF3 c0NvbnRlbnQobV9kcmF3c0NvbnRlbnQgJiYgbV9jb250ZW50c1Zpc2libGUpOwogICAgIG1fbGF5 ZXItPmxheWVyKCktPnNldFNjcm9sbENsaWVudCh0aGlzKTsKKyAgICBtX2xheWVyLT5zZXRBdXRv bWF0aWNhbGx5Q29tcHV0ZVJhc3RlclNjYWxlKHRydWUpOwogICAgIHVwZGF0ZURlYnVnSW5kaWNh dG9ycygpOwogfQogCg== 170008 2012-10-22 15:48:28 -0700 2012-10-23 07:51:40 -0700 Patch bug-100013-20121022184706.patch text/plain 2666 danakj U3VidmVyc2lvbiBSZXZpc2lvbjogMTMyMDc1CmRpZmYgLS1naXQgYS9Tb3VyY2UvUGxhdGZvcm0v Q2hhbmdlTG9nIGIvU291cmNlL1BsYXRmb3JtL0NoYW5nZUxvZwppbmRleCA4ZGFlNWQ0OGI1NGRj YWVmOTY5MzI3NzgxODAxYTQzMGNjZDE5OTIwLi4wYjY3NjU3NTFlYTg0MTU4Zjc4YmY4YmQ1ZWQz ZTVmY2Q3NDg5YThmIDEwMDY0NAotLS0gYS9Tb3VyY2UvUGxhdGZvcm0vQ2hhbmdlTG9nCisrKyBi L1NvdXJjZS9QbGF0Zm9ybS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOSBAQAorMjAxMi0xMC0yMiAg RGFuYSBKYW5zZW5zICA8ZGFuYWtqQGNocm9taXVtLm9yZz4KKworICAgICAgICBbY2hyb21pdW1d IEV4cG9zZSBzZXRBdXRvbWF0aWNhbGx5Q29tcHV0ZVJhc3RlclNjYWxlIG9uIHRoZSBXZWJMYXll ciBBUEkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEw MDAxMworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRo aXMgYWxsb3dzIHdlYiBjb250ZW50IHRvIG9wdC1pbiB0byBoYXZpbmcgdGhlaXIgY29udGVudHNT Y2FsZQorICAgICAgICBkZXRlcm1pbmVkIGZyb20gdGhlaXIgQ1NTIHRyYW5zZm9ybXMsIHdpdGhv dXQgaGF2aW5nIHRoaXMgYmVoYXZpb3VyCisgICAgICAgIHVuY29uZGl0aW9uYWxseSBlbmFibGVk IGdsb2JhbGx5LgorCisgICAgICAgIFN1cHBvcnRzIGh0dHA6Ly9jcmJ1Zy5jb20vMTQ5OTQzCisK KyAgICAgICAgKiBjaHJvbWl1bS9wdWJsaWMvV2ViTGF5ZXIuaDoKKyAgICAgICAgKFdlYkxheWVy KToKKwogMjAxMi0xMC0yMiAgS2Vpc2hpIEhhdHRvcmkgIDxrZWlzaGlAd2Via2l0Lm9yZz4KIAog ICAgICAgICBSZW1vdmUgbW9udGhGb3JtYXRJbkxETUwKZGlmZiAtLWdpdCBhL1NvdXJjZS9QbGF0 Zm9ybS9jaHJvbWl1bS9wdWJsaWMvV2ViQ29udGVudExheWVyLmggYi9Tb3VyY2UvUGxhdGZvcm0v Y2hyb21pdW0vcHVibGljL1dlYkNvbnRlbnRMYXllci5oCmluZGV4IGEwZWQwZTRlYjZhN2UwYmEw YTEzZmU2YTQwYThlNTk2MTJkNjg5NTQuLmJhN2M4M2I1NmFmZTc4MmNlZDM0ZTU2YjE1MzM0MDY3 Nzc5OTIyNWEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9QbGF0Zm9ybS9jaHJvbWl1bS9wdWJsaWMvV2Vi Q29udGVudExheWVyLmgKKysrIGIvU291cmNlL1BsYXRmb3JtL2Nocm9taXVtL3B1YmxpYy9XZWJD b250ZW50TGF5ZXIuaApAQCAtNDksNiArNDksMTEgQEAgcHVibGljOgogICAgIHZpcnR1YWwgdm9p ZCBzZXRCb3VuZHNDb250YWluUGFnZVNjYWxlKGJvb2wpID0gMDsKICAgICB2aXJ0dWFsIGJvb2wg Ym91bmRzQ29udGFpblBhZ2VTY2FsZSgpIGNvbnN0ID0gMDsKIAorICAgIC8vIEFsbG93IHRoZSBj b21wb3NpdG9yIHRvIGRldGVybWluZSB0aGUgc2NhbGUgYXQgd2hpY2ggdGhlIGxheWVyIHNob3Vs ZAorICAgIC8vIGJlIHJhc3Rlcml6ZWQgYmFzZWQgb24gdGhlIGxheWVyJ3MgaGllcmFyY2h5IGFu ZCB0cmFuc2Zvcm0uIFRoaXMgZGVmYXVsdHMKKyAgICAvLyB0byBmYWxzZS4KKyAgICB2aXJ0dWFs IHZvaWQgc2V0QXV0b21hdGljYWxseUNvbXB1dGVSYXN0ZXJTY2FsZShib29sKSB7IH0KKwogICAg IC8vIFNldCB0byByZW5kZXIgdGV4dCBpbiB0aGlzIGxheWVyIHdpdGggTENEIGFudGlhbGlhc2lu Zy4gT25seSBzZXQgaWYgeW91IGtub3cgdGhhdCB0aGlzIGxheWVyIHdpbGwgYmUKICAgICAvLyBk cmF3biBpbiBhIHdheSB3aGVyZSB0aGlzIG1ha2VzIHNlbnNlIC0gaS5lLiBvcGFxdWUgYmFja2dy b3VuZCwgbm90IHJvdGF0ZWQgb3Igc2NhbGVkLCBldGMuCiAgICAgLy8gRGVmYXVsdHMgdG8gZmFs c2U7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1 bS9HcmFwaGljc0xheWVyQ2hyb21pdW0uY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3Jh cGhpY3MvY2hyb21pdW0vR3JhcGhpY3NMYXllckNocm9taXVtLmNwcAppbmRleCAwNzU3NDllOWEx YjhlYzYxN2ZkZWNhODljZmZkMmU0OWE4ODI5NjhkLi5hNTk1ZGYyOGRhMTZhNDA1ZTRmYzQ4MzQ2 NzczMGM3MmY1Y2VhNmVmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFw aGljcy9jaHJvbWl1bS9HcmFwaGljc0xheWVyQ2hyb21pdW0uY3BwCisrKyBiL1NvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL0dyYXBoaWNzTGF5ZXJDaHJvbWl1bS5jcHAK QEAgLTEwNSw2ICsxMDUsNyBAQCBHcmFwaGljc0xheWVyQ2hyb21pdW06OkdyYXBoaWNzTGF5ZXJD aHJvbWl1bShHcmFwaGljc0xheWVyQ2xpZW50KiBjbGllbnQpCiAgICAgbV9sYXllciA9IGFkb3B0 UHRyKFBsYXRmb3JtOjpjdXJyZW50KCktPmNvbXBvc2l0b3JTdXBwb3J0KCktPmNyZWF0ZUNvbnRl bnRMYXllcihtX29wYXF1ZVJlY3RUcmFja2luZ0NvbnRlbnRMYXllckRlbGVnYXRlLmdldCgpKSk7 CiAgICAgbV9sYXllci0+bGF5ZXIoKS0+c2V0RHJhd3NDb250ZW50KG1fZHJhd3NDb250ZW50ICYm IG1fY29udGVudHNWaXNpYmxlKTsKICAgICBtX2xheWVyLT5sYXllcigpLT5zZXRTY3JvbGxDbGll bnQodGhpcyk7CisgICAgbV9sYXllci0+c2V0QXV0b21hdGljYWxseUNvbXB1dGVSYXN0ZXJTY2Fs ZSh0cnVlKTsKICAgICB1cGRhdGVEZWJ1Z0luZGljYXRvcnMoKTsKIH0KIAo=