100010 2012-10-22 09:43:17 -0700 [EFL][WK2] fast/repaint/delete-into-nested-block.html and fast/repaint/4776765.html are flaky 2012-10-29 02:39:25 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 rakuco rakuco d-r kenneth lucas.de.marchi oldest_to_newest 747627 0 rakuco 2012-10-22 09:43:17 -0700 It looks like there's some problem with the focus code in WTR: when fast/repaint/4774354.html (which calls focus() in an iframe) is run before those tests, it looks like the view itself (or the main frame, I don't know) is not considered focused anymore, and the focus ring is not drawn around the <div>s. 748671 1 rakuco 2012-10-23 08:33:06 -0700 So this is how things are working so far: o TestController::resetStateToConsistentValues() calls PlatformWebView::focus(), which calls evas_object_focus_set(..., true) before every test is run. o Before running the first test (fast/repaint/4774354.html), this call to evas_object_focus_set() makes the main view receive focus, and WebPageProxy::viewStateDidChange() ends up making the web process call WebPage::setFocused(true), which is the normal flow anyway. o This test then focuses an iframe it has via `window.frames[0].focus'. This makes WebCore::FrameSelection::setFocused(false) be called for the main frame's frame selection, and WebCore::FrameSelection::setFocused(true) be called for the iframe's frame selection. o When the test finishes, the main frame's frame selection is still internally in an unfocused state, however Evas considers the main view to still be focused. o fast/repaint/delete-into-nested-block.html is then run, and when WebCore then queries the main frame's FrameSelection to see it is focused in order to decide whether to draw the focus ring around the <div>, that query returns false and the focus ring is not drawn. o WebCore::FrameSelection::setFocused(true) is not called despite TestController::resetStateToConsistentValues() and thus PlatformWebView::focus() being called before each test because evas_object_focus_set(..., true) becomes a no-op since Evas thinks the main view (an Evas_Object) is still visible, as we had already called evas_object_focus_set(..., true) before. WebPageProxy::viewStateDidChange() is then not called, and the main frame's frame selection state is never reset to true. That problem does not affect DRT because we call ewk_frame_feed_focus_in() there, whose sole responsibility is to manually call WebCore::FocusController::setFocusedFrame() on the main frame, and this triggers a call to WebCore::FrameSelection::setFocused(true). The next step is thinking of a solution :-) 749539 2 170362 rakuco 2012-10-24 04:39:56 -0700 Created attachment 170362 Patch 749586 3 170362 rakuco 2012-10-24 05:38:14 -0700 Comment on attachment 170362 Patch Clearing flags on attachment: 170362 Committed r132342: <http://trac.webkit.org/changeset/132342> 749587 4 rakuco 2012-10-24 05:38:22 -0700 All reviewed patches have been landed. Closing bug. 749642 5 d-r 2012-10-24 07:21:59 -0700 This causes some extra output in frame-tab-focus.html - shouldn't we fix this in a way that does not require a platform specific result for this test? Going to skip for now. --- /home/buildslave-1/webkit-buildslave/efl-linux-64-debug-wk2/build/layout-test-results/fast/events/frame-tab-focus-expected.txt +++ /home/buildslave-1/webkit-buildslave/efl-linux-64-debug-wk2/build/layout-test-results/fast/events/frame-tab-focus-actual.txt @@ -1,6 +1,8 @@ This page tests tabbing between subframes. To test, click on this text to focus the main window. Then press Tab 7 times, then Shift-Tab 7 times, which should move focus forward and backward through all inputs and frames. Then press Option-Tab 11 times and Shift-Option-Tab 11 times, which should move focus forward and backward through all inputs, frames, and links. [tabindex of one] [tabindex of three] [tabindex of two] [tabindex of three] +main window: window blurred +main window: window focused Tabbing forward... main window: INPUT #2 (tabindex=2) focused 753200 6 rakuco 2012-10-29 02:39:25 -0700 (In reply to comment #5) > This causes some extra output in frame-tab-focus.html I've filed bug 100646 to track this. 170362 2012-10-24 04:39:56 -0700 2012-10-24 05:38:14 -0700 Patch bug-100010-20121024143830.patch text/plain 1914 rakuco SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDEzMjMzNCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDIyIEBACisyMDEyLTEwLTI0ICBSYXBoYWVsIEt1Ym8gZGEgQ29zdGEgIDxyYXBoYWVsLmt1 Ym8uZGEuY29zdGFAaW50ZWwuY29tPgorCisgICAgICAgIFtFRkxdW1dLMl0gZmFzdC9yZXBhaW50 L2RlbGV0ZS1pbnRvLW5lc3RlZC1ibG9jay5odG1sIGFuZCBmYXN0L3JlcGFpbnQvNDc3Njc2NS5o dG1sIGFyZSBmbGFreQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MTAwMDEwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgRm9yY2UgdGhlIG1haW4gdmlldyB0byByZWNlaXZlIGZvY3VzIGV2ZW4gaWYgRXZhcyBh bHJlYWR5CisgICAgICAgIGNvbnNpZGVycyBpdCB0byBiZSBmb2N1c2VkLgorCisgICAgICAgIEl0 IG1pZ2h0IGhhcHBlbiB0aGF0IGEgZGlmZmVyZW50IGZyYW1lIGlzIGZvY3VzZWQgYnkgYSBwYWdl IGFuZAorICAgICAgICB0aGUgZm9jdXMgY2hhbmdlIG5vdGlmaWNhdGlvbiBkb2VzIG5vdCByZWFj aCBFdmFzLiBXaGVuIGFub3RoZXIKKyAgICAgICAgdGVzdCBpcyBydW4sIHRoZSBtYWluIGZyYW1l IGlzIHRoZW4gbm90IGNvbnNpZGVyZWQgdG8gYmUgZm9jdXNlZAorICAgICAgICBieSBXZWJDb3Jl LCBhbmQgdGhpbmdzIHN1Y2ggYXMgZm9jdXMgcmluZ3MgYXJlIG5vdCBkcmF3biBhcworICAgICAg ICBleHBlY3RlZC4KKworICAgICAgICAqIFdlYktpdFRlc3RSdW5uZXIvZWZsL1BsYXRmb3JtV2Vi Vmlld0VmbC5jcHA6CisgICAgICAgIChXVFI6OlBsYXRmb3JtV2ViVmlldzo6Zm9jdXMpOgorCiAy MDEyLTEwLTI0ICBHcnplZ29yeiBDemFqa293c2tpICA8Zy5jemFqa293c2tpQHNhbXN1bmcuY29t PgogCiAgICAgICAgIFdlYktpdFRlc3RSdW5uZXIgbmVlZHMgdG8gdHVybiBvbiAnc2V0Q29udGlu dW91c1NwZWxsQ2hlY2tpbmdFbmFibGVkJwpJbmRleDogVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9l ZmwvUGxhdGZvcm1XZWJWaWV3RWZsLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9XZWJLaXRUZXN0 UnVubmVyL2VmbC9QbGF0Zm9ybVdlYlZpZXdFZmwuY3BwCShyZXZpc2lvbiAxMzIzMzMpCisrKyBU b29scy9XZWJLaXRUZXN0UnVubmVyL2VmbC9QbGF0Zm9ybVdlYlZpZXdFZmwuY3BwCSh3b3JraW5n IGNvcHkpCkBAIC02OSw2ICs2OSwxMSBAQCBXS1BhZ2VSZWYgUGxhdGZvcm1XZWJWaWV3OjpwYWdl KCkKIAogdm9pZCBQbGF0Zm9ybVdlYlZpZXc6OmZvY3VzKCkKIHsKKyAgICAvLyBGb3JjZSB0aGUg dmlldyB0byByZWNlaXZlIGZvY3VzIGV2ZW4gaWYgRXZhcyBjb25zaWRlcnMgaXQgdG8gYmUgZm9j dXNlZDsgc29tZXRpbWVzIGFuIGlmcmFtZSBtaWdodCByZWNlaXZlCisgICAgLy8gZm9jdXNlZCB2 aWEgSmF2YVNjcmlwdCBhbmQgdGhlIG1haW4gZnJhbWUgaXMgY29uc2lkZXJlZCB1bmZvY3VzZWQs IGJ1dCB0aGF0IGlzIG5vdCBub3RpY2VkIGJ5IEV2YXMuCisgICAgLy8gUGVyaGFwcyBXZWJDb3Jl U3VwcG9ydDo6Zm9jdXNlZEZyYW1lQ2hhbmdlZCgpIHNob3VsZCBlbWl0IHNvbWUgc29ydCBvZiBu b3RpZmljYXRpb24/CisgICAgaWYgKGV2YXNfb2JqZWN0X2ZvY3VzX2dldChtX3ZpZXcpKQorICAg ICAgICBldmFzX29iamVjdF9mb2N1c19zZXQobV92aWV3LCBmYWxzZSk7CiAgICAgZXZhc19vYmpl Y3RfZm9jdXNfc2V0KG1fdmlldywgdHJ1ZSk7CiB9CiAK