100008 2012-10-22 09:23:51 -0700 r131955 is has improper function call in LinkHashChromium.cpp 2012-10-22 11:58:22 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 99735 1 msaboff msaboff oldest_to_newest 747602 0 msaboff 2012-10-22 09:23:51 -0700 Change set r131955: <http://trac.webkit.org/changeset/131955> adds the following to LinkHashChromium.cpp: LinkHash visitedLinkHash(const String& url) { return (url.characters(), url.length()); } The return should really be: return visitedLinkHash(url.characters(), url.length()); 747603 1 169924 msaboff 2012-10-22 09:25:37 -0700 Created attachment 169924 Patch 747704 2 169924 ap 2012-10-22 11:10:27 -0700 Comment on attachment 169924 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=169924&action=review Wow. Ideally, this should have a regression test, but I appreciate that this needs to be fixed quickly, and you probably don't have a way to easily test with Chromium. > Source/WebCore/ChangeLog:13 > + * xml/parser/MarkupTokenBase.h: No? 747741 3 msaboff 2012-10-22 11:58:22 -0700 Committed r132116: <http://trac.webkit.org/changeset/132116> 169924 2012-10-22 09:25:37 -0700 2012-10-22 11:10:26 -0700 Patch 100008.patch text/plain 1458 msaboff SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEzMjA3NykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDEyLTEwLTIyICBNaWNoYWVs IFNhYm9mZiAgPG1zYWJvZmZAYXBwbGUuY29tPgorCisgICAgICAgIEFkZCBTdHJpbmcgdmVyc2lv biBvZiB2aXNpdGVkTGlua0hhc2goKSB0byBwcm9wZXJseSBoYW5kbGUgOC1iaXQgVVJMIFN0cmlu Z3MuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05OTcz NQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEZvbGxv d3VwIGZpeCB0byByMTMxOTU1IGZvciBjaHJvbWl1bSBwbGF0Zm9ybS4gIEFkZGVkIGNhbGwgdG8g CisgICAgICAgIChjb25zdCBVQ2hhciosIHVuc2lnbmVkKSB2ZXJzaW9uIG9mIHZpc2l0ZWRMaW5r SGFzaCBmcm9tIFN0cmluZyYgdmVyc2lvbi4KKworICAgICAgICAqIHBsYXRmb3JtL2Nocm9taXVt L0xpbmtIYXNoQ2hyb21pdW0uY3BwOgorICAgICAgICAoV2ViQ29yZTo6dmlzaXRlZExpbmtIYXNo KToKKyAgICAgICAgKiB4bWwvcGFyc2VyL01hcmt1cFRva2VuQmFzZS5oOgorCiAyMDEyLTEwLTIy ICBCcnVubyBkZSBPbGl2ZWlyYSBBYmluYWRlciAgPGJydW5vLmFiaW5hZGVyQGJhc3lza29tLmNv bT4KIAogICAgICAgICBbY3NzMy10ZXh0XSBBZGQgcmVuZGVyaW5nIHN1cHBvcnQgZm9yIC13ZWJr aXQtdGV4dC1kZWNvcmF0aW9uLXN0eWxlCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9j aHJvbWl1bS9MaW5rSGFzaENocm9taXVtLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9jaHJvbWl1bS9MaW5rSGFzaENocm9taXVtLmNwcAkocmV2aXNpb24gMTMyMDc3 KQorKysgU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vY2hyb21pdW0vTGlua0hhc2hDaHJvbWl1bS5j cHAJKHdvcmtpbmcgY29weSkKQEAgLTUzLDcgKzUzLDcgQEAgTGlua0hhc2ggdmlzaXRlZExpbmtI YXNoKGNvbnN0IFVDaGFyKiB1cgogCiBMaW5rSGFzaCB2aXNpdGVkTGlua0hhc2goY29uc3QgU3Ry aW5nJiB1cmwpCiB7Ci0gICAgcmV0dXJuICh1cmwuY2hhcmFjdGVycygpLCB1cmwubGVuZ3RoKCkp OyAKKyAgICByZXR1cm4gdmlzaXRlZExpbmtIYXNoKHVybC5jaGFyYWN0ZXJzKCksIHVybC5sZW5n dGgoKSk7CiB9CiAKIExpbmtIYXNoIHZpc2l0ZWRMaW5rSGFzaChjb25zdCBLVVJMJiBiYXNlLCBj b25zdCBBdG9taWNTdHJpbmcmIGF0dHJpYnV0ZVVSTCkK