100007 2012-10-22 09:14:38 -0700 [EFL][WK2] ewk_view_color_picker_color_set() is leaking 2012-10-22 13:11:56 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 naginenis naginenis gyuyoung.kim kenneth lucas.de.marchi rakuco webkit.review.bot oldest_to_newest 747595 0 naginenis 2012-10-22 09:14:38 -0700 We should adopt the WKStringRef returned by WKStringCreateWithUTF8CString to avoid the leak in ewk_view_color_picker_color_set(). > 1944 const WKStringRef colorString = WKStringCreateWithUTF8CString(color.serialized().utf8().data()); 747617 1 169926 naginenis 2012-10-22 09:31:40 -0700 Created attachment 169926 Patch 747804 2 169926 webkit.review.bot 2012-10-22 13:11:51 -0700 Comment on attachment 169926 Patch Clearing flags on attachment: 169926 Committed r132126: <http://trac.webkit.org/changeset/132126> 747805 3 webkit.review.bot 2012-10-22 13:11:56 -0700 All reviewed patches have been landed. Closing bug. 169926 2012-10-22 09:31:40 -0700 2012-10-22 13:11:51 -0700 Patch 100007.patch text/plain 1731 naginenis ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCA2MDY4MjEwLi5jOTQ0MjYxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYg QEAKKzIwMTItMTAtMjIgIFN1ZGFyc2FuYSBOYWdpbmVuaSAgPHN1ZGFyc2FuYS5uYWdpbmVuaUBp bnRlbC5jb20+CisKKyAgICAgICAgW0VGTF1bV0syXSBld2tfdmlld19jb2xvcl9waWNrZXJfY29s b3Jfc2V0KCkgaXMgbGVha2luZworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTAwMDA3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgRml4IGEgbGVhayBpbiBld2tfdmlld19jb2xvcl9waWNrZXJfY29sb3Jfc2V0 KCkgYnkgYWRvcHRpbmcgV0tTdHJpbmdSZWYKKyAgICAgICAgcmV0dXJuZWQgYnkgV0tTdHJpbmdD cmVhdGVXaXRoVVRGOENTdHJpbmcoKS4KKworICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvZWZsL2V3 a192aWV3LmNwcDoKKyAgICAgICAgKGV3a192aWV3X2NvbG9yX3BpY2tlcl9jb2xvcl9zZXQpOgor CiAyMDEyLTEwLTIyICBKb2NlbHluIFR1cmNvdHRlICA8am9jZWx5bi50dXJjb3R0ZUBkaWdpYS5j b20+CiAKICAgICAgICAgW1F0XSBGaXggIkFTU0VSVElPTiBGQUlMRUQ6ICFkb2N1bWVudC0+aW5Q YWdlQ2FjaGUoKSIgd2hlbiBsb2FkaW5nIGEgcGFnZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktp dDIvVUlQcm9jZXNzL0FQSS9lZmwvZXdrX3ZpZXcuY3BwIGIvU291cmNlL1dlYktpdDIvVUlQcm9j ZXNzL0FQSS9lZmwvZXdrX3ZpZXcuY3BwCmluZGV4IGQ4NjA4YWEuLjAyZTRjODEgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZsL2V3a192aWV3LmNwcAorKysgYi9T b3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2VmbC9ld2tfdmlldy5jcHAKQEAgLTE5NDIsOCAr MTk0Miw4IEBAIEVpbmFfQm9vbCBld2tfdmlld19jb2xvcl9waWNrZXJfY29sb3Jfc2V0KEV2YXNf T2JqZWN0KiBld2tWaWV3LCBpbnQgciwgaW50IGcsIGluCiAgICAgRUlOQV9TQUZFVFlfT05fTlVM TF9SRVRVUk5fVkFMKHByaXYtPmNvbG9yUGlja2VyUmVzdWx0TGlzdGVuZXIsIGZhbHNlKTsKIAog ICAgIFdlYkNvcmU6OkNvbG9yIGNvbG9yID0gV2ViQ29yZTo6Q29sb3IociwgZywgYiwgYSk7Ci0g ICAgY29uc3QgV0tTdHJpbmdSZWYgY29sb3JTdHJpbmcgPSBXS1N0cmluZ0NyZWF0ZVdpdGhVVEY4 Q1N0cmluZyhjb2xvci5zZXJpYWxpemVkKCkudXRmOCgpLmRhdGEoKSk7Ci0gICAgV0tDb2xvclBp Y2tlclJlc3VsdExpc3RlbmVyU2V0Q29sb3IocHJpdi0+Y29sb3JQaWNrZXJSZXN1bHRMaXN0ZW5l ci5nZXQoKSwgY29sb3JTdHJpbmcpOworICAgIFdLUmV0YWluUHRyPFdLU3RyaW5nUmVmPiBjb2xv clN0cmluZyhBZG9wdFdLLCBXS1N0cmluZ0NyZWF0ZVdpdGhVVEY4Q1N0cmluZyhjb2xvci5zZXJp YWxpemVkKCkudXRmOCgpLmRhdGEoKSkpOworICAgIFdLQ29sb3JQaWNrZXJSZXN1bHRMaXN0ZW5l clNldENvbG9yKHByaXYtPmNvbG9yUGlja2VyUmVzdWx0TGlzdGVuZXIuZ2V0KCksIGNvbG9yU3Ry aW5nLmdldCgpKTsKICAgICBwcml2LT5jb2xvclBpY2tlclJlc3VsdExpc3RlbmVyLmNsZWFyKCk7 CiAKICAgICByZXR1cm4gdHJ1ZTsK