Bug 119228 – TextTrackRepresentation captions often disappear then appear again.

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Jer Noble]

TextTrackRepresentation captions often disappear then appear again.

[Jer Noble]

<rdar://problem/14550924>

[Jer Noble]

Created attachment 207677 [details]
Patch

[WebKit Commit Bot]

Attachment 207677 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/html/HTMLMediaElement.cpp', u'Source/WebCore/html/HTMLMediaElement.h']" exit_code: 1
Source/WebCore/html/HTMLMediaElement.h:295:  The parameter name "flags" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 1 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Simon Fraser (smfr)]

Comment on attachment 207677 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=207677&action=review

> Source/WebCore/html/HTMLMediaElement.h:294
> +    enum ConfigureTextTrackDisplayFlags { DoNotAssumeVisibleTextTracksChanged, AssumeVisibleTextTracksChanged };

"Flags" make me think this is a bitmask, and then the "flags == DoNotAssumeVisibleTextTracksChanged" code seemed iffy. Not sure I like "AssumeVisibleTextTracksChanged" etc; can you change the name to something more descriptive of the impact?

[Jer Noble]

Committed r153448: <http://trac.webkit.org/changeset/153448>

[Simon Fraser (smfr)]

This broke the media/video-controls-captions-trackmenu.html test