Bug 134119

Summary: Add copy/move constructors and assignment operators to WTF::Optional
Product: WebKit Reporter: Anders Carlsson <andersca>
Component: New BugsAssignee: Anders Carlsson <andersca>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, cmarcelo, commit-queue
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch kling: review+

Anders Carlsson
Reported 2014-06-20 13:49:56 PDT
Add copy/move constructors and assignment operators to WTF::Optional
Attachments
Patch (3.02 KB, patch)
2014-06-20 13:50 PDT, Anders Carlsson
kling: review+
Note You need to log in before you can comment on or make changes to this bug.
Anders Carlsson
Comment 1 2014-06-20 13:50:22 PDT
Andreas Kling
Comment 2 2014-06-20 13:54:26 PDT
Comment on attachment 233449 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=233449&action=review r=me with a bug fix: > Source/WTF/wtf/Optional.h:137 > + new (NotNull, std::addressof(m_value)) T(std::forward<U>(u)); > + return *this; Missing "m_isEngaged = true;" here.
Anders Carlsson
Comment 3 2014-06-20 13:55:30 PDT