Attachment 343899 Details for Bug 98345 – Patch

[patch] Patch

bug-98345-20180629185433.patch (text/plain), 3.30 KB, created by Fujii Hironori on 2018-06-29 02:54:34 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Fujii Hironori

Created: 2018-06-29 02:54:34 PDT

Size: 3.30 KB

patch

obsolete

>Subversion Revision: 233350
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index 972ad9b4a50ebf1445061d574d35e0d9a777a364..a5277714f89ed0b038992b4201e16e7287009514 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,19 @@
>+2018-06-29  Fujii Hironori  <Hironori.Fujii@sony.com>
>+
>+        [WK2] fast/parser/document-open-in-unload.html makes the following test crash
>+        https://bugs.webkit.org/show_bug.cgi?id=98345
>+        <rdar://problem/12474923>
>+
>+        Reviewed by Ryosuke Niwa.
>+
>+        m_documentLoader can become null in the middle of
>+        FrameLoader::commitProvisionalLoad by stopping the loading.
>+
>+        No new tests (Covered by existing tests).
>+
>+        * loader/FrameLoader.cpp:
>+        (WebCore::FrameLoader::commitProvisionalLoad): Do null check of m_documentLoader.
>+
> 2018-06-29  Zalan Bujtas  <zalan@apple.com>
> 
>         [LFC] The static position for an out-of-flow box should include the previous sibling's collapsed margin
>diff --git a/Source/WebCore/loader/FrameLoader.cpp b/Source/WebCore/loader/FrameLoader.cpp
>index 4ee524631672df923543cd4245ea68e011b0f3f1..48939ff4dc78640b454bb45b0aa931d7ef317bc0 100644
>--- a/Source/WebCore/loader/FrameLoader.cpp
>+++ b/Source/WebCore/loader/FrameLoader.cpp
>@@ -2010,7 +2010,9 @@ void FrameLoader::commitProvisionalLoad()
>     LOG(Loading, "WebCoreLoading %s: Finished committing provisional load to URL %s", m_frame.tree().uniqueName().string().utf8().data(),
>         m_frame.document() ? m_frame.document()->url().stringCenterEllipsizedToLength().utf8().data() : "");
> 
>-    if (m_loadType == FrameLoadType::Standard && m_documentLoader->isClientRedirect())
>+    if (m_loadType == FrameLoadType::Standard
>+        && m_documentLoader
>+        && m_documentLoader->isClientRedirect())
>         history().updateForClientRedirect();
> 
>     if (m_loadingFromCachedPage) {
>diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
>index a952e40e2fef8a9faa8b8a100c85b565f82cdead..100bf69bb0f02cd69a14ef0f0a6783ab4e9bb9e7 100644
>--- a/LayoutTests/ChangeLog
>+++ b/LayoutTests/ChangeLog
>@@ -1,3 +1,13 @@
>+2018-06-29  Fujii Hironori  <Hironori.Fujii@sony.com>
>+
>+        [WK2] fast/parser/document-open-in-unload.html makes the following test crash
>+        https://bugs.webkit.org/show_bug.cgi?id=98345
>+        <rdar://problem/12474923>
>+
>+        Reviewed by Ryosuke Niwa.
>+
>+        * platform/wk2/TestExpectations: Unskipped fast/parser/document-open-in-unload.html.
>+
> 2018-06-27  Antoine Quint  <graouts@apple.com>
> 
>         [Web Animations] Using a Web Animation leaks the Document
>diff --git a/LayoutTests/platform/wk2/TestExpectations b/LayoutTests/platform/wk2/TestExpectations
>index ef20d396424924d40be6cd2e8ad83dea6df19327..5a312bf075bff6a7f1312e045067dd4264382054 100644
>--- a/LayoutTests/platform/wk2/TestExpectations
>+++ b/LayoutTests/platform/wk2/TestExpectations
>@@ -157,9 +157,6 @@ plugins/npruntime/embed-property-iframe-equality.html
> 
> webkit.org/b/105952 fast/loader/submit-form-while-parsing-2.html [ Pass Failure ]
> 
>-# Causes next test to crash only on WebKit2
>-webkit.org/b/98345 fast/parser/document-open-in-unload.html [ Skip ]
>-
> webkit.org/b/141122 editing/selection/programmatic-selection-on-mac-is-directionless.html [ Pass Failure ]
> 
> webkit.org/b/149087 http/tests/cache/disk-cache/disk-cache-cancel.html [ Pass Failure ]

Actions: View | Formatted Diff | Diff

Attachments on bug 98345: 343575 | 343577 | 343579 | 343584 | 343585 | 343701 | 343899 | 344067