Attachment 343888 Details for Bug 187168 – Patch

[patch] Patch

bug-187168-20180628193617.patch (text/plain), 2.00 KB, created by zalan on 2018-06-28 19:36:17 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: zalan

Created: 2018-06-28 19:36:17 PDT

Size: 2.00 KB

patch

obsolete

>Subversion Revision: 233307
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index ee9a8bd0fb44ed6717df2a76f370254c04e21074..56a48e61787940dd98e3440d6f5cf859eaaaf877 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,17 @@
>+2018-06-28  Zalan Bujtas  <zalan@apple.com>
>+
>+        [LFC] Out-of-flow positioned height does not necessarily equal to "bottom - top".
>+        https://bugs.webkit.org/show_bug.cgi?id=187168
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        According to the spec "For absolutely positioned elements, the used values of the vertical dimensions must satisfy this constraint:
>+        'top' + 'margin-top' + 'border-top-width' + 'padding-top' + 'height' + 'padding-bottom' + 'border-bottom-width' + 'margin-bottom' + 'bottom' = height of containing block"
>+        With a non-auto "height" value, the bottom - top does not necessarily compute to the height of the element.
>+
>+        * layout/FormattingContext.cpp:
>+        (WebCore::Layout::FormattingContext::computeOutOfFlowVerticalGeometry const):
>+
> 2018-06-28  Zalan Bujtas  <zalan@apple.com>
> 
>         [LFC] Add Display::Box::nonCollapsedMarginBox for verification purposes.
>diff --git a/Source/WebCore/layout/FormattingContext.cpp b/Source/WebCore/layout/FormattingContext.cpp
>index d81885906013e17cfb999f441bc9980c6f5e91b4..f284d1ecdb985036a1ad71d64d07e28b3ee7af6c 100644
>--- a/Source/WebCore/layout/FormattingContext.cpp
>+++ b/Source/WebCore/layout/FormattingContext.cpp
>@@ -80,7 +80,7 @@ void FormattingContext::computeOutOfFlowVerticalGeometry(LayoutContext& layoutCo
> {
>     auto verticalGeometry = Geometry::outOfFlowVerticalGeometry(layoutContext, layoutBox);
>     displayBox.setTop(verticalGeometry.top);
>-    displayBox.setContentBoxHeight(verticalGeometry.bottom - verticalGeometry.top);
>+    displayBox.setContentBoxHeight(verticalGeometry.heightAndMargin.height);
>     ASSERT(!verticalGeometry.heightAndMargin.collapsedMargin);
>     displayBox.setVerticalMargin(verticalGeometry.heightAndMargin.margin);
> }

Flags:

koivisto: review+

Actions: View | Formatted Diff | Diff

Attachments on bug 187168: 343888