Attachment 343877 Details for Bug 187164 – Patch

[patch] Patch

bug-187164-20180628174556.patch (text/plain), 6.26 KB, created by Olivia Barnett on 2018-06-28 17:45:56 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Olivia Barnett

Created: 2018-06-28 17:45:56 PDT

Size: 6.26 KB

patch

obsolete

>Subversion Revision: 233208
>diff --git a/Source/WTF/ChangeLog b/Source/WTF/ChangeLog
>index b4a742c64445e9619844f6d95955049534a2973d..ff30103c469bfc10a56c19a6418e46f40f03a344 100644
>--- a/Source/WTF/ChangeLog
>+++ b/Source/WTF/ChangeLog
>@@ -1,3 +1,14 @@
>+2018-06-28  Olivia Barnett  <obarnett@apple.com>
>+
>+        Find in page for typographic quotes does not find low (German) quotes
>+        https://bugs.webkit.org/show_bug.cgi?id=187164
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Added Unicode definitions for German quotation marks.
>+
>+        * wtf/unicode/CharacterNames.h:
>+
> 2018-06-25  David Fenton  <david_fenton@apple.com>
> 
>         Unreviewed, rolling out r233120.
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index 976923bbc04115d6bb3b0f1230a050ab6aae15e6..da4ce91914adcfe4650ff7a268ad1782fad5cf31 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,18 @@
>+2018-06-28  Olivia Barnett  <obarnett@apple.com>
>+
>+        Find in page for typographic quotes does not find low (German) quotes
>+        https://bugs.webkit.org/show_bug.cgi?id=187164
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Added additional quote test to LayoutTests/fast/text/find-quotes.html.
>+
>+        Added functionality to replace German quotes when matching.
>+
>+        * editing/TextIterator.cpp:
>+        (WebCore::foldQuoteMark):
>+        (WebCore::foldQuoteMarks):
>+
> 2018-06-26  Thibault Saunier  <tsaunier@igalia.com>
> 
>         [GStreamer] Do not forget to set stream on track switching
>diff --git a/Source/WTF/wtf/unicode/CharacterNames.h b/Source/WTF/wtf/unicode/CharacterNames.h
>index 1bdd0601ce93aa5701615f2767682cdf0e1c3ae1..eb18792f2dd149e0bb67d9fef55cacba6e60d78c 100644
>--- a/Source/WTF/wtf/unicode/CharacterNames.h
>+++ b/Source/WTF/wtf/unicode/CharacterNames.h
>@@ -60,7 +60,9 @@ const UChar ideographicComma = 0x3001;
> const UChar ideographicFullStop = 0x3002;
> const UChar ideographicSpace = 0x3000;
> const UChar leftDoubleQuotationMark = 0x201C;
>+const UChar leftLowDoubleQuotationMark = 0x201E;
> const UChar leftSingleQuotationMark = 0x2018;
>+const UChar leftLowSingleQuotationMark = 0x201A;
> const UChar leftToRightEmbed = 0x202A;
> const UChar leftToRightIsolate = 0x2066;
> const UChar leftToRightMark = 0x200E;
>@@ -125,7 +127,9 @@ using WTF::Unicode::ideographicComma;
> using WTF::Unicode::ideographicFullStop;
> using WTF::Unicode::ideographicSpace;
> using WTF::Unicode::leftDoubleQuotationMark;
>+using WTF::Unicode::leftLowDoubleQuotationMark;
> using WTF::Unicode::leftSingleQuotationMark;
>+using WTF::Unicode::leftLowSingleQuotationMark;
> using WTF::Unicode::leftToRightEmbed;
> using WTF::Unicode::leftToRightIsolate;
> using WTF::Unicode::leftToRightMark;
>diff --git a/Source/WebCore/editing/TextIterator.cpp b/Source/WebCore/editing/TextIterator.cpp
>index 4ade6f42c3d182ed5965c1cdd8ec45ef778f1d91..66508203d4688706a75a697705345641bfcab064 100644
>--- a/Source/WebCore/editing/TextIterator.cpp
>+++ b/Source/WebCore/editing/TextIterator.cpp
>@@ -1756,10 +1756,12 @@ static inline UChar foldQuoteMark(UChar c)
>     switch (c) {
>         case hebrewPunctuationGershayim:
>         case leftDoubleQuotationMark:
>+        case leftLowDoubleQuotationMark:
>         case rightDoubleQuotationMark:
>             return '"';
>         case hebrewPunctuationGeresh:
>         case leftSingleQuotationMark:
>+        case leftLowSingleQuotationMark:
>         case rightSingleQuotationMark:
>             return '\'';
>         default:
>@@ -1775,7 +1777,9 @@ static inline String foldQuoteMarks(String string)
>     string.replace(hebrewPunctuationGeresh, '\'');
>     string.replace(hebrewPunctuationGershayim, '"');
>     string.replace(leftDoubleQuotationMark, '"');
>+    string.replace(leftLowDoubleQuotationMark, '"');
>     string.replace(leftSingleQuotationMark, '\'');
>+    string.replace(leftLowSingleQuotationMark, '\'');
>     string.replace(rightDoubleQuotationMark, '"');
>     string.replace(rightSingleQuotationMark, '\'');
> 
>diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
>index dece0a4273f8a3d4fd3910a4957aa2f0ef41f90b..551d7ea88be031bd72ed13e2c6a66d6f21777c85 100644
>--- a/LayoutTests/ChangeLog
>+++ b/LayoutTests/ChangeLog
>@@ -1,3 +1,14 @@
>+2018-06-28  Olivia Barnett  <obarnett@apple.com>
>+        
>+        Find in page for typographic quotes does not find low (German) quotes
>+        https://bugs.webkit.org/show_bug.cgi?id=187164
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Added additional test for German quotes.
>+
>+        * fast/text/find-quotes.html:
>+
> 2018-06-26  Truitt Savell  <tsavell@apple.com>
> 
>         Layout Test http/tests/resourceLoadStatistics/prevalent-resource-without-user-interaction.html is flaky
>diff --git a/LayoutTests/fast/text/find-quotes.html b/LayoutTests/fast/text/find-quotes.html
>index 523c4a9b57bfff9ad80049a421d07394a5d8a20d..b9b5e0464b9f5e7b146e1a6473447cafb654d26a 100644
>--- a/LayoutTests/fast/text/find-quotes.html
>+++ b/LayoutTests/fast/text/find-quotes.html
>@@ -15,7 +15,9 @@
>         var hebrewPunctuationGeresh = String.fromCharCode(0x05F3);
>         var hebrewPunctuationGershayim = String.fromCharCode(0x05F4);
>         var leftDoubleQuotationMark = String.fromCharCode(0x201C);
>+        var leftLowDoubleQuotationMark = String.fromCharCode(0x201E);
>         var leftSingleQuotationMark = String.fromCharCode(0x2018);
>+        var leftLowSingleQuotationMark = String.fromCharCode(0x201A);
>         var quotationMark = '"';
>         var rightDoubleQuotationMark = String.fromCharCode(0x201D);
>         var rightSingleQuotationMark = String.fromCharCode(0x2019);
>@@ -49,8 +51,8 @@
>             if (window.testRunner)
>                 testRunner.dumpAsText();
> 
>-            var singleQuotes = [ "apostrophe", "hebrewPunctuationGeresh", "leftSingleQuotationMark", "rightSingleQuotationMark" ];
>-            var doubleQuotes = [ "quotationMark", "hebrewPunctuationGershayim", "leftDoubleQuotationMark", "rightDoubleQuotationMark" ];
>+            var singleQuotes = [ "apostrophe", "hebrewPunctuationGeresh", "leftSingleQuotationMark", "rightSingleQuotationMark", "leftLowSingleQuotationMark"];
>+            var doubleQuotes = [ "quotationMark", "hebrewPunctuationGershayim", "leftDoubleQuotationMark", "rightDoubleQuotationMark", "leftLowDoubleQuotationMark"];
> 
>             for (var i = 0; i < singleQuotes.length; ++i) {
>                 for (var j = 0; j < singleQuotes.length; ++j)

Actions: View | Formatted Diff | Diff

Attachments on bug 187164: 343874 | 343877 | 343878