Attachment 343849 Details for Bug 186980 – move-code-outside.patch

move-code-outside.patch

file_186980.txt (text/plain), 1.61 KB, created by Alicia Boya García on 2018-06-28 14:13:01 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Alicia Boya García

Created: 2018-06-28 14:13:01 PDT

Size: 1.61 KB

patch

obsolete

>diff --git a/Source/WebCore/css/StyleBuilderCustom.h b/Source/WebCore/css/StyleBuilderCustom.h
>index bc41d8e3fa1..3458146d666 100644
>--- a/Source/WebCore/css/StyleBuilderCustom.h
>+++ b/Source/WebCore/css/StyleBuilderCustom.h
>@@ -559,8 +559,22 @@ public:
>         setValue(styleResolver.style(), image);
>     }
> 
>+    static void suddenlyNoStackBug(StyleResolver& styleResolver) {
>+        NinePieceImage image(getValue(styleResolver.style()));
>+
>+        // Masks have a different initial value for widths. They use an 'auto' value rather than trying to fit to the border.
>+        image.setBorderSlices(type == BorderImage ? LengthBox(Length(1, Relative), Length(1, Relative), Length(1, Relative), Length(1, Relative)) : LengthBox());
>+
>+        setValue(styleResolver.style(), image);
>+    }
>+
>     static void applyInitialValue(StyleResolver& styleResolver)
>     {
>+        if (modifier == Width) {
>+            suddenlyNoStackBug(styleResolver);
>+            return;
>+        }
>+
>         NinePieceImage image(getValue(styleResolver.style()));
>         switch (modifier) {
>         case Outset:
>@@ -576,8 +590,7 @@ public:
>             image.setFill(false);
>             break;
>         case Width:
>-            // Masks have a different initial value for widths. They use an 'auto' value rather than trying to fit to the border.
>-            image.setBorderSlices(type == BorderImage ? LengthBox(Length(1, Relative), Length(1, Relative), Length(1, Relative), Length(1, Relative)) : LengthBox());
>+            abort();
>             break;
>         }
>         setValue(styleResolver.style(), image);
>-- 
>2.17.1

Actions: View

Attachments on bug 186980: 343849 | 343916 | 344030 | 344031