Attachment 343848 Details for Bug 187072 – Patch

[patch] Patch

bug-187072-20180628140809.patch (text/plain), 5.31 KB, created by Timothy Hatcher on 2018-06-28 14:08:12 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Timothy Hatcher

Created: 2018-06-28 14:08:12 PDT

Size: 5.31 KB

patch

obsolete

>Subversion Revision: 233314
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index 469e7ea40c4f551e2ac82695b8448077495476b8..18013399eca8a07093959346243710030c95f6a0 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,13 @@
>+2018-06-28  Timothy Hatcher  <timothy@apple.com>
>+
>+        Find on page selection color isn't adapted for dark mode.
>+        https://bugs.webkit.org/show_bug.cgi?id=187072
>+
>+        Unreviewed, revert part of r233280.
>+
>+        * rendering/RenderThemeMac.mm:
>+        (WebCore::RenderThemeMac::platformActiveTextSearchHighlightColor const): Use pure yellow again.
>+
> 2018-06-28  Aditya Keerthi  <akeerthi@apple.com>
> 
>         REGRESSION (r232040): Cursor jumping in Safari text fields
>diff --git a/Source/WebCore/rendering/RenderThemeMac.mm b/Source/WebCore/rendering/RenderThemeMac.mm
>index c2b806318def8077d8ab46488b7de644bbe85542..0e9c2410226ca072c1148e85305485956e60da3c 100644
>--- a/Source/WebCore/rendering/RenderThemeMac.mm
>+++ b/Source/WebCore/rendering/RenderThemeMac.mm
>@@ -398,7 +398,7 @@ Color RenderThemeMac::platformActiveTextSearchHighlightColor(OptionSet<StyleColo
>     return colorFromNSColor([NSColor findHighlightColor]);
> #else
>     UNUSED_PARAM(options);
>-    return Color(255, 204, 0); // Yellow.
>+    return Color(255, 255, 0); // Yellow.
> #endif
> }
> 
>diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
>index 4b22608a723c2aa1d99f4692c98e94bdd22f5e57..d2ccba3f23c84e3e330079c3d5502b87f91fe2c7 100644
>--- a/LayoutTests/ChangeLog
>+++ b/LayoutTests/ChangeLog
>@@ -1,3 +1,17 @@
>+2018-06-28  Timothy Hatcher  <timothy@apple.com>
>+
>+        Find on page selection color isn't adapted for dark mode.
>+        https://bugs.webkit.org/show_bug.cgi?id=187072
>+        rdar://problem/40354841
>+
>+        Unreviewed test gardening.
>+
>+        * fast/css/apple-system-control-colors-expected.txt: Use pure yellow for find.
>+        * fast/text/mark-matches-broken-line-rendering-expected.html:
>+        * fast/text/mark-matches-rendering-expected.html:
>+        Use -apple-system-find-highlight-background to work on all macOS versions.
>+        * platform/mac-sierra/fast/css/apple-system-control-colors-expected.txt: Use pure yellow for find.
>+
> 2018-06-28  Jer Noble  <jer.noble@apple.com>
> 
>         Unreviewed gardening; media/video-buffering-allowed.html is flakey due to not completing in time.
>diff --git a/LayoutTests/fast/css/apple-system-control-colors-expected.txt b/LayoutTests/fast/css/apple-system-control-colors-expected.txt
>index 3bfcca2a7ddf7991517f4a0edc16d241d3e5ed30..bfdf27016aba6d61c714ecee50f57f60e8d2e88d 100644
>--- a/LayoutTests/fast/css/apple-system-control-colors-expected.txt
>+++ b/LayoutTests/fast/css/apple-system-control-colors-expected.txt
>@@ -12,7 +12,7 @@
> -apple-system-selected-text-background : rgb(181, 213, 255)
> -apple-system-unemphasized-selected-text-background : rgb(212, 212, 212)
> -apple-system-placeholder-text : rgba(0, 0, 0, 0.247059)
>--apple-system-find-highlight-background : rgb(255, 204, 0)
>+-apple-system-find-highlight-background : rgb(255, 255, 0)
> -apple-system-label : rgba(0, 0, 0, 0.85098)
> -apple-system-secondary-label : rgba(0, 0, 0, 0.498039)
> -apple-system-tertiary-label : rgba(0, 0, 0, 0.247059)
>diff --git a/LayoutTests/fast/text/mark-matches-broken-line-rendering-expected.html b/LayoutTests/fast/text/mark-matches-broken-line-rendering-expected.html
>index ab2a818831942cbab170347e4ff61833d6f8b611..30d7cf4924a108d431516efee91b5b65572b6cd3 100644
>--- a/LayoutTests/fast/text/mark-matches-broken-line-rendering-expected.html
>+++ b/LayoutTests/fast/text/mark-matches-broken-line-rendering-expected.html
>@@ -6,7 +6,7 @@ p {
> }
> 
> span {
>-    background-color: rgb(255, 204, 0);
>+    background-color: -apple-system-find-highlight-background;
>     color: -apple-system-label;
> }
> </style>
>diff --git a/LayoutTests/fast/text/mark-matches-rendering-expected.html b/LayoutTests/fast/text/mark-matches-rendering-expected.html
>index 105179313a9d956305b52fa58047b3f697e450e6..cdd72661d9a63eaf1b8b1e469e109705c2440faf 100644
>--- a/LayoutTests/fast/text/mark-matches-rendering-expected.html
>+++ b/LayoutTests/fast/text/mark-matches-rendering-expected.html
>@@ -1,3 +1,3 @@
>-<p style="display: inline-block; background-color: rgb(255, 204, 0); color: -apple-system-label">
>+<p style="display: inline-block; background-color: -apple-system-find-highlight-background; color: -apple-system-label">
> Quo usque tandem abutere, Catilina, patientia nostra?
> </p>
>diff --git a/LayoutTests/platform/mac-sierra/fast/css/apple-system-control-colors-expected.txt b/LayoutTests/platform/mac-sierra/fast/css/apple-system-control-colors-expected.txt
>index 3bfcca2a7ddf7991517f4a0edc16d241d3e5ed30..bfdf27016aba6d61c714ecee50f57f60e8d2e88d 100644
>--- a/LayoutTests/platform/mac-sierra/fast/css/apple-system-control-colors-expected.txt
>+++ b/LayoutTests/platform/mac-sierra/fast/css/apple-system-control-colors-expected.txt
>@@ -12,7 +12,7 @@
> -apple-system-selected-text-background : rgb(181, 213, 255)
> -apple-system-unemphasized-selected-text-background : rgb(212, 212, 212)
> -apple-system-placeholder-text : rgba(0, 0, 0, 0.247059)
>--apple-system-find-highlight-background : rgb(255, 204, 0)
>+-apple-system-find-highlight-background : rgb(255, 255, 0)
> -apple-system-label : rgba(0, 0, 0, 0.85098)
> -apple-system-secondary-label : rgba(0, 0, 0, 0.498039)
> -apple-system-tertiary-label : rgba(0, 0, 0, 0.247059)

Actions: View | Formatted Diff | Diff

Attachments on bug 187072: 343664 | 343669 | 343680 | 343681 | 343683 | 343685 | 343715 | 343727 | 343733 | 343744 | 343751 | 343753 | 343817 | 343818 | 343828 | 343837 | 343845 | 343848