WebKit Bugzilla
Attachment 343847 Details for
Bug 187020
: Web Inspector: REGRESSION (r213000): copy from Search results content view broken
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
Remember
[x]
|
Forgot Password
Login:
[x]
[patch]
Patch
bug-187020-20180628140223.patch (text/plain), 2.31 KB, created by
Matt Baker
on 2018-06-28 14:02:24 PDT
(
hide
)
Description:
Patch
Filename:
MIME Type:
Creator:
Matt Baker
Created:
2018-06-28 14:02:24 PDT
Size:
2.31 KB
patch
obsolete
>Subversion Revision: 233272 >diff --git a/Source/WebInspectorUI/ChangeLog b/Source/WebInspectorUI/ChangeLog >index c468724b7b497564ac3c8c1c1c1e7d37d1950abc..0c4abdce5b5ce5cb8e77b05443fef08bd8a58d90 100644 >--- a/Source/WebInspectorUI/ChangeLog >+++ b/Source/WebInspectorUI/ChangeLog >@@ -1,3 +1,24 @@ >+2018-06-28 Matt Baker <mattbaker@apple.com> >+ >+ Web Inspector: REGRESSION (r213000): copy from Search results content view broken >+ https://bugs.webkit.org/show_bug.cgi?id=187020 >+ <rdar://problem/40928766> >+ >+ Reviewed by NOBODY (OOPS!). >+ >+ Since WI._copy listens for a copy event from the document, it is called >+ after CodeMirror handles the event and sets clipboard data. If WI._copy >+ finds a custom copy handler to call, that handler can determine whether >+ to overwrite the current clipboard data, or leave it alone. >+ >+ SearchTabContentView's handleCopyEvent method should return early if the >+ content tree outline doesn't have the focus. This prevents the selection >+ in the TextEditor from being overwritten, without any special knowledge of >+ the content browser's current view. >+ >+ * UserInterface/Views/SearchTabContentView.js: >+ (WI.SearchTabContentView.prototype.handleCopyEvent): >+ > 2018-06-25 Nikita Vasilyev <nvasilyev@apple.com> > > Web Inspector: Dark Mode: Box Model section should have dark background >diff --git a/Source/WebInspectorUI/UserInterface/Views/SearchTabContentView.js b/Source/WebInspectorUI/UserInterface/Views/SearchTabContentView.js >index db771acc82724126a942649d1e039c493be14298..f3c5c9054e6f2bef96c678d91724f3e05d8ba292 100644 >--- a/Source/WebInspectorUI/UserInterface/Views/SearchTabContentView.js >+++ b/Source/WebInspectorUI/UserInterface/Views/SearchTabContentView.js >@@ -99,7 +99,11 @@ WI.SearchTabContentView = class SearchTabContentView extends WI.ContentBrowserTa > > handleCopyEvent(event) > { >- let selectedTreeElement = this.navigationSidebarPanel.contentTreeOutline.selectedTreeElement; >+ let contentTreeOutline = this.navigationSidebarPanel.contentTreeOutline; >+ if (contentTreeOutline.element !== document.activeElement) >+ return; >+ >+ let selectedTreeElement = contentTreeOutline.selectedTreeElement; > if (!selectedTreeElement) > return; >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Formatted Diff
|
Diff
Attachments on
bug 187020
:
343547
| 343847