Attachment 343825 Details for Bug 187110 – Patch

[patch] Patch

bug-187110-20180628114955.patch (text/plain), 1.93 KB, created by Jiewen Tan on 2018-06-28 11:49:56 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Jiewen Tan

Created: 2018-06-28 11:49:56 PDT

Size: 1.93 KB

patch

obsolete

>Subversion Revision: 233096
>diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog
>index 7d7cdce1dcd3ab75a0e2b0e227056d077c531b51..a6ea601ae892dfd85032949e8f6837472f3fd35f 100644
>--- a/Source/WebKit/ChangeLog
>+++ b/Source/WebKit/ChangeLog
>@@ -1,3 +1,20 @@
>+2018-06-27  Jiewen Tan  <jiewen_tan@apple.com>
>+
>+        Add nullptr check for xpc_connection_t in AuthenticationManager::initializeConnection
>+        https://bugs.webkit.org/show_bug.cgi?id=187110
>+        <rdar://problem/41536815>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        In some rare cases as shown by crash tracers that the passed xpc_connection_t object could be nullptr,
>+        and xpc_connection_set_event_handler won't do the nullptr check on its parameters. Therefore, we should
>+        do it by ourselves.
>+
>+        * Shared/Authentication/cocoa/AuthenticationManagerCocoa.mm:
>+        (WebKit::AuthenticationManager::initializeConnection):
>+        * UIProcess/Authentication/cocoa/AuthenticationChallengeProxyCocoa.mm:
>+        (WebKit::AuthenticationChallengeProxy::sendClientCertificateCredentialOverXpc const):
>+
> 2018-06-22  Brian Burg  <bburg@apple.com>
> 
>         [Cocoa] REGRESSION(W3C): actions for key equivalents are not respected
>diff --git a/Source/WebKit/Shared/Authentication/cocoa/AuthenticationManagerCocoa.mm b/Source/WebKit/Shared/Authentication/cocoa/AuthenticationManagerCocoa.mm
>index b86ae8afa2d54148a9e3ba2b499de844db19b428..6aae2053e6ba9a170d38bf11de93059aff94ec4b 100644
>--- a/Source/WebKit/Shared/Authentication/cocoa/AuthenticationManagerCocoa.mm
>+++ b/Source/WebKit/Shared/Authentication/cocoa/AuthenticationManagerCocoa.mm
>@@ -40,7 +40,7 @@ void AuthenticationManager::initializeConnection(IPC::Connection* connection)
> {
>     ASSERT(isMainThread());
> 
>-    if (!connection || xpc_get_type(connection->xpcConnection()) != XPC_TYPE_CONNECTION) {
>+    if (!connection || !connection->xpcConnection()) {
>         ASSERT_NOT_REACHED();
>         return;
>     }

Actions: View | Formatted Diff | Diff

Attachments on bug 187110: 343738 | 343775 | 343825 | 343826