Attachment 343823 Details for Bug 186093 – Patch

[patch] Patch

bug-186093-20180628114553.patch (text/plain), 3.20 KB, created by Jeremy Jones on 2018-06-28 11:46:34 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Jeremy Jones

Created: 2018-06-28 11:46:34 PDT

Size: 3.20 KB

patch

obsolete

>Subversion Revision: 233214
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index f049638b707a069c4acc01e0bc84d470d5043c0c..9878c4915ef01d2371c2056ac3b4842cc9ddef20 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,22 @@
>+2018-05-30  Jeremy Jones  <jeremyj@apple.com>
>+
>+        For <video> element, use video fullscreen instead of element fullscreen.
>+        https://bugs.webkit.org/show_bug.cgi?id=186093
>+        rdar://problem/40144751
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Some pages use webkitRequestFullscreen directly on the video element, without any custom controls.
>+        This will prevent native fullscreeen presentation mode conrols from being used.
>+
>+        This change makes webkitRequestFullscreen on a video element call webKitSetPresentationMode
>+        and log to the console to inform the developer that they should adopt webKitSetPresentationMode.
>+
>+        * dom/Element.h:
>+        * html/HTMLVideoElement.cpp:
>+        (WebCore::HTMLVideoElement::webkitRequestFullscreen):
>+        * html/HTMLVideoElement.h:
>+
> 2018-06-26  Eric Carlson  <eric.carlson@apple.com>
> 
>         [Mac] AirPlay picker uses incorrect theme in Dark mode
>diff --git a/Source/WebCore/dom/Element.h b/Source/WebCore/dom/Element.h
>index c9806ab58b51edf898b57a14874b1b2c7d7fb328..f7c46da309dfcee44e9d57c68af2a87eece4dab8 100644
>--- a/Source/WebCore/dom/Element.h
>+++ b/Source/WebCore/dom/Element.h
>@@ -475,7 +475,7 @@ public:
>     WEBCORE_EXPORT bool containsFullScreenElement() const;
>     void setContainsFullScreenElement(bool);
>     void setContainsFullScreenElementOnAncestorsCrossingFrameBoundaries(bool);
>-    WEBCORE_EXPORT void webkitRequestFullscreen();
>+    WEBCORE_EXPORT virtual void webkitRequestFullscreen();
> #endif
> 
> #if ENABLE(POINTER_LOCK)
>diff --git a/Source/WebCore/html/HTMLVideoElement.cpp b/Source/WebCore/html/HTMLVideoElement.cpp
>index 908ed4ca6836ce320c1c3f9083ecec9b3210c8c9..7ac8041ce10743964fcb3e306756924e492f4122 100644
>--- a/Source/WebCore/html/HTMLVideoElement.cpp
>+++ b/Source/WebCore/html/HTMLVideoElement.cpp
>@@ -191,6 +191,15 @@ bool HTMLVideoElement::supportsFullscreen(HTMLMediaElementEnums::VideoFullscreen
> #endif // PLATFORM(IOS)
> }
> 
>+
>+#if ENABLE(FULLSCREEN_API) && PLATFORM(IOS)
>+void HTMLVideoElement::webkitRequestFullscreen()
>+{
>+    document().addConsoleMessage(MessageSource::Media, MessageLevel::Debug, "For <video> element use webkitSetPresentationMode('Fullscreen') instead of webkitRequestFullscreen()."_s);
>+    webkitSetPresentationMode(HTMLVideoElement::VideoPresentationMode::Fullscreen);
>+}
>+#endif
>+
> unsigned HTMLVideoElement::videoWidth() const
> {
>     if (!player())
>diff --git a/Source/WebCore/html/HTMLVideoElement.h b/Source/WebCore/html/HTMLVideoElement.h
>index cb72b7c84451b73f450d8a38770713ca936fab8d..40a7af351f89511ff353a5d64138fddff933cf66 100644
>--- a/Source/WebCore/html/HTMLVideoElement.h
>+++ b/Source/WebCore/html/HTMLVideoElement.h
>@@ -61,6 +61,10 @@ public:
>     unsigned webkitDroppedFrameCount() const;
> #endif
> 
>+#if ENABLE(FULLSCREEN_API) && PLATFORM(IOS)
>+    void webkitRequestFullscreen() override;
>+#endif
>+
>     // Used by canvas to gain raw pixel access
>     void paintCurrentFrameInContext(GraphicsContext&, const FloatRect&);
>

Flags:

jer.noble: review+
ews-watchlist: commit-queue-

Actions: View | Formatted Diff | Diff

Attachments on bug 186093: 341570 | 341606 | 343820 | 343823 | 343843 | 344473 | 344497