Attachment 343819 Details for Bug 187146 – Patch

[patch] Patch

bug-187146-20180628112532.patch (text/plain), 1.92 KB, created by BJ Burg on 2018-06-28 11:25:32 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: BJ Burg

Created: 2018-06-28 11:25:32 PDT

Size: 1.92 KB

patch

obsolete

>Subversion Revision: 233307
>diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog
>index c863b2e7e958e3a7be6feb63793daf95b18e2552..ad506f20570a9b447a2c0887bd5336c4dbc0c7f5 100644
>--- a/Source/WebKit/ChangeLog
>+++ b/Source/WebKit/ChangeLog
>@@ -1,3 +1,20 @@
>+2018-06-28  Brian Burg  <bburg@apple.com>
>+
>+        Web Inspector: REGRESSION(r223770): "Open Link" context menu action on a linkified URL doesn't work
>+        https://bugs.webkit.org/show_bug.cgi?id=187146
>+        <rdar://problem/41369591>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        When Web Inspector's page receives a navigation request, it's supposed to redirect any
>+        non-Inspector navigations to be loaded in the inspected page. When I refactored to use
>+        modern a policy delegate, the one line that redirects the loads was left out.
>+
>+        No new tests, because inspector tests can't navigate the inspector or inspected pages.
>+
>+        * UIProcess/mac/WKInspectorViewController.mm:
>+        (-[WKInspectorViewController webView:decidePolicyForNavigationAction:decisionHandler:]):
>+
> 2018-06-28  Michael Catanzaro  <mcatanzaro@igalia.com>
> 
>         [GTK] ASSERTION FAILED: !HashTranslator::equal(KeyTraits::emptyValue(), key) when dragging file into webview
>diff --git a/Source/WebKit/UIProcess/mac/WKInspectorViewController.mm b/Source/WebKit/UIProcess/mac/WKInspectorViewController.mm
>index f2ad7f8d4ca1aa878ece34c5f586175dbb52ab2c..507f6bac1faaff66bf76c8ec10bd1bbb6b870b54 100644
>--- a/Source/WebKit/UIProcess/mac/WKInspectorViewController.mm
>+++ b/Source/WebKit/UIProcess/mac/WKInspectorViewController.mm
>@@ -225,6 +225,9 @@ - (void)webView:(WKWebView *)webView decidePolicyForNavigationAction:(WKNavigati
> 
>     // Prevent everything else.
>     decisionHandler(WKNavigationActionPolicyCancel);
>+    
>+    // And instead load it in the inspected page.
>+    _inspectedPage->loadRequest(navigationAction.request);
> }
> 
> // MARK: WKInspectorWKWebViewDelegate methods

Actions: View | Formatted Diff | Diff

Attachments on bug 187146: 343819