WebKit Bugzilla
Attachment 343817 Details for
Bug 187072
: Find on page selection color isn't adapted for dark mode
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
Remember
[x]
|
Forgot Password
Login:
[x]
[patch]
Patch
bug-187072-20180628105620.patch (text/plain), 2.06 KB, created by
Timothy Hatcher
on 2018-06-28 10:56:24 PDT
(
hide
)
Description:
Patch
Filename:
MIME Type:
Creator:
Timothy Hatcher
Created:
2018-06-28 10:56:24 PDT
Size:
2.06 KB
patch
obsolete
>Subversion Revision: 233297 >diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog >index 08d9f07e1a46c9cfeb15f31e29a7e4a6ae4339f1..38fd0133e3d1d182439627150bec46d1ad188bfd 100644 >--- a/LayoutTests/ChangeLog >+++ b/LayoutTests/ChangeLog >@@ -1,3 +1,15 @@ >+2018-06-28 Timothy Hatcher <timothy@apple.com> >+ >+ Find on page selection color isn't adapted for dark mode. >+ https://bugs.webkit.org/show_bug.cgi?id=187072 >+ rdar://problem/40354841 >+ >+ Unreviewed test gardening. >+ >+ * fast/text/mark-matches-broken-line-rendering-expected.html: >+ * fast/text/mark-matches-rendering-expected.html: >+ Use -apple-system-find-highlight-background to work on all macOS versions. >+ > 2018-06-27 Ryan Haddad <ryanhaddad@apple.com> > > Mark imported/blink/storage/indexeddb/blob-delete-objectstore-db.html as flaky. >diff --git a/LayoutTests/fast/text/mark-matches-broken-line-rendering-expected.html b/LayoutTests/fast/text/mark-matches-broken-line-rendering-expected.html >index ab2a818831942cbab170347e4ff61833d6f8b611..30d7cf4924a108d431516efee91b5b65572b6cd3 100644 >--- a/LayoutTests/fast/text/mark-matches-broken-line-rendering-expected.html >+++ b/LayoutTests/fast/text/mark-matches-broken-line-rendering-expected.html >@@ -6,7 +6,7 @@ p { > } > > span { >- background-color: rgb(255, 204, 0); >+ background-color: -apple-system-find-highlight-background; > color: -apple-system-label; > } > </style> >diff --git a/LayoutTests/fast/text/mark-matches-rendering-expected.html b/LayoutTests/fast/text/mark-matches-rendering-expected.html >index 105179313a9d956305b52fa58047b3f697e450e6..cdd72661d9a63eaf1b8b1e469e109705c2440faf 100644 >--- a/LayoutTests/fast/text/mark-matches-rendering-expected.html >+++ b/LayoutTests/fast/text/mark-matches-rendering-expected.html >@@ -1,3 +1,3 @@ >-<p style="display: inline-block; background-color: rgb(255, 204, 0); color: -apple-system-label"> >+<p style="display: inline-block; background-color: -apple-system-find-highlight-background; color: -apple-system-label"> > Quo usque tandem abutere, Catilina, patientia nostra? > </p>
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Formatted Diff
|
Diff
Attachments on
bug 187072
:
343664
|
343669
|
343680
|
343681
|
343683
|
343685
|
343715
|
343727
|
343733
|
343744
|
343751
|
343753
|
343817
|
343818
|
343828
|
343837
|
343845
|
343848