Attachment 343790 Details for Bug 187132 – Patch for lldb_webkit.py only

[patch] Patch for lldb_webkit.py only

lldb_vector.patch (text/plain), 1.47 KB, created by Simon Fraser (smfr) on 2018-06-27 21:05:45 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Simon Fraser (smfr)

Created: 2018-06-27 21:05:45 PDT

Size: 1.47 KB

patch

obsolete

>diff --git a/Tools/ChangeLog b/Tools/ChangeLog
>index 974350b8eedf5cee0df05b523d85a3dd0450d4df..935421f9fec294c9fb2d551c1a2a2dc0f85b9564 100644
>--- a/Tools/ChangeLog
>+++ b/Tools/ChangeLog
>@@ -1,3 +1,23 @@
>+2018-06-27  Simon Fraser  <simon.fraser@apple.com>
>+
>+        The lldb vector summary provider always shows zero capacity
>+        https://bugs.webkit.org/show_bug.cgi?id=187132
>+
>+        Reviewed by NOBODY (OOPS!).
>+        
>+        WTFVectorProvider in lldb_webkit.py was calling GetChildMemberWithName('m_capacity')
>+        on the buffer instead of the valobj.
>+
>+        * lldb/lldb_webkit.py:
>+        (WTFVectorProvider.update):
>+
> 2018-06-01  Daniel Bates  <dabates@apple.com>
> 
>         Add some tests for lldb_webkit.py
>diff --git a/Tools/lldb/lldb_webkit.py b/Tools/lldb/lldb_webkit.py
>index e97ef9a6551a02c05026cf5b98c079195f6ba276..34c64c345329e06a75830916907d31c7c74f5376 100644
>--- a/Tools/lldb/lldb_webkit.py
>+++ b/Tools/lldb/lldb_webkit.py
>@@ -383,7 +383,7 @@ class WTFVectorProvider:
>     def update(self):
>         self.buffer = self.valobj.GetChildMemberWithName('m_buffer')
>         self.size = self.valobj.GetChildMemberWithName('m_size').GetValueAsUnsigned(0)
>-        self.capacity = self.buffer.GetChildMemberWithName('m_capacity').GetValueAsUnsigned(0)
>+        self.capacity = self.valobj.GetChildMemberWithName('m_capacity').GetValueAsUnsigned(0)
>         self.data_type = self.buffer.GetType().GetPointeeType()
>         self.data_size = self.data_type.GetByteSize()
>

Flags:

dbates: review+

Actions: View | Formatted Diff | Diff

Attachments on bug 187132: 343789 | 343790