Attachment 343764 Details for Bug 187112 – patch

[patch] patch

a-backup.diff (text/plain), 1.61 KB, created by Saam Barati on 2018-06-27 16:04:36 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Saam Barati

Created: 2018-06-27 16:04:36 PDT

Size: 1.61 KB

patch

obsolete

>Index: Source/JavaScriptCore/ChangeLog
>===================================================================
>--- Source/JavaScriptCore/ChangeLog	(revision 233279)
>+++ Source/JavaScriptCore/ChangeLog	(working copy)
>@@ -1,3 +1,16 @@
>+2018-06-27  Saam Barati  <sbarati@apple.com>
>+
>+        Add some more register state information when we crash in repatchPutById
>+        https://bugs.webkit.org/show_bug.cgi?id=187112
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        This will help us gather info when we end up seeing a ObjectPropertyConditionSet
>+        with an offset that is different than what the put tells us.
>+
>+        * jit/Repatch.cpp:
>+        (JSC::tryCachePutByID):
>+
> 2018-06-27  Keith Miller  <keith_miller@apple.com>
> 
>         Add logging to try to diagnose where we get a null structure.
>Index: Source/JavaScriptCore/jit/Repatch.cpp
>===================================================================
>--- Source/JavaScriptCore/jit/Repatch.cpp	(revision 233273)
>+++ Source/JavaScriptCore/jit/Repatch.cpp	(working copy)
>@@ -573,7 +573,9 @@ static InlineCacheAction tryCachePutByID
>                         if (!conditionSet.isValid())
>                             return GiveUpOnCache;
> 
>-                        RELEASE_ASSERT(offset == conditionSet.slotBaseCondition().offset());
>+                        PropertyOffset conditionSetOffset = conditionSet.slotBaseCondition().offset();
>+                        if (UNLIKELY(offset != conditionSetOffset))
>+                            CRASH_WITH_INFO(offset, conditionSetOffset, slot.base()->type(), baseCell->type(), conditionSet.size());
>                     }
> 
>                 }

Actions: View | Formatted Diff | Diff

Attachments on bug 187112: 343756 | 343764