Attachment 343760 Details for Bug 175602 – Patch

[patch] Patch

bug-175602-20180627171911.patch (text/plain), 2.11 KB, created by Michael Catanzaro on 2018-06-27 15:19:11 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Michael Catanzaro

Created: 2018-06-27 15:19:11 PDT

Size: 2.11 KB

patch

obsolete

>Subversion Revision: 233255
>diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog
>index dfd8848916637e45207cf62fcaf518b075a4c06c..6a9ff325914eeae5f161ad4b0ad3890a65d423f2 100644
>--- a/Source/WebKit/ChangeLog
>+++ b/Source/WebKit/ChangeLog
>@@ -1,3 +1,19 @@
>+2018-06-27  Michael Catanzaro  <mcatanzaro@igalia.com>
>+
>+        [GTK] ASSERTION FAILED: !HashTranslator::equal(KeyTraits::emptyValue(), key) when dragging file into webview
>+        https://bugs.webkit.org/show_bug.cgi?id=175602
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        We check using the GdkDragContext to ensure the DroppingContext is still alive (present in
>+        m_droppingContexts), but access it via the pointer to the DroppingContext that could be
>+        dangling. This happens on every drag. I can't actually reproduce the original assertion
>+        since I'm currently working with an asan build, but I imagine it's probably the same issue
>+        that I'm fixing here.
>+
>+        * UIProcess/gtk/DragAndDropHandler.cpp:
>+        (WebKit::DragAndDropHandler::dragLeave):
>+
> 2018-06-27  Tim Horton  <timothy_horton@apple.com>
> 
>         When trying to print a very long email on iOS, the print preview is blank
>diff --git a/Source/WebKit/UIProcess/gtk/DragAndDropHandler.cpp b/Source/WebKit/UIProcess/gtk/DragAndDropHandler.cpp
>index 2a223580b0fd15613284b5d0d8061fa57f315d56..75a1bb6fb298b0364933af25ee79eb4ed137d511 100644
>--- a/Source/WebKit/UIProcess/gtk/DragAndDropHandler.cpp
>+++ b/Source/WebKit/UIProcess/gtk/DragAndDropHandler.cpp
>@@ -257,8 +257,8 @@ void DragAndDropHandler::dragLeave(GdkDragContext* context)
>     // During a drop GTK+ will fire a drag-leave signal right before firing
>     // the drag-drop signal. We want the actions for drag-leave to happen after
>     // those for drag-drop, so schedule them to happen asynchronously here.
>-    RunLoop::main().dispatch([this, droppingContext]() {
>-        auto it = m_droppingContexts.find(droppingContext->gdkContext);
>+    RunLoop::main().dispatch([this, context, droppingContext]() {
>+        auto it = m_droppingContexts.find(context);
>         if (it == m_droppingContexts.end())
>             return;
>

Actions: View | Formatted Diff | Diff

Attachments on bug 175602: 318181 | 343760 | 343801