Attachment 343752 Details for Bug 187116 – Patch

[patch] Patch

bug-187116-20180627143131.patch (text/plain), 2.19 KB, created by Ryosuke Niwa on 2018-06-27 14:31:32 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Ryosuke Niwa

Created: 2018-06-27 14:31:32 PDT

Size: 2.19 KB

patch

obsolete

>Index: Tools/ChangeLog
>===================================================================
>--- Tools/ChangeLog	(revision 233278)
>+++ Tools/ChangeLog	(working copy)
>@@ -1,3 +1,15 @@
>+2018-06-27  Ryosuke Niwa  <rniwa@webkit.org>
>+
>+        Make MotionMark's plan file more robust against code changes
>+        https://bugs.webkit.org/show_bug.cgi?id=187116
>+        <rdar://problem/41533956>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Moved the code to auto-start the test to the load event listener.
>+
>+        * Scripts/webkitpy/benchmark_runner/data/patches/webserver/MotionMark.patch:
>+
> 2018-06-27  Daniel Bates  <dabates@apple.com>
> 
>         webkit-patch should ignore non-ASCII characters in the status server API key
>Index: Tools/Scripts/webkitpy/benchmark_runner/data/patches/webserver/MotionMark.patch
>===================================================================
>--- Tools/Scripts/webkitpy/benchmark_runner/data/patches/webserver/MotionMark.patch	(revision 233256)
>+++ Tools/Scripts/webkitpy/benchmark_runner/data/patches/webserver/MotionMark.patch	(working copy)
>@@ -1,8 +1,8 @@
> diff --git a/resources/runner/motionmark.js b/resources/runner/motionmark.js
>-index 65e8c54..1643e70 100644
>+index d45155e..b10635a 100644
> --- a/resources/runner/motionmark.js
> +++ b/resources/runner/motionmark.js
>-@@ -393,6 +393,61 @@ window.benchmarkRunnerClient = {
>+@@ -411,6 +411,61 @@ window.benchmarkRunnerClient = {
>      didFinishLastIteration: function()
>      {
>          benchmarkController.showResults();
>@@ -64,12 +64,12 @@ index 65e8c54..1643e70 100644
>      }
>  };
>  
>-@@ -436,7 +491,7 @@ window.sectionsManager =
>- window.benchmarkController = {
>-     initialize: function()
>-     {
>--        benchmarkController.addOrientationListenerIfNecessary();
>-+        setTimeout(benchmarkController.startBenchmark.bind(benchmarkController), 3000);
>-     },
>+@@ -652,4 +707,7 @@ window.benchmarkController = {
>+     }
>+ };
>  
>-     determineCanvasSize: function() {
>+-window.addEventListener("load", function() { benchmarkController.initialize(); });
>++window.addEventListener("load", function() {
>++    benchmarkController.initialize();
>++    setTimeout(benchmarkController.startBenchmark.bind(benchmarkController), 3000);
>++});

Flags:

saam: review+

Actions: View | Formatted Diff | Diff

Attachments on bug 187116: 343752